*** nimish has joined #buildstream | 01:50 | |
*** juergbi has quit IRC | 02:32 | |
*** juergbi has joined #buildstream | 02:33 | |
*** max_ has joined #buildstream | 02:34 | |
*** max has quit IRC | 02:34 | |
*** max_ is now known as max | 02:34 | |
*** max has joined #buildstream | 02:35 | |
gitlab-br-bot | cs-shadow opened (was WIP) MR !1027 (chandan/toxify->master: Use tox as a frontend for running tests) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1027 | 03:06 |
---|---|---|
*** nimish has quit IRC | 03:13 | |
*** kapil___ has joined #buildstream | 04:53 | |
*** alatiera has joined #buildstream | 05:35 | |
*** kapil___ has quit IRC | 07:32 | |
*** kapil___ has joined #buildstream | 07:59 | |
*** rdale has joined #buildstream | 09:14 | |
*** raoul has joined #buildstream | 09:31 | |
*** mohan43u has quit IRC | 09:58 | |
*** mohan43u has joined #buildstream | 10:10 | |
*** jonathanmaw has joined #buildstream | 10:17 | |
*** mohan43u has quit IRC | 10:23 | |
*** mohan43u has joined #buildstream | 10:24 | |
*** max has quit IRC | 10:26 | |
*** mohan43u has quit IRC | 11:15 | |
*** mohan43u has joined #buildstream | 11:16 | |
gitlab-br-bot | jmacarthur approved MR !1030 (valentindavid/remote_execution_configuration->master: Remote execution configuration: HTTPS and user configuration) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1030 | 11:43 |
tpollard | benschubert: interesting mail | 11:46 |
*** kapil___ has quit IRC | 11:53 | |
*** alatiera has quit IRC | 11:53 | |
*** vidal72[m] has quit IRC | 11:53 | |
*** benschubert has quit IRC | 11:53 | |
*** johnward has quit IRC | 11:53 | |
*** persia has quit IRC | 11:53 | |
*** phildawson_ has quit IRC | 11:53 | |
*** valentind has quit IRC | 11:53 | |
*** mablanch has quit IRC | 11:53 | |
*** laurence has quit IRC | 11:53 | |
*** bethw has quit IRC | 11:53 | |
*** Trevinho[m] has quit IRC | 11:53 | |
*** jmac has quit IRC | 11:53 | |
*** flatmush_ has quit IRC | 11:53 | |
*** pro[m] has quit IRC | 11:53 | |
*** theawless[m] has quit IRC | 11:53 | |
*** mattiasb has quit IRC | 11:53 | |
*** oknf[m] has quit IRC | 11:53 | |
*** tintou has quit IRC | 11:53 | |
*** jjardon has quit IRC | 11:53 | |
*** segfault3[m] has quit IRC | 11:53 | |
*** rafaelff[m] has quit IRC | 11:53 | |
*** waltervargas[m] has quit IRC | 11:53 | |
*** inigomartinez has quit IRC | 11:53 | |
*** cgmcintyre[m] has quit IRC | 11:53 | |
*** tlater[m] has quit IRC | 11:53 | |
*** asingh_[m] has quit IRC | 11:53 | |
*** m_22[m] has quit IRC | 11:53 | |
*** dbuch has quit IRC | 11:53 | |
*** ssssam[m] has quit IRC | 11:53 | |
*** kailueke[m] has quit IRC | 11:53 | |
*** dineshdb[m] has quit IRC | 11:53 | |
*** doras[m] has quit IRC | 11:53 | |
*** abderrahim[m] has quit IRC | 11:53 | |
*** connorshea[m] has quit IRC | 11:53 | |
*** krichter[m] has quit IRC | 11:53 | |
*** albfan[m] has quit IRC | 11:53 | |
*** ironfoot has quit IRC | 11:53 | |
*** lchlan has quit IRC | 11:53 | |
*** awacheux[m] has quit IRC | 11:53 | |
*** Demos[m] has quit IRC | 11:53 | |
*** skullman has quit IRC | 11:53 | |
*** jonathanmaw has quit IRC | 11:53 | |
*** raoul has quit IRC | 11:53 | |
*** chill has quit IRC | 11:53 | |
*** SotK has quit IRC | 11:53 | |
*** ctgriffiths has quit IRC | 11:53 | |
*** tpollard has quit IRC | 11:53 | |
*** slaf has quit IRC | 11:53 | |
*** WSalmon has quit IRC | 11:53 | |
*** jmac has joined #buildstream | 11:53 | |
*** ironfoot has joined #buildstream | 11:53 | |
*** lchlan has joined #buildstream | 11:53 | |
*** benschubert has joined #buildstream | 11:53 | |
*** laurence has joined #buildstream | 11:53 | |
*** phildawson_ has joined #buildstream | 11:53 | |
*** alatiera has joined #buildstream | 11:53 | |
*** valentind has joined #buildstream | 11:53 | |
*** doras[m] has joined #buildstream | 11:53 | |
*** johnward has joined #buildstream | 11:55 | |
*** dbuch has joined #buildstream | 11:55 | |
*** mablanch has joined #buildstream | 11:55 | |
*** tintou has joined #buildstream | 11:55 | |
*** jjardon has joined #buildstream | 11:55 | |
*** kapil___ has joined #buildstream | 11:55 | |
*** skullman has joined #buildstream | 11:55 | |
*** bethw has joined #buildstream | 11:55 | |
*** persia has joined #buildstream | 11:55 | |
*** WSalmon has joined #buildstream | 11:55 | |
*** slaf has joined #buildstream | 11:55 | |
*** tpollard has joined #buildstream | 11:55 | |
*** ctgriffiths has joined #buildstream | 11:55 | |
*** SotK has joined #buildstream | 11:55 | |
*** chill has joined #buildstream | 11:55 | |
*** raoul has joined #buildstream | 11:55 | |
*** jonathanmaw has joined #buildstream | 11:55 | |
*** flatmush has joined #buildstream | 11:55 | |
*** persia has quit IRC | 11:57 | |
*** persia has joined #buildstream | 11:57 | |
*** ChanServ sets mode: +o ironfoot | 12:01 | |
*** abderrahim[m] has joined #buildstream | 12:17 | |
*** connorshea[m] has joined #buildstream | 12:20 | |
*** krichter[m] has joined #buildstream | 12:26 | |
*** albfan[m] has joined #buildstream | 12:32 | |
*** raoul has quit IRC | 12:35 | |
*** vidal72[m] has joined #buildstream | 12:49 | |
*** raoul has joined #buildstream | 13:19 | |
*** awacheux[m] has joined #buildstream | 13:20 | |
*** Demos[m] has joined #buildstream | 13:24 | |
*** Trevinho[m] has joined #buildstream | 13:29 | |
*** theawless[m] has joined #buildstream | 13:33 | |
*** pro[m] has joined #buildstream | 13:35 | |
*** mattiasb has joined #buildstream | 13:44 | |
*** nimish has joined #buildstream | 13:47 | |
* tpollard gets caught out with the click7.0 req again | 13:47 | |
*** nimish has quit IRC | 13:48 | |
*** oknf[m] has joined #buildstream | 13:50 | |
*** nimish has joined #buildstream | 13:58 | |
*** rafaelff[m] has joined #buildstream | 14:05 | |
gitlab-br-bot | cs-shadow opened MR !1032 (chandan/fix-bad-filename-mini-disaster->master: tests/frontend/buildcheckout.py: Fix bad filename issue for Windows) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1032 | 14:16 |
tpollard | nice branch name :) | 14:18 |
jmac | If anyone has a chance to review !1023 it'd be appreciated | 14:18 |
gitlab-br-bot | MR !1023: Stop resolving symlinks in _relative_symlink_target https://gitlab.com/BuildStream/buildstream/merge_requests/1023 | 14:18 |
*** waltervargas[m] has joined #buildstream | 14:20 | |
*** max has joined #buildstream | 14:23 | |
*** nimish has quit IRC | 14:34 | |
*** nimish has joined #buildstream | 14:36 | |
*** asingh_[m] has joined #buildstream | 14:37 | |
*** asingh_[m] has quit IRC | 14:38 | |
*** max has quit IRC | 14:38 | |
*** waltervargas[m] has quit IRC | 14:38 | |
*** oknf[m] has quit IRC | 14:38 | |
*** theawless[m] has quit IRC | 14:38 | |
*** Demos[m] has quit IRC | 14:38 | |
*** raoul has quit IRC | 14:38 | |
*** albfan[m] has quit IRC | 14:38 | |
*** krichter[m] has quit IRC | 14:38 | |
*** connorshea[m] has quit IRC | 14:38 | |
*** abderrahim[m] has quit IRC | 14:38 | |
*** persia has quit IRC | 14:38 | |
*** johnward has quit IRC | 14:38 | |
*** dbuch has quit IRC | 14:38 | |
*** kapil___ has quit IRC | 14:38 | |
*** jjardon has quit IRC | 14:38 | |
*** tintou has quit IRC | 14:38 | |
*** skullman has quit IRC | 14:38 | |
*** flatmush has quit IRC | 14:38 | |
*** bethw has quit IRC | 14:38 | |
*** mablanch has quit IRC | 14:38 | |
*** jonathanmaw has quit IRC | 14:38 | |
*** chill has quit IRC | 14:38 | |
*** SotK has quit IRC | 14:38 | |
*** ctgriffiths has quit IRC | 14:38 | |
*** tpollard has quit IRC | 14:38 | |
*** slaf has quit IRC | 14:38 | |
*** WSalmon has quit IRC | 14:38 | |
*** skullman has joined #buildstream | 14:38 | |
*** flatmush has joined #buildstream | 14:38 | |
*** bethw has joined #buildstream | 14:38 | |
*** kapil___ has joined #buildstream | 14:38 | |
*** jjardon has joined #buildstream | 14:38 | |
*** ChanServ sets mode: +o jjardon | 14:38 | |
*** persia has joined #buildstream | 14:38 | |
*** tintou has joined #buildstream | 14:39 | |
*** mablanch has joined #buildstream | 14:39 | |
*** jonathanmaw has joined #buildstream | 14:39 | |
*** chill has joined #buildstream | 14:39 | |
*** SotK has joined #buildstream | 14:39 | |
*** ctgriffiths has joined #buildstream | 14:39 | |
*** tpollard has joined #buildstream | 14:39 | |
*** slaf has joined #buildstream | 14:39 | |
*** WSalmon has joined #buildstream | 14:39 | |
*** raoul has joined #buildstream | 14:39 | |
*** max has joined #buildstream | 14:39 | |
*** johnward has joined #buildstream | 14:39 | |
*** segfault3[m] has joined #buildstream | 14:42 | |
*** inigomartinez has joined #buildstream | 14:48 | |
*** ssssam[m] has joined #buildstream | 14:48 | |
*** tristan has joined #buildstream | 14:50 | |
*** ChanServ sets mode: +o tristan | 14:50 | |
*** cgmcintyre[m] has joined #buildstream | 14:53 | |
*** kailueke[m] has joined #buildstream | 14:53 | |
*** tlater[m] has joined #buildstream | 14:57 | |
*** dineshdb[m] has joined #buildstream | 15:04 | |
*** m_22[m] has joined #buildstream | 15:14 | |
*** albfan[m] has joined #buildstream | 15:18 | |
*** krichter[m] has joined #buildstream | 15:22 | |
*** connorshea[m] has joined #buildstream | 15:29 | |
*** abderrahim[m] has joined #buildstream | 15:29 | |
*** dbuch has joined #buildstream | 15:38 | |
*** asingh_[m] has joined #buildstream | 15:41 | |
jmac | Is there meant to be a `Dockerfile` in the main Buildsteam repo? | 15:45 |
gitlab-br-bot | BenjaminSchubert approved MR !1032 (chandan/fix-bad-filename-mini-disaster->master: tests/frontend/buildcheckout.py: Fix bad filename issue for Windows) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1032 | 15:47 |
gitlab-br-bot | tristanvb merged MR !1027 (chandan/toxify->master: Use tox as a frontend for running tests) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1027 | 15:47 |
tristan | jmac, I don't think so | 15:48 |
tristan | jmac, there is a contrib/bst-here and bst-docker-import | 15:49 |
tristan | bst-here just uses the images from buildstream-docker-images repo, though | 15:49 |
tristan | cs-shadow, tests are now toxic ! | 15:50 |
tristan | cs-shadow, I need you to share with me how you refresh the .txt files from the .in files, so I can jot that into the contributing guide | 15:51 |
*** waltervargas[m] has joined #buildstream | 15:51 | |
*** juergbi has quit IRC | 15:53 | |
cs-shadow | yay! finally | 15:56 |
*** juergbi has joined #buildstream | 15:56 | |
cs-shadow | tristan: I use this little makefile at present: https://gitlab.com/BuildStream/buildstream/blob/chandan/tox-make/Makefile | 15:57 |
cs-shadow | We can either go with this approach, or add a tox environment to do the same | 15:57 |
tristan | cs-shadow, we can add the Makefile in the tools directory | 15:59 |
tristan | I think we should probably rename that to the requirements directory or smth | 15:59 |
jmac | The buildstream-docker-images repo has instructions for building a buildstream docker image which appears to rely on buildstream having a dockerfile | 15:59 |
tristan | it's possible we had one at one point | 16:00 |
*** oknf[m] has joined #buildstream | 16:01 | |
cs-shadow | jmac: seems like the instructions in the README are out-of-date, I'll update it soon. If you want to build something, just go the directory of the image you want to build, and run `docker build .` | 16:04 |
jmac | cs-shadow: That works, thanks | 16:05 |
tristan | cs-shadow, strange, did you change something to cause half of the linter checks to be skipped now ? | 16:06 |
*** Demos[m] has joined #buildstream | 16:07 | |
tristan | cs-shadow, either pylint or pycodestyle is running here, but not both | 16:07 |
*** juergbi has quit IRC | 16:07 | |
tristan | (one of them is collected by pytest and marked as SKIPPED) | 16:07 |
cs-shadow | tristan: that wasn't expected, let me have a look | 16:08 |
*** nimish has quit IRC | 16:08 | |
*** nimish has joined #buildstream | 16:08 | |
*** theawless[m] has joined #buildstream | 16:08 | |
cs-shadow | tristan: that maybe because of pytest cache | 16:09 |
cs-shadow | for example, if you edit the file, is it still skipped? | 16:10 |
tristan | Eh ? | 16:10 |
tristan | Ummm | 16:10 |
tristan | cs-shadow, we'll see | 16:11 |
cs-shadow | i think pytest will cache test results locally in `.pytest_cache`. I was suggesting to `git clean` things and see if they are run when the cache is empty | 16:12 |
cs-shadow | tristan: to clarify, this is locally, right? and not on CI | 16:12 |
tristan | cs-shadow, yeah | 16:14 |
tristan | :) | 16:14 |
tristan | it's winter here so I need to heat the table by running tox in a loop | 16:14 |
tristan | cs-shadow, do you know how to tell tox to parallelize the environments ? | 16:15 |
tristan | I touched a file | 16:15 |
tristan | oh maybe that wont work, maybe it's a content hash ? | 16:16 |
tristan | oh no, that worked | 16:16 |
tristan | cs-shadow, indeed | 16:16 |
tristan | did you enable that ? I hadn't seen it before | 16:16 |
*** juergbi has joined #buildstream | 16:17 | |
cs-shadow | tristan: cool, I think this is the default pytest behavior, I didn't change it as part of the tox change | 16:18 |
cs-shadow | for running thing in parallel, I think there's https://pypi.org/project/detox/ but I haven't tried it myself | 16:18 |
*** cs-shadow is now known as cs-shadow|afk | 16:19 | |
tristan | cs-shadow|afk, maybe the pycodestyle plugin uses the cache but the pep8 one didnt | 16:24 |
tristan | anyway | 16:24 |
*** mieszko has joined #buildstream | 16:25 | |
*** nimish has quit IRC | 16:33 | |
*** nimish has joined #buildstream | 16:34 | |
*** cs-shadow|afk is now known as cs-shadow | 16:49 | |
cs-shadow | tristan: hmm, https://pypi.org/project/pytest-pep8/ says that "... you can see that the pep8 check was skipped because the file has not been modified since it was last checked. As the pep8 plugin uses the pytest-cache plugin to implement its caching ..." | 16:50 |
*** tristan has quit IRC | 16:52 | |
*** max has quit IRC | 16:53 | |
*** tristan has joined #buildstream | 16:55 | |
*** ChanServ sets mode: +o tristan | 16:55 | |
*** tristan has left #buildstream | 16:55 | |
*** tristan has joined #buildstream | 16:55 | |
*** ChanServ sets mode: +o tristan | 16:55 | |
*** max has joined #buildstream | 17:21 | |
*** kapil___ has quit IRC | 17:42 | |
*** raoul has quit IRC | 17:52 | |
jmac | I'm having some trouble setting up the bst-artifact-server docker image. The server starts up correctly, but I cannot guess what CN it's decided to use inside the container for the server. It keeps giving errors like: | 17:55 |
jmac | E0103 17:54:50.103117643 13 ssl_transport_security.cc:1566] No match found for server name: 127.0.0.1. | 17:55 |
jmac | I've tried 127.0.0.1 and localhost | 17:55 |
cs-shadow | jmac: https://gitlab.com/BuildStream/buildstream-docker-images/blob/master/artifact-cache/bst-artifact-cache-start#L6 suggests localhost | 17:59 |
cs-shadow | unless of course CN is already set to something else | 17:59 |
jmac | Yeah, that's what I thought. I've tried passing in CN with `-e CN=<thing>` on the command line too. | 18:01 |
cs-shadow | hmm, not sure. Would be useful to add your error to https://gitlab.com/BuildStream/buildstream-docker-images/issues/22, I'll try to reproduce this later today | 18:02 |
*** max has quit IRC | 18:04 | |
jmac | Actually, I think I know the answer to #22 | 18:05 |
gitlab-br-bot | Issue #22: failed to upgrade buildstream at 640a734ec1db923b5 https://gitlab.com/BuildStream/buildstream/issues/22 | 18:05 |
cs-shadow | ah! that would also be good to know :) | 18:05 |
jmac | Well, not the answer, but a workaround. I've updated the issue. | 18:08 |
jmac | I'll have a think about the CN thing; if I haven't figured it out overnight I'll post an issue about it. | 18:09 |
*** nimish has quit IRC | 18:37 | |
*** tristan has quit IRC | 18:57 | |
*** jonathanmaw has quit IRC | 19:01 | |
*** tristan has joined #buildstream | 19:08 | |
gitlab-br-bot | cs-shadow closed issue #842 (File with invalid characters prevents Windows from checking out master) on buildstream https://gitlab.com/BuildStream/buildstream/issues/842 | 20:03 |
gitlab-br-bot | cs-shadow merged MR !1032 (chandan/fix-bad-filename-mini-disaster->master: tests/frontend/buildcheckout.py: Fix bad filename issue for Windows) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1032 | 20:03 |
*** mieszko has quit IRC | 20:10 | |
*** mieszko has joined #buildstream | 20:13 | |
*** rdale has quit IRC | 20:35 | |
gitlab-br-bot | tristanvb opened MR !1033 (tristan/toxic-linting->master: Run the linter separately from the tests) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1033 | 20:57 |
*** alatiera has quit IRC | 21:12 | |
*** mieszko has quit IRC | 21:19 | |
gitlab-br-bot | juergbi opened MR !1034 (juerg/arch->master: Accept architecture aliases) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1034 | 21:30 |
gitlab-br-bot | tristanvb merged MR !1033 (tristan/toxic-linting->master: Run the linter separately from the tests) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1033 | 22:09 |
gitlab-br-bot | tristanvb closed issue #831 (Some files using collections instead of collections.abc) on buildstream https://gitlab.com/BuildStream/buildstream/issues/831 | 22:36 |
gitlab-br-bot | tristanvb merged MR !1020 (coldtom/collections->master: Use collections.abc for Mapping, Iterable) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1020 | 22:36 |
*** vidal72[m] has left #buildstream | 22:41 | |
*** tristan has quit IRC | 22:44 | |
gitlab-br-bot | cs-shadow opened MR !1035 (chandan/update-requirements-one-liner->master: Add Makefile to update requirements files) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1035 | 23:06 |
gitlab-br-bot | cs-shadow closed issue #841 (There is no way to run our linting configuration directly with pycodestyle) on buildstream https://gitlab.com/BuildStream/buildstream/issues/841 | 23:15 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!