IRC logs for #buildstream for Thursday, 2019-01-03

*** nimish has joined #buildstream01:50
*** juergbi has quit IRC02:32
*** juergbi has joined #buildstream02:33
*** max_ has joined #buildstream02:34
*** max has quit IRC02:34
*** max_ is now known as max02:34
*** max has joined #buildstream02:35
gitlab-br-botcs-shadow opened (was WIP) MR !1027 (chandan/toxify->master: Use tox as a frontend for running tests) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/102703:06
*** nimish has quit IRC03:13
*** kapil___ has joined #buildstream04:53
*** alatiera has joined #buildstream05:35
*** kapil___ has quit IRC07:32
*** kapil___ has joined #buildstream07:59
*** rdale has joined #buildstream09:14
*** raoul has joined #buildstream09:31
*** mohan43u has quit IRC09:58
*** mohan43u has joined #buildstream10:10
*** jonathanmaw has joined #buildstream10:17
*** mohan43u has quit IRC10:23
*** mohan43u has joined #buildstream10:24
*** max has quit IRC10:26
*** mohan43u has quit IRC11:15
*** mohan43u has joined #buildstream11:16
gitlab-br-botjmacarthur approved MR !1030 (valentindavid/remote_execution_configuration->master: Remote execution configuration: HTTPS and user configuration) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/103011:43
tpollardbenschubert: interesting mail11:46
*** kapil___ has quit IRC11:53
*** alatiera has quit IRC11:53
*** vidal72[m] has quit IRC11:53
*** benschubert has quit IRC11:53
*** johnward has quit IRC11:53
*** persia has quit IRC11:53
*** phildawson_ has quit IRC11:53
*** valentind has quit IRC11:53
*** mablanch has quit IRC11:53
*** laurence has quit IRC11:53
*** bethw has quit IRC11:53
*** Trevinho[m] has quit IRC11:53
*** jmac has quit IRC11:53
*** flatmush_ has quit IRC11:53
*** pro[m] has quit IRC11:53
*** theawless[m] has quit IRC11:53
*** mattiasb has quit IRC11:53
*** oknf[m] has quit IRC11:53
*** tintou has quit IRC11:53
*** jjardon has quit IRC11:53
*** segfault3[m] has quit IRC11:53
*** rafaelff[m] has quit IRC11:53
*** waltervargas[m] has quit IRC11:53
*** inigomartinez has quit IRC11:53
*** cgmcintyre[m] has quit IRC11:53
*** tlater[m] has quit IRC11:53
*** asingh_[m] has quit IRC11:53
*** m_22[m] has quit IRC11:53
*** dbuch has quit IRC11:53
*** ssssam[m] has quit IRC11:53
*** kailueke[m] has quit IRC11:53
*** dineshdb[m] has quit IRC11:53
*** doras[m] has quit IRC11:53
*** abderrahim[m] has quit IRC11:53
*** connorshea[m] has quit IRC11:53
*** krichter[m] has quit IRC11:53
*** albfan[m] has quit IRC11:53
*** ironfoot has quit IRC11:53
*** lchlan has quit IRC11:53
*** awacheux[m] has quit IRC11:53
*** Demos[m] has quit IRC11:53
*** skullman has quit IRC11:53
*** jonathanmaw has quit IRC11:53
*** raoul has quit IRC11:53
*** chill has quit IRC11:53
*** SotK has quit IRC11:53
*** ctgriffiths has quit IRC11:53
*** tpollard has quit IRC11:53
*** slaf has quit IRC11:53
*** WSalmon has quit IRC11:53
*** jmac has joined #buildstream11:53
*** ironfoot has joined #buildstream11:53
*** lchlan has joined #buildstream11:53
*** benschubert has joined #buildstream11:53
*** laurence has joined #buildstream11:53
*** phildawson_ has joined #buildstream11:53
*** alatiera has joined #buildstream11:53
*** valentind has joined #buildstream11:53
*** doras[m] has joined #buildstream11:53
*** johnward has joined #buildstream11:55
*** dbuch has joined #buildstream11:55
*** mablanch has joined #buildstream11:55
*** tintou has joined #buildstream11:55
*** jjardon has joined #buildstream11:55
*** kapil___ has joined #buildstream11:55
*** skullman has joined #buildstream11:55
*** bethw has joined #buildstream11:55
*** persia has joined #buildstream11:55
*** WSalmon has joined #buildstream11:55
*** slaf has joined #buildstream11:55
*** tpollard has joined #buildstream11:55
*** ctgriffiths has joined #buildstream11:55
*** SotK has joined #buildstream11:55
*** chill has joined #buildstream11:55
*** raoul has joined #buildstream11:55
*** jonathanmaw has joined #buildstream11:55
*** flatmush has joined #buildstream11:55
*** persia has quit IRC11:57
*** persia has joined #buildstream11:57
*** ChanServ sets mode: +o ironfoot12:01
*** abderrahim[m] has joined #buildstream12:17
*** connorshea[m] has joined #buildstream12:20
*** krichter[m] has joined #buildstream12:26
*** albfan[m] has joined #buildstream12:32
*** raoul has quit IRC12:35
*** vidal72[m] has joined #buildstream12:49
*** raoul has joined #buildstream13:19
*** awacheux[m] has joined #buildstream13:20
*** Demos[m] has joined #buildstream13:24
*** Trevinho[m] has joined #buildstream13:29
*** theawless[m] has joined #buildstream13:33
*** pro[m] has joined #buildstream13:35
*** mattiasb has joined #buildstream13:44
*** nimish has joined #buildstream13:47
* tpollard gets caught out with the click7.0 req again13:47
*** nimish has quit IRC13:48
*** oknf[m] has joined #buildstream13:50
*** nimish has joined #buildstream13:58
*** rafaelff[m] has joined #buildstream14:05
gitlab-br-botcs-shadow opened MR !1032 (chandan/fix-bad-filename-mini-disaster->master: tests/frontend/buildcheckout.py: Fix bad filename issue for Windows) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/103214:16
tpollardnice branch name :)14:18
jmacIf anyone has a chance to review !1023 it'd be appreciated14:18
gitlab-br-botMR !1023: Stop resolving symlinks in _relative_symlink_target https://gitlab.com/BuildStream/buildstream/merge_requests/102314:18
*** waltervargas[m] has joined #buildstream14:20
*** max has joined #buildstream14:23
*** nimish has quit IRC14:34
*** nimish has joined #buildstream14:36
*** asingh_[m] has joined #buildstream14:37
*** asingh_[m] has quit IRC14:38
*** max has quit IRC14:38
*** waltervargas[m] has quit IRC14:38
*** oknf[m] has quit IRC14:38
*** theawless[m] has quit IRC14:38
*** Demos[m] has quit IRC14:38
*** raoul has quit IRC14:38
*** albfan[m] has quit IRC14:38
*** krichter[m] has quit IRC14:38
*** connorshea[m] has quit IRC14:38
*** abderrahim[m] has quit IRC14:38
*** persia has quit IRC14:38
*** johnward has quit IRC14:38
*** dbuch has quit IRC14:38
*** kapil___ has quit IRC14:38
*** jjardon has quit IRC14:38
*** tintou has quit IRC14:38
*** skullman has quit IRC14:38
*** flatmush has quit IRC14:38
*** bethw has quit IRC14:38
*** mablanch has quit IRC14:38
*** jonathanmaw has quit IRC14:38
*** chill has quit IRC14:38
*** SotK has quit IRC14:38
*** ctgriffiths has quit IRC14:38
*** tpollard has quit IRC14:38
*** slaf has quit IRC14:38
*** WSalmon has quit IRC14:38
*** skullman has joined #buildstream14:38
*** flatmush has joined #buildstream14:38
*** bethw has joined #buildstream14:38
*** kapil___ has joined #buildstream14:38
*** jjardon has joined #buildstream14:38
*** ChanServ sets mode: +o jjardon14:38
*** persia has joined #buildstream14:38
*** tintou has joined #buildstream14:39
*** mablanch has joined #buildstream14:39
*** jonathanmaw has joined #buildstream14:39
*** chill has joined #buildstream14:39
*** SotK has joined #buildstream14:39
*** ctgriffiths has joined #buildstream14:39
*** tpollard has joined #buildstream14:39
*** slaf has joined #buildstream14:39
*** WSalmon has joined #buildstream14:39
*** raoul has joined #buildstream14:39
*** max has joined #buildstream14:39
*** johnward has joined #buildstream14:39
*** segfault3[m] has joined #buildstream14:42
*** inigomartinez has joined #buildstream14:48
*** ssssam[m] has joined #buildstream14:48
*** tristan has joined #buildstream14:50
*** ChanServ sets mode: +o tristan14:50
*** cgmcintyre[m] has joined #buildstream14:53
*** kailueke[m] has joined #buildstream14:53
*** tlater[m] has joined #buildstream14:57
*** dineshdb[m] has joined #buildstream15:04
*** m_22[m] has joined #buildstream15:14
*** albfan[m] has joined #buildstream15:18
*** krichter[m] has joined #buildstream15:22
*** connorshea[m] has joined #buildstream15:29
*** abderrahim[m] has joined #buildstream15:29
*** dbuch has joined #buildstream15:38
*** asingh_[m] has joined #buildstream15:41
jmacIs there meant to be a `Dockerfile` in the main Buildsteam repo?15:45
gitlab-br-botBenjaminSchubert approved MR !1032 (chandan/fix-bad-filename-mini-disaster->master: tests/frontend/buildcheckout.py: Fix bad filename issue for Windows) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/103215:47
gitlab-br-bottristanvb merged MR !1027 (chandan/toxify->master: Use tox as a frontend for running tests) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/102715:47
tristanjmac, I don't think so15:48
tristanjmac, there is a contrib/bst-here and bst-docker-import15:49
tristanbst-here just uses the images from buildstream-docker-images repo, though15:49
tristancs-shadow, tests are now toxic !15:50
tristancs-shadow, I need you to share with me how you refresh the .txt files from the .in files, so I can jot that into the contributing guide15:51
*** waltervargas[m] has joined #buildstream15:51
*** juergbi has quit IRC15:53
cs-shadowyay! finally15:56
*** juergbi has joined #buildstream15:56
cs-shadowtristan: I use this little makefile at present: https://gitlab.com/BuildStream/buildstream/blob/chandan/tox-make/Makefile15:57
cs-shadowWe can either go with this approach, or add a tox environment to do the same15:57
tristancs-shadow, we can add the Makefile in the tools directory15:59
tristanI think we should probably rename that to the requirements directory or smth15:59
jmacThe buildstream-docker-images repo has instructions for building a buildstream docker image which appears to rely on buildstream having a dockerfile15:59
tristanit's possible we had one at one point16:00
*** oknf[m] has joined #buildstream16:01
cs-shadowjmac: seems like the instructions in the README are out-of-date, I'll update it soon. If you want to build something, just go the directory of the image you want to build, and run `docker build .`16:04
jmaccs-shadow: That works, thanks16:05
tristancs-shadow, strange, did you change something to cause half of the linter checks to be skipped now ?16:06
*** Demos[m] has joined #buildstream16:07
tristancs-shadow, either pylint or pycodestyle is running here, but not both16:07
*** juergbi has quit IRC16:07
tristan(one of them is collected by pytest and marked as SKIPPED)16:07
cs-shadowtristan: that wasn't expected, let me have a look16:08
*** nimish has quit IRC16:08
*** nimish has joined #buildstream16:08
*** theawless[m] has joined #buildstream16:08
cs-shadowtristan: that maybe because of pytest cache16:09
cs-shadowfor example, if you edit the file, is it still skipped?16:10
tristanEh ?16:10
tristanUmmm16:10
tristancs-shadow, we'll see16:11
cs-shadowi think pytest will cache test results locally in `.pytest_cache`. I was suggesting to `git clean` things and see if they are run when the cache is empty16:12
cs-shadowtristan: to clarify, this is locally, right? and not on CI16:12
tristancs-shadow, yeah16:14
tristan:)16:14
tristanit's winter here so I need to heat the table by running tox in a loop16:14
tristancs-shadow, do you know how to tell tox to parallelize the environments ?16:15
tristanI touched a file16:15
tristanoh maybe that wont work, maybe it's a content hash ?16:16
tristanoh no, that worked16:16
tristancs-shadow, indeed16:16
tristandid you enable that ? I hadn't seen it before16:16
*** juergbi has joined #buildstream16:17
cs-shadowtristan: cool, I think this is the default pytest behavior, I didn't change it as part of the tox change16:18
cs-shadowfor running thing in parallel, I think there's https://pypi.org/project/detox/ but I haven't tried it myself16:18
*** cs-shadow is now known as cs-shadow|afk16:19
tristancs-shadow|afk, maybe the pycodestyle plugin uses the cache but the pep8 one didnt16:24
tristananyway16:24
*** mieszko has joined #buildstream16:25
*** nimish has quit IRC16:33
*** nimish has joined #buildstream16:34
*** cs-shadow|afk is now known as cs-shadow16:49
cs-shadowtristan: hmm, https://pypi.org/project/pytest-pep8/ says that "... you can see that the pep8 check was skipped because the file has not been modified since it was last checked. As the pep8 plugin uses the pytest-cache plugin to implement its caching ..."16:50
*** tristan has quit IRC16:52
*** max has quit IRC16:53
*** tristan has joined #buildstream16:55
*** ChanServ sets mode: +o tristan16:55
*** tristan has left #buildstream16:55
*** tristan has joined #buildstream16:55
*** ChanServ sets mode: +o tristan16:55
*** max has joined #buildstream17:21
*** kapil___ has quit IRC17:42
*** raoul has quit IRC17:52
jmacI'm having some trouble setting up the bst-artifact-server docker image. The server starts up correctly, but I cannot guess what CN it's decided to use inside the container for the server. It keeps giving errors like:17:55
jmacE0103 17:54:50.103117643      13 ssl_transport_security.cc:1566] No match found for server name: 127.0.0.1.17:55
jmacI've tried 127.0.0.1 and localhost17:55
cs-shadowjmac: https://gitlab.com/BuildStream/buildstream-docker-images/blob/master/artifact-cache/bst-artifact-cache-start#L6 suggests localhost17:59
cs-shadowunless of course CN is already set to something else17:59
jmacYeah, that's what I thought. I've tried passing in CN with `-e CN=<thing>` on the command line too.18:01
cs-shadowhmm, not sure. Would be useful to add your error to https://gitlab.com/BuildStream/buildstream-docker-images/issues/22, I'll try to reproduce this later today18:02
*** max has quit IRC18:04
jmacActually, I think I know the answer to #2218:05
gitlab-br-botIssue #22: failed to upgrade buildstream at 640a734ec1db923b5 https://gitlab.com/BuildStream/buildstream/issues/2218:05
cs-shadowah! that would also be good to know :)18:05
jmacWell, not the answer, but a workaround. I've updated the issue.18:08
jmacI'll have a think about the CN thing; if I haven't figured it out overnight I'll post an issue about it.18:09
*** nimish has quit IRC18:37
*** tristan has quit IRC18:57
*** jonathanmaw has quit IRC19:01
*** tristan has joined #buildstream19:08
gitlab-br-botcs-shadow closed issue #842 (File with invalid characters prevents Windows from checking out master) on buildstream https://gitlab.com/BuildStream/buildstream/issues/84220:03
gitlab-br-botcs-shadow merged MR !1032 (chandan/fix-bad-filename-mini-disaster->master: tests/frontend/buildcheckout.py: Fix bad filename issue for Windows) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/103220:03
*** mieszko has quit IRC20:10
*** mieszko has joined #buildstream20:13
*** rdale has quit IRC20:35
gitlab-br-bottristanvb opened MR !1033 (tristan/toxic-linting->master: Run the linter separately from the tests) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/103320:57
*** alatiera has quit IRC21:12
*** mieszko has quit IRC21:19
gitlab-br-botjuergbi opened MR !1034 (juerg/arch->master: Accept architecture aliases) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/103421:30
gitlab-br-bottristanvb merged MR !1033 (tristan/toxic-linting->master: Run the linter separately from the tests) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/103322:09
gitlab-br-bottristanvb closed issue #831 (Some files using collections instead of collections.abc) on buildstream https://gitlab.com/BuildStream/buildstream/issues/83122:36
gitlab-br-bottristanvb merged MR !1020 (coldtom/collections->master: Use collections.abc for Mapping, Iterable) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/102022:36
*** vidal72[m] has left #buildstream22:41
*** tristan has quit IRC22:44
gitlab-br-botcs-shadow opened MR !1035 (chandan/update-requirements-one-liner->master: Add Makefile to update requirements files) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/103523:06
gitlab-br-botcs-shadow closed issue #841 (There is no way to run our linting configuration directly with pycodestyle) on buildstream https://gitlab.com/BuildStream/buildstream/issues/84123:15

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!