| *** nimish has joined #buildstream | 01:08 | |
| *** max has quit IRC | 01:19 | |
| *** tristan has quit IRC | 01:43 | |
| *** nimish has quit IRC | 02:45 | |
| *** kapil___ has joined #buildstream | 03:00 | |
| *** tristan has joined #buildstream | 03:50 | |
| *** nimish has joined #buildstream | 05:51 | |
| *** mimaz has joined #buildstream | 06:15 | |
| *** kapil___ has quit IRC | 06:40 | |
| *** alatiera has joined #buildstream | 06:53 | |
| *** mimaz has quit IRC | 07:39 | |
| *** kapil___ has joined #buildstream | 07:53 | |
| *** rdale has joined #buildstream | 09:28 | |
| *** phildawson_ has joined #buildstream | 09:33 | |
| *** jonathanmaw has joined #buildstream | 10:02 | |
| *** tpollard has joined #buildstream | 10:03 | |
| *** kapil___ has quit IRC | 10:10 | |
| *** Nexus has left #buildstream | 10:36 | |
| gitlab-br-bot | LaurenceUrhegyi approved MR !1026 (chandan/update-doc-makefile-note->master: doc/Makefile: Update comment about sphinx entrypoint) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1026 | 10:50 |
|---|---|---|
| gitlab-br-bot | phildawson approved MR !1026 (chandan/update-doc-makefile-note->master: doc/Makefile: Update comment about sphinx entrypoint) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1026 | 10:54 |
| *** raoul has joined #buildstream | 10:59 | |
| *** nimish has quit IRC | 11:01 | |
| *** nimish has joined #buildstream | 11:01 | |
| phildawson_ | hmm, if i go to docs.buildstream.build, firefox is warning me about an expired certificate | 11:28 |
| phildawson_ | buildstream.build is fine though | 11:28 |
| tpollard | who controls those certs, jjardon? | 11:30 |
| gitlab-br-bot | valentindavid opened MR !1030 (valentindavid/remote_execution_configuration->master: Valentindavid/remote execution configuration) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1030 | 11:41 |
| laurence | nice one, valentind :) | 11:51 |
| valentind | laurence, I did that before holidays, but I did not want to submit it in a rush. | 11:52 |
| laurence | valentind, cool, I think that use of the 'self-assign' feature on gitlab issues is very useful for this | 11:52 |
| laurence | allows others to know you're planning to take it on | 11:53 |
| laurence | I am a fan of it, and will incorporate it into the new guidelines | 11:53 |
| laurence | s/will/think we should/ | 11:54 |
| valentind | Happy new year by the way. | 11:54 |
| *** cs-shadow has joined #buildstream | 11:58 | |
| *** raoul has quit IRC | 12:04 | |
| *** nimish has quit IRC | 12:06 | |
| *** nimish has joined #buildstream | 12:07 | |
| tlater[m] | Happy new year :) | 12:15 |
| *** rdale has quit IRC | 12:26 | |
| *** rdale has joined #buildstream | 12:28 | |
| gitlab-br-bot | tlater approved MR !1020 (coldtom/collections->master: Use collections.abc for Mapping, Iterable) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1020 | 12:31 |
| *** raoul has joined #buildstream | 12:40 | |
| gitlab-br-bot | cs-shadow opened issue #838 (Add tests for python 3.7) on buildstream https://gitlab.com/BuildStream/buildstream/issues/838 | 13:01 |
| *** nimish has quit IRC | 13:02 | |
| *** nimish has joined #buildstream | 13:02 | |
| cs-shadow | Happy new year :) | 13:11 |
| cs-shadow | One of my pipelines (https://gitlab.com/BuildStream/buildstream/-/jobs/140569928) recently hit a seg fault, which seems unrelated to the change. Has anyone seen seg faults in our CI before? | 13:11 |
| cs-shadow | Maybe I just got unlucky on first pipeline of the year | 13:11 |
| tpollard | I've definitely seen the debian pipeline seg before | 13:12 |
| tpollard | happy new year also :) | 13:12 |
| cs-shadow | ah, so I'm not alone. I assume we didn't manage to get any insights about it in the past? | 13:13 |
| *** kapil___ has joined #buildstream | 13:13 | |
| cs-shadow | and we keep hitting the job with the rebuild hammer until it passes | 13:13 |
| tpollard | I can't see an issue for it, we should probably at least raise it | 13:14 |
| * cs-shadow is creating one now | 13:14 | |
| tpollard | :) | 13:14 |
| tlater[m] | Ooi, do the aarch64 runners on buildstream-docker-images only work at a certain time or something? The CI for that was stuck waiting for those runners for a pretty long time yesterday. | 13:15 |
| valentind | tlater[m], they were down. | 13:15 |
| valentind | I put them back on. | 13:16 |
| tlater[m] | Ah, fair enough | 13:16 |
| valentind | Network goes does down from time to time. I still have to figure out why. | 13:16 |
| cs-shadow | tlater[m]: we were considering making the aarch64 builds optional in https://gitlab.com/BuildStream/buildstream-docker-images/issues/24 | 13:17 |
| gitlab-br-bot | cs-shadow opened issue #840 (CI Piepline sometimes seg faults on debian:9) on buildstream https://gitlab.com/BuildStream/buildstream/issues/840 | 13:19 |
| *** nimish has quit IRC | 13:27 | |
| *** nimish has joined #buildstream | 13:38 | |
| gitlab-br-bot | cs-shadow merged MR !1026 (chandan/update-doc-makefile-note->master: doc/Makefile: Update comment about sphinx entrypoint) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1026 | 13:42 |
| *** nimish has quit IRC | 13:48 | |
| *** nimish has joined #buildstream | 13:48 | |
| *** juergbi has quit IRC | 13:52 | |
| *** juergbi has joined #buildstream | 13:52 | |
| *** alatiera_ has joined #buildstream | 13:55 | |
| *** raoul_ has joined #buildstream | 13:55 | |
| *** nimish has quit IRC | 13:56 | |
| *** raoul has quit IRC | 13:56 | |
| *** rdale has quit IRC | 13:56 | |
| *** tpollard has quit IRC | 13:56 | |
| *** alatiera has quit IRC | 13:56 | |
| *** johnward has quit IRC | 13:56 | |
| *** lantw44 has quit IRC | 13:56 | |
| *** phildawson has quit IRC | 13:56 | |
| *** Trevinho has quit IRC | 13:56 | |
| *** jennis has quit IRC | 13:56 | |
| *** ikerperez has quit IRC | 13:56 | |
| *** adds68 has quit IRC | 13:56 | |
| *** coldtom has quit IRC | 13:56 | |
| *** persia has quit IRC | 13:56 | |
| *** ctgriffiths has quit IRC | 13:56 | |
| *** chill has quit IRC | 13:56 | |
| *** SotK has quit IRC | 13:56 | |
| *** tpollard has joined #buildstream | 13:57 | |
| *** persia has joined #buildstream | 13:58 | |
| *** ctgriffiths has joined #buildstream | 13:59 | |
| *** rdale has joined #buildstream | 13:59 | |
| *** johnward has joined #buildstream | 14:03 | |
| *** SotK has joined #buildstream | 14:06 | |
| *** chill has joined #buildstream | 14:11 | |
| *** raoul_ is now known as raoul | 14:19 | |
| laurence | for those interested in attending the Gathering at the end of January, in London, please either add your name here or ping me and I'll add it | 15:16 |
| laurence | https://wiki.gnome.org/Projects/BuildStream/Events/Gathering-201901#preview | 15:16 |
| jmac | Done | 15:31 |
| tpollard | you can add me laurence :) | 15:33 |
| raoul | me too laurence | 15:35 |
| laurence | done and done | 16:00 |
| tlater[m] | Would someone mind taking a look at https://gitlab.com/BuildStream/buildstream/merge_requests/638? It's a pretty small one. | 16:08 |
| jmac | I will | 16:12 |
| * tlater[m] hopes rebasing didn't add new linting errors, but that should be pretty minor | 16:13 | |
| *** max has joined #buildstream | 16:14 | |
| jmac | jjardon: Why did all the image names change in .gitlab-ci.yml in https://gitlab.com/BuildStream/buildstream/merge_requests/638 ? | 16:15 |
| tlater[m] | jmac: That's my commit | 16:16 |
| tlater[m] | We needed a new version of pycodestyle to be installed | 16:16 |
| tlater[m] | So the image versions need to be bumped (the new pycodestyle version was released two weeks ago) | 16:16 |
| *** jennis has joined #buildstream | 16:17 | |
| *** coldtom has joined #buildstream | 16:18 | |
| *** ikerperez has joined #buildstream | 16:18 | |
| *** phildawson has joined #buildstream | 16:18 | |
| *** adds68 has joined #buildstream | 16:18 | |
| jmac | tlater[m]: Bumping the versions makes sense, I was just curious as to why it's changed from `master-123` to `06bab030` | 16:19 |
| cs-shadow | jmac: that's because we changed the versioning scheme of the testsuite images to have the commit sha | 16:20 |
| tlater[m] | I think that's a quirk from the recent updates to the docker images | 16:20 |
| tlater[m] | Yeah :) | 16:20 |
| jmac | Sounds good. No other comments from me, looks good. | 16:25 |
| *** lantw44 has joined #buildstream | 16:25 | |
| tlater[m] | Thanks @cs | 16:27 |
| tlater[m] | cs-shadow: | 16:27 |
| tlater[m] | jmac: | 16:27 |
| tlater[m] | x) | 16:27 |
| cs-shadow | :) | 16:27 |
| tlater[m] | I'll check if we can move the configuration | 16:27 |
| tlater[m] | But I'm not sure it's possible, pytest-pycodestyle is how we currently run the linter. | 16:27 |
| *** max has quit IRC | 16:28 | |
| cs-shadow | For example, if we can put it under something like `pycodestyle` section then I would imagine that both pycodestyle and pytest-codestyle are able to read it. But I haven't verified this just yet. I can also look into this later as this is somewhat orthogonal to your MR | 16:32 |
| cs-shadow | definitely not a blocker for me | 16:32 |
| *** Trevinho has joined #buildstream | 16:33 | |
| tlater[m] | cs-shadow: Eh, I'm already checking just that - might as well get it perfect ;) | 16:36 |
| *** nimish has joined #buildstream | 16:38 | |
| tlater[m] | Judging by 123 max-line-length failures, looks like that's not possible :| We could duplicate the configuration, but that seems off. | 16:39 |
| *** mimaz has joined #buildstream | 16:41 | |
| gitlab-br-bot | tlater opened (was WIP) MR !638 (jjardon/pycodestyle->master: Use pycodestyle instead pep8 python module) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/638 | 16:44 |
| gitlab-br-bot | tlater opened issue #841 (There is no way to run pycodestyle without `setup.py` while maintaining our configuration) on buildstream https://gitlab.com/BuildStream/buildstream/issues/841 | 16:49 |
| raoul | Is there a way of getting the gitlab CI to run a specific test? I'm having issues with 2 tests on the debian image, but it works locally and all other images | 16:50 |
| *** nimish has quit IRC | 16:50 | |
| tlater[m] | raoul: By "locally" do you mean you've tried running the test in a local docker container? | 16:51 |
| tlater[m] | If so, you'll need to modify .gitlab-ci.yml | 16:52 |
| tlater[m] | Remove all but the image you want to test, and modify the TEST_COMMAND variable | 16:52 |
| tlater[m] | But well, it's a lot simpler to spin up a testsuite image locally | 16:53 |
| raoul | ah yeah, guess I should be trying it with docker images | 16:53 |
| raoul | time to remind myself how to use docker then | 16:54 |
| tlater[m] | raoul: If you can figure out how to use it, this may be handy: https://gitlab.com/BuildStream/buildstream/snippets/1684930 | 16:54 |
| tlater[m] | But it's not well maintained atm. I need to sit down and update it at some point. | 16:54 |
| raoul | I shall see if it works, should give an idea of what to do at least | 16:56 |
| raoul | cheers :) | 16:56 |
| *** tristan has quit IRC | 17:08 | |
| *** max has joined #buildstream | 17:15 | |
| *** benschubert has joined #buildstream | 17:15 | |
| benschubert | Hey, I have a question about warnings, are they always project specific or can we have them globally at the user conf? | 17:16 |
| *** raoul has quit IRC | 17:16 | |
| tpollard | I think they're only parsed from project config | 17:18 |
| *** raoul has joined #buildstream | 17:20 | |
| benschubert | And thus, they are per project only and no way of overriding them, correct? | 17:20 |
| *** tristan has joined #buildstream | 17:25 | |
| gitlab-br-bot | tlater opened MR !1031 (tlater/message-lines->master: Avoid "showing 0 lines" messages when there are no lines) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1031 | 17:28 |
| gitlab-br-bot | tlater merged MR !638 (jjardon/pycodestyle->master: Use pycodestyle instead pep8 python module) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/638 | 17:32 |
| tlater[m] | Hmm... What's our policy on tests for buildstream output? I just fixed #799, but to write a test I'd need to write something that asserts a specific bit of text turns up in buildstream's output. | 17:32 |
| gitlab-br-bot | Issue #799: Remote execution: Make TLS and client certificate optional for storage service https://gitlab.com/BuildStream/buildstream/issues/799 | 17:32 |
| tlater[m] | We have a few tests that do that, but I've heard that we don't want to do that too much on occasion. Mostly citing possible text changes and future localization. | 17:32 |
| jmac | I don't see how we can avoid it if we want to do true end-to-end testing; we'd just have to localise the tests as well | 17:34 |
| raoul | after faffing with docker for a bit to get it working your script seems to work tlater[m] | 17:39 |
| tlater[m] | \o/ It's a little quirky though, so don't expect launching it again to give you the same cache ;) | 17:41 |
| raoul | haha, it's working for the one thing I want it for, so I'm happy :P thanks again :) | 17:45 |
| cs-shadow | can someone please verify that https://docs.buildstream.build doesn't have a valid certificate and it's not just me :) | 17:51 |
| cs-shadow | Also, see https://gitlab.com/BuildStream/website/issues/10#note_127932243 | 17:51 |
| *** ChanServ sets mode: +o tristan | 17:54 | |
| tristan | cs-shadow, ah I saw something about that whiz passed me in my inbox, I'll try to find out | 17:55 |
| cs-shadow | thanks! | 17:55 |
| *** max has quit IRC | 17:58 | |
| tristan | cs-shadow, how about the tox stuff, are you going to work on it ? | 18:11 |
| tristan | ummm put another way; I would be delighted to give that branch love myself if you are setting it aside and it was a sort of holiday distraction ;-) | 18:12 |
| tristan | looks like you did make progress on it | 18:23 |
| *** raoul has quit IRC | 18:27 | |
| *** jonathanmaw has quit IRC | 18:38 | |
| *** rdale has quit IRC | 18:44 | |
| cs-shadow | tristan: https://gitlab.com/BuildStream/buildstream/merge_requests/1027 should be ready for review, it's in WIP state as the docker-images change would happen first. | 18:45 |
| cs-shadow | once you (and others) are happy with this MR, i can make the corresponding change to the docker-images | 18:45 |
| tristan | cs-shadow, I was just looking at it | 18:45 |
| tristan | made a comment | 18:45 |
| cs-shadow | I still wish to make some more improvements to it, but I think we can do those in increments | 18:46 |
| * cs-shadow just notices the commets | 18:46 | |
| tristan | lemme make sure my lookover is thorough | 18:46 |
| tristan | I accidentally commented on your FIXME | 18:46 |
| tristan | which I guess needs the docker image change first | 18:46 |
| cs-shadow | np :) | 18:46 |
| cs-shadow | yep, there's a corresponding MR for that, which is also ready to go (barring one change that I need to do) | 18:47 |
| tristan | I think we should rename requirements.in -> requirements.txt | 18:47 |
| tristan | and rename the current requirements.txt -> constraints.txt | 18:48 |
| tristan | and remove all of the stuff from setup.py | 18:48 |
| tristan | but maybe that can be a separate thing | 18:48 |
| tristan | I could try to cleanup setup.py in some way after | 18:48 |
| tristan | oh you did it too ! | 18:49 |
| cs-shadow | hmm, I was thinking to follow the same convention for all requirements file. I had proposed .in for unconstrained and .txt for constrained. | 18:49 |
| cs-shadow | We can also go with .txt for unfrozen, and something like `.frozen.txt` if you'd like to keep requirements.txt for this purpose | 18:49 |
| tristan | With the same trick yeah that is fine | 18:49 |
| cs-shadow | my only concern is that the same extension for all of the requirement files to avoid confusion | 18:49 |
| tristan | cs-shadow, is that the convention ? | 18:50 |
| tristan | That is fine by me then | 18:50 |
| tristan | I find it to be a strange convention; the ".in" to me says that it is input for a file that needs preprocessing in the build | 18:50 |
| cs-shadow | yeah, it's not very obvious. I have seen different conventions in different places so can't say if this is followed everywhere. I know that some tools like https://github.com/jazzband/pip-tools try to promote this convention but there's no real consistency in the wild about this | 18:52 |
| cs-shadow | I am personally not attached to the .in extension so long as we change it for all the files | 18:53 |
| cs-shadow | do `.txt` and `.frozen.txt`sound better to you? | 18:53 |
| tristan | I see | 18:54 |
| tristan | cs-shadow, so what I understand is there are two approaches, and the doc says that basically "requirements.txt is the input of tools, requirements.in is the input to generate requirements.txt" | 18:56 |
| tristan | cs-shadow, the other approach is to have both be the input of tools | 18:56 |
| tristan | am I onto something ? | 18:56 |
| cs-shadow | not sure, I think in our case the .in serves a dual purpose - it's an input to tools and is also the input for requirements.txt | 18:57 |
| tristan | cs-shadow, basically; by putting the output of pip-compile or pip freeze into requirements.txt, then you are advertising that these are the specific requirements | 18:57 |
| tristan | cs-shadow, the other approach is to have requirements.txt be more loosely defined, and add a constraints file which can be combined (it might add only some constraints, or it might be a full pip freeze) | 18:58 |
| cs-shadow | i mean we already have both the files, it's just about the naming I suppose, right? | 18:59 |
| tristan | I think so yes | 19:00 |
| cs-shadow | we have these files at the moment: https://gitlab.com/BuildStream/buildstream/tree/bf5f9ef4d9b45ef10dc0f2c2e9db9edd7534f646/tools | 19:00 |
| tristan | well | 19:00 |
| tristan | cs-shadow, the result is technically different too, if you have both a requirements.txt and a constraints.txt, then you have a slightly more complex install I guess | 19:01 |
| tristan | so using the "requirements.in -> requirements.txt -> python environment install" road means there is only one file ever | 19:01 |
| tristan | cs-shadow, I guess also when people install with pip, they will by default use the requirements.txt ? | 19:02 |
| tristan | I think this is confusing to me because setuptools is confusing | 19:02 |
| tristan | It is possible to have no setup.py and have a requirements.txt I think | 19:03 |
| tristan | cs-shadow, lets drop this; I'm having a hard time to know what is better at this point, and we can just change it later | 19:03 |
| cs-shadow | tristan: yes, that's also possible. But, at this point, _nothing_ is changing for people using setup.py | 19:05 |
| cs-shadow | the txt files are used by tox, and nothing else | 19:05 |
| cs-shadow | nothing in standard python tooling recognizes requirements.txt as special, so I won't expect people's workflow to change because of this. The only thing is that the package maintainers will have to look at the `.in` file for requirements | 19:06 |
| cs-shadow | we can always iterate on it as you said :) | 19:06 |
| tristan | cs-shadow, yeah just realized it was not worth focusing on :) | 19:07 |
| cs-shadow | tristan: cool, let me know if you'd like me to update anything else :) | 19:08 |
| tristan | cs-shadow, I just looked through it, found one important spot I think | 19:15 |
| cs-shadow | tristan: thanks! good catch about INTEGRATION_CACHE, I missed that | 19:15 |
| tristan | cs-shadow, we probably want it in docs too, maybe one day we'll merge INTEGRATION_CACHE and BST_SOURCE_CACHE, that is stupidly redundant | 19:16 |
| tristan | (probably I did that) | 19:16 |
| tristan | cs-shadow, besides that, I think we want to prepare an image, and make this branch use the new image, and remove the FIXME parts where we install non-python stuff | 19:17 |
| tristan | then land it | 19:17 |
| tristan | cs-shadow, once this lands, I'll try to remove the sdist step from gitlab CI, since tox does it for us, and change the overnight tests to also run through tox | 19:19 |
| tristan | (I'll *try* to ditch the whole ./unpack.sh thing if I can delegate it all to tox) | 19:20 |
| cs-shadow | tristan: definitely, I'll fix the FIXME before landing. | 19:20 |
| cs-shadow | tristan: I'd like to ditch the unpacking business as well. I didn't do it just yet as other jobs (like post-test) use it | 19:20 |
| tristan | yeah | 19:21 |
| cs-shadow | but that should be achievable with tox, I'd hope | 19:21 |
| tristan | only in coverage and overnight tests | 19:21 |
| tristan | yes certainly | 19:21 |
| tristan | Just tricky to get the invocation to be nice | 19:21 |
| *** kapil___ has quit IRC | 19:22 | |
| tristan | I wonder if there is a set of default "environments" for tox | 19:22 |
| tristan | so that when you just run "tox", it will only run the tests, unless you do "tox -e docs" | 19:22 |
| * tristan runs `tox` on cs-shadow's branch :) | 19:23 | |
| cs-shadow | yep, that's exactly what envlist does | 19:23 |
| tristan | hmm | 19:24 |
| cs-shadow | https://gitlab.com/BuildStream/buildstream/blob/bf5f9ef4d9b45ef10dc0f2c2e9db9edd7534f646/tox.ini#L2 -> since docs isn't listed there, it shouldn't get run unless you do `-e docs` | 19:24 |
| *** tristan has quit IRC | 19:27 | |
| *** tristan has joined #buildstream | 19:27 | |
| *** ChanServ sets mode: +o tristan | 19:28 | |
| tristan | cs-shadow, pytest: error: unrecognized arguments: --codestyle | 19:28 |
| cs-shadow | tristan: sorry, I messed up a rebase, it's not listed as a requirement on my branch. Let me fix that quickly | 19:29 |
| tristan | tlater[m], still around ? | 19:33 |
| tristan | or too late for you ? | 19:33 |
| tlater[m] | tristan: Incidentally, yes | 19:33 |
| tristan | tlater[m], Do you have time to fix the commit message on https://gitlab.com/BuildStream/buildstream/merge_requests/1031 so that it doesn't close the wrong issue, and merge it ? | 19:34 |
| tristan | :) | 19:34 |
| tlater[m] | Haha, sure, I wanted to write a test first | 19:35 |
| tlater[m] | But I suppose I can merge it for now and add a test later | 19:35 |
| tristan | tlater[m], yeah a test would be welcome | 19:35 |
| cs-shadow | tristan: if you try the new version of my branch, you should hopefully get better results than last time | 19:49 |
| *** juergbi has quit IRC | 19:51 | |
| *** juergbi has joined #buildstream | 19:54 | |
| * cs-shadow needs to catch his train now | 19:54 | |
| * cs-shadow tristan: I'll update the docker-images later tonight and un-WIP the tox MR for one final review tomorrow | 19:54 | |
| tristan | cs-shadow, cool :) | 19:55 |
| tristan | cs-shadow, codestyle not fixed ? | 19:56 |
| * tristan wanted to run it :) | 19:56 | |
| cs-shadow | tristan: should be, are you on 03e50fdf04801f8086cd1a710f8bd0136534d635 ? | 19:57 |
| tristan | cs-shadow, yes | 19:57 |
| tristan | and I have no codestyle in my requirements afaics | 19:58 |
| tristan | wait I do | 19:58 |
| cs-shadow | ah! i think i know | 19:58 |
| cs-shadow | try adding -r to your tox invocation | 19:58 |
| tlater[m] | Might need to pip install again | 19:58 |
| cs-shadow | tox won't automatically recreate the environment if the requirements file changes | 19:58 |
| * tristan runs `git clean -xdff` | 19:59 | |
| * cs-shadow feels we should add something `-r`/`--recreate` to the docs as this may trip people up | 20:00 | |
| cs-shadow | *something about | 20:00 |
| tristan | cs-shadow, is it easier to teach that or to teach `git clean -xdf` | 20:00 |
| tristan | or -xdff, not sure if double force is needed in this case to bypass .gitignore | 20:01 |
| tristan | I think so | 20:01 |
| cs-shadow | i feel like `git clean -fdx` has the potential to destroy people's work if they are not cautious | 20:01 |
| tristan | Yeah, I dont know, I know it is destructive but prefer only needing to know it hehe | 20:02 |
| cs-shadow | sidenote: `-ff` should only be needed if you want it to remove git repos | 20:02 |
| tristan | ah | 20:02 |
| tristan | maybe that's why I always use it with BuildStream | 20:02 |
| tristan | (git repos we create at test time) | 20:03 |
| tristan | tests are running now, that did it | 20:03 |
| tlater[m] | tristan: Hrm, I can't get this test written up as quickly as I'd hoped. I'll defer that to later this week, do you still want me to merge? | 20:04 |
| tristan | they take about 40 min here | 20:04 |
| tristan | tlater[m], yeah | 20:04 |
| * cs-shadow really needs to run, will catch you later :) | 20:04 | |
| tristan | cs-shadow, later :) | 20:04 |
| tlater[m] | tristan: Fixed the message, set to merge :) I'm also finishing up for the night, o/ | 20:06 |
| *** alatiera_ has quit IRC | 20:06 | |
| tristan | \o | 20:16 |
| *** vidal72[m] has joined #buildstream | 20:42 | |
| *** milloni has joined #buildstream | 21:06 | |
| *** milloni has quit IRC | 21:10 | |
| *** milloni has joined #buildstream | 21:11 | |
| *** mimaz has quit IRC | 21:24 | |
| *** tristan has quit IRC | 21:48 | |
| *** tristan has joined #buildstream | 21:48 | |
| *** mimaz has joined #buildstream | 21:53 | |
| *** max has joined #buildstream | 21:54 | |
| *** mimaz has quit IRC | 21:59 | |
| *** mieszko has joined #buildstream | 22:15 | |
| gitlab-br-bot | BenjaminSchubert opened issue #842 (File with invalid characters prevents Windows from checking out master) on buildstream https://gitlab.com/BuildStream/buildstream/issues/842 | 22:18 |
| *** mieszko has quit IRC | 22:38 | |
| *** tristan has quit IRC | 22:39 | |
| *** mieszko has joined #buildstream | 22:56 | |
| *** mieszko has quit IRC | 23:18 | |
| *** mieszko has joined #buildstream | 23:19 | |
| *** mieszko has quit IRC | 23:23 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!