IRC logs for #buildstream for Thursday, 2020-09-24

*** benschubert has quit IRC00:05
*** tristan has joined #buildstream05:18
*** ChanServ sets mode: +o tristan05:18
*** WSalmon has quit IRC05:44
*** WSalmon has joined #buildstream05:46
gitlab-br-bottristanvb closed issue #1240 (Commands to disable remote cache are being ignored / they do not work) on buildstream https://gitlab.com/BuildStream/buildstream/-/issues/124006:19
gitlab-br-bottristanvb closed issue #1396 (Add a way to force a local build) on buildstream https://gitlab.com/BuildStream/buildstream/-/issues/139606:19
tristanLets land this pronto: https://gitlab.com/BuildStream/website/-/merge_requests/14407:04
tristanHow do I run the src/buildstream/testing/_sourcetests/track_cross_junction.py tests ?07:27
tristanMaybe just tox -e py38-nocover -- --integration src/buildstream/testing/_sourcetests/track_cross_junction.py07:28
* tristan tries07:28
tristannope07:29
tristanThats some weird thing going on there which needs to be fixed iirc :-S07:29
tristan--plugins07:31
tristanyeah... /me can't wait for ben to set that straight... better lend a hand on this threading stuff so that can happen sooner...07:31
tristanAnd how do you selectively run one of the `--plugins` tests ?07:43
*** toscalix has joined #buildstream07:56
*** toscalix has quit IRC08:35
*** santi has joined #buildstream08:47
tristanIt looks like we're not getting the START/SKIPPED messages one might expect for a task where the Queue.status() method returned QueueStatus.SKIP08:55
juergbitristan: yes, for tasks that are skipped before even creating a job, there is no log message. for tasks that start a job and then set status as skipped, we get START+SKIPPED08:57
juergbiit can cut down noise but is somewhat inconsistent08:58
tristanjuergbi, Would you be against adding a START/SKIPPED pair for that ?08:58
juergbiI'm not sure. it may make sense to discuss this as part of my WIP move of cache query into jobs08:58
tristanHmmm08:59
juergbiwe have to think about what logging is best there by default08:59
tristanOk, I'll set that aside for now08:59
tristanRight, had part of that discussion in context of my other branch08:59
tristanwith Ben, you probably noticed08:59
juergbinot sure, might not have read that in detail09:00
juergbitristan: btw: !2073 is the filter fix with regression test I mentioned yesterday. is this ok for you?09:00
gitlab-br-botMR !2073: filter.py: Combine integration commands in assemble() https://gitlab.com/BuildStream/buildstream/-/merge_requests/207309:01
juergbi(ignoring potential removal of dynamic public data or additional public data pass through for now)09:01
tristanjuergbi, Quick review, don't understand the test; but I really gotta run straight away...09:09
tristanclass starting in 2009:09
juergbiok, thanks09:09
* tristan commented on mr...09:10
tristanhttps://gitlab.com/BuildStream/buildstream/-/merge_requests/2072 is about ready now, should finally pass it's tests09:11
tristanand ensures consistent skip message behavior for sources which don't implement track() (like workspaces or local or patch sources), and adds a skip test09:12
*** tristan has quit IRC09:16
*** tristan has joined #buildstream09:23
*** ChanServ sets mode: +o tristan09:23
*** tristan_ has joined #buildstream09:29
*** ChanServ sets mode: +o tristan_09:29
*** tristan has quit IRC09:31
*** tomaz has joined #buildstream09:49
tomazpeople, a pipeline failed for me with: "  OSError: [Errno 24] Too many open files: "09:50
tomazthis is something that buildstream should take care? the number of open files on the OS?09:51
juergbitomaz: do you have a backtrace? is this with 1.x or master?10:01
tomazjuergbi: pipeline is running again, Ill paste the backtrace as soon as it fails.10:02
tomazit's on 1.x10:02
tomazfreedesktopsdk is still on 1.x10:03
juergbion 1.x we increase the process file limit as high as the system allows as pyfuse safehardlinks can need a lot of file descriptors10:03
juergbiif this still is insufficient, the system may have a low hard limit (it's configurable in Linux)10:04
juergbithere may be further improvements to this aspect that could be done in 1.x, however, master should no longer have this issue at all with buildbox-fuse10:05
gitlab-br-bottristanvb approved MR !2072 (tristan/remove-bst-key-requires-stage->master: source.py: Remove BST_KEY_REQUIRES_STAGE) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/207211:11
gitlab-br-botmarge-bot123 merged MR !2072 (tristan/remove-bst-key-requires-stage->master: source.py: Remove BST_KEY_REQUIRES_STAGE) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/207211:11
tristan_Are we okay to merge https://gitlab.com/BuildStream/buildstream/-/merge_requests/2070 without additional tests in advance of deciding on logging modes ?11:15
tristan_I think so, but would like some review on the branch if possible11:15
tristan_just me or the pipelines view on gitlab is totally borked11:51
tristan_https://gitlab.com/BuildStream/buildstream/-/pipelines/19397343511:51
tristan_can't see the jobs correctly at the bottom11:51
*** tristan_ has quit IRC12:06
*** tristan_ has joined #buildstream12:07
*** ChanServ sets mode: +o tristan_12:07
gitlab-br-botjuergbi approved MR !2073 (juerg/filter-pass-integration->master: filter.py: Combine integration commands in assemble()) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/207313:57
gitlab-br-botmarge-bot123 merged MR !2073 (juerg/filter-pass-integration->master: filter.py: Combine integration commands in assemble()) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/207313:57
*** tristan_ has quit IRC14:11
*** tristan_ has joined #buildstream14:11
*** ChanServ sets mode: +o tristan_14:11
gitlab-br-botjuergbi opened MR !2074 (juerg/artifact-pull->master: Artifact pull code improvements) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/207414:58
douglaswinshiptristan_: i'm having a lot of trouble with GitLab too. I found it could often get it to reset if I collapsed the sidebar, and then re-expanded it15:23
*** santi has quit IRC17:38

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!