| *** tristan has quit IRC | 05:51 | |
| *** tristan has joined #buildstream | 06:28 | |
| *** ChanServ sets mode: +o tristan | 06:29 | |
| gitlab-br-bot | juergbi opened issue #1293 (Review `Sandbox.run()` API with regards to batching) on buildstream https://gitlab.com/BuildStream/buildstream/-/issues/1293 | 06:34 |
|---|---|---|
| gitlab-br-bot | juergbi opened issue #1294 (Review public `Directory` API) on buildstream https://gitlab.com/BuildStream/buildstream/-/issues/1294 | 06:58 |
| juergbi | any objections to merging !1878? it's a blocker for merging the ported bst-plugins-experimental plugins | 07:01 |
| gitlab-br-bot | MR !1878: storage: Improve Directory API https://gitlab.com/BuildStream/buildstream/-/merge_requests/1878 | 07:01 |
| *** benschubert has joined #buildstream | 07:24 | |
| *** seanborg has joined #buildstream | 07:48 | |
| *** jude has joined #buildstream | 07:56 | |
| *** seanborg has quit IRC | 07:59 | |
| *** seanborg has joined #buildstream | 07:59 | |
| *** seanborg_ has joined #buildstream | 08:06 | |
| *** seanborg has quit IRC | 08:06 | |
| *** seanborg_ has quit IRC | 08:21 | |
| tristan | juergbi, Overall it looks like general future proofing and minimal API improvements, I've made one comment, not sure what direction we want to go with using data types defined outside of BuildStream | 08:24 |
| juergbi | tristan: good point. we could consider a custom, extensible data type instead. are you happy with me adding this to the list in #1294 and merging !1878 as is? | 08:26 |
| *** seanborg has joined #buildstream | 08:26 | |
| tristan | juergbi, Sure :) | 08:26 |
| juergbi | ta | 08:26 |
| *** phildawson has joined #buildstream | 08:33 | |
| *** lachlan has joined #buildstream | 08:38 | |
| *** santi has joined #buildstream | 08:41 | |
| *** phildawson_ has joined #buildstream | 08:45 | |
| *** phildawson has quit IRC | 08:46 | |
| *** rdale has joined #buildstream | 08:48 | |
| *** lachlan has quit IRC | 09:02 | |
| *** lachlan has joined #buildstream | 09:17 | |
| gitlab-br-bot | marge-bot123 merged MR !1878 (juerg/vdirectory->master: storage: Improve Directory API) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1878 | 09:28 |
| *** lachlan has quit IRC | 09:29 | |
| *** narispo has quit IRC | 09:30 | |
| gitlab-br-bot | juergbi opened MR !1886 (juerg/1.93.2->master: Prepare 1.93.2 development snapshot) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1886 | 09:32 |
| juergbi | tristan, benschubert: any objections to tagging 1.93.2 now (with !1886)? need this for bst-plugins-experimental | 09:34 |
| benschubert | juergbi: None, it will bring a few patches I need :D | 09:35 |
| traveltissues | +1 | 09:36 |
| tristan | Go ahead yeah | 09:38 |
| tristan | What's the merge strategy when you make a plugin-breaking change ? | 09:39 |
| tristan | I.e. if I make a change which causes me to have to modify everything in bst-plugins-experimental, what steps do I take ? | 09:40 |
| benschubert | tristan: the way I did it in the past is force the change in bst-plugins-experimental, then update buildstream then fix bst-plugins-experimental | 09:40 |
| tristan | Create a branch in bst-plugins-experimental, make my changes there, and have my buildstream MR depend on that branch (modifying tox.ini), and then do the plugin side, and then another update to buildstream master ? | 09:41 |
| benschubert | We can also change so that | 09:41 |
| benschubert | I usually did the reverse | 09:41 |
| benschubert | like create the branch in buildstream, and have the changes in the plugins | 09:41 |
| tristan | I see | 09:41 |
| benschubert | but either are fine :) | 09:41 |
| benschubert | since the plugins will get exploded in other repos, I prefered wreaking havoc there :) | 09:42 |
| tristan | I suppose if you don't force anything on either side, you will need to have a superfluous commit in order to use a tag in CI rather than a git sha | 09:42 |
| *** lachlan has joined #buildstream | 09:42 | |
| benschubert | correct | 09:43 |
| tristan | Do we have tests in BuildStream which mockup a pip package ? | 09:45 |
| tristan | For testing `pip` origin stuff ? | 09:45 |
| juergbi | tests/integration/pip_source.py | 09:47 |
| juergbi | ah, no | 09:47 |
| tristan | We appear to have tests/testutils/python_repo.py | 09:48 |
| juergbi | examples/flatpak-autotools appears to be the only test of "origin: pip". it uses bst-plugins-experimental | 09:48 |
| tristan | which might be useful for that, I think it's not used for that case though | 09:48 |
| tristan | Yeah | 09:48 |
| tristan | Ok so I'll start with python_repo.py, I would like to have a test which spits out different versions of the pip package which provides some dummy plugins, and test version constraints with that | 09:49 |
| *** lachlan has quit IRC | 10:04 | |
| *** phoenix has joined #buildstream | 10:05 | |
| *** phoenix has quit IRC | 10:14 | |
| *** lachlan has joined #buildstream | 10:25 | |
| *** narispo has joined #buildstream | 10:26 | |
| *** lachlan has quit IRC | 10:34 | |
| gitlab-br-bot | marge-bot123 merged MR !1886 (juerg/1.93.2->master: Prepare 1.93.2 development snapshot) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1886 | 10:38 |
| *** tristan has quit IRC | 10:45 | |
| traveltissues | there doesn't seem to be a `BST_REQUIRED_VERSION_PATCH`, should there be one for api changes which are tagged as patch versions? | 11:01 |
| *** lachlan has joined #buildstream | 11:04 | |
| *** lachlan has quit IRC | 11:13 | |
| juergbi | traveltissues: well, we probably shouldn't do this outside of development snapshots | 11:20 |
| juergbi | also see https://gitlab.com/BuildStream/buildstream/-/merge_requests/1885 | 11:20 |
| traveltissues | right | 11:21 |
| gitlab-br-bot | juergbi opened MR !1887 (juerg/vdirectory->master: Require virtual directory support for element plugins) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1887 | 11:35 |
| *** lachlan has joined #buildstream | 11:45 | |
| *** lachlan has quit IRC | 11:51 | |
| *** lachlan has joined #buildstream | 11:56 | |
| *** lachlan has quit IRC | 12:02 | |
| juergbi | benbrown: can you give the WSL runner a kick? | 12:06 |
| devcurmudgeon | what's the best way for a new user to provide feedback on experiences with docs etc? | 12:24 |
| juergbi | devcurmudgeon: for specific issues I'd say gitlab. for a larger discussion the mailing list. for a small discussion maybe simply here on IRC | 12:34 |
| devcurmudgeon | juergbi: ok thanks :) | 12:36 |
| *** phildawson_ has quit IRC | 12:37 | |
| *** phildawson has joined #buildstream | 12:53 | |
| *** lachlan has joined #buildstream | 13:10 | |
| benbrown | juergbi: I did give it a kick, it seems to be fetching from gitlab now. Give me another poke if it misbehaves again. | 13:17 |
| *** paulsherwood has left #buildstream | 13:18 | |
| *** lachlan has quit IRC | 13:28 | |
| *** lachlan has joined #buildstream | 13:43 | |
| *** lachlan has quit IRC | 13:52 | |
| *** tristan has joined #buildstream | 13:54 | |
| devcurmudgeon | is buildstream.build the live website for the project? | 14:14 |
| devcurmudgeon | and is the project logo the blue waterwheel? | 14:16 |
| devcurmudgeon | and has the beaver been deprecated? | 14:17 |
| devcurmudgeon | if the answer to all three is yes then i'd propose to remove the ##branding section from the community page | 14:18 |
| abderrahim[m] | devcurmudgeon: yes, yes and no | 14:19 |
| abderrahim[m] | the beaver is the project mascot | 14:19 |
| devcurmudgeon | abderrahim[m]: ack, in which case i'll just propose a fix for the text | 14:20 |
| *** lachlan has joined #buildstream | 14:40 | |
| *** lachlan has quit IRC | 14:52 | |
| *** lachlan has joined #buildstream | 15:10 | |
| juergbi | benbrown: I see jobs succeeding, thanks | 15:11 |
| *** lachlan has quit IRC | 15:17 | |
| *** phildawson has quit IRC | 15:48 | |
| *** lachlan has joined #buildstream | 15:49 | |
| *** phildawson has joined #buildstream | 15:51 | |
| *** phildawson has quit IRC | 15:54 | |
| *** lachlan has quit IRC | 16:02 | |
| *** tpreston has joined #buildstream | 16:05 | |
| tpreston | Hi, I'm trying to build gnome-build-meta using bst in a container. The official docs suggest using bst-here, which uses docker but I've modified it slightly to use podman (because I'm running Fedora) https://paste.gnome.org/p1m0cesog | 16:15 |
| tpreston | I've installed bst-external and set off a build, but I get an error from bwrap https://paste.gnome.org/pbkzwms6t | 16:15 |
| tpreston | When trying to build sdk/at-spi2-core.bst | 16:16 |
| *** lachlan has joined #buildstream | 16:16 | |
| tpreston | I'm new to bst, how would I go about debugging this? As you can see, I can't drop into a shell and re-run the command with strcae | 16:17 |
| tpreston | *strace | 16:17 |
| tpreston | I think it might be something to do with bst-here expecting the `docker --privileged` to give bubblewrap root permissions? | 16:18 |
| tpreston | But podman runs as user, so it can't do that - hence permission denied | 16:18 |
| *** narispo has quit IRC | 16:21 | |
| *** narispo has joined #buildstream | 16:21 | |
| *** lachlan has quit IRC | 16:33 | |
| jjardon | tpreston: what version of buildstream are you using? gnome-build-meta only builds with latest stable (1.4.x) | 16:39 |
| tpreston | 1.4.2 | 16:40 |
| tpreston | bst-here pulls the "latest" container I think https://gitlab.com/BuildStream/buildstream/-/blob/master/contrib/bst-here | 16:40 |
| jjardon | tpreston: if that is not the issue, I'd try to use buildstream from the fedora repos; I have never used bst-here myself (I'm actually surprised the official docs recommend to use that) | 16:40 |
| jjardon | tpreston: I can confirm you need a privileged container to run bst, not sure how that can be solved with podman | 16:41 |
| jjardon | tpreston: do you mind open an issue about this? | 16:41 |
| tpreston | yeah no problem :) | 16:41 |
| tpreston | thanks | 16:41 |
| *** lachlan has joined #buildstream | 16:47 | |
| abderrahim[m] | tpreston: do you run podman with --privileged? | 16:52 |
| *** lachlan has quit IRC | 16:53 | |
| abderrahim[m] | I'd recommend toolbox if you're on fedora | 16:53 |
| juergbi | benschubert: I've opened a few MRs on bst-plugins-experimental to port the remaining plugins to the Directory API. If you use any of these plugins, can you please review/test the changes? | 17:00 |
| benschubert | let me have a look | 17:01 |
| juergbi | ta | 17:01 |
| benschubert | mmh I use none of the ones that you updated x) | 17:01 |
| benschubert | can still review but not sure I'll be super useful there | 17:02 |
| juergbi | benschubert: ok. and you also don't know anyone who does, e.g., the dpkg plugins? | 17:02 |
| juergbi | valentind: The oci MR is now up at https://gitlab.com/BuildStream/bst-plugins-experimental/-/merge_requests/98 You've already reviewed and tested this, so I assume you're happy for me to merge it or are you planning any further testing or reviewing? | 17:02 |
| valentind | juergbi, All good | 17:03 |
| juergbi | valentind: Great, will merge. Can you please also take a look at https://gitlab.com/BuildStream/bst-plugins-experimental/-/merge_requests/96 if you haven't already? | 17:03 |
| juergbi | (flatpak_image) | 17:03 |
| juergbi | I've tested bst build of that as well with freedesktop-sdk, but haven't tested the result | 17:04 |
| juergbi | Same for collect_{integration,manifest}.py https://gitlab.com/BuildStream/bst-plugins-experimental/-/merge_requests/97 | 17:04 |
| juergbi | Although these at least have some tests in CI, iirc | 17:04 |
| *** lachlan has joined #buildstream | 17:07 | |
| tpreston | abderrahim[m]: yeah I use --privileged - since I made the change to bst-here it uses the same args | 17:07 |
| tpreston | https://paste.gnome.org/p1m0cesog | 17:07 |
| tpreston | abderrahim[m]: I've actually been meaning to look into toolbox - since I use containers to isolate most of my dev. The problem is that it seems interactive like a chroot. Which I *don't* want. I like having the env explicitly specified | 17:08 |
| tpreston | Unless I've misunderstood what toolbox is | 17:08 |
| abderrahim[m] | tpreston: you can specify the image to use if that's what you mean | 17:09 |
| abderrahim[m] | (although images may need to be modified) | 17:10 |
| tpreston | abderrahim[m]: can you modify the images locally? Like "FROM buildstream RUN dnf install my-dep"; toolbox run my-local-image | 17:11 |
| * tpreston will read the docs... :p | 17:11 | |
| abderrahim[m] | it should work | 17:11 |
| abderrahim[m] | yes | 17:11 |
| valentind | juergbi, I think .split(os.path.sep) probably has the issue to create some empty strings. Does vdir.descend ignores empty names? | 17:12 |
| valentind | For example a//b becomes 'a', '', 'b' | 17:12 |
| juergbi | valentind: yes, empty path segments are ignored | 17:13 |
| juergbi | I've also opened #1294 for potential API improvements | 17:13 |
| gitlab-br-bot | Issue #1294: Review public `Directory` API https://gitlab.com/BuildStream/buildstream/-/issues/1294 | 17:13 |
| valentind | juergbi, The patch looks fine. | 17:14 |
| valentind | It is a simple plugin, so if that does not work, we will figure it out. | 17:14 |
| juergbi | which one do you mean? maybe best to comment directly on the MR(s) | 17:14 |
| valentind | So I am not going to test it now. Let's merge it. | 17:14 |
| tpreston | abderrahim[m]: sorry, how do I use toolbox to specify custom images? ie. https://hub.docker.com/r/buildstream/buildstream ? | 17:24 |
| abderrahim[m] | tpreston: the --image flag to podman create | 17:25 |
| tpreston | abderrahim[m]: I don't understand how to use `toolbox create -i ${my_local_buildstream_image}` | 17:25 |
| abderrahim[m] | how is your image named | 17:26 |
| abderrahim[m] | Sam Thursfield: look for enable-developer-repository | 17:27 |
| tpreston | gnome-build-meta$ podman images | 17:27 |
| tpreston | REPOSITORY TAG IMAGE ID CREATED SIZE | 17:27 |
| tpreston | docker.io/buildstream/buildstream latest cf26903c154a 13 hours ago 536 MB | 17:27 |
| abderrahim[m] | you should be able to use the full name | 17:27 |
| abderrahim[m] | look for utils/run-local-repo.sh or something | 17:28 |
| abderrahim[m] | although I prefer a real httpd (webfsd) as the python one can be unstable | 17:29 |
| tpreston | ahh, this command hung before | 17:29 |
| tpreston | toolbox enter --container buildstream-latest | 17:29 |
| tpreston | Seems to be working after I created a normal fedora toolbox | 17:29 |
| abderrahim[m] | Sam Thursfield: utils/update-repo.sh runs a build+checkout and utils/run-local-repo.sh starts the webserver | 17:30 |
| abderrahim[m] | Sam Thursfield: there is this page https://gitlab.gnome.org/GNOME/gnome-build-meta/-/wikis/Bootable-images-in-virtual-machines | 17:31 |
| abderrahim[m] | Sam Thursfield: btw, there is #_gimpnet_#gnome-os:gnome.org | 17:32 |
| tpreston | abderrahim[m]: laptop is spinning up again, looks successful. jjardon: maybe instead of creating an issue, I can add to the docs about fedora toolbox? | 17:32 |
| tpreston | I can't remember why I didn't just use the distro provided one now | 17:33 |
| jjardon | tpreston: that is even better, of course | 17:33 |
| jjardon | (providing a patch I mean) :) | 17:33 |
| *** santi has quit IRC | 17:35 | |
| *** lachlan has quit IRC | 18:04 | |
| tpreston | thanks abderrahim[m], I see an error running gtk3-demo, but I think that's unrelated to my container | 18:06 |
| tpreston | <dk/gtk+-3.bst:/buildstream/gnome/sdk/gtk+-3.bst]$ gtk3-demo | 18:06 |
| tpreston | (gtk3-demo:11): Pango-CRITICAL **: 17:38:24.967: pango_font_get_hb_font: assertion 'PANGO_IS_FONT (font)' failed | 18:06 |
| tpreston | Segmentation fault (core dumped) | 18:06 |
| tpreston | jjardon: I've updated the docs https://gitlab.com/BuildStream/website/-/merge_requests/138 | 18:17 |
| *** tpreston has quit IRC | 18:22 | |
| *** toscalix has joined #buildstream | 18:23 | |
| *** rdale has quit IRC | 18:33 | |
| *** mohan43u has quit IRC | 18:47 | |
| *** mohan43u has joined #buildstream | 18:50 | |
| *** jude has quit IRC | 19:29 | |
| *** benschubert has quit IRC | 19:32 | |
| *** toscalix has quit IRC | 19:46 | |
| gitlab-br-bot | cs-shadow approved MR !1887 (juerg/vdirectory->master: Require virtual directory support for element plugins) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1887 | 20:12 |
| devcurmudgeon | it seems very surprising that master insists on "min-version" set to "2.0", while its own version is 1.9.x | 21:00 |
| devcurmudgeon | and also surprising that master doesn't seem to handle 1.x bst files nicely in general... | 21:01 |
| devcurmudgeon | is there a conversion script? | 21:02 |
| gitlab-br-bot | cs-shadow merged MR !1866 (willsalmon/more_as_str->master: Adding as_str too Mapping nodes) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1866 | 21:22 |
| *** mohan43u has quit IRC | 21:36 | |
| *** seanborg has quit IRC | 23:37 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!