IRC logs for #buildstream for Sunday, 2020-04-26

« Saturday, 2020-04-25 Index Monday, 2020-04-27 »
*** narispo has quit IRC00:07
*** narispo has joined #buildstream00:07
*** tristan has quit IRC06:54
*** tristan has joined #buildstream07:12
*** ChanServ sets mode: +o tristan07:12
*** rdale has joined #buildstream09:21
juergbijjardon: 429 should probably be detected as temporary failure such that buildstream will retry on its own09:25
juergbi(exception parameter `temporary`)09:26
juergbiI don't remember whether we already wait properly between retries for `temporary` errors09:26
* tristan has unavoidable scope creep in his refactor10:17
* tristan now has to tear apart the first test case ever made... now at tests/internals/pluginfactory, lets replace this with a proper end-to-end test10:17
tristanthis leads to... if I want the tests for plugin API versioning to work properly... I'll have to make the versioning also actually work properly10:18
* tristan blink in disbelief at: "if (bst_major, bst_minor) < (req_major, req_minor): ..."10:19
tristan+s10:19
tristanAnyway, this part is on the todo list *anyway* so... just more will be done in the end10:20
tristanjuergbi, curiously... what would you think about hard requiring plugins to set BST_REQUIRED_VERSION_[MAJOR,MINOR] ?10:20
tristancurrently the strategy is a bit dumb, we define it in plugin.py set to 0 and plugins just never set it10:21
tristanOr maybe instead of that, we could have a BST_REQUIRED_VERSION = "2.0" or such (bit more convenient)10:22
juergbimakes sense to me, or maybe a tuple instead of a string: (2, 0)10:22
tristanSure, we have a convenience function for string parsing, whatever is more readable I would say10:22
juergbialthough I guess string is more convenient and that would match the project.conf min-version10:23
juergbicould also be a simple way to distinguish bst1 and bst2 plugins10:23
tristanExactly10:24
tristanAlso, and a future proof one if ever there is a 3.x10:24
tristanin the same way as min-version10:24
tristanmaybe even call it BST_MIN_VERSION for consistency10:24
* tristan doesnt like how much is changing in the same commit but it's all quite intertwined10:25
tristanTo avoid that... I could destroy all plugin versioning in one commit, have it pass it's tests, and add it back in the improved way in the next commit with improved tests10:26
* tristan thinks he's got tests passing so far after having gutted the versioning stuff and refactored PluginFactory11:05
* tristan posts WIP as https://gitlab.com/BuildStream/buildstream/-/merge_requests/188511:06
tristanThe bulk is done but I'll be adding to it tomorrow11:06
*** tristan has quit IRC11:13
*** tristan has joined #buildstream11:26
*** ChanServ sets mode: +o tristan11:26
*** rdale has quit IRC11:45
*** rdale has joined #buildstream13:38
*** seanborg has joined #buildstream14:52
*** seanborg has quit IRC15:48
*** toscalix has joined #buildstream16:19
*** toscalix has quit IRC16:31
*** toscalix has joined #buildstream17:34
*** toscalix has quit IRC18:58
*** rdale has quit IRC18:58
*** narispo has quit IRC18:58
*** slaf has quit IRC18:58
*** krichter[m] has quit IRC18:58
*** robjh has quit IRC18:58
*** jward has quit IRC18:58
*** juergbi has quit IRC18:58
*** persia has quit IRC18:58
*** segfault1[m] has quit IRC18:58
*** Demos[m] has quit IRC18:58
*** walterve[m][m] has quit IRC18:58
*** dbuch[m] has quit IRC18:58
*** Trevio[m] has quit IRC18:58
*** milloni has quit IRC18:58
*** hergertme has quit IRC18:58
*** tristan has quit IRC18:58
*** tchaik[m] has quit IRC18:58
*** WSalmon has quit IRC18:58
*** jjardon has quit IRC18:58
*** pro[m] has quit IRC18:58
*** cgm[m] has quit IRC18:58
*** skullone[m] has quit IRC18:58
*** awacheux[m] has quit IRC18:58
*** DineshBhattarai[m] has quit IRC18:58
*** asingh_[m] has quit IRC18:58
*** jjardon[m] has quit IRC18:58
*** SamThursfield[m] has quit IRC18:58
*** kailueke[m] has quit IRC18:58
*** mattiasb has quit IRC18:58
*** dylan-m has quit IRC18:58
*** doras[m] has quit IRC18:58
*** reuben640[m] has quit IRC18:58
*** rafaelff1[m] has quit IRC18:58
*** theawless[m] has quit IRC18:58
*** connorshea[m] has quit IRC18:58
*** abderrahim[m] has quit IRC18:58
*** m_22[m] has quit IRC18:58
*** tlater[m] has quit IRC18:58
*** albfan[m] has quit IRC18:58
*** ironfoot has quit IRC18:58
*** flatmush has quit IRC18:58
*** benbrown has quit IRC18:58
*** jswagner has quit IRC18:58
*** gitlab-br-bot has quit IRC18:58
*** milloni has joined #buildstream18:58
*** juergbi has joined #buildstream18:58
*** hergertme has joined #buildstream18:58
*** robjh has joined #buildstream18:59
*** toscalix has joined #buildstream19:00
*** jward has joined #buildstream19:00
*** slaf has joined #buildstream19:00
*** narispo has joined #buildstream19:00
*** persia has joined #buildstream19:00
*** rdale has joined #buildstream19:00
*** tristan has joined #buildstream19:00
*** tchaik[m] has joined #buildstream19:00
*** WSalmon has joined #buildstream19:00
*** jjardon has joined #buildstream19:00
*** pro[m] has joined #buildstream19:00
*** cgm[m] has joined #buildstream19:00
*** skullone[m] has joined #buildstream19:00
*** awacheux[m] has joined #buildstream19:00
*** albfan[m] has joined #buildstream19:00
*** kailueke[m] has joined #buildstream19:00
*** DineshBhattarai[m] has joined #buildstream19:00
*** asingh_[m] has joined #buildstream19:00
*** connorshea[m] has joined #buildstream19:00
*** jjardon[m] has joined #buildstream19:00
*** theawless[m] has joined #buildstream19:00
*** m_22[m] has joined #buildstream19:00
*** mattiasb has joined #buildstream19:00
*** rafaelff1[m] has joined #buildstream19:00
*** SamThursfield[m] has joined #buildstream19:00
*** dylan-m has joined #buildstream19:00
*** tlater[m] has joined #buildstream19:00
*** reuben640[m] has joined #buildstream19:00
*** doras[m] has joined #buildstream19:00
*** abderrahim[m] has joined #buildstream19:00
*** ironfoot has joined #buildstream19:00
*** flatmush has joined #buildstream19:00
*** benbrown has joined #buildstream19:00
*** jswagner has joined #buildstream19:00
*** gitlab-br-bot has joined #buildstream19:00
*** irc.acc.umu.se sets mode: +ooo tristan jjardon ironfoot19:00
*** Demos[m] has joined #buildstream19:05
*** rdale has quit IRC19:08
*** walterve[m][m] has joined #buildstream19:18
*** dbuch[m] has joined #buildstream19:34
*** krichter[m] has joined #buildstream19:53
*** Trevio[m] has joined #buildstream20:03
*** segfault1[m] has joined #buildstream20:34
*** phoenix has joined #buildstream20:42
*** toscalix has quit IRC21:11
*** phoenix has quit IRC22:14
*** narispo has quit IRC23:00
*** narispo has joined #buildstream23:00
« Saturday, 2020-04-25 Index Monday, 2020-04-27 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!