| *** phildawson has quit IRC | 00:13 | |
| *** tristan has joined #buildstream | 02:22 | |
| *** dellie__ has joined #buildstream | 03:32 | |
| *** delli3_ has quit IRC | 03:34 | |
| *** narispo has quit IRC | 03:57 | |
| jjardon | Hi benschubert | 04:59 |
|---|---|---|
| jjardon | did you tag this release? https://gitlab.com/BuildStream/bst-plugins-experimental/commit/4ebd361daff161308166f4aa845b0c9d41fe7840 | 04:59 |
| jjardon | I think we should bump the version of bst-plugins-experimental to 0.90.1 or something similar, otherwise the tag is going to conflict with the existing 0.14 | 05:00 |
| jjardon | (from the bst-external, ie bst-1) | 05:00 |
| jjardon | benschubert: actually, maybe 1.90 and make it match current buildstream version maybe | 05:01 |
| *** lchlan has quit IRC | 05:33 | |
| *** lchlan has joined #buildstream | 05:33 | |
| gitlab-br-bot | jjardon merged MR !1729 (jjardon/move_deb_source->master: Remove deb surce plugin, it has beem moved to bst-plugins-experimental) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1729 | 06:12 |
| *** traveltissues has joined #buildstream | 08:33 | |
| *** tpollard has joined #buildstream | 09:00 | |
| benschubert | jjardon: the tag should not conflict, they are different repositories and packages no? However 0.91 seems a good idea yup. I don't think we really need to match BuildStream's version, since it's anyways going to be exploded later on | 09:24 |
| *** tme5 has joined #buildstream | 09:25 | |
| *** tiagogomes has joined #buildstream | 10:01 | |
| coldtom | could we get https://gitlab.com/BuildStream/bst-plugins-experimental/merge_requests/69 merged please? | 10:02 |
| coldtom | maybe worth a bug fix release tbh | 10:02 |
| benschubert | coldtom: cs-shadow was planning in making another breaking change on plugins today, and doing a release after that. Would you agree in waiting for this for the release? | 10:05 |
| benschubert | Feel free to merge this change, thanks for the catch (Or do you need me to merge?) | 10:05 |
| coldtom | i don't mind waiting for the release if there's one coming today :P i can't merge myself i'm afraid | 10:06 |
| benschubert | Set to merge! Ok, I'll publish a new one if cs-shadow doesn't has time to finish it today | 10:07 |
| coldtom | ta benchubert! | 10:13 |
| *** jonathanmaw has joined #buildstream | 10:38 | |
| *** cs-shadow has joined #buildstream | 10:50 | |
| *** rdale has quit IRC | 11:02 | |
| coldtom | we should probably add black to bst-plugins-experimental too, shouldn't we | 11:16 |
| benschubert | I'd be for ti :) | 11:16 |
| benschubert | *it | 11:16 |
| benschubert | would have definitely caught that | 11:16 |
| * coldtom wants to stop thinking about wrapping his lines | 11:17 | |
| gitlab-br-bot | cs-shadow opened MR !1803 (chandan/plugin-namespace-fix->master: Plugins: Update entrypoint group for pip origin) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1803 | 11:33 |
| coldtom | nice change cs-shadow \o/ | 11:34 |
| cs-shadow | :) | 11:36 |
| *** rdale has joined #buildstream | 11:47 | |
| gitlab-br-bot | cs-shadow opened (was WIP) MR !1803 (chandan/plugin-namespace-fix->master: Plugins: Update entrypoint group for pip origin) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1803 | 11:51 |
| *** santi has joined #buildstream | 11:51 | |
| *** santi has quit IRC | 12:10 | |
| *** santi has joined #buildstream | 12:16 | |
| coldtom | erm, it seems like it's impossible to write some kinds of plugin tests without using internal buildstream api, is this a known problem? | 12:37 |
| coldtom | e.g. to check a plugin throws the correct configurable failure properly, I seem to need to get ErrorDomain from _exceptions | 12:38 |
| coldtom | several plugin tests also generate little projects using the yaml dumper from _yaml | 12:39 |
| *** delli3_ has joined #buildstream | 13:14 | |
| gitlab-br-bot | cs-shadow opened (was WIP) MR !1803 (chandan/plugin-namespace-fix->master: Plugins: Update entrypoint group for pip origin) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1803 | 13:16 |
| *** dellie__ has quit IRC | 13:17 | |
| *** brlogger has joined #buildstream | 13:23 | |
| gitlab-br-bot | tpollard approved MR !1802 (juerg/assemble_done->master: element.py: Optimize assemble_done()) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1802 | 13:32 |
| benschubert | coldtom: would exposing them in 'testutils' do the trick for you? I think it would be fine with making them more open for this purpose (but not for general consumption in the plugin itself) | 13:54 |
| *** traveltissues has quit IRC | 13:56 | |
| coldtom | benschubert: is there a way to import from bst testutils in external plugin repos? | 14:19 |
| benschubert | coldtom: if it is in buildstream.testutils yes. If it is under tests/tesutils no | 14:20 |
| coldtom | ah, yes i'd be happy for it to be in buildstream.testing (especially ErrorDomain as public API there expects that as an arg) | 14:21 |
| benschubert | coldtom: would you mind making either an issue with the list of things or directly a PR? :) Or maybe a ML post? I don't know what's best there? | 14:22 |
| coldtom | benschubert, sure! i'll need to take a closer look at what's being used first | 14:26 |
| *** traveltissues has joined #buildstream | 14:37 | |
| coldtom | hmm, i think we can probably limit the _yaml surface exposed by just giving a wrapper to _yaml.roundtrip _dump | 14:49 |
| benschubert | coldtom: for what are you using it generally? Creating elements? We could have a 'write_element' method exposed | 14:54 |
| benschubert | If you need if for more, we could see to have a nicer way :) | 14:55 |
| coldtom | benschubert: the existing tests seem to use it to dump a template project.conf | 14:55 |
| benschubert | create_project() and create_element() ? | 14:56 |
| coldtom | a fair few even implement methods like that themselves | 14:56 |
| benschubert | Might be a good time to extract and consolidate some of those operations if you have ideas, please open either issues or MRs :D | 14:57 |
| gitlab-br-bot | BenjaminSchubert approved MR !1803 (chandan/plugin-namespace-fix->master: Plugins: Update entrypoint group for pip origin) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1803 | 15:34 |
| gitlab-br-bot | cs-shadow merged MR !1803 (chandan/plugin-namespace-fix->master: Plugins: Update entrypoint group for pip origin) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1803 | 16:41 |
| *** santi has quit IRC | 16:53 | |
| *** santi has joined #buildstream | 16:53 | |
| *** tpollard has quit IRC | 17:01 | |
| gitlab-br-bot | cs-shadow opened MR !1804 (chandan/1.93.0->master: NEWS: Add mark for 1.93.0) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1804 | 17:02 |
| *** santi has quit IRC | 17:19 | |
| *** tme5 has quit IRC | 17:23 | |
| gitlab-br-bot | BenjaminSchubert approved MR !1804 (chandan/1.93.0->master: NEWS: Add mark for 1.93.0) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1804 | 17:31 |
| *** santi has joined #buildstream | 17:50 | |
| gitlab-br-bot | cs-shadow merged MR !1804 (chandan/1.93.0->master: NEWS: Add mark for 1.93.0) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1804 | 17:52 |
| *** phildawson has joined #buildstream | 18:06 | |
| *** phildawson has quit IRC | 18:09 | |
| *** phildawson has joined #buildstream | 18:09 | |
| *** tiagogomes has quit IRC | 18:12 | |
| *** jonathanmaw has quit IRC | 18:44 | |
| *** phildawson has quit IRC | 19:05 | |
| *** santi has quit IRC | 20:21 | |
| *** santi has joined #buildstream | 20:21 | |
| coldtom | anyone got anything against a backport of !1694 to bst-1? I've opened https://gitlab.com/buildstream/bst-external/merge_requests/114 to backport the bazel_* plugins, but i just realised I relied on having /dev/shm in the sandbox | 20:30 |
| gitlab-br-bot | MR !1694: _sandboxbwrap.py: Create /dev/shm in the sandbox https://gitlab.com/BuildStream/buildstream/merge_requests/1694 | 20:30 |
| coldtom | if i can't get a backport, then i can just mark_directory /dev/shm, which isn't as neat but won't be too much effort | 20:30 |
| *** cs-shadow has quit IRC | 20:39 | |
| *** santi has quit IRC | 20:50 | |
| coldtom | erm, i also feel like we should backport the fix to make bst work with python 3.8 to bst-1 | 21:03 |
| *** phildawson has joined #buildstream | 21:05 | |
| gitlab-br-bot | coldtom opened MR !1805 (coldtom/backport-dev-shm->bst-1: Backport creation of /dev/shm in the sandbox to bst-1) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1805 | 21:29 |
| coldtom | if ^ that is not acceptable to get merged, then https://gitlab.com/BuildStream/bst-external/merge_requests/114 can already deal without it | 21:52 |
| *** phildawson has quit IRC | 22:19 | |
| *** phildawson has joined #buildstream | 22:34 | |
| *** phildawson has quit IRC | 23:23 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!