| *** xjuan has quit IRC | 00:00 | |
| *** jjardon has quit IRC | 00:17 | |
| *** cs-shadow has joined #buildstream | 00:20 | |
| *** Trevinho has joined #buildstream | 00:21 | |
| *** jjardon has joined #buildstream | 00:21 | |
| *** ChanServ sets mode: +o jjardon | 00:21 | |
| *** lchlan has joined #buildstream | 00:22 | |
| *** phildawson has quit IRC | 00:30 | |
| *** phildawson has joined #buildstream | 00:30 | |
| *** Trevinho has quit IRC | 00:41 | |
| *** jjardon has quit IRC | 00:41 | |
| *** cs-shadow has quit IRC | 00:43 | |
| *** lchlan has quit IRC | 00:46 | |
| *** benschubert has quit IRC | 00:51 | |
| *** phildawson has quit IRC | 01:42 | |
| *** Trevinho has joined #buildstream | 02:41 | |
| *** Trevinho has quit IRC | 02:43 | |
| *** Trevinho has joined #buildstream | 02:49 | |
| *** Trevinho has quit IRC | 02:54 | |
| *** Trevinho has joined #buildstream | 02:57 | |
| *** Trevinho has quit IRC | 03:02 | |
| *** slaf has quit IRC | 04:36 | |
| *** slaf has joined #buildstream | 05:01 | |
| *** slaf has joined #buildstream | 05:01 | |
| *** slaf has quit IRC | 05:01 | |
| *** slaf has joined #buildstream | 05:02 | |
| *** slaf has joined #buildstream | 05:02 | |
| *** slaf has joined #buildstream | 05:02 | |
| *** slaf has joined #buildstream | 05:02 | |
| *** slaf has joined #buildstream | 05:03 | |
| *** slaf has joined #buildstream | 05:03 | |
| *** slaf has joined #buildstream | 05:03 | |
| *** slaf has quit IRC | 05:03 | |
| *** slaf has joined #buildstream | 05:03 | |
| *** slaf has joined #buildstream | 05:04 | |
| *** Trevinho has joined #buildstream | 06:47 | |
| *** cs-shadow has joined #buildstream | 06:48 | |
| *** benschubert has joined #buildstream | 06:51 | |
| *** jjardon has joined #buildstream | 07:02 | |
| *** ChanServ sets mode: +o jjardon | 07:02 | |
| *** lchlan has joined #buildstream | 07:07 | |
| *** traveltissues has joined #buildstream | 08:45 | |
| *** bochecha has joined #buildstream | 08:57 | |
| *** tme5 has joined #buildstream | 09:23 | |
| *** tiagogomes has joined #buildstream | 09:43 | |
| benschubert | juergbi: https://gitlab.com/BuildStream/bst-plugins-experimental/merge_requests/67 should be good to go now, are you fine with the implementation? Then I'll update BuildStream's CI and do the various releases | 10:20 |
|---|---|---|
| juergbi | let me take a closer look | 10:21 |
| juergbi | a possible alternative to the Consistency import would be to make it a local import in get_consistency() | 10:22 |
| juergbi | however, the current approach is fine with me as well | 10:22 |
| benschubert | The approach of local imports would require me to silence the linter all the time | 10:23 |
| juergbi | ah, I see | 10:23 |
| benschubert | Apart from that does it seems good to go for you? | 10:29 |
| juergbi | benschubert: yes, lgtm | 10:30 |
| benschubert | o/ let's get merging all of this, thanks! | 10:31 |
| benschubert | I'll also remove the __update_source_State later as per your nit | 10:31 |
| *** lachlan has joined #buildstream | 10:35 | |
| *** jonathanmaw has joined #buildstream | 10:37 | |
| *** lachlan has quit IRC | 10:42 | |
| traveltissues | why do we have both element._cached_failure() and element._cached_success() | 10:43 |
| traveltissues | they both primarily consist of a call to cached and _get_build_result | 10:43 |
| traveltissues | the only difference is that _cached_success is memoized | 10:44 |
| benschubert | If you are building, the build fails, it get cached, and you get asked what you want to do. If you retry, it might succeed right? I *think* that's the reason behind it, but would need to look at the code to be sure | 10:46 |
| traveltissues | right but i don't think we need both | 10:46 |
| benschubert | Why? | 10:46 |
| benschubert | I mean: we have: cached successful, cached failed and not cached. Do you want a tristate instead? | 10:47 |
| traveltissues | the implementation of those methods seems to make them just inverse | 10:49 |
| traveltissues | since they are implemented like AND not OR | 10:52 |
| traveltissues | unless i'm missing something here | 10:53 |
| tpollard | traveltissues: I don't think you are | 10:55 |
| tpollard | I don't see a reason to have both | 10:55 |
| tpollard | could just be _cached_result() and add a new __cached_failure | 10:56 |
| benschubert | traveltissues: you are changing the behavior with your PR | 10:56 |
| benschubert | it's less explicit though | 10:56 |
| tpollard | that's also true | 10:59 |
| *** lachlan has joined #buildstream | 11:02 | |
| traveltissues | i usually don't get things right the first time | 11:09 |
| traveltissues | which is why i wip | 11:09 |
| *** lachlan has quit IRC | 11:11 | |
| traveltissues | tpollard, it might be better to do that | 11:11 |
| *** lachlan has joined #buildstream | 11:25 | |
| *** lachlan has quit IRC | 11:29 | |
| *** santi has joined #buildstream | 11:32 | |
| *** lachlan has joined #buildstream | 11:43 | |
| *** lachlan has quit IRC | 11:50 | |
| *** lachlan has joined #buildstream | 11:56 | |
| *** lachlan has quit IRC | 11:59 | |
| *** lachlan has joined #buildstream | 12:03 | |
| *** lachlan has quit IRC | 12:08 | |
| *** lachlan has joined #buildstream | 12:19 | |
| *** lachlan has quit IRC | 12:23 | |
| gitlab-br-bot | BenjaminSchubert opened (was WIP) MR !1739 (bschubert/optimize-consistency->master: Optimize consistency and state handling) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1739 | 12:23 |
| *** lachlan has joined #buildstream | 12:35 | |
| *** lachlan has quit IRC | 12:52 | |
| gitlab-br-bot | tpollard approved MR !1799 (chandan/remove-bst-experimental-unused->master: tests/integration/project.conf: Remove unused external plugins) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1799 | 13:05 |
| gitlab-br-bot | cs-shadow merged MR !1799 (chandan/remove-bst-experimental-unused->master: tests/integration/project.conf: Remove unused external plugins) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1799 | 13:11 |
| benschubert | !1739 ready for a last review if someone wants, otherwise I'll go ahead and merge | 13:32 |
| *** lachlan has joined #buildstream | 14:24 | |
| *** lachlan has quit IRC | 14:36 | |
| *** lachlan has joined #buildstream | 14:37 | |
| *** lachlan has quit IRC | 14:42 | |
| *** lachlan has joined #buildstream | 15:08 | |
| *** lachlan has quit IRC | 15:12 | |
| *** delli3_ has quit IRC | 15:58 | |
| *** delli3_ has joined #buildstream | 15:58 | |
| juergbi | benschubert: I triggered a rebase on !1701 this morning. it's all green, can we merge this? | 16:03 |
| gitlab-br-bot | MR !1701: app.py: Also catch SystemError with click.Abort https://gitlab.com/BuildStream/buildstream/merge_requests/1701 | 16:03 |
| juergbi | (bst-1 backport) | 16:03 |
| benschubert | Oups, I had completely forgotten about that, let me merge that and thanks for taking care of it | 16:05 |
| gitlab-br-bot | BenjaminSchubert merged MR !1701 (bschubert/backport-1690->bst-1: app.py: Also catch SystemError with click.Abort) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1701 | 16:05 |
| benschubert | It was part of a 3 MR change for fixing a few things around interactivity, but I won't have time those days to push further if someone cares enough around bst 1 :) | 16:06 |
| juergbi | I'm not planning to. but we're now back to a single page of pending MRs \o/ ;) | 16:07 |
| benschubert | ah nice | 16:07 |
| benschubert | Will merge mine asap too :) | 16:07 |
| benschubert | (the consistency one) | 16:07 |
| *** ikerperez has quit IRC | 16:28 | |
| *** ikerperez has joined #buildstream | 16:29 | |
| *** traveltissues has quit IRC | 16:34 | |
| juergbi | benschubert: are you asking Chandan or me? | 16:41 |
| benschubert | juergbi: oups, was more chandan, since he asked the change | 16:42 |
| juergbi | ok | 16:42 |
| juergbi | (no objections from my side) | 16:42 |
| benschubert | great thanks! Happy to finally push this one over | 16:43 |
| gitlab-br-bot | juergbi opened MR !1801 (juerg/buildbox-run-test->master: tests/integration/interactive_build.py: Relax expect for buildbox-run) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1801 | 16:51 |
| gitlab-br-bot | BenjaminSchubert approved MR !1801 (juerg/buildbox-run-test->master: tests/integration/interactive_build.py: Relax expect for buildbox-run) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1801 | 16:52 |
| juergbi | ta | 16:53 |
| *** phildawson has joined #buildstream | 16:54 | |
| *** tpollard has quit IRC | 16:58 | |
| *** santi has quit IRC | 17:17 | |
| *** santi has joined #buildstream | 17:18 | |
| *** lachlan has joined #buildstream | 17:22 | |
| *** lachlan has quit IRC | 17:27 | |
| *** tme5 has quit IRC | 17:31 | |
| *** bochecha has quit IRC | 17:33 | |
| *** santi has quit IRC | 17:38 | |
| *** santi has joined #buildstream | 17:38 | |
| *** phildawson has quit IRC | 17:39 | |
| *** tiagogomes has quit IRC | 17:50 | |
| *** xjuan has joined #buildstream | 17:51 | |
| *** lachlan has joined #buildstream | 17:52 | |
| *** lachlan has quit IRC | 17:56 | |
| *** phildawson has joined #buildstream | 18:02 | |
| *** tristan has quit IRC | 18:19 | |
| *** slaf_ has joined #buildstream | 18:22 | |
| *** slaf_ has joined #buildstream | 18:22 | |
| *** slaf_ has joined #buildstream | 18:22 | |
| *** slaf_ has joined #buildstream | 18:23 | |
| *** slaf has quit IRC | 18:24 | |
| *** slaf_ is now known as slaf | 18:24 | |
| gitlab-br-bot | BenjaminSchubert closed issue #1126 (Cache resolution is slow) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1126 | 18:49 |
| gitlab-br-bot | BenjaminSchubert merged MR !1739 (bschubert/optimize-consistency->master: Optimize consistency and state handling) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1739 | 18:49 |
| *** jonathanmaw has quit IRC | 19:06 | |
| *** phildawson_ has quit IRC | 19:21 | |
| *** phildawson_ has joined #buildstream | 19:22 | |
| gitlab-br-bot | juergbi opened MR !1802 (juerg/assemble_done->master: element.py: Optimize assemble_done()) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1802 | 19:28 |
| *** santi has quit IRC | 19:35 | |
| *** santi has joined #buildstream | 19:35 | |
| gitlab-br-bot | BenjaminSchubert approved MR !1802 (juerg/assemble_done->master: element.py: Optimize assemble_done()) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1802 | 19:48 |
| *** traveltissues has joined #buildstream | 19:59 | |
| *** santi has quit IRC | 20:16 | |
| *** santi has joined #buildstream | 20:17 | |
| *** phildawson has quit IRC | 20:20 | |
| *** santi has quit IRC | 20:23 | |
| *** bochecha has joined #buildstream | 20:25 | |
| *** bochecha has quit IRC | 20:26 | |
| *** phildawson has joined #buildstream | 20:45 | |
| *** cs-shadow has quit IRC | 22:15 | |
| *** narispo has joined #buildstream | 22:48 | |
| *** xjuan has quit IRC | 23:30 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!