IRC logs for #buildstream for Tuesday, 2020-01-14

*** phildawson has joined #buildstream01:04
*** phildawson has quit IRC01:29
*** xjuan has quit IRC02:39
*** traveltissues has joined #buildstream07:42
gitlab-br-bottraveltissues approved MR !1745 (tpollard/messagerate->master: Make message & status rendering be tick driven by default) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/174508:20
*** tme5 has joined #buildstream09:40
*** tiagogomes has joined #buildstream09:46
*** rdale has joined #buildstream10:16
*** jonathanmaw has joined #buildstream10:49
*** lachlan has joined #buildstream10:56
*** lachlan has quit IRC11:06
*** lachlan has joined #buildstream11:10
*** santi has joined #buildstream11:12
douglaswinshipjuergbi, cs-shadow thanks!11:15
douglaswinshipcs-shadow: someone in my own project pointed out something similar. I can split the processing into different parts, use a plugin for the things that the plugin can do, and do the other parts with a different script, so I'm okay.11:15
douglaswinshipFor interest, the use case is that i'm generating a manifest of all the different source URLs.11:16
douglaswinshipI was trying to read the YAML declarations that defined the mirrors, so that I can add the mirror URLs to the manifest too.11:16
benschuberttpollard: it's interesting, your rate limitation breaks the overview at the bottom for me? But it is hugely faster11:27
benschubert(numbers coming, still computing on master)11:27
tpollardthe status area?11:27
benschubertyep11:27
tpollardinteresting, I've not tested the branch for a while but it's been rebased a few times11:28
tpollardI'll double check on my end11:28
benschubertThanks, It might not be broken on a fast linux system (in which case it's fine :) )11:28
*** santi has quit IRC11:28
*** lachlan has quit IRC11:31
tme5if i missed a NEWS entry for a previous release (dev snapshot? 1.91.2) shall I add it retroactively into that section or under 'unreleased' ?11:31
*** santi has joined #buildstream11:34
*** lachlan has joined #buildstream11:57
benschuberttpollard: one more question: is everything logged as before with your branch or are we skipping parts? :)11:58
cs-shadowtme5: I'd vote for adding it under `unreleaed` section, and maybe mention that it was actually done in the vesion x.y. (I don't think many people read news entries ffor older releases)11:59
tme5are all the news entries for these pre-releases going to be collected under one 2.0 when it comes out?11:59
cs-shadowtpollard: sidenote - not a blocker at all, but it may be worth considering adding a pexpect-style test to ensure that we always haev the ticker visible under both configurations12:00
cs-shadowtme5: I'd hope so12:00
tpollardbenschubert: everything should be logged as before, in _message_handler()12:03
*** lachlan has quit IRC12:05
tpollardhaving no status area at all on wsl sounds like a bug though12:06
tpollardif it can manage to render it when un restricted, but not once per second12:06
tpollardwfm still on linux12:11
benschuberttpollard: ok I got it12:19
benschubertthe diff of text every second is too big12:20
benschubertso the terminal never catches up and just jumps from update to upadte12:20
benschubert'real' time is 2m35 to build base-files. 'Clock' time (as measured by me and my phone) is over 30 minutes (when I gave up and detached the pane)12:20
gitlab-br-bottmewett opened (was WIP) MR !1774 (tmewett/merge-git-tag->master: Merge 'git_tag' functionality into 'git' source) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/177412:26
tme5ready for review :)12:26
tpollardbenschubert: that is, not pleasant12:27
tpollarda buffer size approach may be more suited then12:28
tpollardin stead of time based12:28
tpollard*instead12:28
tpollardor a mixture of the conditions12:30
*** lachlan has joined #buildstream12:36
*** slaf has quit IRC12:37
*** lachlan has quit IRC12:40
*** lachlan has joined #buildstream12:59
*** lachlan has quit IRC13:03
*** xjuan has joined #buildstream13:37
tpollardbenschubert: if you've got any suggestions please do post them to the MR13:55
benschubertmeh, I think it might be better to go with what we have now, at least for now and if we find a better way later, we can change?13:57
gitlab-br-botBenjaminSchubert approved MR !1745 (tpollard/messagerate->master: Make message & status rendering be tick driven by default) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/174514:00
tpollardif you had to give up waiting for it, then do you not feel that it shouldn't be default behaviour?14:04
benschuberttpollard: I also gave up on master ;)14:07
benschuberttakes 2.7 min to build on master, and then it scrolls for more than an hour14:07
benschubertso I'll be looking at adding a '--quiet' flag or something to remove some of the verbosity (No, I don't care that BuildStream is staging source, if that is slowing down my total time :'D)14:08
tpollardyou could open up unconditional_messages to achieve that14:11
benschubertI'm not familiar with that part of the code, what do you mean? :)14:11
tpollardregardless of context or verbosity, we always print info messages (defined in a global list in _message.py)14:13
benschubertyup exactly, we have only ways of putting things more verbose, not quieter :)14:15
tpollardthere's also the silence context manager, that could be tweaked with configuration14:15
benschubertI'll think about it14:15
benschubertor maybe a 'PROGRESS' message type that allows showing all the exact commands and such?14:16
tpollardI could see that14:24
benschubertGood, I'll play around once I'm done with my two current optimizations :'D14:26
tpollardcs-shadow: I'll take a look at the pexpect tests14:26
*** lachlan has joined #buildstream14:31
*** traveltissues has quit IRC14:35
*** lachlan has quit IRC14:36
*** lachlan has joined #buildstream14:37
*** lachlan has quit IRC14:40
*** lachlan has joined #buildstream14:58
*** lachlan has quit IRC15:01
*** lachlan has joined #buildstream15:11
*** slaf has joined #buildstream15:17
*** slaf has joined #buildstream15:17
*** slaf has joined #buildstream15:18
*** slaf has joined #buildstream15:18
*** slaf has joined #buildstream15:18
*** lachlan has quit IRC15:18
*** slaf has joined #buildstream15:18
*** slaf has joined #buildstream15:19
*** slaf has joined #buildstream15:19
*** phildawson has joined #buildstream15:21
*** lachlan has joined #buildstream15:32
*** lachlan has quit IRC15:37
*** lachlan has joined #buildstream15:54
*** lachlan has quit IRC15:59
gitlab-br-botBenjaminSchubert opened MR !1794 (bschubert/optimize-loading-multiple-targets->master: loader.py: Optimize sorting of elements when they are multiple targets) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/179416:00
*** lachlan has joined #buildstream16:01
benschubert^ also a nice speedup if you like to run multiple heavily intertwined targets :)16:01
*** phildawson has quit IRC16:10
*** santi has quit IRC16:17
*** santi has joined #buildstream16:17
*** lachlan has quit IRC16:20
juergbinice16:24
gitlab-br-botjuergbi approved MR !1794 (bschubert/optimize-loading-multiple-targets->master: loader.py: Optimize sorting of elements when they are multiple targets) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/179416:25
*** lachlan has joined #buildstream16:27
benschubertcheers16:30
*** lachlan has quit IRC16:31
*** rdale has quit IRC16:37
*** lachlan has joined #buildstream16:38
*** rdale has joined #buildstream16:39
*** lachlan has quit IRC16:42
*** lachlan has joined #buildstream16:54
*** lachlan has quit IRC16:57
*** lachlan has joined #buildstream16:59
*** lachlan has quit IRC17:03
*** lachlan has joined #buildstream17:16
*** lachlan has quit IRC17:19
*** lachlan has joined #buildstream17:22
*** lachlan has quit IRC17:26
*** lachlan has joined #buildstream17:29
*** lachlan has quit IRC17:34
gitlab-br-botBenjaminSchubert merged MR !1794 (bschubert/optimize-loading-multiple-targets->master: loader.py: Optimize sorting of elements when they are multiple targets) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/179417:40
*** tme5 has quit IRC17:41
*** tiagogomes has quit IRC17:55
*** lachlan has joined #buildstream18:00
*** jonathanmaw has quit IRC18:02
*** lachlan has quit IRC18:04
*** phildawson has joined #buildstream18:09
*** phildawson has quit IRC18:34
benschubertjuergbi: for !1739, actually would it be fine if I merge https://gitlab.com/BuildStream/buildstream/commit/0e71d28d0c0f31570e42834ab84e4f1491cc70e6 with https://gitlab.com/BuildStream/buildstream/commit/9baf2aba3e4388912dae0bd7a9a3cbfe081ecfa6 ? It shoud fix all the problems there :)18:38
gitlab-br-botMR !1739: WIP: Optimize consistency and state handling https://gitlab.com/BuildStream/buildstream/merge_requests/173918:38
juergbibenschubert: that'd be fine with me. I wouldn't expect it to be necessary to remove the asserts in the same commit, however, I don't see an issue squashing that in as well (assuming it doesn't hide underlying bugs)18:40
*** traveltissues has joined #buildstream18:43
benschubertSure, thanks!18:50
*** phildawson has joined #buildstream19:13
*** delli3_ has joined #buildstream19:32
*** tristan has quit IRC19:33
*** delli3 has quit IRC19:34
*** santi has quit IRC19:56
*** santi has joined #buildstream19:59
*** tristan has joined #buildstream20:22
*** phildawson has quit IRC20:40
*** phildawson has joined #buildstream20:56
*** phildawson has quit IRC21:11
*** santi has quit IRC21:23
*** phildawson has joined #buildstream21:44
*** phildawson has quit IRC21:47
*** phildawson has joined #buildstream21:47
*** phildawson has quit IRC21:50
*** phildawson has joined #buildstream22:03
*** phildawson has quit IRC22:33
gitlab-br-botcs-shadow opened MR !1795 (chandan/gitlab-ci-toxenvs->master: .gitlab-ci.yml: Simplify test environment declaration) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/179522:44
*** phildawson has joined #buildstream22:46
*** slaf has quit IRC22:47
*** slaf has joined #buildstream22:55
*** slaf has joined #buildstream22:55
*** slaf has joined #buildstream22:56
*** phildawson has quit IRC23:14
*** phildawson has joined #buildstream23:15
gitlab-br-botcs-shadow merged MR !1795 (chandan/gitlab-ci-toxenvs->master: .gitlab-ci.yml: Simplify test environment declaration) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/179523:20

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!