*** phildawson has joined #buildstream | 01:04 | |
*** phildawson has quit IRC | 01:29 | |
*** xjuan has quit IRC | 02:39 | |
*** traveltissues has joined #buildstream | 07:42 | |
gitlab-br-bot | traveltissues approved MR !1745 (tpollard/messagerate->master: Make message & status rendering be tick driven by default) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1745 | 08:20 |
---|---|---|
*** tme5 has joined #buildstream | 09:40 | |
*** tiagogomes has joined #buildstream | 09:46 | |
*** rdale has joined #buildstream | 10:16 | |
*** jonathanmaw has joined #buildstream | 10:49 | |
*** lachlan has joined #buildstream | 10:56 | |
*** lachlan has quit IRC | 11:06 | |
*** lachlan has joined #buildstream | 11:10 | |
*** santi has joined #buildstream | 11:12 | |
douglaswinship | juergbi, cs-shadow thanks! | 11:15 |
douglaswinship | cs-shadow: someone in my own project pointed out something similar. I can split the processing into different parts, use a plugin for the things that the plugin can do, and do the other parts with a different script, so I'm okay. | 11:15 |
douglaswinship | For interest, the use case is that i'm generating a manifest of all the different source URLs. | 11:16 |
douglaswinship | I was trying to read the YAML declarations that defined the mirrors, so that I can add the mirror URLs to the manifest too. | 11:16 |
benschubert | tpollard: it's interesting, your rate limitation breaks the overview at the bottom for me? But it is hugely faster | 11:27 |
benschubert | (numbers coming, still computing on master) | 11:27 |
tpollard | the status area? | 11:27 |
benschubert | yep | 11:27 |
tpollard | interesting, I've not tested the branch for a while but it's been rebased a few times | 11:28 |
tpollard | I'll double check on my end | 11:28 |
benschubert | Thanks, It might not be broken on a fast linux system (in which case it's fine :) ) | 11:28 |
*** santi has quit IRC | 11:28 | |
*** lachlan has quit IRC | 11:31 | |
tme5 | if i missed a NEWS entry for a previous release (dev snapshot? 1.91.2) shall I add it retroactively into that section or under 'unreleased' ? | 11:31 |
*** santi has joined #buildstream | 11:34 | |
*** lachlan has joined #buildstream | 11:57 | |
benschubert | tpollard: one more question: is everything logged as before with your branch or are we skipping parts? :) | 11:58 |
cs-shadow | tme5: I'd vote for adding it under `unreleaed` section, and maybe mention that it was actually done in the vesion x.y. (I don't think many people read news entries ffor older releases) | 11:59 |
tme5 | are all the news entries for these pre-releases going to be collected under one 2.0 when it comes out? | 11:59 |
cs-shadow | tpollard: sidenote - not a blocker at all, but it may be worth considering adding a pexpect-style test to ensure that we always haev the ticker visible under both configurations | 12:00 |
cs-shadow | tme5: I'd hope so | 12:00 |
tpollard | benschubert: everything should be logged as before, in _message_handler() | 12:03 |
*** lachlan has quit IRC | 12:05 | |
tpollard | having no status area at all on wsl sounds like a bug though | 12:06 |
tpollard | if it can manage to render it when un restricted, but not once per second | 12:06 |
tpollard | wfm still on linux | 12:11 |
benschubert | tpollard: ok I got it | 12:19 |
benschubert | the diff of text every second is too big | 12:20 |
benschubert | so the terminal never catches up and just jumps from update to upadte | 12:20 |
benschubert | 'real' time is 2m35 to build base-files. 'Clock' time (as measured by me and my phone) is over 30 minutes (when I gave up and detached the pane) | 12:20 |
gitlab-br-bot | tmewett opened (was WIP) MR !1774 (tmewett/merge-git-tag->master: Merge 'git_tag' functionality into 'git' source) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1774 | 12:26 |
tme5 | ready for review :) | 12:26 |
tpollard | benschubert: that is, not pleasant | 12:27 |
tpollard | a buffer size approach may be more suited then | 12:28 |
tpollard | in stead of time based | 12:28 |
tpollard | *instead | 12:28 |
tpollard | or a mixture of the conditions | 12:30 |
*** lachlan has joined #buildstream | 12:36 | |
*** slaf has quit IRC | 12:37 | |
*** lachlan has quit IRC | 12:40 | |
*** lachlan has joined #buildstream | 12:59 | |
*** lachlan has quit IRC | 13:03 | |
*** xjuan has joined #buildstream | 13:37 | |
tpollard | benschubert: if you've got any suggestions please do post them to the MR | 13:55 |
benschubert | meh, I think it might be better to go with what we have now, at least for now and if we find a better way later, we can change? | 13:57 |
gitlab-br-bot | BenjaminSchubert approved MR !1745 (tpollard/messagerate->master: Make message & status rendering be tick driven by default) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1745 | 14:00 |
tpollard | if you had to give up waiting for it, then do you not feel that it shouldn't be default behaviour? | 14:04 |
benschubert | tpollard: I also gave up on master ;) | 14:07 |
benschubert | takes 2.7 min to build on master, and then it scrolls for more than an hour | 14:07 |
benschubert | so I'll be looking at adding a '--quiet' flag or something to remove some of the verbosity (No, I don't care that BuildStream is staging source, if that is slowing down my total time :'D) | 14:08 |
tpollard | you could open up unconditional_messages to achieve that | 14:11 |
benschubert | I'm not familiar with that part of the code, what do you mean? :) | 14:11 |
tpollard | regardless of context or verbosity, we always print info messages (defined in a global list in _message.py) | 14:13 |
benschubert | yup exactly, we have only ways of putting things more verbose, not quieter :) | 14:15 |
tpollard | there's also the silence context manager, that could be tweaked with configuration | 14:15 |
benschubert | I'll think about it | 14:15 |
benschubert | or maybe a 'PROGRESS' message type that allows showing all the exact commands and such? | 14:16 |
tpollard | I could see that | 14:24 |
benschubert | Good, I'll play around once I'm done with my two current optimizations :'D | 14:26 |
tpollard | cs-shadow: I'll take a look at the pexpect tests | 14:26 |
*** lachlan has joined #buildstream | 14:31 | |
*** traveltissues has quit IRC | 14:35 | |
*** lachlan has quit IRC | 14:36 | |
*** lachlan has joined #buildstream | 14:37 | |
*** lachlan has quit IRC | 14:40 | |
*** lachlan has joined #buildstream | 14:58 | |
*** lachlan has quit IRC | 15:01 | |
*** lachlan has joined #buildstream | 15:11 | |
*** slaf has joined #buildstream | 15:17 | |
*** slaf has joined #buildstream | 15:17 | |
*** slaf has joined #buildstream | 15:18 | |
*** slaf has joined #buildstream | 15:18 | |
*** slaf has joined #buildstream | 15:18 | |
*** lachlan has quit IRC | 15:18 | |
*** slaf has joined #buildstream | 15:18 | |
*** slaf has joined #buildstream | 15:19 | |
*** slaf has joined #buildstream | 15:19 | |
*** phildawson has joined #buildstream | 15:21 | |
*** lachlan has joined #buildstream | 15:32 | |
*** lachlan has quit IRC | 15:37 | |
*** lachlan has joined #buildstream | 15:54 | |
*** lachlan has quit IRC | 15:59 | |
gitlab-br-bot | BenjaminSchubert opened MR !1794 (bschubert/optimize-loading-multiple-targets->master: loader.py: Optimize sorting of elements when they are multiple targets) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1794 | 16:00 |
*** lachlan has joined #buildstream | 16:01 | |
benschubert | ^ also a nice speedup if you like to run multiple heavily intertwined targets :) | 16:01 |
*** phildawson has quit IRC | 16:10 | |
*** santi has quit IRC | 16:17 | |
*** santi has joined #buildstream | 16:17 | |
*** lachlan has quit IRC | 16:20 | |
juergbi | nice | 16:24 |
gitlab-br-bot | juergbi approved MR !1794 (bschubert/optimize-loading-multiple-targets->master: loader.py: Optimize sorting of elements when they are multiple targets) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1794 | 16:25 |
*** lachlan has joined #buildstream | 16:27 | |
benschubert | cheers | 16:30 |
*** lachlan has quit IRC | 16:31 | |
*** rdale has quit IRC | 16:37 | |
*** lachlan has joined #buildstream | 16:38 | |
*** rdale has joined #buildstream | 16:39 | |
*** lachlan has quit IRC | 16:42 | |
*** lachlan has joined #buildstream | 16:54 | |
*** lachlan has quit IRC | 16:57 | |
*** lachlan has joined #buildstream | 16:59 | |
*** lachlan has quit IRC | 17:03 | |
*** lachlan has joined #buildstream | 17:16 | |
*** lachlan has quit IRC | 17:19 | |
*** lachlan has joined #buildstream | 17:22 | |
*** lachlan has quit IRC | 17:26 | |
*** lachlan has joined #buildstream | 17:29 | |
*** lachlan has quit IRC | 17:34 | |
gitlab-br-bot | BenjaminSchubert merged MR !1794 (bschubert/optimize-loading-multiple-targets->master: loader.py: Optimize sorting of elements when they are multiple targets) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1794 | 17:40 |
*** tme5 has quit IRC | 17:41 | |
*** tiagogomes has quit IRC | 17:55 | |
*** lachlan has joined #buildstream | 18:00 | |
*** jonathanmaw has quit IRC | 18:02 | |
*** lachlan has quit IRC | 18:04 | |
*** phildawson has joined #buildstream | 18:09 | |
*** phildawson has quit IRC | 18:34 | |
benschubert | juergbi: for !1739, actually would it be fine if I merge https://gitlab.com/BuildStream/buildstream/commit/0e71d28d0c0f31570e42834ab84e4f1491cc70e6 with https://gitlab.com/BuildStream/buildstream/commit/9baf2aba3e4388912dae0bd7a9a3cbfe081ecfa6 ? It shoud fix all the problems there :) | 18:38 |
gitlab-br-bot | MR !1739: WIP: Optimize consistency and state handling https://gitlab.com/BuildStream/buildstream/merge_requests/1739 | 18:38 |
juergbi | benschubert: that'd be fine with me. I wouldn't expect it to be necessary to remove the asserts in the same commit, however, I don't see an issue squashing that in as well (assuming it doesn't hide underlying bugs) | 18:40 |
*** traveltissues has joined #buildstream | 18:43 | |
benschubert | Sure, thanks! | 18:50 |
*** phildawson has joined #buildstream | 19:13 | |
*** delli3_ has joined #buildstream | 19:32 | |
*** tristan has quit IRC | 19:33 | |
*** delli3 has quit IRC | 19:34 | |
*** santi has quit IRC | 19:56 | |
*** santi has joined #buildstream | 19:59 | |
*** tristan has joined #buildstream | 20:22 | |
*** phildawson has quit IRC | 20:40 | |
*** phildawson has joined #buildstream | 20:56 | |
*** phildawson has quit IRC | 21:11 | |
*** santi has quit IRC | 21:23 | |
*** phildawson has joined #buildstream | 21:44 | |
*** phildawson has quit IRC | 21:47 | |
*** phildawson has joined #buildstream | 21:47 | |
*** phildawson has quit IRC | 21:50 | |
*** phildawson has joined #buildstream | 22:03 | |
*** phildawson has quit IRC | 22:33 | |
gitlab-br-bot | cs-shadow opened MR !1795 (chandan/gitlab-ci-toxenvs->master: .gitlab-ci.yml: Simplify test environment declaration) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1795 | 22:44 |
*** phildawson has joined #buildstream | 22:46 | |
*** slaf has quit IRC | 22:47 | |
*** slaf has joined #buildstream | 22:55 | |
*** slaf has joined #buildstream | 22:55 | |
*** slaf has joined #buildstream | 22:56 | |
*** phildawson has quit IRC | 23:14 | |
*** phildawson has joined #buildstream | 23:15 | |
gitlab-br-bot | cs-shadow merged MR !1795 (chandan/gitlab-ci-toxenvs->master: .gitlab-ci.yml: Simplify test environment declaration) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1795 | 23:20 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!