| *** delli3 has joined #buildstream | 04:40 | |
| *** delli3 has joined #buildstream | 04:45 | |
| *** delli3 has quit IRC | 04:58 | |
| *** tristan has joined #buildstream | 05:09 | |
| *** delli3 has joined #buildstream | 05:09 | |
| *** traveltissues has joined #buildstream | 07:43 | |
| *** traveltissues has quit IRC | 07:46 | |
| *** traveltissues has joined #buildstream | 07:46 | |
| *** traveltissues has quit IRC | 08:03 | |
| *** traveltissues has joined #buildstream | 08:03 | |
| *** traveltissues has quit IRC | 08:06 | |
| *** traveltissues has joined #buildstream | 08:07 | |
| *** traveltissues has quit IRC | 08:22 | |
| *** traveltissues has joined #buildstream | 08:22 | |
| *** bochecha has joined #buildstream | 09:21 | |
| *** tpollard has joined #buildstream | 09:25 | |
| *** rdale has joined #buildstream | 09:33 | |
| *** tme5 has joined #buildstream | 09:39 | |
| *** tiagogomes has joined #buildstream | 09:41 | |
| coldtom | anyone got time to give https://gitlab.com/BuildStream/bst-plugins-experimental/merge_requests/61 a quick review? | 09:52 |
|---|---|---|
| benschubert | coldtom: done :) | 09:55 |
| benschubert | out of interest: did you manage to build Bazel with Bazel? :D | 09:56 |
| benschubert | in buildstream | 09:56 |
| coldtom | tyvm benschubert, and yup, here's an element to do it: https://gitlab.com/celduin/burn-sdk/blob/master/elements/bazel.bst | 09:57 |
| benschubert | how did you get around Bazel trying to download a Java SDK ? | 09:58 |
| coldtom | that's what the bazel_source element does, using --experimental_repository_resolved_file and `bazel cquery` you can just about manage to get bazel to give you a list of the sources it's going to download | 10:00 |
| benschubert | ah nice :) | 10:00 |
| coldtom | s/element/plugin/ | 10:00 |
| benschubert | I'll need to take a deeper look into it | 10:01 |
| benschubert | coldtom: also, I'm planning in publishing a new version of bst-plugins-experimental now, is that fine? That will allow the tests on buildstream around sources to be finally merged | 10:01 |
| coldtom | unfortunately due to the extensibility of bazel, avoiding bazel downloading things is hard | 10:02 |
| coldtom | fine with me, finally there'll be a tag compatible with master \o/ | 10:02 |
| juergbi | it will be incompatible again as soon as !1739 is merged, though, afaict | 10:03 |
| gitlab-br-bot | MR !1739: WIP: Optimize consistency and state handling https://gitlab.com/BuildStream/buildstream/merge_requests/1739 | 10:03 |
| coldtom | heh, compatible with the latest dev snapshot then :P | 10:04 |
| benschubert | correct | 10:04 |
| benschubert | I want to tests first hand the process of updating with the two repos having breaking changes :D | 10:05 |
| benschubert | juergbi: btw thanks for the thorough review, I'll go through it | 10:05 |
| juergbi | yw | 10:05 |
| *** jonathanmaw has joined #buildstream | 10:12 | |
| benschubert | Also added the 'real world' benchmark on !1739: https://gitlab.com/BuildStream/buildstream/merge_requests/1739#using-a-real-internal-project :D | 10:13 |
| juergbi | nice speedup :) | 10:16 |
| tpollard | nice | 10:16 |
| benschubert | went from driving me crazy to acceptable :) | 10:17 |
| benschubert | but gosh how tangled was all of this | 10:17 |
| coldtom | wow! that's an amazing speedup! | 10:18 |
| benschubert | bst-plugins-experimental 0.13.0 is out! https://gitlab.com/BuildStream/bst-plugins-experimental/-/tags/0.13.0 | 10:22 |
| tme5 | impressive optimisation | 10:22 |
| *** lachlan has joined #buildstream | 10:34 | |
| *** lachlan has quit IRC | 10:37 | |
| *** lachlan has joined #buildstream | 10:38 | |
| *** lachlan has quit IRC | 10:41 | |
| gitlab-br-bot | juergbi opened MR !1793 (juerg/batch-command-logging->master: _sandboxreapi.py: Improve batch command logging) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1793 | 10:44 |
| gitlab-br-bot | BenjaminSchubert approved MR !1793 (juerg/batch-command-logging->master: _sandboxreapi.py: Improve batch command logging) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1793 | 10:46 |
| juergbi | ta | 10:48 |
| *** lachlan has joined #buildstream | 11:02 | |
| gitlab-br-bot | BenjaminSchubert opened (was WIP) MR !1757 (bschubert/standardized-tests->master: introduce cross-repo standardized source tests) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1757 | 11:05 |
| benschubert | coldtom: ^ if you want to give a last review on this. After multiple months we're finally here :) | 11:06 |
| *** lachlan has quit IRC | 11:07 | |
| coldtom | benschubert: sure, I'll take a look | 11:07 |
| *** lachlan has joined #buildstream | 11:13 | |
| *** santi has joined #buildstream | 11:16 | |
| *** santi has quit IRC | 11:17 | |
| gitlab-br-bot | coldtom approved MR !1757 (bschubert/standardized-tests->master: introduce cross-repo standardized source tests) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1757 | 11:18 |
| *** lachlan has quit IRC | 11:19 | |
| *** santi has joined #buildstream | 11:19 | |
| *** lachlan has joined #buildstream | 11:22 | |
| *** lachlan has quit IRC | 11:25 | |
| *** lachlan has joined #buildstream | 11:27 | |
| *** lachlan has quit IRC | 11:31 | |
| *** santi has quit IRC | 11:40 | |
| *** santi has joined #buildstream | 11:43 | |
| *** lachlan has joined #buildstream | 11:51 | |
| *** traveltissues has quit IRC | 11:57 | |
| gitlab-br-bot | juergbi merged MR !1793 (juerg/batch-command-logging->master: _sandboxreapi.py: Improve batch command logging) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1793 | 12:00 |
| *** traveltissues has joined #buildstream | 12:09 | |
| *** traveltissues has quit IRC | 12:16 | |
| juergbi | tlater[m]: thanks for the update of !1769. I think this has fixed the remaining edge cases | 12:16 |
| gitlab-br-bot | MR !1769: WIP: storage/_casbaseddirectory.py: Add `diff` methods https://gitlab.com/BuildStream/buildstream/merge_requests/1769 | 12:16 |
| tlater[m] | Awesome, thanks juergbi :) | 12:16 |
| *** traveltissues has joined #buildstream | 12:17 | |
| tlater[m] | I've also changed the target as traveltissues requested | 12:17 |
| juergbi | ok | 12:18 |
| *** lachlan has quit IRC | 12:20 | |
| *** lachlan has joined #buildstream | 12:30 | |
| *** lachlan has quit IRC | 12:33 | |
| *** santi has quit IRC | 12:40 | |
| *** santi has joined #buildstream | 12:40 | |
| *** santi has quit IRC | 12:42 | |
| *** santi has joined #buildstream | 12:42 | |
| *** santi has quit IRC | 12:44 | |
| *** santi has joined #buildstream | 12:45 | |
| tme5 | if you specify to a git source that you want to track the latest tag of the branches, what do you think the behaviour should be if a branch doesn't have a tag? | 12:48 |
| tpollard | configurable warning, imo | 12:49 |
| tme5 | currently git_tag will choose the latest commit instead | 12:49 |
| tpollard | like the commit not existing in a specific branch | 12:49 |
| tme5 | yeah, i'm thinking issue a warning | 12:49 |
| *** lachlan has joined #buildstream | 12:53 | |
| *** lachlan has quit IRC | 12:59 | |
| *** rdale has quit IRC | 13:01 | |
| *** xjuan has joined #buildstream | 14:09 | |
| *** lachlan has joined #buildstream | 14:16 | |
| *** lachlan has quit IRC | 14:19 | |
| *** traveltissues has quit IRC | 14:45 | |
| *** traveltissues has joined #buildstream | 14:46 | |
| *** traveltissues has quit IRC | 14:50 | |
| tpollard | hmm, might be issues with our digital ocean runners | 15:47 |
| tpollard | dashboard is only claiming 1 runner active | 15:48 |
| tpollard | yep it's journactl is full of warnings | 15:49 |
| tpollard | I'll restart the bastion servive | 15:49 |
| tpollard | *service | 15:49 |
| tpollard | should be back now | 15:52 |
| *** xjuan has quit IRC | 15:56 | |
| *** lachlan has joined #buildstream | 16:22 | |
| *** lachlan has quit IRC | 16:42 | |
| *** bochecha has quit IRC | 16:47 | |
| *** phildawson has joined #buildstream | 16:49 | |
| *** lachlan has joined #buildstream | 16:53 | |
| *** santi has quit IRC | 16:54 | |
| *** lachlan has quit IRC | 17:00 | |
| *** phildawson-ct has joined #buildstream | 17:00 | |
| *** phildawson has quit IRC | 17:01 | |
| juergbi | tpollard: as I understand it the remaining blocker of !1745 is a final decision on whether it should be enabled by default? and possibly benchmark on more systems (maybe benschubert)? | 17:01 |
| gitlab-br-bot | MR !1745: Make message & status rendering be tick driven by default https://gitlab.com/BuildStream/buildstream/merge_requests/1745 | 17:01 |
| benschubert | I have a good usecase for this. :D will take me a bit of time though | 17:03 |
| benschubert | will try to do that tomorrow | 17:03 |
| juergbi | great | 17:04 |
| benschubert | juergbi: I believe I tackled everything you mentionned in !1739 | 17:06 |
| gitlab-br-bot | MR !1739: WIP: Optimize consistency and state handling https://gitlab.com/BuildStream/buildstream/merge_requests/1739 | 17:06 |
| *** santi has joined #buildstream | 17:06 | |
| benschubert | I'll look at the plugins as soon as my MR around testing them is in :) | 17:06 |
| *** phildawson has joined #buildstream | 17:06 | |
| tpollard | juergbi: I think just a final decision if there's no comments on the actual code | 17:06 |
| *** phildawson-ct has quit IRC | 17:07 | |
| *** phildawson-ct has joined #buildstream | 17:08 | |
| *** phildawson has quit IRC | 17:09 | |
| *** phildawson has joined #buildstream | 17:20 | |
| *** phildawson-ct has quit IRC | 17:20 | |
| *** lachlan has joined #buildstream | 17:29 | |
| *** xjuan has joined #buildstream | 17:31 | |
| *** xjuan has quit IRC | 17:34 | |
| *** lachlan has quit IRC | 17:34 | |
| *** tme5 has quit IRC | 17:36 | |
| juergbi | benschubert: we can always make exceptions for the odd test case to avoid spending too much effort on it. however, would certainly be good to at least be close, so thanks | 17:37 |
| benschubert | juergbi: I might have missed it, but I thought I didn't have any odd tests anymore? did I completely miss one part? | 17:37 |
| juergbi | benschubert: no, I just meant that if we can't get each commit in the branch passing the whole test suite because of one or a few test cases, we can consider an exception | 17:38 |
| *** xjuan has joined #buildstream | 17:39 | |
| benschubert | oh fair enough, I'll give it a bit of time and if I can't I'll give up :) | 17:39 |
| benschubert | but should be fine | 17:39 |
| juergbi | ta | 17:39 |
| benschubert | I also still need to send it through the ML since it's a breaking change | 17:39 |
| gitlab-br-bot | BenjaminSchubert opened issue #1249 (On build error, can't enter twice in the shell) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1249 | 17:42 |
| *** phildawson has quit IRC | 17:44 | |
| *** adds68 has quit IRC | 17:46 | |
| *** lachlan has joined #buildstream | 17:47 | |
| *** lachlan has quit IRC | 18:03 | |
| *** lachlan has joined #buildstream | 18:06 | |
| *** lachlan has quit IRC | 18:09 | |
| *** jonathanmaw has quit IRC | 18:10 | |
| *** lachlan has joined #buildstream | 18:17 | |
| *** tiagogomes has quit IRC | 18:23 | |
| *** phildawson has joined #buildstream | 18:23 | |
| gitlab-br-bot | BenjaminSchubert merged MR !1757 (bschubert/standardized-tests->master: introduce cross-repo standardized source tests) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1757 | 18:25 |
| *** phildawson has quit IRC | 18:26 | |
| *** lachlan has quit IRC | 18:27 | |
| douglaswinship | If i'm writing a plugin, is there any way I can get it to access a particular file, in a particular location in the project repository? | 18:28 |
| douglaswinship | I'm basically looking for a variable that resolves to the top directory of the project. | 18:29 |
| douglaswinship | Or failing that, to the path of the element. | 18:29 |
| douglaswinship | I can't use an absolute path, because the repo will be copied to different places by different users. But i don't want to use a path relative to the current folder, because users might use the "bst build" command from different starting folders | 18:31 |
| *** phildawson has joined #buildstream | 18:34 | |
| juergbi | douglaswinship: you can do this from source plugins with self.get_project_directory() | 18:36 |
| juergbi | I don't think public API allows this in element plugins | 18:36 |
| *** lachlan has joined #buildstream | 18:51 | |
| *** lachlan has quit IRC | 18:55 | |
| *** lachlan has joined #buildstream | 18:58 | |
| cs-shadow | douglaswinship: may i ask the use case for this? (perhaps there's another of achieving that you are trying to do without requiring said access) | 19:03 |
| *** phildawson has quit IRC | 19:07 | |
| *** phildawson has joined #buildstream | 19:07 | |
| *** lachlan has quit IRC | 19:32 | |
| *** lachlan has joined #buildstream | 20:09 | |
| *** lachlan has quit IRC | 20:12 | |
| *** phildawson has quit IRC | 20:13 | |
| *** lachlan has joined #buildstream | 20:17 | |
| *** lachlan has quit IRC | 20:20 | |
| *** lachlan has joined #buildstream | 20:52 | |
| *** phildawson has joined #buildstream | 20:52 | |
| *** lachlan has quit IRC | 21:01 | |
| *** lachlan has joined #buildstream | 21:01 | |
| *** santi has quit IRC | 21:17 | |
| *** lachlan has quit IRC | 21:19 | |
| *** phildawson has quit IRC | 23:03 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!