| *** dylan-m_ has quit IRC | 03:02 | |
| *** narispo has quit IRC | 08:04 | |
| *** narispo has joined #buildstream | 08:04 | |
| *** bochecha has joined #buildstream | 09:12 | |
| *** phoenix has joined #buildstream | 09:14 | |
| gitlab-br-bot | coldtom approved MR !1722 (valentindavid/compose-integration-commands->master: compose: Allow compose elements to run integration commands) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1722 | 09:16 |
|---|---|---|
| *** traveltissues has joined #buildstream | 09:18 | |
| *** qinusty has joined #buildstream | 09:23 | |
| Kinnison | valentind: looks like your pipeline failed black formatting checks | 09:42 |
| valentind | Kinnison, thanks for telling me, I would have not looked. | 09:43 |
| valentind | I thought it was merged. But coldtom only approved a second time. | 09:44 |
| gitlab-br-bot | traveltissues opened (was WIP) MR !1682 (traveltissues/mr3->master: Support RE workspaces (non-incremental)) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1682 | 09:44 |
| valentind | Wow, we got to the point that the code is completely normalized. There is only one way to write it. | 09:45 |
| Kinnison | Yep | 09:45 |
| valentind | It seems compose does not work with buildbox. | 09:48 |
| Kinnison | That could be a problem. Though the current buildbox sandbox isn't the eventual one. | 09:56 |
| Kinnison | It may make sense to block that test on the buildbox sandbox for now | 09:56 |
| valentind | I have marked it as xfail. | 09:57 |
| benschubert | yep that seems good to me :) | 09:57 |
| *** phildawson has joined #buildstream | 10:07 | |
| gitlab-br-bot | valentindavid opened issue #1214 (Compose elements with integration commands do not work on buildbox) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1214 | 10:13 |
| valentind | error: cannot format tests/integration/compose.py: Cannot parse: 152:4: _yaml.roundtrip_dump(element, os.path.join(element_path, element_name)) | 10:16 |
| valentind | Well I can parse it, so the pylint on my machine. | 10:16 |
| valentind | Not sure what is the problem there. | 10:16 |
| benschubert | valentind: aren't you missing a ')' at the end? | 10:16 |
| benschubert | black requires your code to be valid | 10:16 |
| valentind | Nope | 10:16 |
| benschubert | is it up to date on your PR? | 10:17 |
| valentind | Yes | 10:17 |
| valentind | And obviously the line in the log is correct. | 10:17 |
| valentind | There are the right number of parenthesis. | 10:17 |
| benschubert | interesting | 10:18 |
| Kinnison | valentind: very odd | 10:18 |
| *** jonathanmaw has joined #buildstream | 10:18 | |
| valentind | Ah maybe it is "format-check" | 10:18 |
| valentind | I did not try this locally. Let me see if that fails locally. | 10:18 |
| valentind | It fails. | 10:19 |
| Kinnison | Gotta love Python :D | 10:19 |
| benschubert | https://gitlab.com/BuildStream/buildstream/-/jobs/357152700 your linter is also complaining | 10:19 |
| benschubert | (pylint) | 10:19 |
| valentind | Oh I know | 10:19 |
| valentind | The error was on the line before. | 10:20 |
| benschubert | :) | 10:21 |
| valentind | Instead of showing what it cannot parse, the parse should say what it expected. Because it is quite confusing. | 10:22 |
| *** rdale has joined #buildstream | 10:25 | |
| *** phoenix has quit IRC | 10:26 | |
| *** phoenix has joined #buildstream | 10:27 | |
| *** lachlan has joined #buildstream | 10:31 | |
| *** lachlan has joined #buildstream | 10:31 | |
| gitlab-br-bot | juergbi opened MR !1724 (juerg/umask->master: Respect umask for created file and directories) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1724 | 10:36 |
| juergbi | tlater[m]: ^^ is the replacement for the group permission fixes | 10:37 |
| juergbi | review appreciated | 10:37 |
| benschubert | https://docs.python.org/3/library/functools.html#functools.cached_property just stumbled upon that, I wonder if this would make part of our code more readable for things we only compute once :) | 10:39 |
| bochecha | benschubert: it's Python 3.8 only though | 10:45 |
| * bochecha copy-pasted it into his own code, to be able to use it with Python 3.7, until the move to 3.8 | 10:45 | |
| bochecha | and yeah, it's great :) | 10:46 |
| benschubert | that explains why I never saw it before x) | 10:46 |
| benschubert | I'd be curious if it's faster or not | 10:46 |
| bochecha | that computing it each time? certainly :) | 10:46 |
| bochecha | s/that/than/ | 10:47 |
| benschubert | I meant than doing it explicitely as we do ;) | 10:47 |
| bochecha | dunno… it does quite a lot of things so as to be be more generic, a custom-built solution might be faster | 10:49 |
| bochecha | https://github.com/python/cpython/blob/master/Lib/functools.py#L915-L960 | 10:49 |
| bochecha | how is it implemented in bst? | 10:49 |
| benschubert | oh gosh :) | 10:49 |
| bochecha | (e.g the python 3.8 one locks for multithreading) | 10:49 |
| benschubert | if self.__var is None: | 10:50 |
| benschubert | self.__var = .... | 10:50 |
| benschubert | return self.__var | 10:50 |
| benschubert | so probably faster :) | 10:50 |
| bochecha | yeah | 10:50 |
| bochecha | you can generalize that as a custom cached_property decorator though | 10:50 |
| bochecha | so you still get a simpler code | 10:50 |
| bochecha | e.g feel free to steal https://pagure.io/rpkg/blob/master/f/pyrpkg/utils.py#_34 (it's LGPL as well, like bst) | 10:52 |
| bochecha | (I had written that a few years ago, and it seems to have survived ^_^) | 10:53 |
| *** phoenix has quit IRC | 10:57 | |
| *** lachlan has quit IRC | 11:15 | |
| tlater[m] | juergbi: I'm looking through that - while we're at it, I've cleaned up the tracking leftovers: https://gitlab.com/BuildStream/buildstream/merge_requests/1718 | 11:19 |
| tlater[m] | Any chance you could give it a quick look and see whether there's anything else left that could be simplified? | 11:20 |
| juergbi | will take a look in a bit | 11:20 |
| *** lachlan has joined #buildstream | 11:21 | |
| tlater[m] | juergbi: Interesting that os.chmod() doesn't blow up on win32 | 11:37 |
| tlater[m] | `os.umask`, even | 11:38 |
| juergbi | the Microsoft CRT has limited support for umask | 11:40 |
| juergbi | not anything that would be useful for us, though (single user) | 11:41 |
| *** lachlan has quit IRC | 11:45 | |
| *** lachlan has joined #buildstream | 12:22 | |
| gitlab-br-bot | jjardon opened issue #1215 (overnight tests are failing: "Sandbox.run() has been disabled") on buildstream https://gitlab.com/BuildStream/buildstream/issues/1215 | 12:58 |
| gitlab-br-bot | jjardon closed issue #1207 (Overnight-tests: mesa-aco/mesa.bst fails fetch) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1207 | 12:59 |
| *** bochecha has quit IRC | 13:33 | |
| *** bochecha has joined #buildstream | 13:35 | |
| gitlab-br-bot | traveltissues opened issue #1216 (Optional support for file timestamps) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1216 | 13:38 |
| gitlab-br-bot | tlater opened (was WIP) MR !1725 (1211-stop-using-non-posix-features-in-small-test-suite-tests-to-avoid-fake-test-failures->master: Resolve "Stop using non-POSIX features in small test suite tests to avoid fake test failures") on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1725 | 13:50 |
| *** lachlan has quit IRC | 14:21 | |
| *** lachlan has joined #buildstream | 14:27 | |
| *** akvilebirgelyte_ has quit IRC | 14:49 | |
| *** akvilebirgelyte_ has joined #buildstream | 14:53 | |
| *** phoenix has joined #buildstream | 14:53 | |
| gitlab-br-bot | tlater opened (was WIP) MR !1718 (tlater/track-cleanup->master: Simplify the codebase using post-tracking removal simplicity of the pipeline) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1718 | 15:03 |
| gitlab-br-bot | juergbi opened issue #1217 (Optimize fork bottleneck in WSL) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1217 | 15:15 |
| *** bochecha_ has joined #buildstream | 16:01 | |
| *** bochecha has quit IRC | 16:03 | |
| *** bochecha_ is now known as bochecha | 16:03 | |
| *** lachlan has quit IRC | 16:10 | |
| *** bochecha_ has joined #buildstream | 16:11 | |
| *** bochecha has quit IRC | 16:13 | |
| *** bochecha_ is now known as bochecha | 16:13 | |
| *** lachlan has joined #buildstream | 16:14 | |
| *** phoenix has quit IRC | 16:22 | |
| *** phoenix has joined #buildstream | 16:23 | |
| *** mohan43u has quit IRC | 16:31 | |
| *** mohan43u has joined #buildstream | 16:38 | |
| *** tpollard has quit IRC | 17:11 | |
| *** lachlan has quit IRC | 17:25 | |
| *** lachlan has joined #buildstream | 17:29 | |
| *** lachlan has quit IRC | 17:56 | |
| *** phildawson has quit IRC | 18:03 | |
| *** traveltissues has quit IRC | 18:22 | |
| *** slaf_ has joined #buildstream | 18:29 | |
| *** slaf_ has joined #buildstream | 18:29 | |
| *** slaf_ has joined #buildstream | 18:30 | |
| *** slaf_ has joined #buildstream | 18:30 | |
| *** slaf_ has joined #buildstream | 18:30 | |
| *** slaf_ has joined #buildstream | 18:30 | |
| *** slaf_ has joined #buildstream | 18:31 | |
| *** slaf_ has joined #buildstream | 18:31 | |
| *** slaf has quit IRC | 18:31 | |
| *** slaf has joined #buildstream | 18:31 | |
| *** slaf has joined #buildstream | 18:32 | |
| *** slaf has joined #buildstream | 18:32 | |
| *** slaf has joined #buildstream | 18:32 | |
| *** slaf has joined #buildstream | 18:33 | |
| *** slaf has joined #buildstream | 18:33 | |
| *** slaf has joined #buildstream | 18:33 | |
| *** slaf has joined #buildstream | 18:33 | |
| *** jonathanmaw has quit IRC | 18:43 | |
| *** rdale has quit IRC | 18:51 | |
| gitlab-br-bot | jjardon opened MR !1727 (jjardon/debian-10->master: .gitlab-ci.yml: Use Debian9 instead Debian10) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1727 | 19:09 |
| jjardon | Can I have reviews of https://gitlab.com/BuildStream/buildstream-docker-images/merge_requests/145 , please? | 19:24 |
| *** phoenix has quit IRC | 19:39 | |
| jjardon | Can I have review of https://gitlab.com/BuildStream/buildstream/merge_requests/1727/ please? | 21:36 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!