| *** tristan has quit IRC | 01:01 | |
| *** tristan has joined #buildstream | 01:14 | |
| *** tiagogomes has joined #buildstream | 03:31 | |
| *** tiagogomes has quit IRC | 03:32 | |
| *** narispo has joined #buildstream | 07:52 | |
| *** narispo has quit IRC | 07:55 | |
| *** narispo has joined #buildstream | 07:55 | |
| tpollard | jjardon: that would be pretty cool... | 09:19 |
|---|---|---|
| benschubert | jjardon: when's the close of the merge period for 20.04? I'd rather not rush until we have everything we want implemented, but once we have that :) | 09:27 |
| jjardon | Sure, only pointing it out as a data point in case there are some plans | 09:32 |
| benschubert | Yep, do you know when's the merge period close? Or do we need to make it into Debian next first? (Not sure how Ubuntu works those days for that) | 09:32 |
| *** traveltissues has joined #buildstream | 09:50 | |
| *** tristan has quit IRC | 09:51 | |
| *** bochecha has joined #buildstream | 10:00 | |
| *** phildawson_ has joined #buildstream | 10:01 | |
| *** lachlan has joined #buildstream | 10:06 | |
| *** jonathanmaw has joined #buildstream | 10:16 | |
| gitlab-br-bot | traveltissues reopened issue #1207 (Overnight-tests: mesa-aco/mesa.bst fails fetch) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1207 | 10:20 |
| *** lachlan has quit IRC | 10:42 | |
| *** lachlan has joined #buildstream | 10:52 | |
| *** lachlan has quit IRC | 11:04 | |
| *** narispo has quit IRC | 11:18 | |
| gitlab-br-bot | traveltissues opened MR !1721 (traveltissues/incrementaltest->master: Enable the incremental workspace test in integration) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1721 | 11:21 |
| *** lachlan has joined #buildstream | 11:30 | |
| *** lachlan has quit IRC | 11:36 | |
| *** lachlan has joined #buildstream | 12:01 | |
| *** lachlan has quit IRC | 12:06 | |
| *** cs-shadow has quit IRC | 13:02 | |
| *** narispo has joined #buildstream | 13:13 | |
| *** cs-shadow has joined #buildstream | 13:14 | |
| gitlab-br-bot | tlater opened issue #1212 (`_update_state()` may be gone, but it still lives on in our code structure) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1212 | 13:18 |
| gitlab-br-bot | tlater closed issue #902 (Element._update_state() does more stuff than it needs to when it's called) on buildstream https://gitlab.com/BuildStream/buildstream/issues/902 | 13:19 |
| tlater[m] | I assume local/workspace plugins would break completely without BST_KEY_REQUIRES_STAGE? | 13:28 |
| * tlater[m] doesn't see how they would compute cache keys if that wasn't set | 13:28 | |
| gitlab-br-bot | traveltissues opened (was WIP) MR !1721 (traveltissues/incrementaltest->master: Enable the incremental workspace test in integration) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1721 | 13:31 |
| gitlab-br-bot | traveltissues opened (was WIP) MR !1682 (traveltissues/mr3->master: RE workspaces (non-incremental)) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1682 | 13:32 |
| *** narispo has quit IRC | 13:33 | |
| gitlab-br-bot | traveltissues approved MR !1698 (jjardon/powerpc64le->master: buildstream/_platform/platform.py: Add ppc64el, powerpc64 and powerpc64le) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1698 | 14:11 |
| valentind | Why does compose has BUILD_RUN_COMMANDS = False? | 14:31 |
| valentind | integration commands cannot be run now. | 14:31 |
| gitlab-br-bot | valentindavid opened issue #1213 (Compose elements cannot run integration commands) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1213 | 14:38 |
| gitlab-br-bot | valentindavid opened MR !1722 (valentindavid/compose-integration-commands->master: compose: Allow compose elements to run integration commands) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1722 | 14:38 |
| tpollard | valentind: blame the line? it sounds familiar | 14:43 |
| valentind | It was 1 week ago. | 14:44 |
| valentind | https://gitlab.com/BuildStream/buildstream/commit/e6c0686d333a168c7809729a4950149c950245c7 | 14:45 |
| tpollard | so https://gitlab.com/BuildStream/buildstream/merge_requests/1697 | 14:45 |
| benschubert | cs-shadow: ^ | 14:46 |
| *** lachlan has joined #buildstream | 15:15 | |
| cs-shadow | valentind: whoops, sorry about that. I forgot about integration-commands | 15:21 |
| *** tristan has joined #buildstream | 15:23 | |
| *** tpollard has quit IRC | 15:23 | |
| *** tpollard has joined #buildstream | 15:23 | |
| gitlab-br-bot | BenjaminSchubert approved MR !1722 (valentindavid/compose-integration-commands->master: compose: Allow compose elements to run integration commands) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1722 | 15:24 |
| valentind | cs-shadow, I was thinking it was not obvious and keeping BST_RUN_COMMANDS = True with a comment would prevent other people to add BST_RUN_COMMANDS=False. | 15:46 |
| valentind | But I can change it. | 15:46 |
| tpollard | Does anyone know if Clicks `call_on_close()` is closed if you forcefully exit, say with sys.exit() ? | 15:47 |
| tpollard | s/closed/called | 15:47 |
| benschubert | valentind: a perhaps stronger way would be to add a test that would fail if that was reintroduced? | 15:48 |
| valentind | I thought I wrote such tests in the past. | 15:48 |
| * benschubert tpollard: I believe it would. My guess is things like os._exit() would not but this would | 15:49 | |
| valentind | Because integration commands + include/exclude was tricky and needed testing. | 15:49 |
| *** traveltissues has quit IRC | 15:51 | |
| tpollard | benschubert: thanks, that's what I thought | 15:52 |
| tpollard | looks to be the case, if I put an assert in the callback & force a project to cause an exception | 15:52 |
| tlater[m] | Do we keep track of minor output changes in NEWS? | 16:11 |
| tlater[m] | E.g., suddenly showing SKIP in certain situations that were skipped previously but not communicated that way? | 16:12 |
| gitlab-br-bot | tlater opened MR !1723 (tlater/update-workspace-manpages->master: man/bst-workspace-reset.1: Update workspace re-open help message) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1723 | 16:20 |
| *** lachlan has quit IRC | 16:21 | |
| *** lachlan has joined #buildstream | 16:27 | |
| *** bochecha has quit IRC | 16:37 | |
| *** narispo has joined #buildstream | 16:40 | |
| cs-shadow | valentind: fair enough, that makes sense. Up to you. If we have it set to True, a comment about integration command will be nice | 16:58 |
| cs-shadow | And thanks for adding the tests as well | 16:59 |
| valentind | cs-shadow, I removed it and added a test instead | 16:59 |
| gitlab-br-bot | cs-shadow approved MR !1722 (valentindavid/compose-integration-commands->master: compose: Allow compose elements to run integration commands) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1722 | 16:59 |
| valentind | We should really have more tests here. integration commands in compose is not easy with lots of corner cases. A bit annoying we do not have tests. | 16:59 |
| Kinnison | +1 for more tests | 16:59 |
| *** lachlan has quit IRC | 17:03 | |
| *** lachlan has joined #buildstream | 17:04 | |
| *** phildawson has joined #buildstream | 17:34 | |
| *** phildawson_ has quit IRC | 17:34 | |
| *** narispo has quit IRC | 17:53 | |
| *** narispo has joined #buildstream | 18:02 | |
| *** adds68 has quit IRC | 18:04 | |
| *** qinusty has quit IRC | 18:04 | |
| *** ikerperez has quit IRC | 18:04 | |
| *** ikerperez has joined #buildstream | 18:05 | |
| *** adds68 has joined #buildstream | 18:05 | |
| *** lachlan has quit IRC | 18:25 | |
| *** phildawson has quit IRC | 18:43 | |
| *** dylan-m_ has joined #buildstream | 18:54 | |
| *** jonathanmaw has quit IRC | 19:05 | |
| *** phildawson has joined #buildstream | 20:07 | |
| *** lachlan has joined #buildstream | 20:22 | |
| *** dylan-m_ has quit IRC | 21:00 | |
| *** phildawson has quit IRC | 21:17 | |
| *** dylan-m_ has joined #buildstream | 21:54 | |
| *** lachlan has quit IRC | 22:03 | |
| *** narispo has quit IRC | 22:30 | |
| *** narispo has joined #buildstream | 22:30 | |
| *** lachlan has joined #buildstream | 22:57 | |
| *** lachlan has quit IRC | 23:06 | |
| *** dylan-m_ has quit IRC | 23:39 | |
| *** lachlan has joined #buildstream | 23:49 | |
| *** lachlan has quit IRC | 23:51 | |
| *** dylan-m_ has joined #buildstream | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!