*** wberrier has left #buildstream | 00:43 | |
*** narispo has quit IRC | 02:01 | |
*** narispo has joined #buildstream | 02:02 | |
*** tristan has quit IRC | 05:42 | |
*** tristan has joined #buildstream | 06:11 | |
*** cs-shadow has quit IRC | 06:53 | |
*** tristan has quit IRC | 06:55 | |
*** slaf has quit IRC | 07:01 | |
*** slaf has joined #buildstream | 07:04 | |
*** slaf has joined #buildstream | 07:04 | |
*** slaf has joined #buildstream | 07:04 | |
*** slaf has joined #buildstream | 07:04 | |
*** slaf has joined #buildstream | 07:05 | |
*** slaf has joined #buildstream | 07:05 | |
*** slaf has joined #buildstream | 07:05 | |
*** slaf has joined #buildstream | 07:05 | |
*** tristan has joined #buildstream | 07:30 | |
*** ahmed89 has quit IRC | 07:58 | |
benschubert | juergbi: Ok I have more info: the artifact is >60Go (Might want to tweak my flags to compile LLVM...), and the process that dies is buildbox-casd. Are we loading everythign in memory or something? | 08:25 |
---|---|---|
juergbi | benschubert: ok, thanks for the info. I hope not but there might be a bug | 08:44 |
juergbi | upload batches are limited to 1 MB and we shouldn't prepare all batches in memory | 08:45 |
juergbi | maybe I should try to look into this before the planned buildbox update for buildstream | 08:55 |
*** jonathanmaw has joined #buildstream | 09:01 | |
*** bochecha has joined #buildstream | 09:01 | |
benschubert | juergbi: it's quite an edge case, so iw ould not spend too much time to it :) | 09:13 |
*** traveltissues has joined #buildstream | 09:14 | |
juergbi | benschubert: while >60 GB could be considered an edge case for a single artifact, loading the whole artifact into memory should still be fixed | 09:14 |
benschubert | agreed | 09:15 |
benschubert | our caches will be glad about it :) but I would not delay the buildbox update too much for that, I think we gain more by having better exit from buildbox etc | 09:15 |
juergbi | sure, but there is anyway still a buildbox-casd MR pending review. will not (significantly) delay the buildbox update because of this | 09:20 |
benschubert | good for me then :) | 09:21 |
gitlab-br-bot | tlater closed issue #372 (Allow queues to run auxilliary jobs after an element's job finishes) on buildstream https://gitlab.com/BuildStream/buildstream/issues/372 | 09:56 |
*** narispo has quit IRC | 10:15 | |
*** narispo has joined #buildstream | 10:30 | |
gitlab-br-bot | traveltissues opened (was WIP) MR !1563 (traveltissues/985->master: workspaces via sourcecache) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1563 | 10:34 |
*** ChanServ sets mode: +o tristan | 10:35 | |
tristan | juergbi, benschubert ... (anyone in the room) ... Any objections that I push a 1.91.0 tag in master immediately (as we did for 1.3.0 initially, without any associated snapshot) ? | 10:38 |
tristan | Rationale: When you checkout BuildStream from master and run it, it currently reports that it is something like version 1.3.0 | 10:38 |
benschubert | seems sensible, we can anyways have the snapshot published afterwards | 10:41 |
tristan | right, with 1.3.x we rolled a 1.3.1 as the first one | 10:42 |
juergbi | tristan: no objections for tagging | 10:47 |
*** narispo has quit IRC | 11:25 | |
*** bochecha has quit IRC | 11:25 | |
*** tristan has quit IRC | 11:25 | |
*** phildawson_ has quit IRC | 11:25 | |
*** flatmush has quit IRC | 11:25 | |
*** valentind has quit IRC | 11:25 | |
*** juergbi has quit IRC | 11:25 | |
*** paulsherwood has quit IRC | 11:25 | |
*** bethw has quit IRC | 11:25 | |
*** laurence has quit IRC | 11:25 | |
*** connorshea[m] has quit IRC | 11:25 | |
*** kailueke[m] has quit IRC | 11:25 | |
*** reuben640[m] has quit IRC | 11:25 | |
*** theawless[m] has quit IRC | 11:25 | |
*** Demos[m] has quit IRC | 11:25 | |
*** Trevinho[m] has quit IRC | 11:25 | |
*** waltervargas[m] has quit IRC | 11:25 | |
*** mrmcq2u[m] has quit IRC | 11:25 | |
*** dineshdb[m] has quit IRC | 11:25 | |
*** skullone[m] has quit IRC | 11:25 | |
*** swick has quit IRC | 11:25 | |
*** gimpnet-irc[m] has quit IRC | 11:25 | |
*** asingh_[m] has quit IRC | 11:25 | |
*** dbuch has quit IRC | 11:25 | |
*** verdre[m] has quit IRC | 11:25 | |
*** rafaelff[m] has quit IRC | 11:25 | |
*** segfault3[m] has quit IRC | 11:25 | |
*** slaf has quit IRC | 11:25 | |
*** tiagogomes has quit IRC | 11:25 | |
*** benbrown has quit IRC | 11:25 | |
*** kapip has quit IRC | 11:25 | |
*** aevri has quit IRC | 11:25 | |
*** krichter[m] has quit IRC | 11:25 | |
*** albfan[m] has quit IRC | 11:25 | |
*** tlater[m] has quit IRC | 11:25 | |
*** cgmcintyre[m] has quit IRC | 11:25 | |
*** nielsdg has quit IRC | 11:25 | |
*** doras has quit IRC | 11:25 | |
*** mattiasb has quit IRC | 11:25 | |
*** awacheux[m] has quit IRC | 11:25 | |
*** jjardon[m] has quit IRC | 11:25 | |
*** m_22[m] has quit IRC | 11:25 | |
*** abderrahim[m] has quit IRC | 11:25 | |
*** pro[m] has quit IRC | 11:25 | |
*** ssssam[m] has quit IRC | 11:25 | |
*** tchaik[m] has quit IRC | 11:25 | |
*** jjardon has quit IRC | 11:25 | |
*** benschubert has quit IRC | 11:25 | |
*** lchlan has quit IRC | 11:25 | |
*** persia has quit IRC | 11:25 | |
*** hergertme has quit IRC | 11:25 | |
*** ironfoot has quit IRC | 11:25 | |
*** raoul_ has quit IRC | 11:25 | |
*** traveltissues has quit IRC | 11:25 | |
*** jonathanmaw has quit IRC | 11:25 | |
*** tpollard has quit IRC | 11:25 | |
*** samkirkham has quit IRC | 11:25 | |
*** Kinnison has quit IRC | 11:25 | |
*** SotK has quit IRC | 11:25 | |
*** Iker has quit IRC | 11:25 | |
*** qinusty has quit IRC | 11:25 | |
*** adds68 has quit IRC | 11:25 | |
*** jward has quit IRC | 11:25 | |
*** WSalmon has quit IRC | 11:25 | |
*** lantw44 has quit IRC | 11:25 | |
*** mohan43u has quit IRC | 11:25 | |
*** jswagner has quit IRC | 11:25 | |
*** gitlab-br-bot has quit IRC | 11:25 | |
*** Trevinho has quit IRC | 11:25 | |
*** traveltissues has joined #buildstream | 11:25 | |
*** jonathanmaw has joined #buildstream | 11:25 | |
*** tpollard has joined #buildstream | 11:25 | |
*** samkirkham has joined #buildstream | 11:25 | |
*** Kinnison has joined #buildstream | 11:25 | |
*** SotK has joined #buildstream | 11:25 | |
*** Iker has joined #buildstream | 11:25 | |
*** qinusty has joined #buildstream | 11:25 | |
*** adds68 has joined #buildstream | 11:25 | |
*** jward has joined #buildstream | 11:25 | |
*** WSalmon has joined #buildstream | 11:25 | |
*** lantw44 has joined #buildstream | 11:25 | |
*** gitlab-br-bot has joined #buildstream | 11:25 | |
*** Trevinho has joined #buildstream | 11:25 | |
*** narispo has joined #buildstream | 11:25 | |
*** laurence has joined #buildstream | 11:25 | |
*** slaf has joined #buildstream | 11:25 | |
*** tiagogomes has joined #buildstream | 11:25 | |
*** benbrown has joined #buildstream | 11:25 | |
*** kapip has joined #buildstream | 11:25 | |
*** aevri has joined #buildstream | 11:25 | |
*** krichter[m] has joined #buildstream | 11:25 | |
*** albfan[m] has joined #buildstream | 11:25 | |
*** tlater[m] has joined #buildstream | 11:25 | |
*** cgmcintyre[m] has joined #buildstream | 11:25 | |
*** nielsdg has joined #buildstream | 11:25 | |
*** doras has joined #buildstream | 11:25 | |
*** mattiasb has joined #buildstream | 11:25 | |
*** awacheux[m] has joined #buildstream | 11:25 | |
*** jjardon[m] has joined #buildstream | 11:25 | |
*** m_22[m] has joined #buildstream | 11:25 | |
*** abderrahim[m] has joined #buildstream | 11:25 | |
*** pro[m] has joined #buildstream | 11:25 | |
*** ssssam[m] has joined #buildstream | 11:25 | |
*** tchaik[m] has joined #buildstream | 11:25 | |
*** jjardon has joined #buildstream | 11:25 | |
*** benschubert has joined #buildstream | 11:25 | |
*** lchlan has joined #buildstream | 11:25 | |
*** persia has joined #buildstream | 11:25 | |
*** hergertme has joined #buildstream | 11:25 | |
*** ironfoot has joined #buildstream | 11:25 | |
*** raoul_ has joined #buildstream | 11:25 | |
*** irc.acc.umu.se sets mode: +oo jjardon ironfoot | 11:25 | |
*** paulsherwood has joined #buildstream | 11:25 | |
*** flatmush has joined #buildstream | 11:25 | |
*** juergbi has joined #buildstream | 11:25 | |
*** swick has joined #buildstream | 11:25 | |
*** bethw has joined #buildstream | 11:25 | |
*** tristan has joined #buildstream | 11:25 | |
*** phildawson_ has joined #buildstream | 11:25 | |
*** bochecha has joined #buildstream | 11:25 | |
*** mohan43u has joined #buildstream | 11:26 | |
*** valentind has joined #buildstream | 11:26 | |
*** jswagner has joined #buildstream | 11:27 | |
*** ChanServ sets mode: +o tristan | 11:27 | |
tristan | tag pushed | 11:52 |
*** segfault3[m] has joined #buildstream | 11:53 | |
*** reuben640[m] has joined #buildstream | 11:59 | |
*** theawless[m] has joined #buildstream | 12:02 | |
*** kailueke[m] has joined #buildstream | 12:08 | |
*** tristan has quit IRC | 12:09 | |
*** connorshea[m] has joined #buildstream | 12:39 | |
*** phoenix has joined #buildstream | 12:54 | |
*** jonathanmaw has quit IRC | 13:04 | |
*** phoenix has quit IRC | 13:13 | |
*** waltervargas[m] has joined #buildstream | 13:16 | |
*** mrmcq2u[m] has joined #buildstream | 13:24 | |
*** Demos[m] has joined #buildstream | 13:29 | |
*** jonathanmaw has joined #buildstream | 13:43 | |
*** skullone[m] has joined #buildstream | 13:57 | |
*** Trevinho[m] has joined #buildstream | 14:02 | |
*** tpollard has quit IRC | 14:30 | |
*** tpollard has joined #buildstream | 14:30 | |
*** traveltissues has quit IRC | 14:32 | |
*** traveltissues has joined #buildstream | 14:32 | |
tlater[m] | Hrm, I wonder if it would make sense to load plugins on-demand in the loader (i.e., whenever we encounter an element 'kind'). We could error out much more quickly in some cases if we did. | 14:43 |
*** asingh_[m] has joined #buildstream | 14:43 | |
Kinnison | Rather than waiting until we instantiate the elements? | 14:44 |
*** bochecha has quit IRC | 14:47 | |
*** gimpnet-irc[m] has joined #buildstream | 14:49 | |
*** dineshdb[m] has joined #buildstream | 14:49 | |
benschubert | tlater[m]: but that would make the other error cases much slower? :) | 14:51 |
tlater[m] | Kinnison: Yeah | 14:51 |
benschubert | Dont' get me wrong, I'd love to have a single loading step, parallelisable if possible | 14:51 |
benschubert | but ... that's a lot of effort | 14:52 |
Kinnison | We could fire off test-loads of plugins in spawned subprocesses | 14:52 |
tlater[m] | Which error cases would be slower? | 14:52 |
Kinnison | so they happen in parallel with the rest of the load | 14:52 |
benschubert | tlater[m]: cicles, unresolvable dependencies | 14:52 |
tlater[m] | That would be interesting | 14:53 |
benschubert | misformed yaml files | 14:53 |
tlater[m] | Ehh, if you use like 100 plugins I expect that not to slow down things too much | 14:53 |
tlater[m] | And I don't think there are 100 plugins | 14:53 |
tlater[m] | I'm thinking that because of this: https://gitlab.com/BuildStream/buildstream/commit/5edac8407254953eb778975a82f8bcbeed4608b7 | 14:54 |
tlater[m] | It just seems like such a waste to load dependencies for an element that will never actually have dependencies, just to error out a minute later. | 14:55 |
tlater[m] | When we already have all the information we need to decide whether to abort or not. | 14:56 |
*** tpollard has quit IRC | 15:10 | |
*** cs-shadow has joined #buildstream | 15:14 | |
*** verdre[m] has joined #buildstream | 15:17 | |
*** phoenix has joined #buildstream | 15:19 | |
*** rafaelff[m] has joined #buildstream | 15:20 | |
*** narispo has quit IRC | 15:31 | |
*** narispo has joined #buildstream | 15:31 | |
*** tristan has joined #buildstream | 15:32 | |
benschubert | tlater[m]: if it doesn't slow down the successful case, I'm fine with that | 15:38 |
benschubert | but I'd much rather optimize for success than failure | 15:38 |
tlater[m] | benschubert: That's the nice thing, I don't think it would, since we do that work later anyway. | 15:38 |
benschubert | fair enough, if it's still as fast (or faster) I'm happy with it | 15:39 |
*** dbuch has joined #buildstream | 15:41 | |
*** bochecha has joined #buildstream | 15:42 | |
*** tpollard has joined #buildstream | 16:33 | |
*** tiagogomes has quit IRC | 16:47 | |
*** phoenix has quit IRC | 17:25 | |
gitlab-br-bot | tlater opened MR !1608 (tlater/progress-tests->master: Improve assertions around element loading progress reporting) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1608 | 17:33 |
*** jonathanmaw has quit IRC | 17:36 | |
*** traveltissues has quit IRC | 17:44 | |
*** bochecha has quit IRC | 17:52 | |
*** jward has quit IRC | 18:19 | |
*** jward has joined #buildstream | 18:19 | |
*** tpollard has quit IRC | 18:23 | |
*** narispo has quit IRC | 22:16 | |
*** narispo has joined #buildstream | 22:17 | |
*** narispo has quit IRC | 22:37 | |
*** narispo has joined #buildstream | 22:37 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!