| *** tristan_ has quit IRC | 00:14 | |
| *** tristan_ has joined #buildstream | 00:30 | |
| *** tristan has joined #buildstream | 00:51 | |
| *** narispo has quit IRC | 01:41 | |
| *** narispo has joined #buildstream | 01:42 | |
| *** narispo has quit IRC | 01:45 | |
| *** narispo has joined #buildstream | 01:45 | |
| *** tristan has quit IRC | 02:14 | |
| *** tristan has joined #buildstream | 02:26 | |
| *** tristan has quit IRC | 02:29 | |
| *** tristan has joined #buildstream | 02:32 | |
| *** tristan has quit IRC | 02:33 | |
| *** tristan has joined #buildstream | 02:33 | |
| *** tristan has quit IRC | 02:36 | |
| *** tristan has joined #buildstream | 02:47 | |
| *** tristan has quit IRC | 02:48 | |
| *** tristan has joined #buildstream | 02:48 | |
| *** tristan has quit IRC | 02:51 | |
| *** tristan has joined #buildstream | 02:52 | |
| *** tristan has quit IRC | 02:54 | |
| *** tristan has joined #buildstream | 02:57 | |
| *** tristan has quit IRC | 02:58 | |
| *** tristan has joined #buildstream | 03:01 | |
| *** tristan has quit IRC | 03:02 | |
| *** tristan has joined #buildstream | 05:06 | |
| *** tristan has quit IRC | 05:14 | |
| *** tristan has joined #buildstream | 05:24 | |
| *** tristan has quit IRC | 05:25 | |
| *** tristan has joined #buildstream | 05:26 | |
| *** tristan has quit IRC | 05:28 | |
| *** tristan has joined #buildstream | 05:31 | |
| *** tristan has quit IRC | 05:32 | |
| *** tristan has joined #buildstream | 05:33 | |
| *** tristan has quit IRC | 05:34 | |
| *** tristan has joined #buildstream | 05:54 | |
| *** tristan has joined #buildstream | 05:59 | |
| *** tristan has quit IRC | 06:00 | |
| *** tristan has joined #buildstream | 06:01 | |
| *** tristan has quit IRC | 06:02 | |
| *** tristan has joined #buildstream | 06:03 | |
| *** tristan has quit IRC | 06:04 | |
| *** tristan has joined #buildstream | 06:05 | |
| *** tristan has quit IRC | 06:06 | |
| *** tristan has joined #buildstream | 06:07 | |
| *** tristan has quit IRC | 06:08 | |
| *** tristan has joined #buildstream | 06:08 | |
| *** tristan has joined #buildstream | 06:10 | |
| *** tristan has joined #buildstream | 06:12 | |
| *** tristan has quit IRC | 06:15 | |
| *** tristan has joined #buildstream | 06:44 | |
| *** narispo has quit IRC | 06:48 | |
| *** narispo has joined #buildstream | 06:48 | |
| *** toscalix has joined #buildstream | 07:33 | |
| *** narispo has quit IRC | 07:52 | |
| *** narispo has joined #buildstream | 07:52 | |
| *** tristan has quit IRC | 08:14 | |
| *** tristan has joined #buildstream | 08:16 | |
| *** tristan has quit IRC | 08:18 | |
| *** tristan has joined #buildstream | 08:18 | |
| *** tristan has quit IRC | 08:20 | |
| *** tristan has joined #buildstream | 08:23 | |
| *** tme5 has joined #buildstream | 08:27 | |
| *** tristan has joined #buildstream | 08:30 | |
| *** tristan has quit IRC | 08:33 | |
| *** tristan has joined #buildstream | 08:34 | |
| *** tristan has quit IRC | 08:36 | |
| tme5 | benschubert, hi, your branch fix-plugins-yaml doesn't seem to have advanced to include all your fixup commits -- do you know whether CI passes with those additions? | 08:44 |
|---|---|---|
| tme5 | on bst-plugins-experimental | 08:44 |
| benschubert | I didn't get to have something working no | 08:44 |
| tme5 | shall i open an issue for it? | 08:48 |
| tme5 | does it block further development on the plugins or is there a way i can do that? that's why i'm curious | 08:48 |
| benschubert | we already have https://gitlab.com/BuildStream/buildstream/issues/1090 for tracking this | 08:49 |
| benschubert | There is lots of work to cleanup this repository that would need to be done to put it in a nice state | 08:49 |
| benschubert | I sadly don't have a really good answer for new plugins | 08:50 |
| benschubert | I might have a bit of time today to look at it, but no guarantees | 08:50 |
| tme5 | ahh ok, no worries, i will look at something else :) | 08:52 |
| tpollard | Does anybody fancy approving https://gitlab.com/BuildStream/buildstream/merge_requests/1534 to fix bst init | 08:54 |
| Kinnison | Is Gitlab working today? | 08:55 |
| Kinnison | Because that LGTM, IMO you can marge it 👍 | 08:56 |
| Kinnison | tpollard: ^^^ | 08:59 |
| tpollard | cheers | 08:59 |
| *** jonathanmaw has joined #buildstream | 09:01 | |
| gitlab-br-bot | tmewett closed issue #1048 (`bst artifact checkout --tar` should allow compression) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1048 | 09:29 |
| *** lachlan has joined #buildstream | 09:29 | |
| *** rdale has joined #buildstream | 09:39 | |
| gitlab-br-bot | marge-bot123 closed issue #1100 (Error when using interactive bst init) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1100 | 09:49 |
| gitlab-br-bot | marge-bot123 merged MR !1534 (tpollard/initfix->master: _frontend/app.py: Fixup node._assert_symbol_name() positional args) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1534 | 09:49 |
| benschubert | jennis: you are a maintainer of bst-plugins-experimental, correct? | 09:50 |
| jennis | benschubert, not officially, but my name is on the maintainers file because the repo started as a copy from bst-external :D | 09:58 |
| jennis | What'd you need? | 09:58 |
| benschubert | just wanted to check if moving the repo to an architecture more like the bst-plugins-container would be accepted (tox, tip of master instead of version frozen in time, etc) ? | 09:59 |
| jennis | i.e. always run CI against latest master? | 10:02 |
| jennis | I've proposed this twice, separately to tristan_ and jjardon, and both times was informed that this is not a good idea | 10:03 |
| jennis | I was unaware that bst-plugins-container is tested again the tip of master | 10:04 |
| benschubert | it is: https://gitlab.com/BuildStream/bst-plugins-container/blob/master/tox.ini | 10:05 |
| jennis | oh, cool. I'm personally in favour of doing this | 10:06 |
| jennis | But I would like tristan_ and/or jjardon to be part of this discussion too, seeing as they have vetoed this decision before | 10:06 |
| jennis | I also think that in general, we need to make an effort to get the repo in a "working" state | 10:08 |
| benschubert | yep | 10:08 |
| benschubert | especially now that many plugins are moving to it | 10:09 |
| coldtom | fwiw i think testing it against the tip of master is also a good idea | 10:09 |
| benschubert | yeah, I'd rather have to force the merge, than test an outdated version :) | 10:10 |
| *** narispo has quit IRC | 10:10 | |
| *** narispo has joined #buildstream | 10:10 | |
| benschubert | Also, we have the templated sources test, does someone how they are meant to run on other repos? I can't find where this is defined | 10:12 |
| jennis | phildawson does | 10:19 |
| benschubert | phildawson: do you have an example? :) | 10:21 |
| gitlab-br-bot | marge-bot123 merged MR !1533 (jennis/fix_artifact_log->master: Fix artifact log) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1533 | 10:33 |
| tlater[m] | juergbi: What's the use case for a CASCache with no casd? Is that for remote caches? | 10:45 |
| * tlater[m] wonders if there's a better way to do this since all these caches are basically just basiccache with slightly different protocols | 10:49 | |
| phildawson | benschubert, !1261 (the MR which merged them) has some instructions. For an example, see https://gitlab.com/BuildStream/bst-plugins-experimental/commit/c9fb1ebb1331a4814d87f3821e6b5506f4be3cd2 Unfortunately I didn't get round to adding an example to the docs before I got reassigned. | 10:59 |
| gitlab-br-bot | MR !1261: Expose templated source tests https://gitlab.com/BuildStream/buildstream/merge_requests/1261 | 10:59 |
| benschubert | phildawson: ok thanks a lot! | 11:03 |
| phildawson | :) | 11:07 |
| *** lachlan has quit IRC | 11:23 | |
| juergbi | tlater[m]: casd=False is only for tests | 11:25 |
| tlater[m] | Ah, gotcha | 11:25 |
| juergbi | for read-only access casd is not required | 11:25 |
| *** lachlan has joined #buildstream | 11:31 | |
| *** bochecha has joined #buildstream | 11:46 | |
| *** lachlan has quit IRC | 11:57 | |
| *** tpollard has quit IRC | 11:59 | |
| gitlab-br-bot | jennis opened issue #1101 (Sometimes failed builds are not cached as failed) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1101 | 12:03 |
| gitlab-br-bot | jennis opened MR !1536 (jennis/fix_failed_workspaces->master: Don't reset a failed (but cached) workspaced Element) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1536 | 12:19 |
| jennis | juergbi ^ some update_state tinkering there ;) | 12:20 |
| jennis | benschubert, !1536 should resolve your open issue :) | 12:20 |
| jjardon | jennis: benschubert I think is better to use a fixed buildstream version so CI doesn't break between runs, without us knowing the cause. I think is nicer to expect errors and fix them when we intentionally upgrade the buildstream version we are using. Saying that if It's working fine for bst-plugins-container gor for it | 12:25 |
| jjardon | we could have both things really; It's a matter of adding additional jobs | 12:26 |
| juergbi | will take a look | 12:33 |
| benschubert | jjardon: what about having a fixed version that breaks the build, and the master version that is allowed failures? And then we can have the same on the BuildStream side of things? | 12:41 |
| jjardon | benschubert: looks like a good idea | 12:50 |
| benschubert | Ok, I'm starting a cleanup there then, thanks | 12:53 |
| *** amin has joined #buildstream | 13:12 | |
| *** amin has quit IRC | 13:16 | |
| *** amin has joined #buildstream | 13:16 | |
| tme5 | would love some thoughts on this idea https://gitlab.com/BuildStream/buildstream/merge_requests/1423#note_202049351 | 13:17 |
| tme5 | i'm aware it's quite a breaking change for something that's not a big issue | 13:18 |
| *** lachlan has joined #buildstream | 13:30 | |
| *** jonathanmaw has quit IRC | 13:32 | |
| *** lachlan has quit IRC | 13:37 | |
| benschubert | phildawson: do you have a minute? | 13:42 |
| benschubert | phildawson: I don't understand how the testing of source plugins is supposed to work. In the commit you showed me, all the tests are skipped. Trying to run them fails because 'ostree' is not registered as a plugin. I don't see the place where this registration would happen. Am I missing some magic there? | 13:43 |
| benschubert | Also, what do you mean by "repo_kind" ? | 13:47 |
| phildawson | benschubert, give me a couple of minutes to remind myself about how it all works. | 13:49 |
| jennis | jjardon, nice idea. I'm all for two jobs, providing we fix the current situation first | 13:50 |
| jennis | juergbi: thanks :) | 13:50 |
| benschubert | jennis: I'm trying to fix it as we speak | 13:51 |
| jennis | benschubert, oh nice, did you see that I had a branch? Which cherry-picked your changes and made some others? | 13:51 |
| *** lachlan has joined #buildstream | 13:52 | |
| benschubert | no, I didn't see that. I just restarted the process slightly differently | 13:52 |
| benschubert | https://gitlab.com/BuildStream/bst-plugins-experimental/merge_requests/22 is still in WIP | 13:52 |
| gitlab-br-bot | aevri opened (was WIP) MR !1511 (aevri/spawn->master: Support the 'spawn' method of starting processes) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1511 | 13:53 |
| gitlab-br-bot | beckyella16 opened (was WIP) MR !1529 (becky/artifact_list_contents->master: Addition of bst artifact list-contents) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1529 | 13:54 |
| jjardon | benschubert: probably you already noticed but master of that repo is now green. Not that it helps a lot for that specific problem but at least there is a reference point where things work | 13:54 |
| benschubert | jjardon: it's green because it's skipping most tests... so I'd rather have it red at that point | 13:55 |
| benschubert | uh it's not? ok, my bad sorry | 13:55 |
| coldtom | the unix tests on bst-plugins-experimental are a bit redundant, given they basically all get skipped | 13:56 |
| coldtom | but the linux platform tests run | 13:56 |
| phildawson | the unix tests are getting skipped on unix because most of the tests are related to ostree, which won't run on a none linux platform | 13:57 |
| benschubert | Ah, no they don't (at least not as you expect) | 13:57 |
| benschubert | https://gitlab.com/BuildStream/buildstream/tree/377f20fe5f2a20d8d432e9a5a09e666cdba5afb3/buildstream/plugins/sources is the version of BuildStream we have in bst-plugins-external master | 13:58 |
| benschubert | that means the ostree tests are actually the tests on the buildstream repo, not the ones from the bst-plugins-experimental repo | 13:58 |
| benschubert | so we are not running the correct test | 13:58 |
| benschubert | phildawson: that probably means we never actually tested something external with your changes | 13:59 |
| benschubert | and explains why now that ostree is removed, the registration system doesn't work | 13:59 |
| phildawson | benschubert, that would explain it. And it hasn't been spotted until now because the docker image for bst-plugins experimental hasn't been updated since then. | 14:01 |
| benschubert | yep | 14:01 |
| phildawson | We really should have caught that. | 14:02 |
| benschubert | we need to start having proper code reviews on this bst-plugins-experimentla, now that we are moving proper stuff in | 14:02 |
| phildawson | benschubert, agreed. Though I think this is a bug with the templated test code in buildstream, so I'm not sure how likely more thorough review of bst-experimental would have been to catch this. A bit more love in terms of regularly updating the CI image would have definitely uncovered it earlier though. | 14:06 |
| benschubert | yep | 14:06 |
| benschubert | I'm working on a fix | 14:06 |
| phildawson | Thanks benschubert | 14:06 |
| *** lachlan has quit IRC | 14:23 | |
| gitlab-br-bot | coldtom opened (was WIP) MR !1535 (coldtom/move-make->master: Move make plugin to bst-plugins-experimental) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1535 | 14:23 |
| *** lachlan has joined #buildstream | 14:27 | |
| jennis | i also think we should enforce that each plugin has at least one test | 14:34 |
| jennis | that tests its basic use | 14:34 |
| benschubert | how is name of plugins discovered? Is it the name of the python module? | 14:39 |
| jennis | yes | 14:47 |
| jennis | if you're using pip source.. but the plugins have to be added as entry points | 14:48 |
| jennis | well, benschubert, that's the name of the plugin package | 14:49 |
| benschubert | ah right I see, thanks! | 14:49 |
| jennis | benschubert, thanks for the MR on bst-experimental! I'll review shortly | 14:53 |
| *** lachlan has quit IRC | 14:55 | |
| benschubert | jennis: it's a WIP, I still have lots to do | 14:55 |
| *** lachlan has joined #buildstream | 14:55 | |
| jennis | ah, yes, let me know when :) | 14:55 |
| jennis | juergbi, are there some docs on how I can test with buildbox locally? | 14:56 |
| juergbi | jennis: probably no docs yet but you can use: BST_FORCE_SANDBOX=buildbox tox | 14:57 |
| juergbi | if you've installed buildbox-fuse | 14:57 |
| jennis | ah, perfect, thanks! | 14:58 |
| *** lachlan has quit IRC | 15:14 | |
| *** toscalix has quit IRC | 15:16 | |
| coldtom | is it possible to expect a certain node member to be either a list or a string in bst1.2.x? e.g. i have a parameter i want to take either a string or a list of strings | 15:27 |
| *** lachlan has joined #buildstream | 15:33 | |
| jennis | coldtom, have you looked at the plugin methods? | 15:35 |
| coldtom | jennis: it looks to me like all require a single type? | 15:36 |
| jennis | If not, I think I have recalled seeing self.node_get(node, list, 'foo'), then caught the error if it's not a list and then try and get the string | 15:36 |
| jennis | It's pretty ugly though | 15:36 |
| *** lachlan has quit IRC | 15:37 | |
| benschubert | self.node_get(node, None, 'foo') should work if I remember correctly | 15:38 |
| jennis | oh nice trick. A shame it's not documented :( https://docs.buildstream.build/buildstream.plugin.html#buildstream.plugin.Plugin.node_get_member | 15:50 |
| coldtom | ty | 15:50 |
| benschubert | The new API is more explicit for this | 15:50 |
| benschubert | I'm confused as to why we call plugin kinds 'repo_kind', does someone has an explanation? | 15:55 |
| *** lachlan has joined #buildstream | 15:59 | |
| *** tme5 has quit IRC | 16:02 | |
| *** lachlan has quit IRC | 16:03 | |
| *** lachlan has joined #buildstream | 16:08 | |
| benschubert | phildawson: is it expected that we use ALL_REPO_KIND in tests that are outside of _sourcetests? | 16:15 |
| *** lachlan has quit IRC | 16:16 | |
| *** phildawson_ has joined #buildstream | 16:32 | |
| *** phildawson has quit IRC | 16:33 | |
| *** lachlan has joined #buildstream | 16:49 | |
| *** rdale has quit IRC | 16:51 | |
| *** lachlan has quit IRC | 16:54 | |
| *** phildawson_ has quit IRC | 17:00 | |
| *** lachlan has joined #buildstream | 17:02 | |
| gitlab-br-bot | BenjaminSchubert opened MR !1537 (bschubert/register-sources-on-test->master: testing/sources: Automatically register plugin sources) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1537 | 17:04 |
| *** lachlan has quit IRC | 17:06 | |
| *** bochecha has quit IRC | 17:17 | |
| *** lachlan has joined #buildstream | 17:41 | |
| *** lachlan has quit IRC | 17:46 | |
| *** lachlan has joined #buildstream | 17:55 | |
| *** amin has quit IRC | 17:59 | |
| *** lachlan has quit IRC | 18:21 | |
| *** lachlan has joined #buildstream | 18:28 | |
| *** tristan has joined #buildstream | 18:30 | |
| *** lachlan has quit IRC | 19:03 | |
| *** lachlan has joined #buildstream | 19:12 | |
| *** tristan has quit IRC | 19:22 | |
| *** lachlan has quit IRC | 19:25 | |
| *** lachlan has joined #buildstream | 19:27 | |
| *** tristan has joined #buildstream | 19:29 | |
| *** tristan has quit IRC | 19:30 | |
| *** tristan has joined #buildstream | 19:31 | |
| *** tristan has quit IRC | 19:32 | |
| *** tristan has joined #buildstream | 19:33 | |
| *** tristan has quit IRC | 19:34 | |
| *** tristan has joined #buildstream | 19:35 | |
| *** lachlan has quit IRC | 19:35 | |
| *** tristan has quit IRC | 19:36 | |
| *** tristan has joined #buildstream | 19:37 | |
| *** tristan has quit IRC | 19:38 | |
| *** tristan has joined #buildstream | 19:39 | |
| *** lachlan has joined #buildstream | 19:42 | |
| *** tristan has quit IRC | 19:42 | |
| *** lachlan has quit IRC | 19:55 | |
| *** tristan has joined #buildstream | 22:04 | |
| *** tristan has quit IRC | 23:22 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!