| *** rabbitear has joined #buildstream | 00:30 | |
| *** tristan has joined #buildstream | 00:31 | |
| *** tristan_ has joined #buildstream | 00:43 | |
| *** tristan has quit IRC | 00:51 | |
| *** tristan has joined #buildstream | 00:52 | |
| *** tristan has quit IRC | 01:50 | |
| *** tristan has joined #buildstream | 01:52 | |
| *** tristan has quit IRC | 01:53 | |
| *** tristan has joined #buildstream | 01:53 | |
| *** tristan has quit IRC | 01:55 | |
| *** tristan has joined #buildstream | 01:55 | |
| *** tristan has quit IRC | 01:56 | |
| *** tristan has joined #buildstream | 01:57 | |
| *** tristan has quit IRC | 01:59 | |
| *** rabbitear has quit IRC | 02:04 | |
| *** tristan has joined #buildstream | 04:01 | |
| *** tristan has quit IRC | 04:52 | |
| gitlab-br-bot | juergbi opened MR !1527 (juerg/artifact-blobs->master: Artifact blob handling) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1527 | 05:26 |
|---|---|---|
| *** tristan has joined #buildstream | 05:49 | |
| *** tristan has quit IRC | 05:54 | |
| *** tristan has joined #buildstream | 06:03 | |
| *** tristan has quit IRC | 06:52 | |
| *** tristan has joined #buildstream | 06:57 | |
| *** tristan has joined #buildstream | 07:06 | |
| juergbi | Kinnison: I've looked into generating a wheel for a static buildbox-casd binary, however, it doesn't seem ideal. afaict, I could only include the binary as data (file will not be marked as executable and not be put in 'bin') or script (pip attempts to insert #!/bin/python line, oops) | 07:11 |
| juergbi | the only alternative for automatic installation I can think of is to create a fake Python source tarball. i.e., a tarball that contains the static binary + a setup.py script that installs the static binary | 07:11 |
| Kinnison | Ugh, that is not nice, is it? | 07:12 |
| * Kinnison wonders what other python libraries do which need to install tools | 07:12 | |
| juergbi | the build system interface expected by `pip install` is documented at https://pip.pypa.io/en/stable/reference/pip_install/#build-system-interface | 07:12 |
| juergbi | so this might actually be reliable but it doesn't seem ideal | 07:12 |
| juergbi | I checked grpcio-tools, which includes the protobuf compiler. they put the whole code into a .so Python C extension module. I don't really want to do this | 07:13 |
| juergbi | not sure about other packages | 07:13 |
| juergbi | do you anticipate any actual issues with the tarball approach or does it simply feel odd? | 07:13 |
| juergbi | I'm not aware of any other pip-installable formats that would be suitable but maybe I'm missing something | 07:14 |
| juergbi | i.e., the only other alternative I see would be manual download/installation of the binary | 07:15 |
| Kinnison | I guess short-term the tarball approach is acceptable. Maybe benschubert might know of some other approach? | 07:16 |
| juergbi | (well, could also use a git repo instead of a tarball but that doesn't really improve the situation) | 07:17 |
| *** toscalix has joined #buildstream | 07:48 | |
| *** tristan has quit IRC | 07:50 | |
| *** tristan has joined #buildstream | 07:52 | |
| *** tristan has quit IRC | 07:53 | |
| *** tristan has joined #buildstream | 07:56 | |
| *** tristan has joined #buildstream | 07:58 | |
| *** tristan has quit IRC | 07:59 | |
| *** tristan has joined #buildstream | 07:59 | |
| *** tristan has joined #buildstream | 08:03 | |
| *** tristan has quit IRC | 08:05 | |
| *** tristan has joined #buildstream | 08:05 | |
| qinusty | I think nightly-extra is broken :( https://paste.gnome.org/pubilrn8v/v3mfie/raw | 08:10 |
| laurence | valentind is on holiday, however we ensured last week that tpollard and jennis also had credentials to have a poke around the infra | 08:14 |
| jjardon | qinusty: probably because plugins from bst-plugings-experimental are broken at the moment https://gitlab.com/BuildStream/buildstream/issues/1090 | 08:16 |
| qinusty | ah | 08:17 |
| benschubert | Kinnison, juergbi I am not aware of any good solution. What other programs I know usually do it ask for the program to be installed on the host directly. I also think that this is in line with the rest of BuildStream (we do require bwrap, fuse), even though it might not be super simple due to buildbox not being commonly available on distributions yet. On our side, we would like to be able to build buildbox ourselves | 08:17 |
| jjardon | There is a MR linked on that issue which tries to fix the plugins | 08:17 |
| juergbi | benschubert: adding buildbox-casd build instructions to the documentation is on my TODO. maybe we should just do that + as a convenience upload a static binary and write instructions how to download/install it for those who'd like to skip the build | 08:19 |
| juergbi | the second part could potentially follow post merge, although lack of that binary is an issue for WSL CI | 08:20 |
| juergbi | we could always pursue the pip-installable tarball route later | 08:21 |
| benschubert | juergbi: that seems good to me (as long as the pip-installable is not required :D) | 08:22 |
| benschubert | juergbi: did I read the benchmarks correctly, the building is slower with casd? | 08:36 |
| juergbi | yes | 08:36 |
| benschubert | Do you have an idea where this is coming from? Is it expected? | 08:37 |
| juergbi | this might be due to IPC overhead without file batching | 08:37 |
| juergbi | batching / capturing whole directory with single call is already a planned optimization | 08:37 |
| juergbi | however, I have not confirmed that this is the reason for the overhead | 08:37 |
| benschubert | ok, thanks! | 08:38 |
| jennis | I'm trying to get the logs from the proto. Currently, we have the Artifact.get_files() and Artifact.get_buildtree() methods which "get" a field digest, and then create a CASBasedDirectory with this | 08:40 |
| juergbi | expiry should be much faster, though :) will be interesting to get real user feedback in that aspect | 08:40 |
| jennis | This works because files and buildtree's are both build.bazel.remote.execution.v2.Digest | 08:40 |
| jennis | However, now I'm trying to do something similar with the logs, which are defined differently in the proto | 08:40 |
| jennis | How should I go about getting these? | 08:41 |
| Kinnison | I'd suggest returning a dict of name -> casbaseddirectory | 08:43 |
| juergbi | the digests are files, though, not directories | 08:43 |
| Kinnison | oops, yes, erm | 08:43 |
| juergbi | jennis: maybe it would make sense to create an empty CASBasedDirectory and add the log files | 08:43 |
| *** alexandrufazakas has left #buildstream | 08:43 | |
| juergbi | i.e., create a virtual directory | 08:43 |
| *** alexandrufazakas has joined #buildstream | 08:43 | |
| jennis | ok sure, but it's still the getting of each log file I'm not sure about | 08:44 |
| juergbi | the `logs` field should simply be a python list | 08:44 |
| jennis | oh, so when we get the proto (artifact = self._get_proto() ) artifact.logs is just a list? | 08:45 |
| juergbi | each entry being a LogFile proto where you can get 'name' and [file] 'digest' | 08:45 |
| juergbi | yes | 08:45 |
| jennis | <class 'google.protobuf.pyext._message.RepeatedCompositeContainer'> | 08:45 |
| jennis | is type(artifact.logs) | 08:46 |
| juergbi | well, not quite a standard list but you should be able to loop over it | 08:46 |
| jennis | ok thanks, and with each logfile, I can create a use the digest and create a CASBasedDirectory with it | 08:47 |
| juergbi | we might actually not have an API to add files by digest to a CASBasedDirectory | 08:48 |
| juergbi | but it should be fairly easy to add this, at least as internal API | 08:48 |
| *** phildawson has joined #buildstream | 08:48 | |
| jennis | return CasBasedDirectory(self._cas, digest=buildtree_digest) | 08:48 |
| juergbi | that's for directories | 08:48 |
| juergbi | for logs we need to create an empty directory and then add the file digests | 08:48 |
| jennis | ah, gotcha | 08:49 |
| jennis | 09:43 <juergbi> the digests are files, though, not directories | 08:49 |
| jennis | I'm playing catch up | 08:49 |
| juergbi | jennis: maybe it would have been better to just create a Directory for logs as well | 08:49 |
| juergbi | not sure why we didn't | 08:49 |
| juergbi | (in the proto, I mean) | 08:49 |
| jennis | I guess that'd be more consistent with "files" | 08:50 |
| *** tristan has quit IRC | 08:51 | |
| jennis | juergbi, which would you prefer? | 08:52 |
| Kinnison | juergbi: We didn't because it was yet another object which we didn't want to have to create and push | 08:52 |
| Kinnison | I'd rather that Artifact.get_logs() returned a dict of name -> PutativeCasBlob | 08:53 |
| Kinnison | Where PutativeCasBlob offers a .read() | 08:53 |
| Kinnison | or somesuch | 08:53 |
| juergbi | we could return name => objpath(digest), assuming we ensure the log files are local first | 08:54 |
| Kinnison | Also acceptable | 08:54 |
| juergbi | objpath being the real file path to the CAS blob | 08:54 |
| * Kinnison nods | 08:54 | |
| juergbi | (I'd rather not implicitly open files) | 08:55 |
| Kinnison | PutativeCasBlob in my proposal wouldn't until you tried to read it | 08:55 |
| Kinnison | But I'm fine with `objpath` | 08:56 |
| jennis | cool, lets do that for now then | 08:57 |
| *** tristan has joined #buildstream | 09:03 | |
| *** tristan has quit IRC | 09:05 | |
| *** tristan has joined #buildstream | 09:08 | |
| *** tristan has quit IRC | 09:10 | |
| *** tristan has joined #buildstream | 09:11 | |
| *** jonathanmaw has joined #buildstream | 09:12 | |
| jennis | oh, just getting the object paths made the code much simpler | 09:12 |
| jennis | No need for vdirs | 09:12 |
| *** tristan has quit IRC | 09:13 | |
| *** tristan has joined #buildstream | 09:13 | |
| *** bochecha has joined #buildstream | 09:29 | |
| *** tme5 has joined #buildstream | 09:35 | |
| *** tme5 has quit IRC | 09:41 | |
| *** tme5 has joined #buildstream | 09:42 | |
| *** tme5 has left #buildstream | 09:42 | |
| *** tme5 has joined #buildstream | 09:46 | |
| *** tristan has quit IRC | 09:50 | |
| *** tristan has joined #buildstream | 09:51 | |
| tme5 | what do you think would be the best way to create a job that exits with a code not in _ReturnCode ? | 09:52 |
| tme5 | trying to create a local test for https://gitlab.com/BuildStream/buildstream/issues/1089 | 09:52 |
| * Kinnison grumbles that gitlab thinks his branch doesn't exist | 09:52 | |
| *** tristan has quit IRC | 09:52 | |
| *** tristan has joined #buildstream | 09:53 | |
| *** tristan has quit IRC | 09:55 | |
| *** tristan has joined #buildstream | 09:55 | |
| *** tristan has quit IRC | 09:56 | |
| Kinnison | I particularly like how it can show the commits on the MR | 09:56 |
| Kinnison | and the diffs | 09:56 |
| Kinnison | But believes the branch doesn't exist | 09:57 |
| *** tristan has joined #buildstream | 09:57 | |
| *** tristan has quit IRC | 09:59 | |
| *** tristan has joined #buildstream | 09:59 | |
| benschubert | tme5: you could have the plugin raise SystemExit(137) for example :) | 10:01 |
| benschubert | actually not 137, since this would be a segfault | 10:01 |
| benschubert | but another number | 10:01 |
| benschubert | (otherwise we might think it is a real segfault) | 10:01 |
| *** tristan has quit IRC | 10:02 | |
| *** tristan has joined #buildstream | 10:03 | |
| *** tristan has quit IRC | 10:05 | |
| Kinnison | The git repo itself is insistent it exists | 10:06 |
| * Kinnison is very confused | 10:06 | |
| tpollard | gitlab seems to be having a bad day | 10:07 |
| Kinnison | It seems possible to review the MR, just not merge it :/ | 10:07 |
| tpollard | it couldn't open a 3 line diff for me earlier | 10:07 |
| Kinnison | And no pipeline | 10:07 |
| tpollard | yep I can see that branch locally | 10:10 |
| *** narispo has quit IRC | 10:11 | |
| *** narispo has joined #buildstream | 10:11 | |
| *** tristan has joined #buildstream | 10:24 | |
| tme5 | benschubert, thanks, I ended up doing that, just stuck a raise in ChildElementJob.child_process | 10:24 |
| *** tristan has quit IRC | 10:25 | |
| benschubert | that seems good!, also please ping me once you have the MR up, I'm interested by this one :) | 10:25 |
| *** tristan has joined #buildstream | 10:26 | |
| tme5 | benschubert, i have it in a local branch now, not sure how you want me to submit, do i need permissions to push to main repo? | 10:26 |
| *** tristan has quit IRC | 10:27 | |
| *** tristan has joined #buildstream | 10:33 | |
| benschubert | tme5: I'll add you as a dev, what's your gitlab handle? | 10:35 |
| *** tristan has quit IRC | 10:35 | |
| tme5 | thanks, it's tmewett | 10:35 |
| *** tristan has joined #buildstream | 10:35 | |
| benschubert | done | 10:36 |
| *** tristan has quit IRC | 10:36 | |
| *** tristan has joined #buildstream | 10:37 | |
| tme5 | thanks | 10:41 |
| *** tristan has quit IRC | 10:43 | |
| *** tristan has joined #buildstream | 10:43 | |
| *** tristan has quit IRC | 10:45 | |
| *** tristan has joined #buildstream | 10:45 | |
| *** narispo has quit IRC | 10:49 | |
| *** tristan has quit IRC | 10:51 | |
| *** tristan has joined #buildstream | 10:51 | |
| *** tristan has quit IRC | 10:58 | |
| *** tristan has joined #buildstream | 11:02 | |
| *** tristan has quit IRC | 11:03 | |
| *** tristan has joined #buildstream | 11:04 | |
| *** tristan has quit IRC | 11:05 | |
| *** tristan has joined #buildstream | 11:06 | |
| *** tristan has quit IRC | 11:07 | |
| *** tristan has joined #buildstream | 11:08 | |
| *** tristan has quit IRC | 11:09 | |
| *** tristan has joined #buildstream | 11:09 | |
| laurence | Ahhh | 11:09 |
| laurence | Gitlab incident today, Kinnison | 11:10 |
| laurence | and all | 11:10 |
| laurence | https://status.gitlab.com/ | 11:10 |
| *** tristan has quit IRC | 11:11 | |
| *** tristan has joined #buildstream | 11:11 | |
| *** tristan has quit IRC | 11:13 | |
| *** tristan has joined #buildstream | 11:13 | |
| *** tristan has quit IRC | 11:15 | |
| *** tristan has joined #buildstream | 11:16 | |
| *** tristan has quit IRC | 11:19 | |
| *** tristan has joined #buildstream | 11:20 | |
| *** tristan has quit IRC | 11:21 | |
| *** tristan has joined #buildstream | 11:22 | |
| *** tristan has quit IRC | 11:23 | |
| tlater[m] | Is there a way to iterate over a mappingnode? | 11:23 |
| *** tristan has joined #buildstream | 11:25 | |
| *** tristan has quit IRC | 11:27 | |
| benschubert | tlater[m]: it supports .items(), .keys() and .values() like a dict | 11:27 |
| tlater[m] | Ah, but not `for x in node` then? | 11:27 |
| benschubert | tlater[m]: it wasn't implemented no, but you can do `for x in node.keys()` which is the same behavior | 11:29 |
| tlater[m] | Yep, I overlooked that | 11:29 |
| tlater[m] | Thanks benschubert | 11:29 |
| tme5 | benschubert, as requested: https://gitlab.com/BuildStream/buildstream/merge_requests/1531 | 11:33 |
| tpollard | I think you need to set your committer email for git tme5 | 12:05 |
| Kinnison | benschubert: I've added that cdef as per your request, and pushed, but gitlab's dippytime still hasn't resolved so it might take a while | 12:11 |
| tme5 | tpollard, yeah i realised, done so now, do i need to re-do anything? | 12:21 |
| * Kinnison wonders why gitlab's UI takes so long to realise a push has happened | 12:21 | |
| juergbi | I think normally it's fairly quick but occasionally it's slow | 12:25 |
| Kinnison | They have an incident going on right now, but I'm just wondering what about that part is slow, when you can comment/deal with things on MRs instantly | 12:26 |
| benschubert | Kinnison: cheers, LGTM then! | 12:33 |
| Kinnison | benschubert: Just have to wait for gitlab to catch up :D | 12:33 |
| juergbi | hm, can I assign an MR to marge despite gitlab not seeing the pushed update yet? | 12:41 |
| Kinnison | I doubt that'd be safe | 12:41 |
| juergbi | we need a bot to assign an MR to marge when gitlab sees the changes ;) | 12:42 |
| tme5 | stupid question maybe, but where is the ostree source implemented? | 12:48 |
| benschubert | tme5: in https://gitlab.com/BuildStream/bst-plugins-experimental for master, in https://gitlab.com/BuildStream/bst-plugins-external for v1.X | 12:50 |
| tpollard | tme5: still looks like you need to ammend the author email on that commit, and then force push it | 12:53 |
| *** narispo has joined #buildstream | 13:00 | |
| tme5 | tpollard, do I do that by resetting and re-commiting? | 13:03 |
| tpollard | tme5: "git commit --amend --author="Author Name <email@address.com>" | 13:04 |
| tpollard | should be faster than recommitting :) | 13:05 |
| *** narispo has quit IRC | 13:12 | |
| gitlab-br-bot | coldtom closed MR !1523 (coldtom/cython-req->master: Add cython as a dev requirement) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1523 | 13:16 |
| *** narispo has joined #buildstream | 13:21 | |
| gitlab-br-bot | marge-bot123 merged MR !1520 (coldtom/move-cmake->master: Move cmake plugin to bst-plugins-experimental) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1520 | 13:25 |
| *** tristan has joined #buildstream | 13:29 | |
| *** narispo has quit IRC | 13:36 | |
| *** narispo has joined #buildstream | 13:36 | |
| Kinnison | benschubert: looks like the commits are showing up for my MR now, so as and when the pipeline goes green, I'll marge it if it has your 👍 | 13:43 |
| laurence | is all the opening and clsing of MRs today due to gitlab issues? | 13:47 |
| *** tristan has quit IRC | 13:53 | |
| *** tristan has joined #buildstream | 13:53 | |
| *** tristan has quit IRC | 13:58 | |
| Kinnison | probably | 14:05 |
| *** tristan has joined #buildstream | 14:07 | |
| gitlab-br-bot | danielsilverstone-ct opened MR !1528 (danielsilverstone-ct/load-reject-duplicates->master: Reject elements which have duplicated dependencies) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1528 | 14:11 |
| tme5 | laurence, i screwed up mine due to unfamiliarity with GitLab | 14:12 |
| tme5 | (i wish buttons would give more of a warning when they randomly create branches and MRs...) | 14:13 |
| qinusty | I find it best to do everything via git CLI, I only really use gitlab for MRs | 14:15 |
| qinusty | Local branch creation can be done with `git checkout -b <branch-name> <base branch>` | 14:16 |
| qinusty | pushing with `git push origin <remote branch name>` will create the branch for you, and then give you a URL to click for creating an MR (at least with gitlab) | 14:17 |
| gitlab-br-bot | BenjaminSchubert approved MR !1500 (tpollard/messageobject->master: Message rework) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1500 | 14:23 |
| adds68 | Hi, does anyone know if "BST_ARTIFACTS_ONLY=1" has any effect when installing from pip? | 14:23 |
| adds68 | or does that only work when installing from source | 14:23 |
| gitlab-br-bot | tmewett opened MR !1531 (tmewett/report-weird-return-codes->master: Report error when job process unexpectedly dies) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1531 | 14:32 |
| tme5 | so to clarify, changes to ostree plugin go in bst-plugins-experimental ? | 14:34 |
| benschubert | tme5: correct | 14:36 |
| laurence | tme5, i see. I saw the same thing happen on another project you see. but perhaps that was also a hunman error | 14:37 |
| benschubert | adds68: if you use a source distribution, definitely, if using a wheel, I would guess so, but not 100% sure | 14:37 |
| adds68 | benschubert, hey i think i am going to use instead: https://hub.docker.com/r/buildstream/artifact-cache | 14:38 |
| benschubert | that also works :) | 14:39 |
| adds68 | benschubert, i don't think it existed when fdsdk cache was set up, so less pain to stay in line with upstream now :D | 14:39 |
| benschubert | definitely | 14:40 |
| *** alexandrufazakas has left #buildstream | 14:40 | |
| gitlab-br-bot | jennis opened MR !1533 (jennis/fix_artifact_log->master: Fix artifact log) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1533 | 14:40 |
| adds68 | benschubert, if i'm going to be setting up the cache via systemd unit files, do you think it would be easier to install the bst-here script discussed here: https://buildstream.build/docker_install.html ? | 14:46 |
| adds68 | I'm unsure if that would be easier than just calling bst from docker/podman | 14:47 |
| benschubert | adds68: if you want to start an artifact cache, I would just start the docker image instead of going through bst-here (which I'm not even sure supports this usecase) | 14:47 |
| adds68 | cool thanks benschubert, i was hoping that to be the answer :) | 14:48 |
| gitlab-br-bot | marge-bot123 merged MR !1527 (juerg/artifact-blobs->master: Artifact blob handling) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1527 | 14:48 |
| * Kinnison assigns his MR to marge in the hope it'll come before some other in the queue and actually merge | 14:48 | |
| Kinnison | since I was clearly being silly rebasing it and waiting for a green pipe before merging, that's the sixth rebase in a row | 14:49 |
| benschubert | Kinnison: marge will rebase worst case :) | 14:49 |
| Kinnison | If she doesn't time out :D | 14:49 |
| gitlab-br-bot | marge-bot123 merged MR !1500 (tpollard/messageobject->master: Message rework) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1500 | 14:51 |
| gitlab-br-bot | BenjaminSchubert approved MR !1533 (jennis/fix_artifact_log->master: Fix artifact log) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1533 | 14:51 |
| gitlab-br-bot | BenjaminSchubert approved MR !1528 (danielsilverstone-ct/load-reject-duplicates->master: Reject elements which have duplicated dependencies) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1528 | 14:52 |
| gitlab-br-bot | tpollard approved MR !1533 (jennis/fix_artifact_log->master: Fix artifact log) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1533 | 14:52 |
| *** tristan has quit IRC | 14:59 | |
| gitlab-br-bot | coldtom opened (was WIP) MR !1532 (coldtom/move-meson->master: Move meson element to bst-plugins-experimental) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1532 | 15:01 |
| *** tristan has joined #buildstream | 15:01 | |
| *** tristan has quit IRC | 15:03 | |
| juergbi | I added the commit structure to the !1499 description as overview for reviewers | 15:11 |
| gitlab-br-bot | MR !1499: WIP: Use buildbox-casd for CAS access https://gitlab.com/BuildStream/buildstream/merge_requests/1499 | 15:11 |
| *** tristan has joined #buildstream | 15:13 | |
| tme5 | AttributeError: 'OSTreeSource' object has no attribute 'node_validate'. have I missed something? | 15:15 |
| *** tristan has joined #buildstream | 15:15 | |
| tme5 | this is just trying to run flatpak-autotools examples with ostree plugin cloned locally | 15:16 |
| benschubert | tme5: the ostree plugin on bst-experimetnal is currently out of date with the latest buildstream master | 15:17 |
| *** tristan has quit IRC | 15:17 | |
| *** tristan has joined #buildstream | 15:17 | |
| tme5 | ah, does it run against current release? | 15:18 |
| benschubert | I tried fixing it in https://gitlab.com/BuildStream/bst-plugins-experimental/tree/bschubert/fix-plugins-yaml, but tests were not running correctly. There is some cleanup to be done there | 15:18 |
| benschubert | tme5: bst-plugins-external would run against the current release | 15:18 |
| *** tristan has quit IRC | 15:18 | |
| benschubert | for master, https://buildstream.gitlab.io/buildstream/buildstream.node.html is the documentation about nodes | 15:19 |
| tme5 | benschubert, is that bst-external? it doesn't have ostree | 15:19 |
| *** tristan has joined #buildstream | 15:19 | |
| benschubert | ah, ostree is bundled with the current release of buildstream | 15:20 |
| tme5 | but from where? experimental at the time? | 15:21 |
| *** tristan has quit IRC | 15:21 | |
| *** tristan has joined #buildstream | 15:21 | |
| *** tristan has quit IRC | 15:23 | |
| *** tristan has joined #buildstream | 15:23 | |
| benschubert | tme5: no, in buildstream itself | 15:24 |
| *** tristan has quit IRC | 15:25 | |
| *** tristan has joined #buildstream | 15:25 | |
| tme5 | maybe i'm being stupid but i can't find it | 15:26 |
| *** tristan has quit IRC | 15:26 | |
| *** tristan has joined #buildstream | 15:27 | |
| tpollard | btw if anyone sees any bugs to do with frontend messaging that seem to be new please do raise an issue :) | 15:28 |
| tpollard | as the tests can only cover so much... | 15:28 |
| tpollard | especially interactive stuff | 15:28 |
| *** tristan has quit IRC | 15:29 | |
| benschubert | tme5: https://gitlab.com/BuildStream/buildstream/blob/bst-1/buildstream/plugins/sources/ostree.py | 15:29 |
| tme5 | interactive bst init is completely broken for me :) | 15:29 |
| * Kinnison remains confused as to why that was ever a thing | 15:29 | |
| tme5 | oh it's not on master, i see | 15:29 |
| *** tristan has joined #buildstream | 15:30 | |
| benschubert | tme5: yep, currently released version | 15:30 |
| tme5 | thanks very much | 15:30 |
| *** tristan has quit IRC | 15:31 | |
| *** tristan has joined #buildstream | 15:32 | |
| gitlab-br-bot | tpollard approved MR !1533 (jennis/fix_artifact_log->master: Fix artifact log) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1533 | 15:32 |
| *** tristan has quit IRC | 15:33 | |
| tpollard | tme5: please can you raise an issue for the bst init error you're seeing? I know we recently changed some of that code | 15:41 |
| tme5 | sure | 15:42 |
| gitlab-br-bot | marge-bot123 closed issue #1077 (Build skipped when element has duplicate build dependencies.) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1077 | 15:50 |
| gitlab-br-bot | marge-bot123 merged MR !1528 (danielsilverstone-ct/load-reject-duplicates->master: Reject elements which have duplicated dependencies) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1528 | 15:50 |
| tpollard | tme5: ta! | 15:51 |
| tpollard | it is indeed borked | 15:54 |
| gitlab-br-bot | tmewett opened issue #1100 (Error when using interactive bst init) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1100 | 16:01 |
| *** narispo has quit IRC | 16:04 | |
| *** narispo has joined #buildstream | 16:06 | |
| *** tme5 has quit IRC | 16:27 | |
| gitlab-br-bot | tpollard opened MR !1534 (tpollard/initfix->master: _frontend/app.py: Fixup node._assert_symbol_name() positional args) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1534 | 16:30 |
| *** narispo has quit IRC | 16:47 | |
| *** narispo has joined #buildstream | 16:47 | |
| *** tristan_ has quit IRC | 16:52 | |
| *** tristan_ has joined #buildstream | 16:52 | |
| *** bochecha has quit IRC | 17:05 | |
| *** xjuan has joined #buildstream | 17:17 | |
| *** tristan has joined #buildstream | 17:36 | |
| *** toscalix has quit IRC | 17:44 | |
| *** xjuan has quit IRC | 17:52 | |
| *** tristan has quit IRC | 17:55 | |
| *** jonathanmaw has quit IRC | 18:16 | |
| gitlab-br-bot | marge-bot123 merged MR !1532 (coldtom/move-meson->master: Move meson element to bst-plugins-experimental) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1532 | 23:27 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!