| *** Teljkon has joined #buildstream | 02:40 | |
| *** Teljkon has quit IRC | 02:51 | |
| *** nimish has quit IRC | 03:23 | |
| *** tristan has joined #buildstream | 06:22 | |
| *** cs-shadow has joined #buildstream | 06:28 | |
| *** bochecha has joined #buildstream | 06:42 | |
| gitlab-br-bot | cs-shadow opened MR !1153 (chandan/bst-here-tags->master: Chandan/bst here tags) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1153 | 06:57 |
|---|---|---|
| cs-shadow | tristan: hi :) When you get a chance, please have a look at https://gitlab.com/BuildStream/buildstream/merge_requests/998#note_140589452 | 07:23 |
| *** ChanServ sets mode: +o tristan | 07:37 | |
| tristan | cs-shadow, Added couple comments there | 07:37 |
| tristan | cs-shadow, I wonder if the inner loop body from _extract_depends_from_node() should be moved into the Dependency constructor itself, this would place all the Dependency parsing and error reporting in the same function | 07:42 |
| cs-shadow | tristan: thanks! | 07:46 |
| cs-shadow | tristan: that seems sensible, I'll give that a go | 07:46 |
| cs-shadow | i now understand your point about distinguishing the two kinds of errors, will fix that | 07:47 |
| tristan | cs-shadow, There is a "gotcha" to passing only the opaque list element to the Dependency constructor just incase you didn't notice yet | 08:05 |
| tristan | As it is allowed to be a simple string, in the case that a simple string is specified, the provenance cannot be extracted, so the provenance of the list element itself needs to be passed through for that case | 08:06 |
| cs-shadow | tristan: yes, I am passing the `dep_provenance` as `provenance` attribute of the Dependency constructor for that purpose | 08:10 |
| cs-shadow | (in my local copy that is) | 08:10 |
| tristan | Good, just hoped to save you some frustration :) | 08:14 |
| cs-shadow | :) | 08:25 |
| *** tristan has quit IRC | 08:44 | |
| gitlab-br-bot | cs-shadow closed issue #705 (Provide some way of visualising the dependency graph of a given element) on buildstream https://gitlab.com/BuildStream/buildstream/issues/705 | 08:50 |
| gitlab-br-bot | cs-shadow merged MR !1148 (chandan/dot-graph->master: contrib/bst-graph: Add script to print graph in DOT format) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1148 | 08:50 |
| gitlab-br-bot | jjardon reopened issue #705 (Provide some way of visualising the dependency graph of a given element) on buildstream https://gitlab.com/BuildStream/buildstream/issues/705 | 08:57 |
| doras[m] | I see 1.2.4 is out. Nice. | 09:10 |
| *** kapil___ has joined #buildstream | 09:24 | |
| *** benschubert has joined #buildstream | 09:27 | |
| gitlab-br-bot | BenjaminSchubert opened MR !1154 (bschubert/set-as-set->master: Use sets when checking for existence of an element) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1154 | 09:43 |
| *** tristan has joined #buildstream | 09:46 | |
| *** raoul has joined #buildstream | 10:01 | |
| gitlab-br-bot | BenjaminSchubert approved MR !1152 (danielsilverstone-ct/variables-rework->master: Variables: Rework how expansion strings work) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1152 | 10:09 |
| *** jonathanmaw has joined #buildstream | 10:14 | |
| *** lachlan has joined #buildstream | 10:36 | |
| *** lachlan has quit IRC | 10:40 | |
| *** lachlan has joined #buildstream | 10:42 | |
| gitlab-br-bot | tpollard approved MR !1149 (aevri/mtime1->master: storage.Directory.export_to_tar: default mtime=utils._magic_timestamp) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1149 | 10:44 |
| gitlab-br-bot | tristanvb approved MR !1149 (aevri/mtime1->master: storage.Directory.export_to_tar: default mtime=utils._magic_timestamp) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1149 | 10:58 |
| gitlab-br-bot | BenjaminSchubert merged MR !1152 (danielsilverstone-ct/variables-rework->master: Variables: Rework how expansion strings work) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1152 | 11:04 |
| gitlab-br-bot | aevri approved MR !1153 (chandan/bst-here-tags->master: contrib/bst-here: Allow users to specify image variant) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1153 | 11:09 |
| *** lachlan has quit IRC | 11:14 | |
| *** lachlan has joined #buildstream | 11:16 | |
| aevri | I'm looking forward to that mergebot! :) | 11:17 |
| *** lachlan has quit IRC | 11:23 | |
| *** lachlan has joined #buildstream | 11:28 | |
| jmac | This is annoying, there are tar files which OSX's native `tar` can extract, but python3's tarfile can't | 11:40 |
| *** tristan has quit IRC | 11:41 | |
| gitlab-br-bot | aevri approved MR !1154 (bschubert/set-as-set->master: Use sets when checking for existence of an element) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1154 | 11:45 |
| benschubert | jmac: do you have an example? | 11:50 |
| jmac | Not one I can share publically | 11:54 |
| *** tristan has joined #buildstream | 11:56 | |
| gitlab-br-bot | aevri closed issue #914 (checkout --tar: mtime=0 is problematic for some software) on buildstream https://gitlab.com/BuildStream/buildstream/issues/914 | 12:25 |
| gitlab-br-bot | aevri merged MR !1149 (aevri/mtime1->master: storage.Directory.export_to_tar: default mtime=utils._magic_timestamp) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1149 | 12:25 |
| *** alatiera has joined #buildstream | 12:41 | |
| *** raoul has quit IRC | 12:47 | |
| Kinnison | jmac: does 'file $tarfile' tell you anything interesting about them? | 12:53 |
| jmac | Kinnison: Nothing unusual, just 'POSIX tar archive (GNU)' for the tar, and 'gzip compressed data' for the compressed version | 13:04 |
| Kinnison | jmac: Oddness, does python give you any hints? | 13:05 |
| *** cs-shadow has quit IRC | 13:07 | |
| jmac | I've found two different tars so far; one results in a 'File not found' error, but I don't know why, and one goes into infinite recursion and breaks the stack | 13:08 |
| Kinnison | erk | 13:09 |
| jmac | I might be able to chop them up and find smaller examples | 13:09 |
| Kinnison | recursion error in tarfile really ought not to be possible | 13:09 |
| *** raoul has joined #buildstream | 13:22 | |
| gitlab-br-bot | BenjaminSchubert merged MR !1154 (bschubert/set-as-set->master: Use sets when checking for existence of an element) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1154 | 13:39 |
| *** bochecha has quit IRC | 13:49 | |
| *** raoul has quit IRC | 14:03 | |
| gitlab-br-bot | aevri approved MR !913 (adamjones/labels->master: Add a link to the label descriptions in the issue templates) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/913 | 14:16 |
| *** raoul has joined #buildstream | 14:46 | |
| *** cs-shadow has joined #buildstream | 14:51 | |
| gitlab-br-bot | aevri closed issue #726 ('Are you sure?' prompts don't suit all users) on buildstream https://gitlab.com/BuildStream/buildstream/issues/726 | 14:55 |
| gitlab-br-bot | aevri closed issue #744 (proposed break: change non-interactive prompt behaviour) on buildstream https://gitlab.com/BuildStream/buildstream/issues/744 | 14:55 |
| gitlab-br-bot | aevri merged MR !1130 (are_you_sure2->master: userconfig: rm really-workspace-close-project-inaccessible) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1130 | 14:55 |
| *** lachlan has quit IRC | 15:00 | |
| gitlab-br-bot | aevri approved MR !1153 (chandan/bst-here-tags->master: contrib/bst-here: Allow users to specify image variant) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1153 | 15:08 |
| *** lachlan has joined #buildstream | 15:29 | |
| *** lachlan has quit IRC | 15:34 | |
| * tlater[m] notices that the testsuite-fedora image disappeared from the gitlab repository | 15:35 | |
| tlater[m] | Any idea how that might have happened? | 15:35 |
| tlater[m] | Hum, nevermind | 15:38 |
| tlater[m] | It just doesn't show up under https://gitlab.com/BuildStream/buildstream-docker-images/container_registry somehow | 15:38 |
| *** lachlan has joined #buildstream | 15:42 | |
| *** nimish has joined #buildstream | 15:50 | |
| *** lachlan has quit IRC | 15:55 | |
| *** lachlan has joined #buildstream | 16:08 | |
| gitlab-br-bot | cs-shadow merged MR !1153 (chandan/bst-here-tags->master: contrib/bst-here: Allow users to specify image variant) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1153 | 16:09 |
| jonathanmaw | Are there any objections to me making the WSL tests start automatically, but failure is allowed and they'll time-out at 1 hour (in case they decide to hang again)? | 16:13 |
| jonathanmaw | I'd like to put the new gitlab-runners through its paces to see if it's suitable | 16:14 |
| *** lachlan has quit IRC | 16:14 | |
| juergbi | jonathanmaw: cancelling the WSL job (e.g., because of long queueing time) would then still make CI proceed to the post stage, right? | 16:16 |
| juergbi | if so, fine with me | 16:17 |
| jonathanmaw | juergbi: I think a cancelled test counts as a failure, but I'll see if I can find some documentation on that | 16:17 |
| juergbi | jonathanmaw: and do we now reliably have multiple runners or at least multiple concurrent jobs per runner? | 16:18 |
| tlater[m] | jennis (or anyone else really): Any idea where this `bst-measure` script is? | 16:18 |
| tlater[m] | I vaguely recall an initiative to make specific parts of buildstream timeable | 16:19 |
| tlater[m] | This might be what kinnison produced for the performance measurements | 16:19 |
| jennis | https://mail.gnome.org/archives/buildstream-list/2019-January/msg00034.html | 16:24 |
| *** tristan has quit IRC | 16:32 | |
| *** lachlan has joined #buildstream | 16:33 | |
| *** lachlan has quit IRC | 16:53 | |
| jmac | FYI, this morning's bug with tarfile is https://bugs.python.org/issue23228, still outstanding | 17:03 |
| *** tpollard has quit IRC | 17:08 | |
| *** rdale has quit IRC | 17:22 | |
| *** rdale has joined #buildstream | 17:24 | |
| *** lachlan has joined #buildstream | 17:37 | |
| raoul | hmmm looks like the source cache somewhat complicates how we might do cache cleanups. As artifact cache just goes through artifact refs it wont clear out sources which ideally we also want to clear out in a sensible way. A separate cache clearer might be the way forward but I'm not sure. Anyone got any thoughts on this? | 17:37 |
| juergbi | raoul: I think the plan is to switch to object-based expiry instead of the current artifact-based expiry | 17:48 |
| juergbi | this would work independent of any artifact or source refs | 17:48 |
| juergbi | we already do this on the server side, however, can't do it on the client side until we support 'partial CAS', i.e., until we don't fail miserably when parts of an artifact are missing | 17:49 |
| *** raoul has quit IRC | 17:51 | |
| *** cs-shadow has quit IRC | 17:51 | |
| *** jonathanmaw has quit IRC | 18:18 | |
| *** alatiera has quit IRC | 18:58 | |
| *** lachlan has quit IRC | 19:11 | |
| *** alatiera has joined #buildstream | 19:45 | |
| *** alatiera has quit IRC | 19:46 | |
| *** alatiera has joined #buildstream | 19:46 | |
| *** lachlan has joined #buildstream | 20:02 | |
| *** lachlan has quit IRC | 20:41 | |
| *** benschubert has quit IRC | 20:46 | |
| *** kapil___ has quit IRC | 20:58 | |
| *** tristan has joined #buildstream | 21:54 | |
| *** kapil___ has joined #buildstream | 22:06 | |
| gitlab-br-bot | aevri approved MR !1143 (jjardon/distros->master: README.rst: Add table with distros with packaged buildstream) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1143 | 23:00 |
| gitlab-br-bot | jjardon merged MR !1143 (jjardon/distros->master: README.rst: Add table with distros with packaged buildstream) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1143 | 23:08 |
| *** tristan has quit IRC | 23:43 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!