| *** nimish has joined #buildstream | 00:37 | |
| *** tristan has joined #buildstream | 00:57 | |
| *** tristan has quit IRC | 02:14 | |
| *** mohan43u has joined #buildstream | 02:16 | |
| *** tristan has joined #buildstream | 02:27 | |
| *** tristan has quit IRC | 02:56 | |
| *** tristan has joined #buildstream | 02:59 | |
| *** alatiera has joined #buildstream | 03:01 | |
| *** tristan has quit IRC | 03:03 | |
| *** tristan has joined #buildstream | 03:06 | |
| *** alatiera has joined #buildstream | 03:13 | |
| *** rdale has quit IRC | 03:16 | |
| *** nimish has quit IRC | 03:18 | |
| *** alatiera has joined #buildstream | 03:22 | |
| gitlab-br-bot | tristanvb opened MR !1044 (tristan/fix-command-status-messages->master: sandbox/sandbox.py: Fix regression of command logging) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1044 | 04:00 |
|---|---|---|
| gitlab-br-bot | tristanvb merged MR !1044 (tristan/fix-command-status-messages->master: sandbox/sandbox.py: Fix regression of command logging) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1044 | 04:20 |
| *** alatiera has quit IRC | 04:23 | |
| *** alatiera has joined #buildstream | 04:25 | |
| *** tristan has quit IRC | 07:26 | |
| *** toscalix has joined #buildstream | 08:40 | |
| *** raoul has joined #buildstream | 09:07 | |
| *** raoul has quit IRC | 09:08 | |
| *** jonathanmaw has joined #buildstream | 09:37 | |
| gitlab-br-bot | LaurenceUrhegyi approved MR !913 (adamjones/labels->master: Add a link to the label descriptions in the issue templates) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/913 | 10:24 |
| *** lachlan has joined #buildstream | 10:29 | |
| gitlab-br-bot | juergbi merged MR !1041 (phil/remove-source-bundle-reference->master: element.py: remove documentation reference to source bundle command) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1041 | 10:54 |
| gitlab-br-bot | jmacarthur approved MR !985 (gokcennurlu/remote_url_override_push_error->master: Set ArtifactCache for push/pull correctly when `--remote` is used) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/985 | 11:10 |
| *** lachlan has quit IRC | 11:18 | |
| *** bochecha has joined #buildstream | 11:21 | |
| *** lachlan has joined #buildstream | 11:27 | |
| *** lachlan has quit IRC | 11:32 | |
| *** lachlan has joined #buildstream | 11:32 | |
| *** lachlan has quit IRC | 11:58 | |
| *** lachlan has joined #buildstream | 12:10 | |
| *** lachlan has quit IRC | 12:16 | |
| *** lachlan has joined #buildstream | 12:17 | |
| *** lachlan has quit IRC | 12:40 | |
| *** lachlan has joined #buildstream | 12:44 | |
| *** lachlan has quit IRC | 12:50 | |
| *** lachlan has joined #buildstream | 12:52 | |
| Kinnison | juergbi: thanks for your response on the artifact as a proto thread. I've skimmed it and will re-read it in more detail either later today or tomorrow with a view to responding | 13:19 |
| juergbi | ta. it got a bit longer than expected | 13:19 |
| Kinnison | It's not a simple thing to discuss :-D | 13:22 |
| *** alatiera has quit IRC | 13:30 | |
| *** nimish has joined #buildstream | 13:37 | |
| *** nimish has quit IRC | 13:46 | |
| *** alatiera has joined #buildstream | 13:49 | |
| *** alatiera has joined #buildstream | 13:49 | |
| *** alatiera has quit IRC | 13:57 | |
| *** nimish has joined #buildstream | 13:59 | |
| *** alatiera has joined #buildstream | 14:03 | |
| *** alatiera has joined #buildstream | 14:03 | |
| *** lachlan has quit IRC | 14:40 | |
| *** lachlan has joined #buildstream | 14:42 | |
| *** lachlan has quit IRC | 14:53 | |
| *** lachlan has joined #buildstream | 14:54 | |
| *** alatiera_ has joined #buildstream | 15:32 | |
| *** alatiera has quit IRC | 15:34 | |
| *** nimish has quit IRC | 15:34 | |
| *** alatiera has joined #buildstream | 15:35 | |
| *** alatiera has joined #buildstream | 15:35 | |
| *** nimish has joined #buildstream | 15:35 | |
| *** alatiera has quit IRC | 15:35 | |
| *** nimish has quit IRC | 15:40 | |
| *** nimish has joined #buildstream | 15:40 | |
| *** lachlan has quit IRC | 15:56 | |
| *** lachlan has joined #buildstream | 15:58 | |
| *** alatiera has joined #buildstream | 16:06 | |
| *** tristan has joined #buildstream | 16:13 | |
| *** ChanServ sets mode: +o tristan | 16:14 | |
| *** alatiera has joined #buildstream | 16:15 | |
| *** nimish has quit IRC | 16:20 | |
| *** nimish has joined #buildstream | 16:21 | |
| *** nimish has joined #buildstream | 16:21 | |
| juergbi | jmac: just noticed that the instance config option is documented as 'instance-name' but implemented as 'instance_name', if I'm reading the code correctly | 16:36 |
| juergbi | for consistency with other config keys, please change the implementation to use 'instance-name' | 16:36 |
| juergbi | tpollard: regarding configurable buildtree uploading, might it make sense to defer a more detailed discussion on this until there is some more clarity whether we'll go forward with the 'artifact as a proto' approach? or what do you think? | 16:38 |
| jmac | Hmm, quite right juergbi | 16:38 |
| *** WSalmon_ has quit IRC | 16:41 | |
| mablanch | juergbi, jmac: I'm testing it at the moment and can't get it to work, neither 'instance-name' or 'instance_name' works for me (current master). | 16:43 |
| jmac | Can you paste your config somewhere? | 16:44 |
| mablanch | Also, I was wondering which instance name would be used for action-cache-service, as it doesn't seen to accept 'instance-name'? | 16:45 |
| jmac | We don't support instance names for action-cache-service yet. | 16:45 |
| tristan | juergbi, I think this should be an assertion: https://gitlab.com/BuildStream/buildstream/blob/master/buildstream/sandbox/sandbox.py#L292, mind if I change it ? | 16:45 |
| mablanch | jmac: Sure, https://paste.codethink.co.uk/?5318 | 16:45 |
| juergbi | tristan: a plugin bug can trigger this. do we use asserts for potential plugin bugs? I forgot | 16:46 |
| *** nimish has quit IRC | 16:46 | |
| tristan | "programming errors" | 16:47 |
| jmac | mablanch: As said, instance_name for action-cache-service won't work | 16:47 |
| jmac | mablanch: Also, storage-service must use https, and you must supply tls keys | 16:47 |
| tristan | juergbi, I think the distinction is basically that crashes should never happen while using, but can happen when your own plugin is being developped | 16:47 |
| tristan | in that case, it will be helpful to have a stack trace for the plugin developer to ensure it doesnt happen | 16:47 |
| juergbi | good point, makes sense to me | 16:48 |
| tristan | But, then I think the question is, is it possible for the user to configure a scenario in YAML which triggers this ? | 16:48 |
| tristan | I doubt it | 16:48 |
| juergbi | no, that shouldn't be possible | 16:48 |
| tristan | good :) | 16:48 |
| jmac | mablanch: This means there is currently no way to use the same endpoint for storage-service and execution-service, because execution-service does not support TLS yet. !1030 should allow that. | 16:49 |
| gitlab-br-bot | MR !1030: Remote execution configuration: HTTPS and user configuration https://gitlab.com/BuildStream/buildstream/merge_requests/1030 | 16:49 |
| mablanch | jmac: This config. does work for me if every 'instance-name' lines are commented (and server set-up accordingly). | 16:49 |
| jmac | mablanch: I cannot imagine how that works. Are you sure it's using remote execution? | 16:50 |
| mablanch | jmac: Yep. I'm using an all-in-one BuildGrid server (including CAS). | 16:50 |
| jmac | I suppose it's possible BuildGrid's CAS server could work without TLS; it's not a situation I'd considered | 16:54 |
| jmac | BuildStream was meant to require TLS keys for storage service; I think your use of blank strings has worked around that | 16:55 |
| gitlab-br-bot | tristanvb opened MR !1046 (tristan/sandbox-programming-error->master: sandbox/sandbox.py: Use assertions for programming errors instead of BstErrors.) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1046 | 17:06 |
| *** nimish has joined #buildstream | 17:08 | |
| *** nimish has quit IRC | 17:18 | |
| *** nimish has joined #buildstream | 17:18 | |
| *** nimish has quit IRC | 17:23 | |
| gitlab-br-bot | raoul.hidalgocharman approved MR !1030 (valentindavid/remote_execution_configuration->master: Remote execution configuration: HTTPS and user configuration) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1030 | 17:23 |
| *** nimish has joined #buildstream | 17:25 | |
| tpollard | juergbi: sorry I've been afk, I don't think the proto stuff has to be a blocker if the current implementation approach is acceptable | 17:27 |
| juergbi | ok | 17:28 |
| tpollard | I mean it would lead to refactoring some of it out, but that's the same for pulling buildtree's too to some extent | 17:28 |
| *** alatiera has joined #buildstream | 17:29 | |
| *** alatiera has joined #buildstream | 17:30 | |
| *** alatiera has joined #buildstream | 17:31 | |
| *** nimish has quit IRC | 17:35 | |
| *** nimish has joined #buildstream | 17:35 | |
| *** dtf has joined #buildstream | 17:39 | |
| *** nimish has quit IRC | 17:43 | |
| *** jonathanmaw has quit IRC | 18:05 | |
| *** tristan has quit IRC | 18:16 | |
| *** tristan has joined #buildstream | 18:19 | |
| *** ChanServ sets mode: +o tristan | 18:27 | |
| *** lachlan has quit IRC | 18:37 | |
| *** alatiera_ has joined #buildstream | 18:48 | |
| *** alatiera has quit IRC | 18:49 | |
| *** alatiera_ is now known as alatiera | 18:49 | |
| *** xjuan has joined #buildstream | 18:52 | |
| *** cs-shadow has quit IRC | 19:08 | |
| gitlab-br-bot | tristanvb merged MR !1046 (tristan/sandbox-programming-error->master: sandbox/sandbox.py: Use assertions for programming errors instead of BstErrors.) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1046 | 19:19 |
| *** toscalix has quit IRC | 19:47 | |
| *** bochecha has quit IRC | 19:57 | |
| *** brlogger has joined #buildstream | 20:19 | |
| *** tristan has quit IRC | 20:21 | |
| *** tristan has joined #buildstream | 20:22 | |
| *** alatiera has quit IRC | 20:46 | |
| *** mohan43u has quit IRC | 20:54 | |
| *** mohan43u has joined #buildstream | 20:55 | |
| *** tristan has quit IRC | 21:21 | |
| *** xjuan has quit IRC | 21:42 | |
| *** xjuan has joined #buildstream | 22:19 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!