*** tristan has joined #buildstream | 01:52 | |
*** tristan has quit IRC | 01:58 | |
*** tristan has joined #buildstream | 01:59 | |
*** tristan has quit IRC | 02:11 | |
*** tristan has joined #buildstream | 02:18 | |
*** alatiera has joined #buildstream | 05:51 | |
*** tristan has quit IRC | 06:58 | |
*** alatiera has quit IRC | 07:04 | |
*** alatiera has joined #buildstream | 07:44 | |
*** toscalix has joined #buildstream | 08:18 | |
*** alatiera has quit IRC | 08:36 | |
*** mohan43u has quit IRC | 09:04 | |
*** WSalmon_ has joined #buildstream | 09:16 | |
*** benschubert has joined #buildstream | 09:25 | |
*** rdale has joined #buildstream | 09:26 | |
*** kapil___ has joined #buildstream | 10:01 | |
*** raoul has joined #buildstream | 10:04 | |
*** tpollard has joined #buildstream | 10:05 | |
*** jonathanmaw has joined #buildstream | 10:34 | |
*** bochecha has joined #buildstream | 10:54 | |
gitlab-br-bot | phildawson opened MR !1041 (phil/remove-source-bundle-reference->master: element.py: remove reference to source bundle command) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1041 | 11:24 |
---|---|---|
phildawson_ | ^ one liner documentation change for review | 11:24 |
*** alatiera has joined #buildstream | 11:36 | |
*** alatiera has joined #buildstream | 11:44 | |
juergbi | jmac: commented on !1023 again. however, my question whether it's still needed before moving to a pure CAS workflow still stands | 12:06 |
gitlab-br-bot | MR !1023: Stop resolving symlinks in _relative_symlink_target https://gitlab.com/BuildStream/buildstream/merge_requests/1023 | 12:06 |
juergbi | i.e., if we agree that this becomes irrelevant in the future (pure CAS, no symlink conversion), do we really want/need to touch the current code path? | 12:08 |
jmac | I agree it becomes irrelevant in the future, but we cannot do !991 without it | 12:18 |
gitlab-br-bot | MR !991: Cache artifacts with virtual directories instead of filesystem. https://gitlab.com/BuildStream/buildstream/merge_requests/991 | 12:18 |
*** mohan43u has joined #buildstream | 12:30 | |
*** raoul has quit IRC | 13:17 | |
*** mohan43u has quit IRC | 13:18 | |
gitlab-br-bot | jonathanmaw opened MR !1042 (jonathan/test-missing-workspace-guessing->master: Add tests to cover reinstated support for guessing targets) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1042 | 13:27 |
gitlab-br-bot | valentindavid closed MR !995 (valentindavid/overnight_build_arch->master: .gitlab-ci.yml: Fix arch options for overnight freedesktop-sdk build) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/995 | 13:37 |
*** raoul has joined #buildstream | 13:52 | |
*** raoul has quit IRC | 14:02 | |
*** phildawson_ has quit IRC | 14:02 | |
*** phildawson_ has joined #buildstream | 14:02 | |
*** kapil___ has quit IRC | 14:50 | |
*** raoul has joined #buildstream | 14:55 | |
*** nimish has joined #buildstream | 14:58 | |
*** nimish has quit IRC | 15:03 | |
*** nimish has joined #buildstream | 15:03 | |
*** tristan has joined #buildstream | 15:06 | |
jennis | Could someone add me as a developer to the benchmarking repo? pls | 15:40 |
jennis | oh nvm, already there, probably something my end | 15:41 |
ikerperez | hi, I am running a script like root (it needs to be run like root) that executes buildstream, the script finds the bst command but it can't find the buildstream module, how can I fix that? Where is the buildstream module stored? | 15:46 |
*** raoul_ has joined #buildstream | 15:53 | |
*** raoul has quit IRC | 15:54 | |
*** raoul__ has joined #buildstream | 15:56 | |
*** raoul_ has quit IRC | 15:57 | |
gitlab-br-bot | jonathanmaw opened issue #846 (Elements with an open workspace cannot be fetched) on buildstream https://gitlab.com/BuildStream/buildstream/issues/846 | 16:01 |
*** raoul has joined #buildstream | 16:17 | |
*** bochecha has quit IRC | 16:17 | |
*** raoul__ has quit IRC | 16:18 | |
*** nimish has quit IRC | 16:18 | |
*** nimish has joined #buildstream | 16:18 | |
*** tristan has quit IRC | 16:28 | |
tpollard | is it expected that we can't run the tests outside of tox? | 16:32 |
tpollard | or am I just having issues locally | 16:32 |
tpollard | as I can't run the integration tests standalone anymore | 16:33 |
*** tristan has joined #buildstream | 16:40 | |
*** ChanServ sets mode: +o tristan | 16:41 | |
gitlab-br-bot | phildawson opened issue #847 (Expose testing api for use by external plugins) on buildstream https://gitlab.com/BuildStream/buildstream/issues/847 | 16:46 |
tpollard | looks like it might just be me | 16:47 |
*** nimish has quit IRC | 16:53 | |
*** nimish has joined #buildstream | 16:54 | |
gitlab-br-bot | phildawson opened issue #848 (Create api for plugins to give deprecation warnings) on buildstream https://gitlab.com/BuildStream/buildstream/issues/848 | 16:55 |
*** nimish has quit IRC | 17:01 | |
*** nimish has joined #buildstream | 17:02 | |
benschubert | tpollard: it should run locally still | 17:02 |
benschubert | what problem are you seeing? | 17:02 |
*** nimish has joined #buildstream | 17:02 | |
*** nimish has joined #buildstream | 17:03 | |
tpollard | 'AttributeError: 'Function' object has no attribute 'get_marker'' on near enough every tests, I've tried a 'pip3 install --user -e .' again too | 17:03 |
tpollard | work fine under tox | 17:04 |
*** nimish_ has joined #buildstream | 17:05 | |
benschubert | Can you paste the complete traceback somewhere? :) | 17:05 |
*** nimish has quit IRC | 17:06 | |
*** nimish_ is now known as nimish | 17:06 | |
tpollard | sure | 17:08 |
*** tristan has quit IRC | 17:09 | |
tpollard | benschubert: that's the snipped https://paste.gnome.org/ppljhsxin | 17:09 |
*** Kinnison has joined #buildstream | 17:10 | |
tpollard | from './setup.py test --addopts '--integration'' | 17:10 |
benschubert | Never seen that :/ Seems unlikely this comes from tox though :) | 17:10 |
tpollard | np! | 17:12 |
*** xjuan has joined #buildstream | 17:12 | |
*** tristan has joined #buildstream | 17:23 | |
*** ChanServ sets mode: +o tristan | 17:23 | |
*** nimish has quit IRC | 17:25 | |
jmac | ikerperez: It's a bit difficult to say as I usually install in user mode, but I'd expect the modules to be in one of the 'site-packages' directories | 17:25 |
*** nimish has joined #buildstream | 17:25 | |
jmac | ikerperez: Either in /usr/lib/python3XX/site-packages or /root/.local/lib/python3XX/site-packages | 17:25 |
jmac | Depending on how it was installed | 17:26 |
gitlab-br-bot | tristanvb opened MR !1043 (tristan/keyboard-interrupt-stack-trace->master: Fix stack traces discovered with ^C forceful termination.) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1043 | 17:30 |
gitlab-br-bot | raoul.hidalgocharman opened (was WIP) MR !1013 (raoul/802-refactor-artifactcache->master: Raoul/802 refactor artifactcache) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1013 | 17:31 |
benschubert | tristan: I was looking at the Pipeline, and was wondering. What is the reason behind creating a new Process for every job? Couldn't we reuse them? | 17:32 |
tristan | benschubert, reuse the data model; which is very expensive to load | 17:34 |
tristan | benschubert, the processes are fork() without execve() | 17:34 |
benschubert | Ok, but wouldn't it be faster to spawn processes and then send them jobs by a queue? If I recall correclty, we are not modifying the datamodel in the jobs right? | 17:35 |
benschubert | I'm just asking since on my computer, this leads to a horrendus amount of exceptions logged because of too short-lived processes | 17:36 |
benschubert | (a "bug" (or is it a feature?) in asyncio) | 17:36 |
Kinnison | We'd have to replicate model updates to each subprocess if they were to live longer and run more than one job | 17:36 |
* Kinnison is surprised those asyncio signalfd things haven't been silenced upstream yet | 17:37 | |
benschubert | just to make sure we are on the same page, when you mean model updates, you mean the elements correct? | 17:38 |
Kinnison | ]yes | 17:38 |
Kinnison | Well, I do :-) | 17:38 |
benschubert | and that shouldn't be needed if we have self contained jobs, correct? | 17:39 |
Kinnison | If a job doesn't need to know any of the data model beyond what is packaged up for it, then perhaps not | 17:39 |
Kinnison | me will let you and tristan discuss this though, I have to run away now, | 17:39 |
ikerperez | jmac thanks! | 17:39 |
benschubert | Kinnison: perfect thanks! I was wondering if something else was behind it or not :) I've been looking into optimisations a bit | 17:40 |
tristan | benschubert, the plugin code is allowed to read the data model | 17:53 |
tristan | benschubert, a plausible change would be to use threads instead | 17:54 |
tristan | but right now it's processes | 17:54 |
benschubert | threads were problematic with grpc correct? And the plugin code shouldn't be modifying the code during the run right? | 17:54 |
*** nimish has quit IRC | 17:55 | |
*** nimish has joined #buildstream | 17:56 | |
gitlab-br-bot | tristanvb merged MR !1043 (tristan/keyboard-interrupt-stack-trace->master: Fix stack traces discovered with ^C forceful termination.) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1043 | 18:00 |
*** nimish has quit IRC | 18:03 | |
*** toscalix has quit IRC | 18:04 | |
*** mohan43u has joined #buildstream | 18:08 | |
*** xjuan has quit IRC | 18:18 | |
*** raoul has quit IRC | 18:19 | |
*** kapil___ has joined #buildstream | 18:22 | |
*** tristan has quit IRC | 18:23 | |
*** xjuan has joined #buildstream | 18:23 | |
*** jonathanmaw has quit IRC | 18:38 | |
gitlab-br-bot | gokcennurlu opened issue #849 (BuildStream installs using the git repo without tags, but doesn't work) on buildstream https://gitlab.com/BuildStream/buildstream/issues/849 | 18:42 |
gitlab-br-bot | tristanvb closed issue #753 (Cache size logging is very spammy) on buildstream https://gitlab.com/BuildStream/buildstream/issues/753 | 18:50 |
gitlab-br-bot | tristanvb merged MR !1040 (tristan/one-cache-size-job->master: Only queue one cache size job) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1040 | 18:50 |
*** dbscoach has joined #buildstream | 19:12 | |
*** dbscoach has joined #buildstream | 19:13 | |
*** dbscoach has quit IRC | 19:24 | |
*** alatiera has quit IRC | 20:22 | |
*** kapil___ has quit IRC | 20:32 | |
*** mohan43u has quit IRC | 21:05 | |
*** mohan43u has joined #buildstream | 21:09 | |
*** mohan43u has quit IRC | 21:13 | |
*** mohan43u has joined #buildstream | 21:16 | |
*** mohan43u has quit IRC | 21:47 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!