IRC logs for #buildstream for Friday, 2018-09-28

*** catonano_ has joined #buildstream00:19
*** catonano has quit IRC00:21
*** catonano_ is now known as catonano00:21
*** catonano has quit IRC00:58
*** catonano has joined #buildstream01:12
*** catonano has quit IRC02:01
*** alatiera_ has quit IRC02:35
*** alatiera_ has joined #buildstream03:52
*** alatiera__ has joined #buildstream03:54
*** alatiera_ has quit IRC03:55
*** alatiera_ has joined #buildstream03:56
*** alatiera__ has quit IRC03:57
*** alatiera_ has quit IRC04:00
*** catonano has joined #buildstream04:22
*** catonano has joined #buildstream04:23
*** catonano has joined #buildstream04:25
*** catonano has quit IRC06:28
*** alatiera_ has joined #buildstream06:30
*** WSalmon has joined #buildstream06:38
*** WSalmon has quit IRC06:41
*** iker has joined #buildstream07:08
*** alatiera__ has joined #buildstream07:36
*** alatiera_ has quit IRC07:38
*** toscalix has joined #buildstream07:39
*** alatiera_ has joined #buildstream07:40
*** alatiera__ has quit IRC07:41
*** alatiera__ has joined #buildstream07:42
*** alatiera_ has quit IRC07:43
*** alatiera_ has joined #buildstream07:44
*** alatiera__ has quit IRC07:45
*** alatiera__ has joined #buildstream07:46
*** alatiera_ has quit IRC07:47
*** alatiera_ has joined #buildstream07:50
*** alatiera__ has quit IRC07:51
*** alatiera__ has joined #buildstream07:52
*** alatiera_ has quit IRC07:54
*** alatiera_ has joined #buildstream07:55
*** alatiera__ has quit IRC07:56
*** finn has joined #buildstream08:04
*** alatiera_ has joined #buildstream08:14
*** bochecha has joined #buildstream08:16
*** WSalmon has joined #buildstream08:22
*** alatiera__ has joined #buildstream08:32
*** alatiera_ has quit IRC08:34
juergbijmac: thanks for the import rules write-up08:43
juergbi3.3.1: the IS_DIR check first resolves the symlinks, so symlinks to directories are accepted, if I'm reading the code correctly08:44
juergbialso, regarding 1: would the resulting directory tree differ in any way if non-empty directories were explicitly listed as well?08:46
juergbican't think of a case OTOH but I might be missing something08:47
juergbi(it seems a somewhat odd rule, so I'm wondering)08:47
jmacI'm not sure juergbi08:48
jmacToday I'm going to be writing more tests and seeing if I can break the existing system. I think including non-empty directories will be a good test.08:49
juergbiok, sounds good08:51
juergbijmac: I'm also not sure I understand the ordering issue. both the list_relative_paths case and the other case sort things, just not at the same place. is the concern that they don't use exactly the same sorting rules?08:52
jmacjuergbi: list_relative_paths has a specific sort order (directories then non-directories) and the comments in it suggest this is very intentional08:55
jmacSorting the whole list alphabetically produces a different order08:55
juergbiright. the most or even only critical aspect might be that symlinks to directories are handled in the right order, as per comment in _process_list()08:57
*** alatiera__ is now known as alatiera_08:57
juergbialthough, things could also break if a symlink to a directory is replaced by e.g. a regular file. it will depend on when that replacement happens08:58
jmacYes, I think that's one of the most important cases.08:58
juergbitricky topic08:58
* juergbi is surprised to see that the 'ignored' file list will only ever produce a warning, never an error09:01
gitlab-br-botbuildstream: merge request (jmac/vdir_import_test->master: WIP: Import test for virtual directories) #815 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/81509:07
*** jonathanmaw has joined #buildstream09:09
tiagogomesvalentindavid are you planning to backport your project path fixes to 1.2? I can do it if you are busy09:22
gitlab-br-botbuildstream: merge request (bochecha/cache-size->master: data/userconfig.yaml: Document the cache.quota setting) #833 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83309:23
*** mohan43u has quit IRC09:24
gitlab-br-botbuildstream: merge request (valentindavid/silverblue-path-1.2->bst-1.2: Backport to 1.2: Fix outside-of-project check when project path is not canonical.) #834 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83409:25
gitlab-br-botbuildstream: issue #684 ("Staging OSTree sources with very strict permissions fails") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/68409:26
valentindtiagogomes, !83409:26
tiagogomescool, I set it to merge automatically when the pipeline succeeds09:27
*** mohan43u has joined #buildstream09:28
juergbijmac: #684 is a regression from the switch to the virtual directory API09:28
*** lachlan has joined #buildstream09:28
jmacjuergbi: OK, I'll take a look09:29
juergbita09:38
*** ikerperez has joined #buildstream09:49
*** lachlan has quit IRC09:49
gitlab-br-botbuildstream: merge request (valentindavid/silverblue-path-1.2->bst-1.2: Backport to 1.2: Fix outside-of-project check when project path is not canonical.) #834 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/83409:52
*** ikerperez has quit IRC09:52
gitlab-br-botbuildstream: merge request (jonathan/pickle-yaml->master: WIP: Add a cache of parsed and provenanced yaml) #787 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78709:54
*** lachlan has joined #buildstream09:55
gitlab-br-botbuildstream: issue #673 ("Silverblue: Specified path 'elements' must not lead outside of the project directory") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/67310:04
*** lachlan has quit IRC10:13
gitlab-br-botbuildstream: merge request (coldtom/strip-rules->master: WIP: Upstream freedesktop-sdk strip rules) #750 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/75010:16
*** ikerperez has joined #buildstream10:21
*** ikerperez has joined #buildstream10:25
*** ikerperez has quit IRC10:27
*** lachlan has joined #buildstream10:28
gitlab-br-botbuildstream: merge request (jonathan/pickle-yaml->master: WIP: Add a cache of parsed and provenanced yaml) #787 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78710:31
*** ikerperez has joined #buildstream10:31
*** ikerperez has quit IRC10:31
gitlab-br-botbuildstream: merge request (bochecha/cache-size->master: data/userconfig.yaml: Document the cache.quota setting) #833 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83310:34
gitlab-br-botbuildstream: merge request (bochecha/cache-size->master: data/userconfig.yaml: Document the cache.quota setting) #833 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/83310:34
gitlab-br-botbuildstream: merge request (tiagogomes/docs-improvements->master: Documentation improvements) #835 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83510:38
gitlab-br-botbuildstream: merge request (tiagogomes/docs-improvements->master: Documentation improvements) #835 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83510:38
*** lachlan has quit IRC10:43
*** abderrahim has quit IRC11:07
*** abderrahim has joined #buildstream11:07
tiagogomesAnyone for https://gitlab.com/BuildStream/buildstream/merge_requests/83511:29
*** ikerperez has joined #buildstream11:34
*** lachlan has joined #buildstream11:39
*** ikerperez has quit IRC11:50
*** iker has quit IRC12:00
tpollardhaving documentation without installation instructions just feels wrong to me12:03
tiagogomesI think it is the usual thing to do12:04
tiagogomesWhen the docs website is separate from the main website12:04
tiagogomesFlatpak does the same12:04
*** catonano has joined #buildstream12:12
bochechafor those using ripgrep (an alternative to the venerable grep, much better, faster, and written in rust), in its next release it will be able to filter searches specifically in .bst files with --type=buildstream :)12:35
bochechahttps://github.com/BurntSushi/ripgrep/pull/107112:35
bochechaimproving the DX one little step at a time :-°12:35
tpollardcool12:35
tiagogomesbochecha nice, fyi the official repo for the docs is now https://docs.buildstream.build :)13:22
tpollarddoes search not work anymore on the docs?13:33
gitlab-br-botbuildstream: merge request (valentindavid/cache_server_fill_up->master: WIP: Fix cleanup of cache in server when disk is full) #830 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83013:34
tiagogomestpollard https://gitlab.com/BuildStream/buildstream/issues/68113:35
tiagogomesI suspect that to happened when the docker containers were updated13:37
tpollardcheers tiagogomes13:38
*** lachlan has quit IRC13:44
*** lachlan has joined #buildstream13:49
*** alatiera__ has joined #buildstream14:13
*** alatiera_ has quit IRC14:14
gitlab-br-botbuildstream: merge request (lachlan/pickle-yaml-test-list-composite->master: WIP: Add a cache of parsed and provenanced yaml) #836 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83614:17
*** finn has quit IRC14:39
*** finn has joined #buildstream14:39
*** catonano has quit IRC14:43
*** lachlan has quit IRC14:55
*** toscalix has quit IRC15:15
*** lachlan has joined #buildstream15:20
*** lachlan has quit IRC15:29
gitlab-br-botbuildstream: merge request (jmac/vdir_import_test->master: WIP: Import test for virtual directories) #815 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/81515:35
*** lachlan has joined #buildstream15:40
*** lachlan has quit IRC15:50
*** lachlan has joined #buildstream15:51
*** phildawson has quit IRC15:54
gitlab-br-botbuildstream: merge request (lachlan/pickle-yaml-test-list-composite->master: WIP: Add a cache of parsed and provenanced yaml) #836 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83615:56
*** finn_ has joined #buildstream15:58
*** finn has quit IRC16:00
*** lachlan has quit IRC16:01
*** finn_ has quit IRC16:02
gitlab-br-botbuildstream: issue #685 ("bst shell --build <element.bst> should automatically cache build dependencies") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/68516:12
jjardonbochecha: in case you are interested, I've filled ^ after the chat the other day16:18
bochechajjardon: I am!16:19
bochechaI use bst shell --build all the time in fdo sdk :)16:19
bochecha> Also taking account what the documentation says about bst shell --build16:19
bochechajjardon: I have a feeling this sentence is unfinished?16:20
jjardonbochecha: I have talk about the docs in the begining of the report16:21
* jjardon reword16:26
* tiagogomes is not a fan of that idea16:34
tiagogomes`bst shell` shouldn't build or pull, even if an option was passed16:35
jjardontiagogomes: the issue is not about make bst shell to build16:36
*** lachlan has joined #buildstream16:38
*** raoul has quit IRC16:49
*** tpollard has quit IRC16:53
*** lachlan has quit IRC16:53
gitlab-br-botbuildstream: merge request (jmac/vdir_import_unreadable_files->master: WIP: Import unreadable files) #837 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83717:00
gitlab-br-botbuildstream: merge request (jmac/vdir_import_unreadable_files->master: WIP: Import unreadable files) #837 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83717:00
*** tiagogomes has quit IRC17:02
*** tiagogomes has joined #buildstream17:13
*** jonathanmaw has quit IRC17:13
gitlab-br-botbuildstream: issue #686 ("Package Buildstream in the official Fedora repositories") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/68617:48
bochechaI just opened #686 to track where I'm at with inclusion in Fedora; I started the process today, hopefully it's done before the end of next week :)17:49
*** catonano has joined #buildstream18:01
*** mohan43u has quit IRC19:07
*** catonano has quit IRC19:38
*** mohan43u has joined #buildstream19:52
*** catonano has joined #buildstream22:15
*** bochecha has quit IRC23:08
*** catonano has quit IRC23:33

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!