IRC logs for #buildstream for Thursday, 2018-09-27

*** alatiera_ has quit IRC00:02
*** tiagogomes has quit IRC01:33
*** catonano has joined #buildstream03:24
*** catonano has quit IRC05:38
*** catonano has joined #buildstream05:44
*** catonano has quit IRC06:55
*** WSalmon has joined #buildstream07:02
*** iker has joined #buildstream07:10
*** bochecha has joined #buildstream07:22
*** WSalmon has quit IRC07:43
*** toscalix has joined #buildstream07:44
*** WSalmon has joined #buildstream07:56
*** finn has joined #buildstream08:09
*** finn has quit IRC08:31
Kinnisonjuergbi: Did you get a chance to split out the work you did on mac_fixes ?08:31
*** phildawson has joined #buildstream08:35
juergbiKinnison: yes, I opened !82908:35
juergbireview appreciated08:36
* Kinnison shall give it a proper going over this morning08:36
juergbithanks08:36
*** tiagogomes has joined #buildstream08:36
* Kinnison would appreciate it if someone else would too08:36
juergbimaybe jmac could take a look as well08:36
juergbithe branch has quite a few commits but it's really just refactoring, the individual commits are all small08:37
jmacI can do, I'm yet to start on my sprint's tasks yet though...08:37
jmacNot that sprints mean much on this channel08:38
Kinnison:-)08:38
juergbithanks08:38
juergbithe most interesting commit review wise is likely "Move artifact cache creation to Context". also small but I'd be interested in feedback whether I'm moving things to the right place08:39
* jmac wonders why https://gitlab.com/BuildStream/buildstream/merge_requests/825 hasn't merged08:39
juergbimaster moved on before CI finished, i.e., rebase required?08:42
jmacSo it won't merge even if there's fast-forwardable changes?08:44
juergbiI think so, yes. gitlab never implicitly rebases08:44
juergbifreedesktop-sdk has a merge bot for this, afaict08:44
juergbimight be useful for us as well08:44
KinnisonYeah, it may be worth looking into a merge bot08:44
KinnisonRust uses one which can roll up multiple PRs into a single test-run+push-to-master which is nice for speeding things up08:45
KinnisonUnfortunately I think bors is github specific08:45
juergbi(to be precise, !825 is no longer fast forwardable because master moved on in the meantime)08:45
juergbithe fdo-sdk one (marge bot) should be good enough08:45
juergbiit serializes things, so immediately rebases the next MR in the queue after the merging of the previous one08:46
KinnisonWhat does it do for testing?  Does it issue CI runs after each rebase, or does it rebase a stack of MRs together and test once?08:46
juergbifor each MR individually08:46
gitlab-br-botbuildstream: merge request (mablanch/668-remote-build-failure->master: Better handle remote build failures) #825 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/82508:46
juergbii.e., it really does the same thing as we can do as gitlab users, but organized by a single bot entity08:47
KinnisonI see08:49
KinnisonSo it automates what currently happens08:49
KinnisonI guess that's a good step forward, saves human cognitive load for sure08:49
Kinnisonjuergbi: The commits on !829 look sane to me.  I'm not really in a position to speak to the correctness of the approach as a whole, though I will say that it makes sense to me, I'm not fully au-fait with everything in the lower levels of bst.  I raised a single discussion but otherwise I think 829 is good08:51
*** finn has joined #buildstream08:53
*** WSlamon has joined #buildstream08:56
*** WSlamon has quit IRC08:57
*** jonathanmaw has joined #buildstream09:00
juergbithanks09:01
gitlab-br-botbuildstream: merge request (juerg/platform->master: Make platform independent of context) #829 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/82909:05
juergbiadded preflight method to artifact cache for basic sanity check09:06
*** tpollard has joined #buildstream09:07
jmacYep, similarly, it looks sensible to me, but it'll take a while to review fully09:07
jmacI'm fine with the changes to the remote execution parts09:07
Kinnisonjuergbi: I'm satisfied with the preflight() change and have resolved the discussion09:08
juergbijmac: ok, thanks. are you planning to do a full review later, i.e., shall I wait with the merge or just go ahead?09:14
jmacIf you're happy to merge it then merge it09:15
juergbiok09:15
gitlab-br-botbuildstream: merge request (mablanch/668-remote-build-failure->master: Better handle remote build failures) #825 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/82509:16
gitlab-br-botbuildstream: merge request (juerg/platform->master: Make platform independent of context) #829 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/82909:20
*** raoul has joined #buildstream09:22
NexusI've not had to do it in a while, how do i rebuild the docs again?09:29
juergbiNexus: if you have the dependencies, it should just be: make -C doc09:31
*** catonano has joined #buildstream09:33
Nexusta :)09:35
*** finn has quit IRC09:36
tiagogomesjjardon https://docs.buildstream.build should work now without certificate related warnings09:37
jjardonCool!09:39
*** lachlan has joined #buildstream09:41
tiagogomeswe could apply some tweaks from http://docs.flatpak.org/ to https://docs.buildstream.build/09:41
jjardontiagogomes: thanks for reviewing the patches about the main website page later yesterday btw :)09:46
gitlab-br-botbuildstream: merge request (juerg/platform->master: Make platform independent of context) #829 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/82909:48
toscalixtiagogomes: it works, thanks09:48
toscalixtiagogomes: maybe you want also to change the menu link09:49
toscalixin the front page of the site09:49
gitlab-br-botbuildstream: merge request (mac_fixes->master: Implement compatibility fixes for MacOSX and WSL Blocks #411 and #412") #726 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/72609:49
tiagogomestoscalix which menu link?09:51
toscalixthe top menu on the front page. One option is documentation09:52
toscalixthe night builds of freedesktop-sdk failed09:52
toscalixhummm.... mails are moderated09:53
toscalixnice, we have notifications about the nightly builds on the mailing list09:55
toscalixnotificatoins mailing list09:55
gitlab-br-botbuildstream: merge request (juerg/git-describe->master: git.py: Make `ref` human readable) #291 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/29109:56
toscalixadds68: jjardon coldtom valentind you probably are interested in this notifications09:57
toscalixyou can easily firter them among the rest of the notifications we send to the notifications-mailing -list09:58
toscalixhttps://mail.gnome.org/mailman/listinfo/buildstream-notifications-list09:58
tiagogomesI think that list is useless as it is. It is too noisy to track10:00
juergbitiagogomes: for CI you've updated the fd sdk ref but kept the comment "18.08.12", which is now outdated, afaict10:01
toscalixtiagogomes: depends on how you manage firlters10:01
toscalixfilters10:02
toscalixit is noisy because the activity is very high10:02
tiagogomesjuergbi, right, I didn't bother to be accurate as that is just an indication. But I should have used the output of git describe10:02
*** CTtpollard has joined #buildstream10:02
adds68toscalix, i already receive notifications from gitlab when pipelines fail? Have i missed some context here?10:03
*** tpollard has quit IRC10:03
toscalixadds68: this one is from buildstream repo10:04
toscalixfrom the new pipelines created by tiagogomes10:04
toscalixadds68: https://gitlab.com/BuildStream/buildstream/pipelines/3130371610:05
tiagogomesIf those pipelines fail, it is probably a problem with buildstream or a server being down, so it doesn't directly concern the freedesktop-sdk team10:05
toscalixhttps://gitlab.com/BuildStream/buildstream/pipelines/3130371510:05
toscalixtiagogomes: which is why I pinged valentind10:06
toscalixbut maybe users ping the freedesktop-sdk guys if something goes wrong10:06
valentindAre not those gitlab notifications?10:07
tiagogomesHmm, in this case two jobs failed due lack of disk space10:07
toscalixyes, sent to the notifications list10:08
tiagogomesThis one is more strange https://gitlab.com/BuildStream/buildstream/-/jobs/10197837410:09
toscalixthis is a better link https://gitlab.com/BuildStream/buildstream/pipeline_schedules10:09
adds68There seems to be emails from every pipeline in that inbox, i think it's best if we get pinged for any freedesktop-sdk related issues10:10
tiagogomesNot easily possible10:11
toscalixadds68: we just got notifications from pipelines. It is an improvement. You can filter the ones you are interested on10:11
*** finn has joined #buildstream10:12
valentindOK, so I added notifications for all build fails on BuildStream/buildstream for me.10:13
adds68toscalix, from what i'm aware if you run a pipeline Gitlab automatically notifies the person who started it/any MR/issue associated with that pipeline?10:15
valentindadds68, In this case this is a scheduled pipeline.10:15
juergbitiagogomes: imo, the comment could also just indicate the branch (18.08) or have something like 18.08.12+ to indicate it's been updated after that tag10:16
juergbijust want to avoid confusion due to mismatch10:16
adds68valentind, ah ok10:19
gitlab-br-botbuildstream: merge request (juerg/git-describe->master: git.py: Make `ref` human readable) #291 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/29110:19
toscalixtiagogomes: correct me if I am wrong. The pipeline ID is fixed.10:20
* tiagogomes doesn't know10:20
toscalixthe ID is part of the subject of the notification mail10:20
valentindtoscalix, I do not think it is.10:20
valentindOtherwise you cannot go see the history of builds.10:21
valentindThere seems to be an ID however, when you hover the "play" button, you can see the url contains a number. I think this is the number of the schedule.10:22
valentindLike: "https://gitlab.com/BuildStream/buildstream/pipeline_schedules/12238/play"10:22
valentindSo this is 1223810:23
toscalixhttps://docs.gitlab.com/ee/ci/variables/#using-the-ci-variables-in-your-job-scripts I see here several IDs, some internal10:23
jjardontoscalix: tiagogomes thanks10:23
toscalixvalentind: sadly the default mail notification does not include such number10:24
toscalixso we would need to work with the API so include the tag on the notification so we can filter them in mail clients10:27
jjardontoscalix: this should not affect our users though (we used a fixed bst 1.2 version), but nice you care to not break fdsk with buildstream master :)10:31
*** lachlan has quit IRC10:34
toscalixjjardon: there is a pipeline for bst-1.210:48
jjardonjuergbi: is the description in https://gitlab.com/BuildStream/buildstream/merge_requests/291 still valid?10:48
jjardontoscalix: cool10:48
juergbijjardon: no, that was the initial proposal10:48
jjardonah, ok10:49
* jjardon keeps reading10:49
juergbidon't really want to completely remove that but maybe i should still amend it10:49
juergbijjardon: https://gitlab.com/BuildStream/buildstream/merge_requests/291#note_6126197010:49
jjardonyeah, maybe an update after what is already there would help in case we have to look to that later10:49
toscalixjjardon: https://gitlab.com/BuildStream/buildstream/pipelines/31303716/builds10:49
jjardoncool, I will try and remember to update https://gitlab.com/BuildStream/buildstream/blob/master/.gitlab-ci.yml#L166 when a new freedesktop-sdk release is out10:52
gitlab-br-botbuildstream: merge request (juerg/git-describe->master: git.py: Make `ref` human readable) #291 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/29110:54
juergbidescription updated10:54
*** lachlan has joined #buildstream10:55
toscalixjjardon: is there a way to avoid in that line a hardcoded ref so you do not have to update it manually?10:55
tiagogomesI don't want to use the tip of 18.06, but rather a fixed ref10:57
jjardontoscalix: sure, you can build wherever is latest, but that's a question for tiagogomes10:57
toscalixtiagogomes: ok, your call10:57
tiagogomesfixed ref10:57
tiagogomesOtherwise we need to workout if what is causing the failure is buildstream or fd-sdk10:58
tiagogomesfd-dsk could have a release document with the steps involved in doing a release (tag, announcement, release party…). That could be one of the steps so that is not forgotten10:59
toscalixI wonder if we need to document that or it is obvious from reading .gitlab-ci.yml11:00
raoulHow would I go about creating a flatpak binary with buildstream? Have managed to build doom with freedesktop following the flatpak-autotools example, but can't seem to find how I'd output a binary I can then use (maybe this should be in the docs somewhere?)11:00
tiagogomesFrom reading .gitlab-ci.yml it is obviously what needs to be done, but we still need to remember to do that11:01
jjardontiagogomes: It can not be fdsk; nothing goes to master without passing the CI. But I understand your argument11:05
*** abderrahim has quit IRC11:06
*** abderrahim has joined #buildstream11:07
gitlab-br-botbuildstream: merge request (coldtom/strip-rules->master: WIP: Upstream freedesktop-sdk strip rules) #750 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/75011:07
*** finn has quit IRC11:07
valentindraoul, we have made flatpaks of tuxracer with buildstream. That still involves a lot of boiler plate. See https://gitlab.com/valentindavid/org.gnu.Hello/tree/valentindavid/supertuxkart11:08
valentindSorry super tux kart. Not tuxracer.11:08
raoulI'll have a gander at that, thanks valentind11:10
valentindraoul, note it is using a branch of freedesktop sdk.11:10
valentindI hope to merge that soon. But I have not had time.11:10
jjardonjuergbi: I like https://gitlab.com/BuildStream/buildstream/merge_requests/291, but maybe we should make it optional?11:11
juergbijjardon: might make sense. via project-wide defaults this should be convenient enough11:14
jjardonyeah, mostly for users doesnt get confused by their refs suddenly not being the standard git SHA1; probably better to have an option so people can opt in11:15
juergbitrack-describe as option?11:16
jjardonI'd say "ref-format: sha1/git-describe"?11:18
jjardonand default to sha1?11:18
*** finn has joined #buildstream11:33
gitlab-br-botbuildstream: issue #682 ("Handle rogue plugin exceptions.") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/68211:52
*** finn has quit IRC12:03
gitlab-br-botbuildstream: merge request (juerg/git-describe->master: git.py: Make `ref` human readable) #291 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/29112:08
gitlab-br-botbuildstream: merge request (juerg/git-describe->master: git.py: Make `ref` human readable) #291 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/29112:12
gitlab-br-botbuildstream: merge request (juerg/git-describe->master: git.py: Make `ref` human readable) #291 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/29112:17
gitlab-br-botbuildstream: merge request (juerg/git-describe->master: git.py: Make `ref` human readable) #291 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/29112:18
gitlab-br-botbuildstream: merge request (willsalmon/outOfSourecBuild->master: Out of source builds) #776 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/77612:19
paulsher1oodraising this here, in case anyone has helpful suggestions https://lists.trustable.io/pipermail/trustable-software/2018-September/000457.html12:27
coldtomhow can i stop pytest skipping tests when i'm testing locally?12:28
paulsher1oodhow can we clean this up? it's frustrating that we are still relying on binaries and huge configure files in 201812:28
juergbicoldtom: to not skip integration tests: ./setup.py test --addopts --integration12:31
juergbitests with missing dependencies are also skipped (e.g., in case you don't have bzr)12:31
coldtomthanks juergbi :)12:31
gitlab-br-botbuildstream: merge request (tpollard/494->master: WIP: Don't pull artifact buildtrees by default) #786 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78612:31
juergbipaulsher1ood: I can't think of a generic way how to solve this. if pre-generated configure files and similar are to be avoided (which would be good, I agree), either all the extra dependencies/steps have to be added or upstream has to be convinced to improve things12:49
juergbiboth require extra work, the former is likely less time consuming in many cases, but the latter would be better long term12:50
juergbi(the former less time consuming and actually feasible for the most part; the latter might often result in a dead end, depending on the project/community)12:51
juergbipotential third approach would be to patch up the build systems even if the patch is not accepted upstream12:51
paulsher1oodflatmush: ^^ ?12:52
flatmushpaulsher1ood: I don't disagree, but it requires someone with the correct understanding of autotools and the time to do it, for me it seems like a very large task12:53
juergbiI agree. especially gcc config is very complex12:54
juergbialthough it is possible that it's mostly compatible with latest autoconf12:54
*** gitlab-br-bot has quit IRC12:54
*** gitlab-br-bot has joined #buildstream12:54
*** gitlab-br-bot has joined #buildstream12:54
*** gitlab-br-bot has quit IRC12:55
*** gitlab-br-bot has joined #buildstream12:55
juergbiat least it's not autoconf 2.13 which firefox still appears to require... (they have a mix of old autoconf project and some new stuff)12:55
*** ctgriffiths has joined #buildstream13:05
gitlab-br-botbuildstream: merge request (tpollard/494->master: WIP: Don't pull artifact buildtrees by default) #786 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78613:06
gitlab-br-botbuildstream: merge request (tpollard/494->master: WIP: Don't pull artifact buildtrees by default) #786 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78613:09
*** lachlan has quit IRC13:12
gitlab-br-botbuildstream: merge request (juerg/git-describe->master: git.py: Make `ref` human readable) #291 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/29113:13
juergbijjardon: added ref-format config key to !29113:17
juergbijonathanmaw: does this addition make sense to you as well?13:17
jonathanmawjuergbi: yep13:17
juergbita13:17
*** CTtpollard is now known as tpollard13:20
tpollardjuergbi: do I have to any anything special for my artifact server to use batch? I updated the checkout of buildstream to the head of master, but it's still catching the exceptions batchreadblobs not implemented13:20
juergbitpollard: hm, your artifact server is running from master and you see these exceptions? or have you only updated the client?13:21
tpollardjuergbi: the artifact server is checked out against master. and my client pushing to it is on a branch based off of master13:22
juergbiBatchReadBlobs is definitely implemented on master. just to be sure, you've restarted the artifact server after updating the checkout?13:24
tpollardI believe so13:25
tpollardwill try again13:25
tpollardyep still happening13:26
tpollardbst-version on the server seems to be correct too13:27
*** lachlan has joined #buildstream13:29
*** finn has joined #buildstream13:30
jmactpollard: Is it practical to wipe the caches on both client and server?13:30
tiagogomesjuergbi with your recent changes on moving the creating of the artifact server to a different place, any chance the tests are more reliable in parallel?13:30
tpollardjmac: I could overnight, the cache that I'm pushing up to it came from a pre batch artifact server13:31
tpollardif that could be part of the issue13:31
tiagogomesThe current runners have two vCPUs, so we should take benefit from that if possible13:31
jmactpollard: I'm just wondering if you have a cached failure13:31
juergbitiagogomes: they might. it fixes parallel test issue with the mac_fixes branch, but it might also fix other existing issues13:32
juergbitiagogomes: last I checked the integration tests didn't work in parallel, though, and I don't expect my changes to help there13:33
juergbihowever, it might not be too difficult to fix them up13:33
*** finn has quit IRC13:33
tiagogomesok, I will do a local run to see how it goes13:34
juergbitiagogomes, tpollard: the exception is on the server side, as I understand it. cached failures can't trigger that13:34
juergbieh, tpollard, jmac13:34
*** ahmed89 has quit IRC13:36
*** finn has joined #buildstream13:42
*** catonano has quit IRC13:45
gitlab-br-botbuildstream: merge request (juerg/git-describe->master: git.py: Make `ref` human readable) #291 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/29113:46
gitlab-br-botbuildstream: issue #683 ("Let's Encrypt certificate needs to be renewed") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/68313:47
gitlab-br-botbuildstream: merge request (valentindavid/silverblue-path->master: Fix outside-of-project check when project path is not canonical.) #832 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83213:50
tiagogomesI had that ^^ on my radar valentind :)13:51
valentindtiagogomes, oh sorry.13:52
tiagogomesno worries, I didn't start any work on it besides reproducing it13:52
valentindtiagogomes, then you can review it.13:52
valentindBut wait for the tests to pass first.13:52
tiagogomesyup, as I wrote the original code13:53
valentindI did that quickly before I go play MTG.13:53
* tiagogomes used to have a good starving for blood deck of Zombies :)13:54
tpollardcheers juergbi, looks like I didn't have -e on the server bst install13:56
*** catonano has joined #buildstream14:01
* Kinnison is having difficulty getting gitlab to load MR pages, is anyone else?14:02
tpollardwfm14:04
* Kinnison blames his notwork then :-)14:05
gitlab-br-botbuildstream: merge request (tpollard/494->master: WIP: Don't pull artifact buildtrees by default) #786 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78614:11
gitlab-br-botbuildstream: merge request (mac_fixes->master: Implement compatibility fixes for MacOSX and WSL Blocks #411 and #412") #726 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/72614:16
*** alatiera_ has joined #buildstream14:19
gitlab-br-botbuildstream: issue #665 ("Buildstream tries to use message without a message handler if linux platform and no user namespace support") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/66514:19
*** catonano has quit IRC14:23
*** catonano has joined #buildstream14:24
WSalmonif i get a failure mid build then bst tells me what make said to make it unhappy but if ./configure etc fail then i have not message just the command so i have to drop in to a shell and run the command my self, is this know? a bug or a feature? its supper anoying14:24
juergbihm, it should normally show the last few log lines independent of which command failed14:25
juergbiand with (l) you can take a look at the whole log14:25
gitlab-br-botbuildstream: merge request (mac_fixes->master: Implement compatibility fixes for MacOSX and WSL Blocks #411 and #412") #726 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/72614:30
gitlab-br-botbuildstream: merge request (valentindavid/silverblue-path->master: Fix outside-of-project check when project path is not canonical.) #832 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83214:30
tpollardcan anyone on ubuntu 18.04 currently run the tests?14:49
tpollard18.04.1 actually14:49
jmacI'm 18.04.1, I'll try14:50
tpollardadding pytest == 3.6.3 to install requires used to work for me the last time I had to run them14:50
tpollardbut that conflicts now14:51
jmacThey appear to be running and from what I can tell I have pytest 3.8.014:51
* tpollard kills .eggs and tries again14:52
tpollardthat looks to have done the trick, jumped to 3.8.114:52
gitlab-br-botbuildstream: merge request (mac_fixes->master: Implement compatibility fixes for MacOSX and WSL Blocks #411 and #412") #726 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/72614:54
WSalmonjuergbi, you are right, however the last thing in the log is a echo of the last command run but it was so long it was shaddowing the error, the (l) option is just what i was after! thanks14:57
gitlab-br-botbuildstream: merge request (jonathan/pickle-yaml->master: WIP: Add a cache of parsed and provenanced yaml) #787 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78715:02
jmactpollard: I get a huge number of RemovedInPytest4Warning messages, which is annoying, but the tests pass15:05
gitlab-br-botbuildstream: issue #411 ("Native bst support on OS X, remote execution only") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/41115:09
gitlab-br-botbuildstream: issue #412 ("Native bst support on Windows w/ WSL, remote execution only") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/41215:10
gitlab-br-botbuildstream: issue #575 ("os.sched_getaffinity() not supported on MacOSX Blocks #411") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/57515:10
gitlab-br-botbuildstream: issue #269 ("buildstream hangs forever if fuse device is not present") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/26915:16
gitlab-br-botbuildstream: merge request (richardmaw/push-failed-build-regression->master: tests: Add regression test for pushing failed builds) #824 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/82415:17
*** finn has quit IRC15:17
jjardonjuergbi: cool! thanks a lot15:18
*** finn has joined #buildstream15:18
gitlab-br-botbuildstream: merge request (tpollard/494->master: WIP: Don't pull artifact buildtrees by default) #786 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78615:19
*** finn has quit IRC15:23
tlater[m]jmac: I've recently started seeing those messages from flycheck... I'll probably want to write a patch to fix these soon.15:27
tlater[m]Interestingly, we don't seem to support python 3.8 at all, because we use features that are going to be deprecated.15:27
juergbitlater[m]: python 3.8 or pytest 3.8?15:28
tlater[m]juergbi: python 3.815:30
tlater[m]Pylint handily informed me that some of the @abc stuff will be deprecated, for example15:30
juergbitlater[m]: ok, but if it's just deprecated, it should still work15:31
tlater[m]juergbi: The warning suggests that it will be moved entirely and not work anymore15:31
juergbiwe should still port things over to the corresponding replacements, of course, as long as that doesn't break Python 3.515:32
jmacCould someone with GNOME wiki permissions allow the user 'JMacArthur' to edit the BuildStream wiki?15:32
juergbitlater[m]: oh, that would be Python breaking backward compatibility? I thought that shouldn't happen...15:32
juergbijmac: sure, just a sec15:32
tlater[m]I agree, I haven't looked into exactly how migration is supposed to happen yet.15:33
juergbijmac: there is already a JimMacArthur in the list. two accounts? shall I still add it?15:33
* tlater[m] will take a look when fixing these annoying new pylint errors15:33
jmacjuergbi: JimMacArthur is me, but I don't have the password or email address for that account15:33
juergbiok15:33
jmacjuergbi: Hence JMacArthur15:33
juergbijmac: done15:34
jmacThanks15:34
*** finn has joined #buildstream15:35
*** finn has quit IRC15:38
gitlab-br-botbuildstream: issue #429 ("BuildStream refuses to cache artifacts with files that have very strict permissions") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/42915:38
gitlab-br-botbuildstream: issue #534 ("Failed builds not pushing artifacts on quit") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/53415:42
gitlab-br-botbuildstream: merge request (richardmaw/push-failed-build-regression->master: tests: Add regression test for pushing failed builds) #824 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/82415:42
*** lachlan has quit IRC15:56
juergbivalentind: commented on !830 but overall looks good to me16:00
*** iker has quit IRC16:06
* tiagogomes doesn't understand why if `path` is given, we don't always link16:17
tiagogomesIs this because the original object could reside in a different filesystem?16:18
tiagogomesAnyway, link_file is a confusing parameter, as there will be always be a link operation occurring16:19
jmacI've written up my reverse engineering of the file import rules at https://wiki.gnome.org/Projects/BuildStream/ImportRules. This is only likely to be of niche interest, but I think it should be part of our developer documentation, if we create such a thing.16:21
juergbitiagogomes: it's mainly a precaution against potential CAS repo corruption. if the input file was not created by CAS, the one that created it might modify it later on, which would corrupt the cache16:23
juergbiit's possible that we could link in more cases, maybe even all, but we'd have to be very carefully check where the files are coming from16:24
juergbiand make sure we don't accidentally introduce issues at the call sites in the future16:24
tiagogomesThat makes sense16:27
gitlab-br-botbuildstream: merge request (valentindavid/silverblue-path->master: Fix outside-of-project check when project path is not canonical.) #832 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/83216:33
*** toscalix has quit IRC16:33
*** catonano has quit IRC16:41
*** lachlan has joined #buildstream16:42
gitlab-br-botbuildstream: issue #22 ("failed to upgrade buildstream at 640a734ec1db923b5") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/2216:42
gitlab-br-botbuildstream: issue #429 ("BuildStream refuses to cache artifacts with files that have very strict permissions") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/42916:53
gitlab-br-botbuildstream: issue #673 ("Silverblue: Specified path 'elements' must not lead outside of the project directory") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/67316:57
gitlab-br-botbuildstream: merge request (valentindavid/silverblue-path->master: Fix outside-of-project check when project path is not canonical.) #832 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/83216:57
*** jonathanmaw has quit IRC17:00
gitlab-br-botbuildstream: issue #673 ("Silverblue: Specified path 'elements' must not lead outside of the project directory") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/67317:00
gitlab-br-botbuildstream: issue #429 ("BuildStream refuses to cache artifacts with files that have very strict permissions") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/42917:02
*** catonano has joined #buildstream17:09
*** lachlan has quit IRC17:36
bochechahow do I set the cache.quota option in buildstream.conf ?18:57
bochechathe doc isn't very clear on this :(18:57
bochechacan I set something like `quota: 10G` ?18:57
bochechaor do I have to use an integer in bytes?18:58
juergbibochecha: K/M/G/T suffices are supported19:03
juergbi*suffixes19:04
*** toscalix has joined #buildstream19:14
bochechajuergbi: thanks19:29
bochechajuergbi: would a MR explaining that be welcome? :)19:29
*** catonano has quit IRC19:54
*** catonano has joined #buildstream19:54
*** xjuan has joined #buildstream22:10
jjardonbochecha: yup22:45
*** xjuan has quit IRC23:08
*** WSalmon has quit IRC23:14
*** bochecha has quit IRC23:15

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!