IRC logs for #buildstream for Thursday, 2018-09-06

*** leopi has joined #buildstream04:34
paulsher1oodmorning folks... https://gitlab.com/BuildStream/website/merge_requests/5706:45
paulsher1oodthat changes Portfolio to About06:45
*** tristan has quit IRC07:07
*** lachlan has quit IRC07:11
*** tristan has joined #buildstream07:24
*** ChanServ sets mode: +o tristan07:24
* tristan realizes he was speaking into a disconnected black hole07:25
tristanpaulsher1ood, SotK fixed the site to be relocatable, which effects how we express internal site links07:25
tristanpaulsher1ood, It's a small fix, [About](about.html) becomes [About]({filename}about.md}), and...07:25
tristan...a change to the page itself, at the top instead of "save_as: about.html", you need "slug: about"07:26
tristanpaulsher1ood, I can do the change myself07:26
tristanAnd thanks, I was really wondering what this portfolio thing was all about, also07:26
tristanAny thoughts about "Updates" > "News" ?07:27
*** rdale has joined #buildstream07:59
*** leopi has quit IRC08:00
paulsher1ood+1 for that08:09
qinusty+108:11
paulsher1oodhmmm... how come my website mr can no longer be merged?08:13
qinustyRequire local rebase perhaps?08:13
paulsher1oodyup08:14
gitlab-br-botbuildstream: merge request (jmac/remote_execution_client->master: WIP: Remote execution client) #626 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/62608:16
*** leopi has joined #buildstream08:19
paulsher1oodfixing now08:20
paulsher1oodshould be ready pls could someone review? https://gitlab.com/BuildStream/website/merge_requests/5708:23
qinustyIs it just me, or does gitlab seem more responsive today?08:23
qinustyPush/pull/fetch wise08:24
tristanpaulsher1ood, Did you get my comments above ?08:24
tristanpaulsher1ood, just some minor points about how we refer to links have changed with SotK's change that allows the website to be relocatable when built with `make html`08:25
* tristan looks at the MR...08:25
tristanA right, thanks qinusty for review, indeed your comment is correct and the only one08:27
qinustyDid we end up deciding on what to do regarding links?08:28
qinustyinline or...08:28
tristanpaulsher1ood, Note that you can now `pip3 install -r requirements.txt` and run `make html`, and view the resulting output/index.html in your browser08:28
* qinusty recommends using pipenv or virtualenv08:28
tristanqinusty, I have a middle ground to propose for that to be honest08:28
qinustyWait!08:29
* qinusty finds what he wanted to suggest08:29
tristanqinusty, I think that (A) The argument to keep links separate at the bottom is mostly about the desire to copy paste parts of the site and duplicate them elsewhere08:29
qinustyhttps://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#links [text][1]08:29
tristanqinusty, And (B) I think that the only place where we would ever want that to happen, is in the articles08:29
qinusty[1]: link08:30
tristanqinusty, that is worse08:30
tristanqinusty, it just adds an *extra* level of ambiguitiy/lookup08:30
qinustyYou think? Feels more natural since the text can be modified in one place, so can the link. But the reference is unique08:30
tristanThen you have to make sure your numbers all match up08:30
qinustyYou don't need to use numbers :D08:30
tristanMeh, I'm ambivalent; I want [Links](inline.html) all the time, but am trying to be understanding of people who want to copy paste for other purposes08:31
tristanWhich I think is *only* relevant for articles08:31
tristanThe "articles" (public service announcements, releases, etc), are pretty much one off writeups08:32
qinustyFair enough. [text][id] .... [id]: link... Seems more like referencing in papers/articles to me :D08:32
tristanIf you are Copy/Pasting the FAQ, instead of referring to the website; you are doing something wrong08:32
tristanYou are duplicating information that is likely to get out of date, the up to date copy should always be linked to, never copied in some location where people can have an opportunity to read something out of date08:33
tristanThat goes for the whole site basically, except for the articles08:33
paulsher1oodtristan: i've been viewing in my browser already08:34
tristanSo what I would prefer; is that we *always* do [link](target.html) everywhere on the site; to make things all inline and easy to maintain08:34
paulsher1oodi'd be surprised if my changes have broken any links08:34
paulsher1ooddo we have a link-checker on the CI?08:34
tristanpaulsher1ood, Links were previously pointing to file:///faq.html, until I changed them to be relative a day ago (probably before you tried viewing them, it was early morning yesterday)08:35
tristanpaulsher1ood, but I screwed it up, and SotK fixed it08:35
tristanpaulsher1ood, unfortunately no :(08:35
paulsher1oodack, and my mr is rebased on top of sotk's fix08:35
tristanSphinx does this like a grown up, pelican on the other hand is very bad about error checking08:35
*** toscalix has joined #buildstream08:35
tristanpaulsher1ood, Did you fix qinusty's comment ?08:35
paulsher1oodno i hadn't seen them08:36
tristantoscalix, We are discussing links again; My understanding is that you want easier copy/paste-ability for publicity stuff08:37
tristantoscalix, So I'd like to propose a middle ground: Always [Link](inline.html) when editing any of the "Site pages"... and always [Link] with the references at the bottom for the Articles08:37
tristantoscalix, My thoughts are that, if people are copying parts of the actual site, they are duplicating something which should be referred to instead; however the articles make sense for press releases and such08:38
tiagogomeso/08:38
tristantoscalix, Also the articles should be one off changes08:38
tristanI.e. articles dont risk getting outdated08:39
qinustyhttps://gitlab.com/BuildStream/website/merge_requests/58 I assume I'm fine to just merge something like this?08:39
tristanBut copy/pasting the FAQ instead of referring to it, is a bad thing08:39
tristantoscalix, anyway; that is the middle ground I'd like to propose for the linking08:39
tristantiagogomes, ?08:39
tristanqinusty, I don't think so, it looks like you removed some comments which were there to assist whoever was going to fill out some content ?08:40
* qinusty reviews his MR08:40
tiagogomesah, {filename} only works if slug was set08:41
* qinusty realises he accidently branched from his other MR08:41
tristantiagogomes, right, SotK's MR changes the pages to set slug: instead of save_as:08:41
tristanI tried it locally, seems to work well08:41
qinustyhttps://gitlab.com/BuildStream/website/merge_requests/58/diffs Fixed tristan :D That was the intention of the MR08:42
tristanThere are again still some hardcoded references to buildstream.build creeping into the FAQ08:42
tristanqinusty, Yeah, definitely :)08:42
tristanqinusty, So if you're going to accidentally merge stuff you didn't intend to, please be more careful !08:43
tristanhehe08:43
* qinusty needs to stop checking out new branches from his MR branches08:43
qinustyI kinda wish checkout used master by default D:08:43
tristanI saw the discussion about the table for the releases, and yeah agree it's a downside to the alchemy theme, we should fix that in some way08:44
tristanqinusty, You can use a git invocation which does that explicitly, I'm pretty sure08:44
tristanqinusty, then it would always be in your ^R search history :)08:44
qinustyYeah `git checkout -b newbranch frombranch`08:45
qinusty:D08:45
qinustyBut since newbranch comes first, I have to type out frombranch every time08:45
tristanyep, and you probably want origin/master juuuust incase08:45
qinustyIndeed08:45
qinustyIt's usually easy to rebase master onto origin/master anyway, since we don't modify history08:46
tristanqinusty, I mean in case you have staged changes there which you forgot to create a branch for (happens to me at times)08:47
qinustyahhhh08:47
qinustyyes08:47
KinnisonI tend to start by `git checkout frombranch` ... check I'm where I thought I wanted to branch from ... `git checkout -b newbranch`08:47
qinustyYeah, I just tried to quickly throw up an MR for the gitignore change :D08:47
* tristan very frequently just checks `git branch`08:47
qinustyand skipped the thought of which branch I was coming from08:47
* qinusty has his branch in his shell prompt08:48
* qinusty should really know08:48
tristanBut then it's true that it's tedious, like... I almost never change my CWD, why "go all the way over there" just to run a command; kindof novice08:48
tristanbut I guess I'm a git novice, I always change my branch first :)08:49
Kinnison:-)08:49
qinustygit is just too powerful08:49
* Kinnison thinks that using git as a novice is usually the best way08:49
qinustyalways more to learn08:49
Kinnisonuse the simple commands08:49
* qinusty never rebased or bisected before working on BuildStream08:49
* Kinnison made the mistake of learning *how git works* (internally) and so thinks of rebase as a simple command08:50
paulsher1oodqinusty: incoming... i fixed a bit more text in response to your comment08:50
* Kinnison wonders if paulsher1ood intends to have a 1 instead of a w08:51
* paulsher1ood fails to parse Kinnison's comment08:54
Kinnisonpaulsher1ood: your nick is your backup nick08:54
qinustytristan, I'm not 100% on `slug` myself, is the convention for {filename} to contain .html?08:54
tiagogomesqinusty {filename} is to specify intra-site links to files in the source content hierarchy instead of files in the generated hierarchy08:59
*** tristan has quit IRC09:00
*** tristan has joined #buildstream09:00
*** ChanServ sets mode: +o tristan09:01
SotKthe thing that fixed {filename} was setting PAGE_URL and PAGE_SAVE_AS in pelicanconf.py, which uses the slug09:02
* tristan lost power :(09:02
Kinnisonoops09:03
Kinnisonat least you found it again09:03
tiagogomesThat's basically the plot for Thor09:03
qinusty:D09:04
tristanyep, checked logs09:04
qinustyIn a gitlab ci script can I run something as `command &` to run in the background?09:04
paulsher1oodKinnison: ack. not intentional09:05
tiagogomesqinusty I don't why you couldn't. But why would you do that09:06
qinustyLink validation :D09:06
qinustyGotta serve the site09:06
qinustythen crawl09:06
paulsher1oodright. so have a staging site, serve there09:07
paulsher1oodany codethings could crib the codethink soln for example09:07
* paulsher1ood gets gently irritated about being a second-class citizen on this project, just as he has been before...09:08
paulsher1oodspeci09:08
paulsher1oodspecifically... i can't merge my own changes to the website. others are critiquing my changes, which is fine... but it wold be easier and less work all round in some cases to just fix and merge, rather than discuss09:10
paulsher1oodthere's a possibility that some folks think it best to 'train/educate' contributors... which would be fine...09:10
paulsher1oodexcept that first-class citizens have already committed stuff that's worse than my patches09:10
paulsher1ood /lecture mode off09:11
gitlab-br-botbuildstream: merge request (richardmaw/subprocess-PWD->master: Ensure PWD is set in process environment) #782 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78209:12
tiagogomesqinusty can you revert https://gitlab.com/BuildStream/website/merge_requests/58? The generated files are in the 'output' directory since yesterday I add pre merge CI :)09:14
toscalixI set up the review process on the website09:15
tiagogomesSo your 'public' directory is stale09:15
qinustyAhhhhh okay tiagogomes, I still had files locally :D09:15
toscalixI added 4 approvers and 3-4 people had merge rights09:15
toscalixthe approvers part was removed yesterday09:15
toscalixI believe. I think we should put it back09:15
toscalixso we can increase the number of people involved in changes09:16
toscalixbetween approvers and maintainers09:16
toscalixI have been adding those who work on the website as approvers and maintainers as needed09:17
qinustyIt makes sense to have someone review changes with content/links etc. Even to just make sure things make sense to more than one individual09:17
toscalixI have no problem with adding paulsher1ood to the group now that he seems interested in contributing to the website09:18
toscalixI take paulsher1ood words as a request, so I add you09:18
toscalixIn my case, for instance, I am perfectly happy with not having merge rights on the website09:19
toscalixI sleep better, with my git, knowlege, without that responsibility09:19
toscalixby the way, the rule I put is having one approver09:20
*** jonathanmaw has joined #buildstream09:20
toscalixI will put it back09:20
toscalixif tiagogomes is ok with it since he is doing the technical work. Maybe you want to do it after a couple of extra days, when the web is settle09:21
toscalixtiagogomes: ? ^09:21
toscalixah, no, 5 approvers. We started with 309:22
qinustyhttps://gitlab.com/BuildStream/website/merge_requests/60 fixes our broken link on rebasing issue. Gitlab CI will now fail if any internal links on our CI leads to 40409:22
qinustyplease review09:22
qinustySee pipeline for example09:22
toscalixpaulsher1ood: is now approver and maintainer09:23
toscalixdoes anybody else want to contribute as approver? It would be of great help09:23
* qinusty isn't sure if he is classed as an approver. But is happy to review/approve MR's09:23
toscalixqinusty: I think you would be a good one09:23
toscalixout of the 5, for instance we have one on vacation, one in an event and one in a different timezone09:24
tiagogomesI am fine with anything. I wouldn't like to not receive a new item on Todos whenever someone sends a MR though09:24
toscalixtiagogomes: I support your idea09:24
tiagogomes*would09:25
tiagogomesqinusty looks good, did you check that if any 404 happens the exit code is not 0?09:25
toscalixqinusty: added09:25
tiagogomespelican was always 0 by default09:25
qinustyYeah, see https://gitlab.com/BuildStream/website/pipelines/29544020 where it broke before I added a sleep09:26
qinustyI needed to sleep for `make serve &` to initialize properly09:26
tiagogomesIt doesn't validate if some uses buildstream.build in the URL, but that's better than nothing :)09:27
*** lachlan has joined #buildstream09:31
tristanpaulsher1ood, I can make you merger there, it's a recently created repo, just need to add you09:32
qinustyyeah tiagogomes, hopefully they will be picked up on MR. Primarily this is to stop someone rebasing and not realising the changes they just dragged in break their links09:34
tristanah someone already did it09:34
tiagogomesqinusty merged. Perhaps we should also have a "make test" target which runs the link checker, so that one can check the links before pushing it to CI09:34
qinustyyeah, I'll add that now :D09:34
tristanIf you all want to get bogged down in approvals, I won't object - I feel that at this stage, most of the changes required are no-brainer one liners; and we're wasting valuable time with approvers09:35
toscalixI think this is a good place to try different approaches adnd see how it goes09:37
toscalixso we can translated them to other areas of the project09:37
toscalixso omre people get involve in reviewing09:37
toscalixmore involved in ....09:37
paulsher1ood:-)09:38
toscalixSo I am willing to sacrifice a little bit of efficiency for those some if we gain traction in reviewing activities09:38
toscalixman I need coffee. I cannot write a single sentence today correctly09:39
tiagogomespaulsher1ood are you going to fix the slug on your MR or you lack time09:39
toscalixbad day for writing contents :-D09:39
paulsher1oodtiagogomes: sorry, busy elsewhere09:40
tiagogomesok09:40
tristanAgain I wont object but; there is also the angle that: Not requiring approvals, does not need to mean people cannot give approvals09:41
tristanOr ask for review09:41
tiagogomesDoes anyone mind if I merge https://gitlab.com/BuildStream/website/merge_requests/57 and then fix the slug afterwards? The branch for that MR is an different repo so I can't check it out easily09:43
tristantiagogomes, I think you should go ahead, I offered to fix it for paulsher1ood this morning too09:43
tiagogomeshm, I can't merge09:44
tristantiagogomes, you have to fetch his repo, make the change, and submit new MR09:46
tristantiagogomes, because it went out of date, rebase UI feature is not possible on an external repo (we don't have rights to modify paulsher1ood's own repo)09:46
toscalixtiagogomes: fixing that09:47
toscalixah, no, need rebase09:47
toscalixcannot fix09:47
tristanexactly09:47
tristantoscalix, Have you given some thought to what I said about links when you walked in ?09:47
qinustyhttps://gitlab.com/BuildStream/website/merge_requests/61 do the job tiagogomes?09:48
toscalixI want to leave it as tiago propose it09:48
toscalixI think it is a nice and clean way to review content09:48
tristantoscalix, I think that we really should not allow copy/paste of the site, *unless* it is for the release announcements or articles, for press releases09:48
qinustyThe slight inconvenience is that this `make devserver` command doesn't seem to work for me09:48
toscalixI bought his reason for using this way09:48
toscalixI remember using it in mediawiki, I think. It was cool09:49
tristanHmmm09:49
tristanOk sure, tiagogomes so what is the policy then exactly ? All links must be at the bottom except for links which link into the internal site ?09:49
toscalixI have used it in two pages only09:49
toscalixso it will take some time until we comply09:49
tristantiagogomes, I.e. [Link]({filename}faq.md) always... and [Link]: http://external-link.com at the bottom always ?09:50
tiagogomestristan that's my personal preference, but I know that we disagree :)09:50
tristanI think it's error prone and harder to maintain yes, but I've said my peace09:51
tiagogomesI need an approval for https://gitlab.com/BuildStream/website/merge_requests/6209:51
tristantiagogomes, but it would be good to make it policy whatever is chosen, an intermingled mess is not a good idea09:51
tristanOk, so we need a new one like this for "Updates" -> "News"09:52
toscalixfor contents, you can assign the MR to me. I will get a notification and review it09:52
* tristan creates09:52
tiagogomesI argue that you will change the content more than to edit the urls of the links. So having the content easier to parse and edit by not adding possibly longs URLs is more important09:52
toscalixfor tech topics, assign it to a different person. You can assign the MR to several people09:52
qinustyAlso toscalix, The thing I was talking about yesterday exists. https://paste.gnome.org/pja13hhzy/b4bsxx/raw09:52
tristantiagogomes, It's fine, actually since the beginning, I raised it because I think it's error prone in general; but the conversation evolved since then, it's not a battle worth fighting for me :)09:53
toscalixqinusty: I see what you mean. Yes, I was aware of these two options09:53
qinustyhttps://gitlab.com/BuildStream/website/merge_requests/61/commits needs approval post rebase09:54
toscalixWhat I was not aware of was the one tiagogomes told me about. I only saw it in mediawiki, confluence... maybe some other I do not remember09:54
tiagogomestristan but most of all, let's be consistent :)09:54
tristantiagogomes, that's why I said about policy09:55
toscalixplease let's not forget about the tables09:55
tristantiagogomes, it's worth going over the whole site and doing it once, so that people fall inline when editing anything09:55
* toscalix stops talking about somebodyelse's job and goes back to his09:55
tristantoscalix, qinusty has a branch for the tables I believe09:55
qinustyHe knows :D09:56
qinustytiagogomes and toscalix disagree on tables though, did we decide on a style?09:56
toscalixqinusty: we disagree with what we have now is nice09:56
toscalixI am sure we can find a format we both agree with.09:57
qinustyOkay, well I'll merge the tables one with my features page branch09:57
qinustyand we can experiment in the future09:57
tiagogomesI really think that makes tables look awful09:58
tiagogomesDo you still have the link?09:58
tristanqinusty, post merge comment: https://gitlab.com/BuildStream/website/merge_requests/61#note_9936553009:58
toscalixtiagogomes: we need a way to clearly differentiate rows and columns. If you do not like borders.... experiment with colours09:58
qinustyIntentional tristan :D09:59
tristanqinusty, ok :)09:59
qinustyThe apostrophes are shifteed09:59
qinustyshifted*09:59
tristanIf the text is all aligned, and at least more space between columns, why is it important to distinguish between columns ?10:00
tristanI think it is certainly true for rows10:00
tristancolor alternation between them could be good10:01
tristanThen again, I'm not religiously opposed to borders even if they are old fashion and look like a spreadsheet10:01
toscalixisn't the install guide assuming the user knows what PyPi is? I wonder if every developer that requires an integration tool is familiar with it10:05
tristantoscalix, We could call it `pip` but, I think the key part here is that at https://buildstream.build/install.html, the PyPI link says "(recommended)"10:11
tristanThe same could be said of a tarball or git, with varying accuracy10:12
tristantiagogomes, any idea why there is a MENUITEM for 'updates.html', but there is no 'updates.md' ?10:14
tristanhard coded pelican stuff ?10:14
tiagogomestristan that page is automatically generated based on the list of articles (ARTICLES_SAVE_AS)10:15
tristantiagogomes, ah gotcha10:15
tristanqinusty, eeek, how come when I do `make test` it tells me pylinkvalidate.py is not there, and it isn't ?10:15
tristanqinusty, how did it pass the CI if you forgot to `git add` it ?10:16
toscalixI think that the less knowledge of python we assume the developer has, the wider audience we are reaching, specially with developers coming from other languages10:16
toscalixyes, the same applies to git... sadly10:17
tiagogomestristan requirements.txt10:17
tristantoscalix, the problem with saying "pip" is that, you also use "pip" to install from a tarball or from git10:17
tristantiagogomes, ah I see, I notice now the Makefile doesnt prefix it with $(BASEDIR)10:18
tiagogomeshttps://gitlab.com/BuildStream/website/merge_requests/63/10:18
toscalixmaybe a clarification or a link to a resource that explains that would be enough10:18
toscalixit was a general comment. I do not know the solution10:18
tristantoscalix, yeah I understand, note that there will also be a badge for this provided by PyPI itself, not sure of the status on that yet10:20
tristanbadge was broken last time around saying "Invalid json response", but normally it links to BuildStream page at PyPI and shows the latest release published there10:21
tristanhttps://gitlab.com/BuildStream/website/merge_requests/64 <-- changes "Updates" -> "News", I grepped for "updates" in the content and didnt find any links to that page besides the menubar (and ran the test)10:22
qinustytristan pip install -r requirements.txt10:24
tristanqinusty, yup, tiagogomes told me :)10:42
qinustyspotted after scrolling down :D I jumped to the ping10:43
tristanqinusty, Is there any reason BTW, that `make test` link checking requires running the server in the background ?10:43
tristanqinusty, couldn't it just instpect the output/ directory, and implicitly depend on the html target ?10:43
qinustyThe link checker requires it to be served.10:43
tristanMeh10:44
tristanOk10:44
* qinusty shrugs10:44
tristanobnoxious when running locally, unimportant in CI10:44
qinustyIdeally10:44
qinustymake devserver would work10:44
qinustyaand I could have make test do `make devserver \n make test \n make stopserver`10:44
qinustybut noooooo10:44
tristanheh10:46
*** finn has quit IRC10:52
tiagogomeshttps://gitlab.com/BuildStream/website/merge_requests/6310:53
*** finn has joined #buildstream10:55
toscalixqinusty: could not merge your MR10:56
tristantiagogomes, haha, Kill the TOCs !10:56
qinustyYup, it needs rebasing and I haven't pushed my latest rebase toscalix10:56
toscalixsince we are adding content to the same page, can you review mine so I merge it first?10:56
qinustySure10:56
tristantiagogomes, I personally like it, but I feel that we should split up the source install into three pages (install dependencies, install, post install setup on different pages)10:56
qinustyIn general, approve and let someone merge. I wouldn't merge incase someone has local changes they'd like to push to their MR10:57
toscalixtristan: that is a terrible idea10:58
toscalixevery time you split a page, you loose most of the visitors10:58
toscalixbecause they have to come back and forth since you are creating a tree instead of a single path10:58
toscalixso if the instructions are a single path... fine11:00
toscalixbut no back and forth11:01
qinustyBut then again, having one massive page makes people want to leave11:01
qinustytoo much text on the screen11:01
toscalixqinusty: depends in if you have to consume it all or not11:01
paulsher1oodchange font style. use less words :-)11:01
toscalixthat is your guess11:01
paulsher1oods/style/size/11:01
toscalixI have been in projects in which having different pages for instructions ended up in loosing users11:02
paulsher1ood+1 for killing ToCs11:02
qinusty+111:02
SotK+111:02
toscalixI am too used to listening to opinions that are not backed up by data in this regard. As a starting point, make the most conservative guess, with a reduced number of pages11:02
qinustyHonestly, if they're going to leave over having to click a link. They really didn't want to open a terminal and follow install instructions in the first place11:02
toscalixthen check the data and plit up11:03
tristanWell, with the +1's for killing the tocs, I will just point out: https://gitlab.com/BuildStream/website/merge_requests/63#note_9938605211:03
tristanFor your collective consideration11:03
SotKalso +1 for keeping the whole install path on one page, unless its crazy complicated11:03
tristanSotK, https://buildstream.build/install.html11:04
tristanProblem is we provide per-distro instructions to make installing dependencies easier for people (just copy paste), that part grows11:04
toscalixwe had in the design https://gitlab.com/BuildStream/nosoftware/alignment/blob/master/content_design/BuildStream_Content_Structure_critical_path.pdf11:04
tristanThen again; It could be alright to just keep the ToC on that page11:05
toscalixwe analise data and then decide to modifiy it11:05
toscalixthat was my original approach11:05
toscalixsadly I was not able to convince that we should stick to it.11:06
tristanIf we're going to remove ToCs, we still need easy navigation, and consumable parts; otherwise we should keep ToCs at least where they help11:06
toscalixbut the principle remains. Short and clearly defined critical path, data anlysis and then... guess again11:07
toscalixanyway....11:07
tristantoscalix, The fact that you did this design is still valuable, even if it is not followed in practice. The overhead of doing all of this was clearly too much however for people to contribute meaningfully in the design phase.11:07
tristanThat is unfortunate, but we have time constraints, rather restraints in resourcing our time to contribute to this process11:08
*** lachlan has quit IRC11:08
toscalixI appreciate your words but I disagree with that view. You have in your team somebody that has done this several times and you decided to trust your ideas above his experience11:08
toscalixbut no, the design is correct to start with11:09
toscalixbased on my previous experience. I am fine with challenging it11:09
SotKtristan: I feel like I'd have something like a page for each type of source install, each containing the full instructions for that install11:09
toscalixbut not based on ..... gut feelings11:09
tristantoscalix, There is one single point that you got wrong - please don't conflate that too much. Users do not download BuildStream, the design needs to fit the actual recommendations, and that is all.11:09
*** alatiera_ has joined #buildstream11:10
toscalixbut again, all this isn't important now. We need to finish the content and then go out there and make noise11:10
tristanSotK, it's duplicating a lot of information, though11:10
toscalixwith data, we will find out what to do next11:10
toscalixI think we could have started in a much better position that we will taking advantage of previous "mistakes"11:10
toscalixthat's all11:11
SotKtristan: yeah that's the downside I guess, though I expect you could use a custom page template to remove duplication in the source11:11
*** jonathanmaw_ has joined #buildstream11:12
*** jonathanmaw has quit IRC11:13
SotK(you can add arbitrary metadata to the top of pelican markdown files, so defining "pre-install-instructions" and "post-install-instructions" pointing to the relevant source files, and use those in a custom template for that type of page to inline the rendered content from that source file11:13
SotK)11:13
*** finn has quit IRC11:14
*** abderrahim has quit IRC11:18
*** abderrahim has joined #buildstream11:19
*** finn has joined #buildstream11:19
tristanSotK, indeed, an "include" style of page generation could work well here11:19
qinustyreviewed toscalix, a few of these are completely based off how I interpret the text. But would accept any further review on my comments from people.11:20
tristanThis way we have all of the relevant information for the selected install method in one place, sacrificing the ability to link specifically to pre/post steps (but that seems unneeded in this case)11:20
qinustyGoing for lunch, will check back after.11:20
* tristan comments on the ToC removing MR with a summary of SotK's suggested changes: https://gitlab.com/BuildStream/website/merge_requests/63#note_9939189311:25
*** lachlan has joined #buildstream11:26
tiagogomesSome pages should still have a ToC, like  the FAQ page, so I didn't remove all the ToCs for now but just the ones which were visibly wrong to have11:29
tiagogomesIf source_install is split, then probably shouldn't have one. But right now it is a single page (and I actually prefer that)11:31
tristantiagogomes, sorry then I misunderstood what https://gitlab.com/BuildStream/website/merge_requests/63/diffs#4cd8c938f4dfb9b2579dcfaf97c623df6ca28eb8_44_44 does11:36
tristantiagogomes, I thought that means we're removing the extension, but it just means we're not "titling the tocs" ?11:36
* tiagogomes lazily:11:37
tiagogomes44f8a83 (HEAD -> tiagogomes/toc-improvements, origin/tiagogomes/toc-improvements) faq: improve table of contents11:37
tiagogomes6fcbdca Remove TOC from about and community pages11:37
tiagogomes2c102d9 Don't set a title for the table of contents11:37
tristantiagogomes, you prefer that it is all on one page over SotK's include idea ?11:37
tristanI'm a bit ambivalent, but think it would be nice to provide a page that has less information, more targeted at what the user chose11:38
tiagogomesI prefer to have less pages as possible. But looking at install, there's a direct link from pypi, tarball and git, so there wouldn't be an extra step to get there11:42
tiagogomesSo I am fine with it. But then we should also split package_install.html no?11:43
tiagogomeshttps://flatpak.org/setup/ has a different page for each distro11:43
tristantiagogomes, splitting up package install could be good too, I'm surprised there is no command line to copy/paste for Arch users :-S11:46
tristanjjardon, would you like to correct that at https://buildstream.build/package_install.html#arch ?11:46
tiagogomesHe is on US11:49
SotKyeah I'd split up package install too11:49
SotKits a bit intimidating to see a page with a million sections when what you want are quick copy/paste instructions11:50
SotKI *think* links to anchors in the included pages will work fine (though it'd have to be something like `{filename}install/pypi.md#pre-instruction-foo` in the source I expect)11:51
tristanok yeah he's in LAS11:54
tristanSotK, except I can't seem to find a use case for that off hand, but nice to know it might be possible11:55
*** tristan has quit IRC12:02
toscalixhi, since we have today at 17:00 BST a talk in LAS where bst will be named so people might look on our website it would be smart to avoid risky changes as we approach that time12:05
paulsher1oodwhat's LAS?12:05
persiaLibre Application Summit12:05
paulsher1oodah, ok12:06
tiagogomesThe buildstream website doesn't pop up when searching on google12:09
toscalixbuildstream.com will be hard to beat12:10
toscalixwe need to define the keywords on the front page12:10
toscalixin order to elaborate a text that help us in that regard12:11
persiaAlso takes time.  Age of sites is important in many ranking algorithms.12:11
*** bochecha has joined #buildstream12:12
*** lachlan has quit IRC12:20
toscalixqinusty: the content design doc make reference to the following12:29
toscalixthere are pages that, with the next release, will need to be "moved" because new pages will replace them12:29
toscalixwhen you have only a couple of those cases, it is not big deal, but when the number of pages grow, you need a strategy on you will manage the links to those pages12:30
toscalixthe risks is not just to break the links on your side,12:30
toscalixbut to break first class references from external sites12:31
SotKhm, what pages will be moved?12:31
toscalixwe need a strategy for the release announcement and the feature page for now, which are release specific12:31
toscalixeach tool/website tool manage links differently12:32
toscalixso usually you manage this by setting some fixed links in your dns12:32
toscalixso that was my original idea12:32
toscalixtiagogomes: confirmed that this is not possible with gitlab pages12:32
toscalixI just told qinustyin the MR to avoid using specific version numbers in the page titles12:33
toscalixI would like to have time to think about how will we do it12:33
toscalixwell.... propose it12:34
toscalixso we call the 1.2 feature page just feature page and the 1.2 release announc. release-announcement12:35
toscalixfor now12:35
*** bochecha has quit IRC12:38
SotKany specific reason to avoid the version number in the page names/links?12:38
SotKjust having a "1.2 feature page" or similar from the beginning feels like the easiest future-proof option to me12:39
toscalixthere are already several pages pointing at feature page, without number12:50
toscalixstatic pages that will always point to the latest version12:50
toscalixof the feature page12:50
toscalixif you version the title.... you need to change them every time12:50
toscalixon the contrary, we might find a way that, when we move the pages in the future, we can redirect. We can take the opposite approach, but now we have only two pages to move so I guess that the first strategy will be cheaper12:52
qinustybut the current feature page is feature_page.md?12:52
toscalixso it is good12:52
toscalixthat is correct. With the next release, we will substitu it for the new feature page and put the 1.2 somewhere else12:53
toscalixeither we change the name, or add it into a different folder and use categories...12:53
toscalixI really do not know how to handle group of pages with gitlab12:53
toscalixI assume we can make use of the category field12:54
toscalixI cannot remember now but I added a category and tag to the release announcement12:54
toscalixI do not know how we will handle it. But we will need to12:55
qinustytoscalix I disagree with this process. We should have feature_page_1.2.md. We can give it the slug feature_page. Which will give it the url feature_page...12:55
toscalixthe original idea was to have announcment.buildstream.build12:55
toscalixfor instance12:55
qinustyRenaming the feature_page.md file every release just means moving the file in git every time...12:55
*** bochecha has joined #buildstream12:56
toscalixall I am saying is that I had a plan. It doesn work. We need a new plan. We do not have it. So let's try to avoid creating overhead until we do. I hope you guys put some technical solutions on the table and see what is best12:57
qinustymerged toscalix12:57
toscalixqinusty: thanks12:58
*** phildawson has quit IRC12:59
*** phildawson has joined #buildstream12:59
qinustyPlease review https://gitlab.com/BuildStream/website/merge_requests/55 toscalix :D13:01
*** bochecha has quit IRC13:02
qinustyWe can resolve any styling issues for the tables in a separate issue.13:02
*** bochecha has joined #buildstream13:02
*** bochecha has joined #buildstream13:03
qinustyI also raised https://gitlab.com/BuildStream/website/issues/21 for people to discuss the whole Install/Download thing tiagogomes, toscalix, tristan, valentind13:04
*** bochecha has quit IRC13:04
*** bochecha has joined #buildstream13:04
*** bochecha has quit IRC13:09
*** bochecha has joined #buildstream13:09
*** bochecha has quit IRC13:11
*** bochecha has joined #buildstream13:12
*** bochecha has joined #buildstream13:13
tiagogomestoscalix what should I do next for the wesite?13:29
qinustyCan you review https://gitlab.com/BuildStream/website/merge_requests/55 if you're free tiagogomes13:30
*** bochecha has quit IRC13:31
*** bochecha has joined #buildstream13:31
tiagogomesqinusty could you remove the change added to the css for the tables from that MR?13:31
qinustyI /can/, but my thoughts were that we'd add it then modify the style as appropriate based on further discussion13:32
tiagogomesAlso looking at https://buildstream.gitlab.io/-/website/-/jobs/95309553/artifacts/output/feature.html, you want to left justify the 2nd column, and right or left justify the 1st column13:32
tiagogomesWhat "What's new software components table:" supposed to be?13:33
qinustySplitting it into a new commit.13:34
qinustytable css that is13:34
qinustyNew software components is not part of the diff. It was there before I started my changes. toscalix, drew up the structure13:35
qinustyI couldn't populate it due to not understanding the desired contents13:35
tiagogomesRight, but I still do wonder13:35
qinustyAlso, the justify will happen in our css13:36
qinustyColumn headers should be left justified.13:36
qinustycorrect?13:36
qinustysorry, table rows*13:36
qinustynot columns headers13:36
qinustyJustifying individual columns is where it gets tricky with markdown tables I think. We don't have that much control over pelican13:37
tiagogomesis this not possible with css?13:39
qinustyNot with how pelican generates the tables afaik13:39
tiagogomesI wouldn't even use tables there. Prose would be better13:40
*** bochecha has quit IRC13:40
tiagogomestd:nth-child(2)13:40
qinustyIf you look at the html, we have <th> and <td> to work with for styling13:40
*** bochecha has joined #buildstream13:41
* qinusty shrugs, web stuff13:41
qinustyif it can be done13:41
qinustyfeel free to push to my css MR when I make it13:41
*** bochecha has quit IRC13:42
*** alatiera_ has quit IRC13:42
*** bochecha has joined #buildstream13:42
qinustyhttps://gitlab.com/BuildStream/website/merge_requests/6613:43
*** alatiera_ has joined #buildstream13:43
*** bochecha has quit IRC13:44
toscalixtiagogomes: the ticket corresponding to that page provides some hints, if they are not in the template itself https://gitlab.com/BuildStream/website/issues/113:47
toscalixI put 3 tables to cover all cases. We might end up having only two13:47
toscalixone table is for the features. Each one of them would be explained in more detaile in buildstream in detail, with references to the tech docu13:48
toscalixthe second table make reference to software components13:48
toscalixthis is the table that provides info about software and versions that the tool brings or requires that I need to know in order to avoid dependency problems, or things like that13:49
toscalixI believe for instance that we have quite a very hard requirement on the python version13:49
toscalixwhich for people working on corporate environments is very important to know in advance. They might be more13:50
toscalixthe third table is more questionable. Since we have a plugin oriented strategy, my guess was that we might need to consider information that does not fit in the previous two tables13:51
toscalixit is important to understand that we will try to keep the first two tables, at least, in the coming features pages13:51
toscalixadding a row for the following release13:51
toscalixthe first table will provide a sense of how features evolve and the second table is very valuable for anybody in need to manage the installation, but specially the maintenance, of the installations13:53
toscalixlet's keep in mind that we aim to develop a tool for those who care about long term maintenance of their apps, so having a clear view of the dependencies that our tool carry on is essential13:54
toscalixI am usure how the third table is going to work. Maybe when I see it completed, we agree that it is better to remove it and add the content as paragraph13:54
toscalixI am confident that the first two tables will be valuable overtime13:55
*** lachlan has joined #buildstream13:56
gitlab-br-botbuildstream: merge request (jmac/remote_execution_client->master: WIP: Remote execution client) #626 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/62613:57
tiagogomesI don't think we need a table for the software dependencies, and if we indeed needed one for the package creator, it shouldn't be there13:57
tiagogomesNew features in software project are typically described in a list of items, or just prose, but never in a table13:57
toscalixtiagogomes: if you check the template you will see that the three main features will have a short paragraph at the beginning of the table13:58
toscalixthe features will be described in BuildStream in detail13:59
toscalixthe table is to name them, have a sens e of "per release" and add a short comment about what is new on it13:59
toscalixso I obviously agree with your view13:59
toscalixthat there should not be description in tables13:59
toscalixbut again, there are 5 maintainers, I believe and more with approve rights. And since somebody disagree in every single page paragraph.... feel free to implement what you think is right, convince an approver and maintainer... and problem solved. We will deal with the collage effect in the far future14:03
toscalixah, I need to fill out what the 3 main features are, based on what it is in the release announcement14:04
gitlab-br-botbuildstream: issue #631 ("Remote-execution user configuration (technical debt)") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/63114:11
gitlab-br-botbuildstream: issue #632 ("CAS server: Implement BatchReadBlobs") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/63214:13
gitlab-br-botbuildstream: merge request (juerg/cas-batch->master: WIP: _artifactcache/casserver.py: Implement BatchReadBlobs) #785 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/78514:14
*** lachlan has quit IRC14:15
*** tiagogomes has quit IRC14:16
*** tiagogomes has joined #buildstream14:16
*** lachlan has joined #buildstream14:33
*** lachlan has quit IRC14:39
* qinusty hates pylint/pytest14:45
qinustyWhy is there /always/ something wrong with it, primarily with linting and consistency between versions.14:46
*** lachlan has joined #buildstream14:46
*** jonathanmaw has joined #buildstream14:51
*** jonathanmaw_ has quit IRC14:52
gitlab-br-botbuildstream: merge request (Qinusty/message-helpers->master: Continued work on improving BuildStream messaging API) #670 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/67014:53
toscalixtiagogomes: did you change the name of the page from updates to news ?15:19
toscalixcan it be turned back, please?15:19
toscalix1.- we do not change names15:20
toscalix2.- that link will also be for the blog, which is no news15:20
toscalixI chose that name base of the codethink page, which I think is an improvement15:20
toscalixand now there are links to it15:20
toscalixI would reaaaaally appreciate if we stop chenging names of pages15:21
toscalixadding pages, spliting pages, removing pages....at this point so we do not have to go back and fix what we did15:21
toscalixwe can do that in a second round of effort in the near future15:21
toscalixtiagogomes: I am not saying you did it. I do not know who. I do not care honestly. I just want it back, if possible15:23
tiagogomesI didn't change the name of that page to news. Though it was discussed here and agreed that it would preferable.15:28
*** lachlan has quit IRC15:28
toscalixonce again, people does not cosider the already done work and refuse to read the design document15:28
toscalixthat page will have news.... and blog posts15:29
tiagogomesRegarding your last point, I wished when I started working on some feature / bug fix master was frozen so I never had to rebase my changes. However is not how collaborative work is done with git15:29
paulsher1oodtoscalix: we discussed the change to news earlier today and got multiple +1s15:29
paulsher1oodit's a better word than updates15:30
toscalixdid you guys consider that there will be blog posts there?15:30
toscalixjust like in the codethink page?15:30
paulsher1oodblog posts can be considered news15:30
toscalixdisagree completely..... let's move on15:30
paulsher1ood:)15:30
paulsher1oodtristan asked updates > news, qinusty and i  were +115:32
tiagogomesIf there were both 'news' and 'updates' links, I'd be confused15:32
qinustyUpdates can be software updates.15:32
qinustyNews is news15:32
toscalixpaulsher1ood: did you guys paid attention to current links?15:34
toscalixnot sure there is any pointing there15:34
* qinusty is confused at why this is an issue.15:35
qinustyIf there are links, change them. If not, *shrug*. Renaming a page is not a massive issue at this stage. We're talking < 1m of effort. Changing at a later date may break public links from articles which we cannot change15:36
*** iker has joined #buildstream15:55
*** lachlan has joined #buildstream16:00
*** iker has quit IRC16:00
*** lachlan has quit IRC16:03
*** lachlan has joined #buildstream16:09
mablanchAny reason why running 'python setup.py test' would randomly stop at some point of the execution with 'Aborted'?16:18
tiagogomesat a random test?16:23
gitlab-br-botbuildstream: merge request (jmac/remote_execution_client->master: WIP: Remote execution client) #626 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/62616:25
WSalmonwho looks after https://gnome7.codethink.co.uk/tarballs/ and who build the arch image?16:27
WSalmon*alphine not arch..16:29
tpollarddoes bst pull --deps (all) also bring in runtime dependencies?16:34
mablanchtiagogomes, As it seems yes...16:36
tpollardI'm trying to workout why a local artifact cache from bst build (when pulling from a remote) is smaller than when doing bst pull --deps all16:40
tpollardif it's bringing in runtimes then I guess it makes sense16:40
tiagogomesWSalmon I think you should ask on #freedesktop-sdk on freenode16:41
tiagogomesmablanch weird16:41
tiagogomestpollard could it be because of the artifacts/extract directory16:45
tpollardhmm16:54
*** phildawson has quit IRC17:01
*** lachlan has quit IRC17:07
gitlab-br-botbuildstream: merge request (jmac/remote_execution_client->master: WIP: Remote execution client) #626 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/62617:19
*** jonathanmaw has quit IRC17:22
*** phildawson has joined #buildstream18:13
*** phildawson has quit IRC18:17
*** toscalix has quit IRC18:23
*** bochecha has joined #buildstream19:20
*** alatiera_ has quit IRC20:02
*** alatiera_ has joined #buildstream20:02
*** benschubert has quit IRC20:18
*** leopi has quit IRC20:56
*** tristan has joined #buildstream21:29
*** bochecha has quit IRC21:37
*** alatiera_ has quit IRC21:38
*** alatiera_ has joined #buildstream21:38
*** Prince781 has joined #buildstream22:16
*** alatiera_ has quit IRC22:25
*** tristan has quit IRC22:31
*** rdale has quit IRC23:00
*** Prince781 has quit IRC23:39

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!