| *** bochecha has quit IRC | 00:21 | |
| *** mohan43u has quit IRC | 01:07 | |
| *** mohan43u has joined #buildstream | 01:10 | |
| *** leopi has joined #buildstream | 02:35 | |
| *** leopi has quit IRC | 03:29 | |
| *** leopi has joined #buildstream | 03:29 | |
| *** tristan has quit IRC | 05:41 | |
| *** tristan has joined #buildstream | 05:59 | |
| *** ChanServ sets mode: +o tristan | 06:19 | |
| gitlab-br-bot | buildstream: merge request (tristan/notifications->master: _frontend/app.py: Notify session completions) #672 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/672 | 06:20 |
|---|---|---|
| gitlab-br-bot | buildstream: issue #538 ("ostree mirror fallback breaks assertion") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/538 | 06:22 |
| *** solid_black has joined #buildstream | 08:14 | |
| *** rdale has joined #buildstream | 08:16 | |
| qinusty | Anyone fancy lending a set of eyes to double check I'm not missing something simple? I've got some unexpected behaviour on a test of mine. https://paste.gnome.org/pj28v1ql2#line-30 is the test output, https://gitlab.com/BuildStream/buildstream/merge_requests/662/diffs are my changes. The test runs `bst fetch delaymock.bst` which uses the plugin in | 08:21 |
| qinusty | delayed.py , however the output is indicating the use of consistencybug.py... | 08:21 |
| tristan | omg | 08:23 |
| tristan | qinusty, I think that implementing "cli_run_in_process()" is quite a task | 08:24 |
| * qinusty realises that it's quite hacked together, but can't understand where consistencybug.py is coming from | 08:24 | |
| tristan | qinusty, I was thinking of giving that to tiagogomes after the release, i.e. the task of making it possible to test interactive aspects of BuildStream | 08:25 |
| qinusty | Ah, I'd just fixed a regression so attempted to write a test for it | 08:25 |
| tristan | qinusty, I can say right away, that the lack of __init__.py files leading up to the test plugin you added can be confusing to pytest | 08:26 |
| qinusty | Also, only fails on CI | 08:26 |
| qinusty | not locally | 08:26 |
| qinusty | and only when CI runs a sequence of tests, not when configured to run the single test | 08:27 |
| tristan | does it pass locally, when you run all the tests in one batch ? | 08:27 |
| tristan | or only when you run *that* test ? | 08:27 |
| tristan | right | 08:28 |
| qinusty | I think so, I can't exactly recall because I did it yesterday. But I'm fairly sure it did. | 08:28 |
| tristan | What is happening is pytest is going to import everything, and then start running tests | 08:28 |
| tristan | What often happens if you fail to include __init__.py files in all the directories leading up to a python file in the tests directory, is a cryptic import error | 08:29 |
| tristan | in this case, it looks like something very weird is happening, and plausibly effected by the subprocessing of the test | 08:30 |
| tristan | qinusty, you might have better luck if you used the __main__.py entry point I initially added to allow docs to build properly | 08:31 |
| gitlab-br-bot | buildstream: merge request (jjardon/pyproject->master: Some minor setuptools improvements) #639 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/639 | 08:31 |
| tristan | instead of forking the process and running it in a harness | 08:31 |
| tristan | then of course, coverage.py might need extending in order to collect the resulting coverage reports (and ensure they are happening) | 08:32 |
| jjardon | Hi, Is there a way to execute buildstream as my user (so it can download stuff from restricted git repos). Or if not, is there any way to configure it to use specific credentials? | 08:34 |
| tristan | qinusty, it's worth trying running the test through subprocess instead of multiprocessing anyway; using an invocation like `python3 -m buildstream [args...]` | 08:34 |
| tristan | qinusty, it can be informative to future test harness improvements | 08:35 |
| tristan | jjardon, credentials should be out of band and not involve BuildStream config | 08:36 |
| tristan | jjardon, for instance for a git repo, it should work so long as you have the ssh key | 08:36 |
| tristan | of course, it is a bad idea to add private repos to public projects, you will need to share private keys with every user that needs to build the project | 08:37 |
| jjardon | tristan: I have the ssh key and buildstream refuses to clone | 08:37 |
| jjardon | tristan: Its not a public project; and that's not needed, everyone in the project have ssh access to that repo | 08:38 |
| tristan | jjardon, maybe you are not using the ssh:// url format ? | 08:38 |
| jjardon | tristan: /o\ maybe let me check | 08:38 |
| tristan | jjardon, I'm not sure about all the details of how the auth works with https:// | 08:38 |
| tristan | jjardon, oh - that or you need to have your ssh-agent activated first | 08:39 |
| tristan | jjardon, if your ssh key also requires a password, you would need the agent running (that happens fairly transparently on a lot of mainstream distros nowadays) | 08:40 |
| tristan | can be tied into login | 08:40 |
| *** finn has joined #buildstream | 08:42 | |
| jjardon | tristan: nah, I was using the https URL instead the SSH one, sorry for the noise! | 08:46 |
| *** jonathanmaw has joined #buildstream | 08:50 | |
| qinusty | Is there any way to easily clear all the .pyc files? I keep getting HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules.... | 08:51 |
| gitlab-br-bot | buildstream: issue #385 ("Should notify when build fails") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/385 | 08:52 |
| gitlab-br-bot | buildstream: merge request (tristan/notifications->master: _frontend/app.py: Notify session completions) #672 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/672 | 08:52 |
| jjardon | tristan: btw, any chance we can progress on https://gitlab.com/BuildStream/buildstream/merge_requests/661 ? I think is a good enough stop-gap solution for now | 08:52 |
| gitlab-br-bot | buildstream: merge request (Qinusty/531-fetch-retries-on-terminate->master: WIP: Prevent jobs retrying on terminate) #662 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/662 | 09:01 |
| tristan | jjardon, oh... I reviewed an MR from laurence for that purpose I think | 09:02 |
| tristan | it's not the same ? | 09:02 |
| tristan | jjardon, ok so... I also want this solved, yours looks a bit different... but really along the same lines, lemme find the other | 09:04 |
| tristan | I'll comment on 657, where you also commented | 09:05 |
| *** tpollard has joined #buildstream | 09:06 | |
| WSalmon | tristan if you get a chance it would be great if you could confirm you are happy with my tweak to https://gitlab.com/BuildStream/buildstream/merge_requests/621 so we can get it merged out the way :) | 09:08 |
| tiagogomes | qinusty `find . -name '*pyc' -delete` | 09:13 |
| gitlab-br-bot | buildstream: merge request (jmac/remote_execution_client->master: WIP: Remote execution client) #626 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/626 | 09:14 |
| tristan | jjardon, https://gitlab.com/BuildStream/buildstream/merge_requests/657#note_95089021 | 09:15 |
| tristan | WSalmon, I just added one comment there... but now I realize this is a review of a *backport* (?!) | 09:19 |
| tristan | WSalmon, these changes we made certainly need to be made on master as well | 09:19 |
| tristan | WSalmon, I'm very curious how it could have possibly passed CI with `reason = "foo"` instead of `reason="foo"`, it would seem that is the first time we have a keyword argument specified with spaces | 09:20 |
| WSalmon | tristan, well we already merged version 1 of this in to master so i was gona wait for you to be happy with this and then update !628 to match what we come up with in !621 Its not how it should be done but i thought i was following your lead | 09:21 |
| WSalmon | see !580 | 09:22 |
| *** phildawson has quit IRC | 09:22 | |
| WSalmon | RE: linting oh yes my bad, will fix | 09:23 |
| WSalmon | also like you said about the CI how odd | 09:23 |
| tristan | WSalmon, ok, so to expedite this, please fix that final comment (regarding coding style), apply that to bst-1.2, and make sure to port the changes back to master | 09:23 |
| WSalmon | yep | 09:24 |
| tristan | WSalmon, don't wait for review to apply the changes to master | 09:24 |
| WSalmon | ok | 09:24 |
| tristan | Maybe pylint/pep8 doesnt lint for kwargs like that, although they do get very picky about variable assignments requiring one space on either side, and no spaces after commas in literal lists | 09:25 |
| tristan | so it is surprising :-S | 09:25 |
| * tristan would prefer a single space after every comma in a literal list, but whatever, consistency is key :) | 09:25 | |
| gitlab-br-bot | buildstream: merge request (willsalmon/580-backport->bst-1.2: Add warning to git track if track and ref are not present) #621 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/621 | 09:29 |
| WSalmon | tristan, ^ | 09:31 |
| tristan | WSalmon, yup, please go ahead and pull the trigger on these :) | 09:33 |
| gitlab-br-bot | buildstream: issue #385 ("Should notify when build fails") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/385 | 09:35 |
| tpollard | Does anyone have time to get this approve please? https://gitlab.com/BuildStream/buildstream/merge_requests/564/ | 09:36 |
| gitlab-br-bot | buildstream: merge request (jjardon/doc_releases->master: Add section about current releases) #661 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/661 | 09:36 |
| gitlab-br-bot | buildstream: merge request (jjardon/doc_releases->master: Add section about current releases) #661 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/661 | 09:37 |
| gitlab-br-bot | buildstream: merge request (jjardon/license->master: docs: Add license: Creative Commons Attribution 4.0 International License) #336 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/336 | 09:39 |
| tiagogomes | Erm. Provenence for project.conf shows the wrong file: Error loading project: /home/tiagogomes/repos/buildstream/buildstream/data/projectconfig.yaml [line 8 column 0]: Dictionary did not contain expected key 'name' | 09:42 |
| tristan | jmac, do you remember the issue number or title that tiagogomes is talking about ^^^^^ ? | 09:43 |
| tiagogomes | Could this be a regression of the junctions work or it as always like this | 09:43 |
| jmac | Argh | 09:43 |
| tristan | As I recall, this happens whenever we expect something that is not found anywhere | 09:44 |
| tristan | Or similar | 09:44 |
| jmac | Actually I'm not sure I'm familiar with this one. I was thinking of the yaml integer conversion issue, but it's not that | 09:44 |
| gitlab-br-bot | buildstream: merge request (jjardon/license->master: docs: Add license: Creative Commons Attribution 4.0 International License) #336 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/336 | 09:44 |
| tristan | jmac, ok, I was pretty sure you raised the issue initially | 09:44 |
| tristan | I might be misremembering | 09:45 |
| jmac | Looking now | 09:45 |
| jmac | Aha, yes | 09:45 |
| jmac | https://gitlab.com/BuildStream/buildstream/issues/253 | 09:45 |
| gitlab-br-bot | buildstream: merge request (jjardon/license->master: docs: Add license: Creative Commons Attribution 4.0 International License) #336 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/336 | 09:46 |
| jmac | I'm not familiar with the actual fix unfortunately | 09:46 |
| tristan | Ah, closed ! | 09:49 |
| tristan | tiagogomes, valentind ... want to please talk about issue 253 and reopen if necessary ? | 09:50 |
| gitlab-br-bot | buildstream: merge request (willsalmon/APIFix->master: Updating the no track or ref fix to match the buildstream style) #628 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/628 | 09:50 |
| * tristan has to flee the scene of the crime... | 09:50 | |
| tiagogomes | I think it is a bit different. It is better to open a new one | 09:52 |
| valentind | tristan, was there a new report? | 09:52 |
| tristan | ok | 09:52 |
| tristan | juergbi, can we close https://gitlab.com/BuildStream/buildstream/issues/242 ? | 09:52 |
| tristan | looks like that issue just failed to be closed | 09:52 |
| valentind | tiagogomes, How do you reproduce the problem? | 09:53 |
| tiagogomes | valentind just required 'name' key from a project.conf | 09:54 |
| tiagogomes | *remove* | 09:54 |
| tristan | I seem to recall thinking that we were going to need to enhance the low level yaml APIs to fix this | 09:54 |
| tristan | And I think that valentind's patch only handles unresolved variables | 09:55 |
| valentind | Well, in this case yes. I think it is different. | 09:55 |
| tristan | I see | 09:55 |
| valentind | Well, when something is missing, where is it missing from. | 09:55 |
| tristan | I am under the impression that it is the same issue, and that valentind only fixed a surface wound that was related | 09:55 |
| tristan | valentind, Exactly... the "where is it missing from" gives rise to the idea that _yaml doesnt have enough context to work that out | 09:56 |
| tristan | which is why I seem to recall thinking that this couldnt be fixed without adding some additional context to the _yaml codepaths | 09:56 |
| tristan | but memory is foggy at this point; I do recall the unresolved variables being fixed | 09:57 |
| valentind | tristan, if you wanted to fix it generally, then we would need swap some provenance after composition. | 09:57 |
| tristan | valentind, maybe that would work | 09:57 |
| tristan | valentind, but that seems destructive | 09:57 |
| valentind | Well, for variables it was a different case. | 09:57 |
| tristan | _yaml composition needs to preserve the location from whence everything was loaded, that is the point of provenance | 09:58 |
| tristan | Ok looking at the issue, I think I know what happened | 09:59 |
| tristan | jmac, filed the issue; and I thought it was the issue that tiagogomes is reporting now | 09:59 |
| tristan | valentind, found out that jmac's issue was addressable at the variable level | 09:59 |
| valentind | Now I remember. This was really a bug in element.py. We were showing the provenance where we were looking for the variable rather than showing the provenance of where the missing variable was used. | 10:00 |
| tristan | this did not make the issue tiagogomes is reporting go away, but the issue did get closed | 10:00 |
| tristan | Alright, whatever... tiagogomes please open a new issue and mark it related to 253 so that some of the conversation there is close at hand | 10:01 |
| * tristan has to go meet people for dinner | 10:01 | |
| tiagogomes | The old issue mentions "undefined variables". So what I am reporting seems like a new issue, but possibly related to 253 | 10:01 |
| *** cs-shadow has joined #buildstream | 10:02 | |
| gitlab-br-bot | buildstream: issue #242 ("Allow building as non-root inside the sandbox") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/242 | 10:02 |
| tristan | Yup, there is a little box after you file an issue with a "+" sign, lets you add related issues :) | 10:02 |
| tiagogomes | I'll do it after some coffee :) | 10:02 |
| tristan | yeah hehe | 10:02 |
| gitlab-br-bot | buildstream: merge request (Qinusty/531-fetch-retries-on-terminate->master: WIP: Prevent jobs retrying on terminate) #662 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/662 | 10:04 |
| *** tristan has quit IRC | 10:05 | |
| *** solid_black has quit IRC | 10:12 | |
| *** tlsa has joined #buildstream | 10:17 | |
| tlsa | how can I tell why buildstream is not getting stuff from the cache server? | 10:21 |
| jmac | tlsa: Did you get a warning line near the start of your build saying it couldn't contact the cache server? | 10:25 |
| tlsa | [00:00:00][][] SUCCESS Initializing remote caches | 10:26 |
| jmac | OK, good start. Is it possible the cache doesn't contain anything? | 10:27 |
| gitlab-br-bot | buildstream: issue #591 ("Missing required key on project.conf causes wrong provenance file name on error message") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/591 | 10:28 |
| tlsa | its https://testcache.codethink.co.uk:11001 | 10:28 |
| gitlab-br-bot | buildstream: merge request (willsalmon/580-backport->bst-1.2: Add warning to git track if track and ref are not present) #621 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/621 | 10:28 |
| jmac | I'm not familiar with that server unfortunately | 10:28 |
| tlsa | neither am I :) It seems to be what freedesktop-sdk uses | 10:28 |
| jmac | tlsa: Is your project set up to push artifacts to the cache? | 10:29 |
| tlsa | I don't know how to tell | 10:29 |
| tlsa | https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/18.08/project.conf#L162 | 10:29 |
| jmac | Typically, you would have "artifacts:<cr> push: true" in your project.conf if set up to push | 10:30 |
| finn | adds68 ^^ | 10:30 |
| jmac | And also a client certificate/key pair | 10:30 |
| tlsa | no, I don't have that | 10:30 |
| jmac | Right, not a problem, it's just that if you did push then the cache would definitely not be empty | 10:31 |
| tlsa | my project isn't freedesktop sdk, but its intended to piggyback off the freedesktop-sdk artifacts | 10:31 |
| valentind | Nice try tlsa! | 10:31 |
| valentind | ;) | 10:31 |
| jmac | So the best suggestion I can offer at the moment is to contact whoever set up testcache and ask them to manually look for the artifacts you're trying to retrieve | 10:32 |
| valentind | tlsa, is there any relation to freedesktop-sdk though? | 10:32 |
| finn | You could always set up your own artifact server | 10:33 |
| valentind | Yes, I would recommend that. It is not that difficult. | 10:33 |
| valentind | Me, adds68 and jjardon can add client certificates for the push. But we do not even do that ourselves. It is only the CI that pushes. | 10:34 |
| finn | tlsa, depending on your needs, I was tempted to write an artifact server this afternoon | 10:34 |
| finn | it would rely on non-encrypted calls | 10:34 |
| finn | so no certs | 10:34 |
| adds68 | tlsa, the cache will only pull for elements that match exactly, so if you are using freedesktop-sdk it should pull that from out cache, also providing that you are using the same version of bst as us, as currently the cache keys unstable | 10:34 |
| tlsa | I am using 1.1.6 of bst | 10:35 |
| adds68 | tlsa, to pull from our cache server you also do not require any certs, as we are verified by Lets Encrypt | 10:35 |
| tlsa | and this .bst file: https://pastebin.com/x1kkTQhP | 10:36 |
| adds68 | tlsa, that should work correctly, it is my understanding that junctions will still use the cache | 10:37 |
| adds68 | tlsa, do you have "artifacts" configured in your project.conf ? | 10:38 |
| tlsa | hmm, unfortunatly it wants to build everything locally. Currently its on bootstrap-junction.bst:gcc-stage1.bst | 10:38 |
| jjardon | adds68: yes, we have | 10:39 |
| jjardon | And the logs shows it connects successfully to the cache server | 10:39 |
| tlsa | [00:00:00][90c0b9b4][ pull:bootstrap-junction.bst:gcc-stage1.bst] SUCCESS freedesktop-sdk-bootstrap/gcc-stage1/90c0b9b4-pull.27280.log | 10:41 |
| tlsa | it says it pulled it, but now its building it | 10:42 |
| valentind | tlsa what version of bst do you use? | 10:43 |
| tlsa | 1.1.6 | 10:44 |
| *** jonathanmaw_ has joined #buildstream | 10:49 | |
| *** jonathanmaw has quit IRC | 10:50 | |
| gitlab-br-bot | buildstream: merge request (willsalmon/APIFix->master: Updating the no track or ref fix to match the buildstream style) #628 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/628 | 10:51 |
| tiagogomes | tlsa valentind the cascache doesn't know if an artifact is cached in the sever or not. So failing to pull (because the artifact did not exist, is treated as success) | 10:52 |
| tiagogomes | Though, it probably should shown as skipped if the number of bytes downloaded was 0 | 10:53 |
| valentind | I just wondered if there were different keys used. | 10:54 |
| valentind | tlsa, what architecture are you using? | 10:54 |
| jjardon | tiagogomes: that would help immensely debugging problems with the artifact server | 10:55 |
| tlsa | valentind: aarch64 | 10:55 |
| valentind | tlsa, an you are not building with qemu? | 10:56 |
| tlsa | valentind: buildstream running natively on an aarch64 system, building for an aarch64 target | 10:56 |
| valentind | Just asking, because if you do not set the bootstrap architecture, then it might not take the right one, and have differences with the cache. | 10:57 |
| tlsa | how do I set the bootstrap arch? | 10:58 |
| tlsa | i ran with `bst -o target_arch aarch64 build linux.bst`, but that -o may be redundant | 10:58 |
| valentind | tlsa, the option is bootstrap_build_arch | 10:59 |
| valentind | So you would have to set that in the junction. | 11:00 |
| tlsa | what do you mean by set it in the junction? | 11:01 |
| tlsa | oh, in my freedesktop-sdk.bst, under config: options: ? | 11:02 |
| gitlab-br-bot | buildstream: merge request (Qinusty/531-fetch-retries-on-terminate->master: WIP: Prevent jobs retrying on terminate) #662 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/662 | 11:02 |
| tlsa | nah, that hasn't helped | 11:05 |
| gitlab-br-bot | buildstream: issue #592 ("Allow testing of interactivate code paths within BuildStream") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/592 | 11:07 |
| gitlab-br-bot | buildstream: merge request (Qinusty/531-fetch-retries-on-terminate->master: Prevent jobs retrying on terminate) #662 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/662 | 11:09 |
| gitlab-br-bot | buildstream: issue #471 ("Missing track parameter in sources should raise appropriate error") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/471 | 12:05 |
| gitlab-br-bot | buildstream: merge request (tpollard/483->master: plugins/git.py: Warn if ref is not in given track) #564 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/564 | 12:11 |
| tlsa | update: with same .bst files, and same config, but using buildstream 1.1.5 it is downloading and using artifacts from freedesktop-sdk | 12:13 |
| *** solid_black has joined #buildstream | 12:22 | |
| adds68 | \o/ | 12:44 |
| adds68 | tlsa, so it was the cache keys! :D | 12:44 |
| valentind | Did not we update to 1.1.6? | 12:44 |
| tlsa | apparently freedesktop-sdk has been updated to 1.1.6, so it's a mystery why it didn't work with 1.1.6 | 12:45 |
| coldtom | i don't think the pipeline got past i586 | 12:47 |
| coldtom | yeah, there was an ostree error in the i586 pipeline, so it never reached aarch64 on the 18.08 branch | 12:50 |
| coldtom | is it possible to mount a disk image in the build sandbox? | 12:51 |
| jjardon | coldtom: thats for the flatpak runtimes, no the bst cache | 12:51 |
| jjardon | coldtom: the build with 1.1.6 got build in all the arches: https://gitlab.com/freedesktop-sdk/freedesktop-sdk/merge_requests/420 | 12:51 |
| valentind | Do not the branches push to artifacts? | 12:55 |
| tiagogomes | Can someone explain to me why 'sources' is allowed on the top level of project.conf even if it not in the list passed to node_validate | 12:57 |
| valentind | tiagogomes, it is extracted and removed before validation I think. | 12:58 |
| valentind | What I remember. | 12:58 |
| tiagogomes | aah why is it extracted? | 12:59 |
| valentind | No idea. | 12:59 |
| *** finn_ has joined #buildstream | 13:00 | |
| valentind | You will have to look at the logs. | 13:00 |
| *** finn has quit IRC | 13:01 | |
| coldtom | is there a way i can mount a disk image in the sandbox? | 13:14 |
| qinusty | Can I get a review on https://gitlab.com/BuildStream/buildstream/merge_requests/662? | 13:15 |
| *** bochecha has joined #buildstream | 13:16 | |
| jmac | qinusty: Sure, I'll do it | 13:16 |
| jmac | Looks pretty simple | 13:16 |
| gitlab-br-bot | buildstream: merge request (Qinusty/531-fetch-retries-on-terminate->master: Prevent jobs retrying on terminate) #662 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/662 | 13:16 |
| qinusty | Yeah, I've opened a separate issue for the test for it since we don't really have the framework for testing interactive parts of buildstream in place yet | 13:16 |
| jmac | qinusty: Yes, I'm happy with that - rebase it and merge it | 13:17 |
| gitlab-br-bot | buildstream: merge request (Qinusty/531-fetch-retries-on-terminate->master: Prevent jobs retrying on terminate) #662 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/662 | 13:19 |
| gitlab-br-bot | buildstream: issue #593 ("Error after apparently successful build") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/593 | 13:28 |
| *** xjuan has joined #buildstream | 13:58 | |
| gitlab-br-bot | buildstream: issue #531 ("Fetch jobs resume despite "terminate" option on CTRL-C") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/531 | 14:29 |
| gitlab-br-bot | buildstream: merge request (Qinusty/531-fetch-retries-on-terminate->master: Prevent jobs retrying on terminate) #662 changed state ("merged"): https://gitlab.com/BuildStream/buildstream/merge_requests/662 | 14:29 |
| *** leopi has quit IRC | 15:23 | |
| *** leopi has joined #buildstream | 15:26 | |
| gitlab-br-bot | buildstream: merge request (tiagogomes/issue-287->master: Add validation of configuration variables) #678 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/678 | 15:27 |
| gitlab-br-bot | buildstream: merge request (jonathan/cache-cache-size->master: Jonathan/cache cache size) #679 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/679 | 15:28 |
| gitlab-br-bot | buildstream: issue #593 ("Error after apparently successful build") changed state ("closed") https://gitlab.com/BuildStream/buildstream/issues/593 | 15:29 |
| gitlab-br-bot | buildstream: merge request (tpollard/591->master: buildstream/_project.py: Report if project.conf is missing name) #680 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/680 | 15:46 |
| tpollard | tiagogomes: I've sent an MR to 'fix' #591 that you raised today, hopefully it's ok | 15:48 |
| tiagogomes | tpollard awesome! I wasn't working on it but next time assign first the issue to yourself so we don't end up doing the same work :) | 15:50 |
| tpollard | tiagogomes: ouch, yeh sorry | 15:51 |
| gitlab-br-bot | buildstream: merge request (tpollard/483->master: plugins/git.py: Warn if ref is not in given track) #564 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/564 | 15:54 |
| gitlab-br-bot | buildstream: merge request (Qinusty/message-helpers->master: Continued work on improving BuildStream messaging API) #670 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/670 | 16:07 |
| gitlab-br-bot | buildstream: merge request (tpollard/591->master: buildstream/_project.py: Report if project.conf is missing name) #680 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/680 | 16:12 |
| *** tiagogomes has quit IRC | 16:39 | |
| jmac | Right, I think remote execution is done sufficiently for a review. Gitlab appears to be down at the moment, so I'll push it later in the weekend. | 17:02 |
| gitlab-br-bot | buildstream: merge request (tpollard/591->master: WIP: buildstream/_project.py: Report if project.conf is missing name) #680 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/680 | 17:07 |
| *** solid_black has quit IRC | 17:07 | |
| *** jonathanmaw_ has quit IRC | 17:31 | |
| gitlab-br-bot | buildstream: merge request (tpollard/591->master: WIP: buildstream/_project.py: Report if project.conf is missing name) #680 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/680 | 17:33 |
| *** tpollard has quit IRC | 17:34 | |
| *** leopi has quit IRC | 18:44 | |
| *** leopi has joined #buildstream | 19:16 | |
| *** alatiera_ has quit IRC | 19:29 | |
| *** leopi has quit IRC | 19:42 | |
| *** mohan43u has quit IRC | 19:43 | |
| *** mohan43u has joined #buildstream | 19:44 | |
| *** finn_ has quit IRC | 20:17 | |
| *** rdale has quit IRC | 21:55 | |
| *** cs-shadow has quit IRC | 22:02 | |
| *** xjuan has quit IRC | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!