IRC logs for #buildstream for Wednesday, 2018-05-30

*** mohan43u has quit IRC03:34
*** mohan43u has joined #buildstream03:35
*** Prince781 has joined #buildstream03:50
*** mohan43u has quit IRC04:47
*** mohan43u has joined #buildstream04:48
*** skullman has quit IRC05:24
*** skullman has joined #buildstream05:24
*** ernestask has joined #buildstream05:37
*** Prince781 has quit IRC05:46
*** mohan43u has quit IRC06:25
*** mohan43u has joined #buildstream06:32
*** toscalix has joined #buildstream07:26
*** bochecha_ has quit IRC07:34
*** bochecha_ has joined #buildstream07:41
*** jonathanmaw has joined #buildstream08:24
*** bethw has joined #buildstream08:28
*** dominic has joined #buildstream08:40
*** tiago has joined #buildstream08:50
Nexustlater: Please can i get some of your thoughts regarding the "Source code available in environment in order to debug" task?09:06
Nexuswhat the actual background for this idea was and what's hoped to be achieved etc09:06
Nexuspotentially juergbi too if he's here09:06
* tlater thinks he mostly went over that yesterday, but sure09:07
tlaterWe want to be able to run software debuggers & co when we run `bst shell`09:08
tlaterThat's essentially it09:08
NexusSo do we want a workspace in the shell?09:08
tlaterWhat do you mean by that?09:08
Nexusasin actually open a workspace inthe sandbox09:09
Nexusas if the user called workspace open09:09
tlaterHow do you even expect that to work? You don't even have elements inside the sandbox09:09
NexusThat's what i wanted to clarify, whether we'd be introducing them, or we're just adding a directory containing the source09:10
Nexuslike a "oh by the way, there's source here too"09:10
tlaterThe only reason workspaces come into play here is because we don't want to stage the sources of *all* dependencies.09:10
tlaterBack when we came up with the feature we decided that any elements that have open workspaces should have their sources (workspace, I suppose) staged into the sandbox somewhere, if this makes sense09:11
tlaterIMO this makes sense when `bst shell` is run09:11
Nexusisn't that what bst shell --build does?09:12
tlaterSort of, but it does it for the element whose build environment you want to inspect09:12
tlaterSo this is limited since you cannot actually run a debugger on the build output09:12
tlaterBecause there will be no build output...09:13
tlaterSimilarly, if there's a bug in a library, your debugger won't be able to look into library source code either09:13
*** slaf_ has joined #buildstream09:14
NexusSo we instead want to add "all of the sources used in the build process" ?09:14
*** slaf_ has joined #buildstream09:14
tlaterNo, because that would be slow as hell09:15
tlater> The only reason workspaces come into play here is because we don't09:15
tlater         want to stage the sources of *all* dependencies.09:15
tlaterI.e., we stage the sources of only those elements who have workspaces09:16
tlaterThat in turn allows the user to specify exactly which elements they'd like to debug09:16
*** slaf has quit IRC09:16
*** slaf_ is now known as slaf09:16
tlaterSo they're happy, and buildstream isn't slow09:16
Nexusso if i have 10 workspaces, and i open a shell, i'll get all of those sources too?09:17
tlaterYeah, I think that's sensible09:17
tlaterSince clearly those are being developed09:17
tlaters/$/on/09:18
tlaterWe can of course think about enabling/disabling this with a switch on shell, but that's a detail we can consider later09:18
*** dominic has quit IRC09:19
Nexuskk09:19
gitlab-br-botbuildstream: issue #411 ("Native bst support on OS X, remote execution only") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/41109:29
gitlab-br-botbuildstream: issue #412 ("Native bst support on Windows w/ WSL, remote execution only") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/41209:31
*** dominic has joined #buildstream09:39
jennisDoes anyone have any strong feelings against introducing mocking into our tests?09:47
skullmannot particularly, I already feel like they are mocking me when they fail09:48
jennishttps://docs.python.org/3/library/unittest.mock.html09:49
Nexusi agree with skullman09:56
Nexusit might make me more inclined to fix them if they mock me09:56
skullmanha09:57
*** aday has joined #buildstream10:11
*** noisecell has quit IRC10:24
*** noisecell has joined #buildstream10:25
*** noisecell has quit IRC10:48
*** noisecell has joined #buildstream11:00
NexusPlease can we clean up the "correction :" commits?12:12
tlaterNexus: It's too late, they're on master now12:12
Nexusdamn12:12
tlater+1 on not making commits called "correction :" though12:12
tlater(By extension perhaps not committing to master without *some* review, even for non-code work)12:13
* Nexus likes the issue templates12:17
laurenceI have posted to the list re dog-fooding, and would appreciate any comments12:21
laurencespecifically if there's an obvious thing I'm missing which would block this from getting started straight away12:21
Nexusdidn't tlater raise a point yesterday about a potential problem?12:24
tlaterNexus: We'll see if it is a problem when we start working on it :)12:43
noisecellhi, does someone knows anything about: https://gnome1.codethink.co.uk/logs/build-2018-05-30-091327/build.txt ? these logs are linked from https://wiki.gnome.org/Projects/BuildStream/Infrastructure in "Flatpak SDK builds for ARM" section. Both builds have a number of packages which failed to build in both architectures. I was going to file a bug in: https://gitlab.gnome.org/GNOME/gnome-apps-nightly (as agreed with jjardon) but I feel I should ask h12:49
noisecellere before doing it, just in case some of you know anything about this.12:49
jjardonmmm, the info in that wiki https://wiki.gnome.org/Projects/BuildStream/Infrastructure is incorrect / out-of-date12:53
* jjardon updates12:53
*** xjuan has joined #buildstream12:54
gitlab-br-botbuildstream: issue #413 ("Add sources to bst shell") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/41312:59
valentindjuergbi, I get some error "TypeError: __new__() got an unexpected keyword argument 'file'" when running juerg/googlecas branch. Would you have any hint on how to debug that? https://pastebin.com/9LkAaGvH13:01
toscalixjjardon: thanks13:01
toscalixjjardon: is there a chance to keep the wiki pages on gitlab and ask people to change them there? At least some of the basic ones. Is this something other GNOME projects do or they always edit directly?13:02
jjardontoscalix: first question; depends on buildstream  maintainers where they want to keep the wiki pages. Second question not sure I understand; every trusted user can edit the gnome wiki is that's what you are asking13:04
toscalixdirectly then, ok13:05
juergbivalentind: hm, an error in the generated code, that's odd. and that's also with Python 3.613:18
valentindjuergbi, I managed to get it to run by running build_grpc. I suppose this one should be always run if it depends on the python version.13:18
valentindIt worked on a python 3.5 without changes. But python 3.6 did not work.13:18
juergbiinteresting, I've been testing on 3.6 and it works in CI with Python 3.4 and 3.613:19
juergbialways regenerating the code would add a build/install dependency of grpcio_tools. not sure how much of an issue this would be in practice13:20
valentindjuergbi, I have python3-protobuf installed by the system. Could it be related?13:20
juergbiit could well be an issue of a mismatch in the installed protobuf version, yes13:21
valentindOr are there other python packages on which the version is important?13:21
juergbiprotobuf and grpcio are likely the only modules that matter in this regard13:22
juergbishould probably try to investigate about the stability of generated code13:22
*** aday has quit IRC13:35
*** aday has joined #buildstream13:35
valentindjuergbi, minor, but annoying, the server prints a lot of warnings "Could not get common name of subject from certificate.". I followed the documentation. I think we need CN for client certificates for this to disappear.13:35
*** finn has quit IRC13:46
*** finn has joined #buildstream13:48
juergbivalentind: right, thanks. I changed this locally but forgot to change it to the docu13:57
gitlab-br-botbuildstream: merge request (juerg/googlecas->master: Remote Execution CAS-based artifact cache) #337 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/33714:04
*** finn has quit IRC14:16
*** finn has joined #buildstream14:16
*** finn has quit IRC14:21
*** finn has joined #buildstream14:23
*** sstriker has joined #buildstream14:26
gitlab-br-botbuildstream: merge request (valentindavid/359_cross_junction_elements->master: Allow names for cross junction elements) #454 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/45414:29
tlaterDoes the tarcache currently store two artifacts for weak and strong cache keys?14:46
tlaterI suppose there is no deduplication going on there, so...14:46
tlaterWell, at least that explains my test failures14:49
juergbitlater: I thought it used symlinks but don't remember exactly14:50
tlaterHm, perhaps the cache size calculation follows symlinks then14:52
tlaterNo, it doesn't14:52
juergbitlater: oh, you're right, it creates two archives14:53
juergbino deduplication at all14:53
tlaterProbably not worth looking into too much, the tar cache definitely will be superseded by CAS14:54
juergbiyes14:54
tlaterStill, gotcha for my test cases...14:54
juergbitlater: if it's just an issue with a test case, not causing an actual regression, you could consider marking the test case as linux-only14:56
juergbi(in light of the CAS replacement)14:56
tlaterjuergbi: I suppose, but it really just made choosing file sizes trickier than I thought. Already solved it, I just thought I was creating an artifact twice for a moment (:14:58
juergbiah ok14:59
gitlab-br-botbuildstream: merge request (135-expire-artifacts-in-local-cache->master: WIP: Resolve "Expire artifacts in local cache") #347 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/34715:00
gitlab-br-botbuildstream: merge request (135-expire-artifacts-in-local-cache->master: WIP: Resolve "Expire artifacts in local cache") #347 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/34715:01
*** Prince781 has joined #buildstream15:02
*** jennis has quit IRC15:11
*** jennis has joined #buildstream15:11
*** jennis has quit IRC15:18
*** bochecha_ has quit IRC15:19
*** bochecha_ has joined #buildstream15:19
*** jennis has joined #buildstream15:20
*** sstriker has quit IRC15:31
jennismhmm I'm running a specific test file `./setup.py test --addopts 'tests/frontend/push.py'` and it's passing, however when I run ALL the tests `./setup.py test` that file is the only one failing15:49
jennisThat's weird, right?15:49
Nexuswhy is it failing? Maybe the test before isn't cleaning up properly and it's failing because of that15:52
jennispotentially15:58
jennisBut that test has just passed in CI16:01
noisecellHello, Im trying to build https://gitlab.com/baserock/definitions/blob/master/elements/systems/openstack-system-content.bst which it seems it does build in definitions CI: https://gitlab.com/baserock/definitions/-/jobs/71226696  but it doesn't build in my local VM: https://paste.baserock.org/ukugetawos  -- Im using BuildStream Version 1.1.3+72.gc0de75e2 and master of definitions. I have followed the instructions to set up buildstream in my VM. am16:11
noisecellIm missing something?16:11
noisecellas a second question I was expecting that none of the packages for that system would need to be rebuilt given that it should be in the cached (the system is built in gitlab) but it seems that some of the packages run build commands, is this expected?16:12
gitlab-br-botbuildstream: merge request (jennis/alternative_remote_expiry->master: Jennis/alternative remote expiry) #477 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/47716:22
gitlab-br-botbuildstream: merge request (jennis/136-clean-remote-cache->master: WIP: jennis/136 clean remote cache) #421 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/42116:23
gitlab-br-botbuildstream: merge request (jennis/136-clean-remote-cache->master: WIP: jennis/136 clean remote cache) #421 changed state ("closed"): https://gitlab.com/BuildStream/buildstream/merge_requests/42116:23
gitlab-br-botbuildstream: merge request (jennis/alternative_remote_expiry->master: Expire artifacts in the remote artifact cache) #477 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/47716:24
jjardonnoisecell:  it's rebuilding because the cache key between the version of bst you are using and the one used to generate the artifacts in the cache is not the same16:24
paulsherwoodjjardon: ybd supports versionign of keys... does bst not do that?16:25
jjardonnoisecell: https://gitlab.com/BuildStream/buildstream/issues/22616:25
jjardonpaulsherwood: I do not think so16:26
noisecelljjardon, oh, so you have opened this issue already.16:34
jjardonnoisecell: did I? :)16:36
noisecelljjardon, https://gitlab.com/BuildStream/buildstream/issues/326 -- for the second question yeah :)16:37
noisecellthe first question still stand. Why gnu-toolchain-stage2-gawk detects that it doesn't have a valid compiler?16:44
noisecell"checking whether the C compiler works... no"16:44
noisecelland in the CI this is not an issue?16:44
jjardonnoisecell: have you tried to use the exact same version in the CI, to be sure this is not a problem in your environment?16:46
noisecelljjardon, not yet. which problem could I have in my environment jjardon?16:48
jjardonnoisecell: I do not know, but I know the CI env is inmutable16:48
noisecelljjardon, I am using a fedora 28 VM with only the packages required to run buildstream so far.16:50
*** toscalix has quit IRC16:51
gitlab-br-botbuildstream: merge request (jennis/alternative_remote_expiry->master: Expire artifacts in the remote artifact cache) #477 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/47716:54
noisecelljjardon, with 1.0.1 version, it does pull all the artefacts, it doesn't build anything so there are not errors.17:03
*** bethw has quit IRC17:05
*** finn has quit IRC17:11
*** dominic has quit IRC17:11
*** jonathanmaw has quit IRC17:15
gitlab-br-botbuildstream: merge request (richardmaw/cache-fail->master: WIP: Store failed builds in the cache) #475 changed state ("opened"): https://gitlab.com/BuildStream/buildstream/merge_requests/47517:16
*** ernestask has quit IRC17:16
jjardonnoisecell: yeah, seems a regression with bst 1.1.3: https://gitlab.com/baserock/definitions/merge_requests/78,  1.1.2 seems to work (It's failing in another place): https://gitlab.com/baserock/definitions/merge_requests/7717:36
*** lantw44 has quit IRC17:49
*** lantw44 has joined #buildstream17:49
*** finn has joined #buildstream17:58
gitlab-br-botbuildstream: issue #414 ("Seems bst 1.1.3 doesn't build correctly anymore (it works fine with 1.1.2)") changed state ("opened") https://gitlab.com/BuildStream/buildstream/issues/41418:07
jjardonnoisecell: I have opened ^18:08
*** finn has quit IRC18:17
*** aday has quit IRC18:59
*** aday has joined #buildstream19:07
*** aday has quit IRC19:34
*** xjuan has quit IRC19:42
*** aday has joined #buildstream20:08
*** milloni has quit IRC20:09
*** milloni has joined #buildstream20:10
*** milloni has quit IRC20:18
*** aday has quit IRC20:18
*** milloni has joined #buildstream20:18
*** bochecha_ has quit IRC20:27
*** Prince781 has quit IRC21:06
*** cs_shadow has quit IRC22:05
*** aday has joined #buildstream22:26
*** aday has quit IRC22:30

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!