| *** gtristan has joined #baserock | 08:34 | |
| *** ctbruce has joined #baserock | 08:36 | |
| *** toscalix has joined #baserock | 09:14 | |
| *** rdale has joined #baserock | 09:39 | |
| *** edcragg has joined #baserock | 10:21 | |
| *** CTtpollard has joined #baserock | 10:25 | |
| *** edcragg has quit IRC | 10:36 | |
| *** edcragg has joined #baserock | 10:37 | |
| *** locallycompact has joined #baserock | 10:37 | |
| *** lc_ has joined #baserock | 10:38 | |
| *** lc_ has joined #baserock | 10:38 | |
| *** jude_ has quit IRC | 11:28 | |
| locallycompact | one more for this spec change? | 11:40 |
|---|---|---|
| locallycompact | https://gitlab.com/baserock/spec/merge_requests/3 | 11:40 |
| locallycompact | https://gitlab.com/baserock/definitions/merge_requests/17 | 11:40 |
| gtristan | locallycompact, just uploaded a cleaner ybd patch on https://gitlab.com/baserock/ybd/merge_requests/279 btw | 11:49 |
| locallycompact | +1 | 11:51 |
| gtristan | and oops, looks like pep8 wants an extra empty line between functions | 11:52 |
| gtristan | (although the runner error doesnt seem to indicate that exactly) | 11:52 |
| * gtristan resubmits with pep8 fix | 11:56 | |
| locallycompact | jjardon, I made you a thing https://gitlab.com/baserock/definitions/merge_requests/19 | 12:49 |
| locallycompact | pedroalvarez, I know you would love to approve this spec change https://gitlab.com/baserock/spec/merge_requests/3/diffs | 13:04 |
| *** gtristan has quit IRC | 13:28 | |
| locallycompact | I said we should pin dependency versions of ybd, now an update to a ybd dependency has broken every master | 13:52 |
| locallycompact | so | 13:53 |
| locallycompact | I will update that | 13:53 |
| jjardon | locallycompact: nice, I commented in the MR | 14:01 |
| locallycompact | https://gitlab.com/baserock/ybd/merge_requests/282 | 14:02 |
| jjardon | aproved | 14:03 |
| locallycompact | the new one looks much better actually https://www.willmcgugan.com/blog/tech/post/announcing-pyfilesystem-2/ | 14:04 |
| *** gtristan has joined #baserock | 14:13 | |
| locallycompact | https://gitlab.com/baserock/ybd/merge_requests/283 | 14:23 |
| jjardon | +1 | 14:28 |
| jjardon | can someone else review https://gitlab.com/baserock/ybd/merge_requests/282 ? ybd master is broken at the moment because of this | 14:47 |
| jjardon | gtristan: paulsherwood ^ | 14:48 |
| pedroalvarez | maybe 2 reviews are too many? having someone that can "+2" things might be a good idea | 14:48 |
| pedroalvarez | also, would it be sensible to fix the breackage instead of freezing the deps? | 14:49 |
| pedroalvarez | s/ck/k | 14:49 |
| locallycompact | both | 14:49 |
| pedroalvarez | (i believe that was what paulsherwood wanted when not wanting to freeze the dependencies) | 14:49 |
| locallycompact | one sec | 14:50 |
| jjardon | locallycompact already do that in another patch: https://gitlab.com/baserock/ybd/merge_requests/282 | 14:50 |
| locallycompact | I will break that out separately | 14:50 |
| locallycompact | ok now it's just the upgrade https://gitlab.com/baserock/ybd/merge_requests/283 | 14:51 |
| locallycompact | pedroalvarez, if we do that by default, then if someone is using the same definitions as we are then they will just break and not know what is happening | 14:53 |
| locallycompact | but I like that the ci spotted there was a new version of pyfs | 14:53 |
| locallycompact | approve this one instead for now https://gitlab.com/baserock/ybd/merge_requests/283 | 14:55 |
| jjardon | +1 | 14:57 |
| pedroalvarez | now i wonder | 15:02 |
| pedroalvarez | cnn i cancel my approval? | 15:02 |
| pedroalvarez | i cant? | 15:04 |
| * pedroalvarez adds a poo to the merge request as a note that he doesn't want to approve the change anymore | 15:06 | |
| pedroalvarez | now i like gitlab and using poo's in Merge requests | 15:07 |
| locallycompact | I poo it too | 15:08 |
| locallycompact | hmm can't downvote my own MR | 15:08 |
| locallycompact | just poo | 15:08 |
| locallycompact | and a koala bear | 15:09 |
| pedroalvarez | hahaha I totally agree | 15:10 |
| jjardon | locallycompact: https://gitlab.com/baserock/ybd/builds/7230376 | 15:29 |
| jjardon | it fails with this commit: https://gitlab.com/baserock/ybd/commit/93739f49297a2ae560a584292eb1901920cfc2ee | 15:30 |
| jjardon | locallycompact: anahuelamo (or anyone else) do you have any free time to review https://gitlab.com/baserock/definitions/merge_requests/13 ? | 16:11 |
| locallycompact | looks cool | 16:12 |
| anahuelamo | jjardon, sure | 16:14 |
| *** ctbruce has quit IRC | 16:25 | |
| *** toscalix has quit IRC | 16:43 | |
| jjardon | anahuelamo: locallycompact can you review again https://gitlab.com/baserock/definitions/merge_requests/13 , please ? the approvals were lost when I rebase manually against master | 16:55 |
| anahuelamo | done | 16:56 |
| jjardon | anahuelamo: locallycompact can you review https://gitlab.com/baserock/definitions/merge_requests/2 as well? | 16:59 |
| jjardon | also https://gitlab.com/baserock/definitions/merge_requests/5 ? | 17:02 |
| locallycompact | radiofree, could you check over https://gitlab.com/baserock/ybd/merge_requests/271/diffs the first of splitting/manifest renovation | 17:02 |
| radiofree | ok, i'll test it over the weekend | 17:13 |
| locallycompact | ok, it should not be a functional change | 17:15 |
| jjardon | locallycompact: https://gitlab.com/baserock/definitions/merge_requests/20 | 17:45 |
| *** tiagogomes has quit IRC | 17:48 | |
| jjardon | anahuelamo: can you review https://gitlab.com/baserock/definitions/merge_requests/20 as well? It will help to have more runners available | 17:56 |
| locallycompact | this too please https://gitlab.com/baserock/definitions/merge_requests/19 | 17:56 |
| *** tiagogomes has joined #baserock | 17:56 | |
| anahuelamo | approved | 17:57 |
| *** CTtpollard has quit IRC | 18:02 | |
| *** locallycompact has quit IRC | 18:19 | |
| *** rdale has quit IRC | 20:44 | |
| *** locallycompact has joined #baserock | 22:46 | |
| *** locallycompact has quit IRC | 23:12 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!