| *** gtristan has quit IRC | 02:34 | |
| *** gtristan has joined #baserock | 02:34 | |
| *** gtristan has quit IRC | 02:59 | |
| *** gtristan has joined #baserock | 03:03 | |
| *** rdale has joined #baserock | 05:41 | |
| *** jonathanmaw has joined #baserock | 06:23 | |
| *** tiagogomes has joined #baserock | 07:14 | |
| *** ssam2 has joined #baserock | 07:15 | |
| *** ChanServ sets mode: +v ssam2 | 07:15 | |
| *** ctbruce has joined #baserock | 07:31 | |
| *** anahuelamo has joined #baserock | 07:56 | |
| *** jonathanmaw_ has joined #baserock | 08:01 | |
| *** jonathanmaw has quit IRC | 08:05 | |
| *** franred has joined #baserock | 08:43 | |
| *** edcragg has joined #baserock | 08:47 | |
| *** edcragg has quit IRC | 08:52 | |
| *** CTtpollard has joined #baserock | 09:10 | |
| *** edcragg has joined #baserock | 09:18 | |
| *** Lachlan1975 has joined #baserock | 09:24 | |
| *** franred has quit IRC | 09:28 | |
| *** franred has joined #baserock | 09:49 | |
| *** jonathanmaw_ has quit IRC | 10:36 | |
| *** CTtpollard has quit IRC | 10:46 | |
| *** rdale has quit IRC | 11:23 | |
| *** rdale has joined #baserock | 11:40 | |
| paulsherwood | benbrown_: #gitano is a thing | 12:43 |
|---|---|---|
| paulsherwood | :) | 12:43 |
| benbrown_ | indeed it is | 12:44 |
| rjek | ENOCONTEXT | 13:06 |
| benbrown_ | rjek: I did an email | 13:08 |
| rjek | Oh :) | 13:12 |
| *** fay_ has quit IRC | 13:33 | |
| *** fay_ has joined #baserock | 13:47 | |
| *** toscalix has joined #baserock | 13:49 | |
| *** toscalix has quit IRC | 13:54 | |
| *** toscalix has joined #baserock | 13:55 | |
| *** fay_ has quit IRC | 13:59 | |
| *** fay_ has joined #baserock | 13:59 | |
| paulsherwood | edcragg: thanks for the patch! i assume you've verified that other deploys (ie without subsystems) still work? | 14:05 |
| paulsherwood | edcragg: pep8! | 14:09 |
| edcragg | paulsherwood: i haven't, but i don't see any reason why it should | 14:10 |
| edcragg | that codepath only happens for subsystems | 14:10 |
| edcragg | i wasn't aware that ybd followed pep8 particularly | 14:11 |
| paulsherwood | it says so in the project guidelines :) | 14:12 |
| paulsherwood | edcragg: will you resubmit or shall i fix it here? | 14:17 |
| edcragg | there are many serious contraventions of pep8 elsewhere in ybd | 14:17 |
| paulsherwood | are there? | 14:18 |
| edcragg | yep | 14:18 |
| paulsherwood | i run it and nothing screams | 14:18 |
| edcragg | bare exceptions are one example | 14:18 |
| paulsherwood | pep8 --version > 1.7.0 | 14:18 |
| paulsherwood | silent on ybd | 14:19 |
| edcragg | that surprises me | 14:19 |
| paulsherwood | :-) | 14:19 |
| rjek | That command will be silent | 14:19 |
| rjek | It will direct output to a file called 1.7.0 | 14:19 |
| paulsherwood | rjek: no, i meant that the version i'm running is 1.7.0 and it accepts ybd sielently | 14:20 |
| edcragg | i think bare exceptions is a recommendation, a fairly sound one though | 14:20 |
| richard_maw | all of pep8 is recommendations | 14:21 |
| rjek | bare exceptions are a mistake | 14:21 |
| locallycompact | There's lots of things in pep8 that can't be syntactically checked that ybd breaks, like bug masking | 14:21 |
| rjek | http://paste.baserock.org/geyimoyuca | 14:22 |
| paulsherwood | we're getting off track. edcragg - will you fix your patch so the pep8 program passes, or shall i? | 14:24 |
| edcragg | done | 14:25 |
| paulsherwood | ./ybd/deployment.py:68:80: E501 line too long (83 > 79 characters) | 14:29 |
| * richard_maw notes that the pep8 tool doesn't check for everything in pep8, it also doesn't even check everything it *can* check in the default configuration | 14:30 | |
| *** gtristan has quit IRC | 14:30 | |
| *** gary_per- has joined #baserock | 14:32 | |
| *** gary_perkins has quit IRC | 14:33 | |
| *** gary_per- is now known as gary_perkins | 14:33 | |
| paulsherwood | the point is that i'm running pep8 as part of ybd's ci... so this patch will break it, is all | 14:33 |
| rjek | paulsherwood: flake8 is another handy Python linter | 14:34 |
| paulsherwood | rjek: thanks :) | 14:36 |
| * paulsherwood wonders whether adding that will will increase or reduce friction for ybd | 14:36 | |
| rjek | Also pylint | 14:37 |
| richard_maw | paulsherwood: I think having a requirement that it pass everything in .gitlab-ci.yml without providing a way for contributors to run all your verification criteria themselves is of more friction. | 14:38 |
| edcragg | paulsherwood: re-submitted, i think it's uglier, but hey | 14:39 |
| *** toscalix has quit IRC | 14:40 | |
| paulsherwood | richard_maw: not sure i get your point? they can install pep8? | 14:49 |
| paulsherwood | edcragg: wow... i agree with you :-) | 14:50 |
| richard_maw | paulsherwood: they can, and while you are documented as saying you need to run pep8 to verify the code, people can't execute the .gitlab-ci.yml file and that's your canonical source of the verification criteria | 14:54 |
| paulsherwood | richard_maw: ack | 14:56 |
| paulsherwood | richard_maw: with a gitlab account they can trivially fork and run the same ci though :) | 14:57 |
| paulsherwood | edcragg: http://paste.baserock.org/ipaxeqemis | 14:57 |
| richard_maw | I disagree with the claim that this is trivial | 14:57 |
| * SotK thought upstream was on github | 14:57 | |
| paulsherwood | is that notioinally the same? i can't test your work in my environment | 14:57 |
| rjek | Is it me, or does the second line not use d? | 14:58 |
| SotK | rjek: it isn't just you | 14:58 |
| paulsherwood | http://paste.baserock.org/ujazamesis | 14:59 |
| paulsherwood | :) | 14:59 |
| *** gtristan has joined #baserock | 15:00 | |
| paulsherwood | SotK: upstream is github. i'm mirroring to gitlab too... | 15:00 |
| * SotK would recommend deployment.get(l, ''), so as to not try to call strip() on None | 15:01 | |
| paulsherwood | a) so that if github got hacked i might notice | 15:01 |
| SotK | aha! :) | 15:01 |
| paulsherwood | b) to try the extra features of gitlab ci | 15:01 |
| paulsherwood | http://paste.baserock.org/elodunocos | 15:02 |
| paulsherwood | thnaks for the reviews :-) | 15:03 |
| richard_maw | SotK: except he's already checked that the key exists with `deployment.get(l)` (which is also wrong IMO, should be `l in deployment` | 15:03 |
| SotK | oh yeah, I didn't notice that | 15:04 |
| * SotK disappears | 15:05 | |
| richard_maw | after that you can just use deployment[l] rather than deployment.get(l) | 15:05 |
| richard_maw | deployment[l] is shorter, faster, and gives more useful error messages when the key doesn't exist | 15:05 |
| edcragg | +1 | 15:06 |
| paulsherwood | if only i could get this level of attention on all the other lines of ybd :-) | 15:06 |
| richard_maw | you did once | 15:06 |
| *** richard_maw has left #baserock | 15:06 | |
| paulsherwood | heh | 15:06 |
| *** Lachlan1975 has quit IRC | 15:10 | |
| JPohlmann | So it looks like ssam2 and I will be having a little Codethink get-together in Luebeck this weekend :) | 15:18 |
| *** Lachlan1975 has joined #baserock | 15:22 | |
| ssam2 | yes indeed ! | 15:22 |
| ssam2 | we can rewrite ybd in clojure in that time i imagine ;-) | 15:23 |
| *** ctbruce has quit IRC | 15:27 | |
| JPohlmann | Mmh, Clojure | 15:31 |
| *** fay_ has quit IRC | 15:32 | |
| *** ssam2 has quit IRC | 15:53 | |
| rjek | https://twitter.com/cultureshipname/status/726077195135913985 | 15:54 |
| *** edcragg has quit IRC | 16:45 | |
| *** gtristan has quit IRC | 16:48 | |
| *** gtristan has joined #baserock | 16:48 | |
| *** tiagogomes has quit IRC | 16:48 | |
| *** franred has quit IRC | 17:13 | |
| *** anahuelamo has quit IRC | 17:18 | |
| *** anahuelamo has joined #baserock | 17:18 | |
| *** rdale has quit IRC | 17:43 | |
| *** cosm has quit IRC | 18:20 | |
| *** gtristan has quit IRC | 18:47 | |
| *** gtristan has joined #baserock | 18:56 | |
| *** locallycompact has quit IRC | 19:06 | |
| *** Lachlan1975 has quit IRC | 19:12 | |
| *** richard_maw has joined #baserock | 19:18 | |
| *** ChanServ sets mode: +v richard_maw | 19:18 | |
| *** gtristan has quit IRC | 22:34 | |
| *** gtristan has joined #baserock | 22:43 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!