*** kejiahu has quit IRC | 00:37 | |
*** kejiahu has joined #baserock | 00:37 | |
*** edcragg has joined #baserock | 10:16 | |
*** edcragg has quit IRC | 10:54 | |
*** edcragg has joined #baserock | 10:56 | |
*** edcragg has quit IRC | 11:05 | |
*** edcragg has joined #baserock | 11:12 | |
jjardon | Hi, was there any technical reason to hardcode the use of /src instead use the user home directory with the directorirs specify in the XDG Base Directory Specification? | 11:21 |
---|---|---|
straycat | hardcode the use of /src for storing morph cache etc? | 11:22 |
paulsherwood | jjardon: one thing was/is so that /src can be mounted as a separate volume, i believe | 11:41 |
paulsherwood | what would be the advantage of changing? | 11:41 |
* paulsherwood googles, and notices ryan lortie in the thick of xdg specification | 11:42 | |
jjardon | It would make easier to run morph outside chroot/vm | 11:57 |
straycat | iirc the only hardcoded part is the location of the morph.conf file | 11:59 |
jjardon | paulsherwood: also, you can still mount your local folder as a separate volume | 12:11 |
paulsherwood | jjardon: ok | 12:18 |
paulsherwood | jjardon: would you accept foo-tools or foo-set rather than foo-stratum ? | 12:18 |
paulsherwood | or foo-things :) | 12:20 |
paulsherwood | or foo-group | 12:20 |
jjardon | :) From those options I would prefer foo-group | 12:20 |
paulsherwood | straycat: can i interest you in the above? | 12:21 |
paulsherwood | (if so i'll send patches...) | 12:22 |
straycat | hrm, cat of little brain today, what is this in relation too? | 12:22 |
straycat | *to | 12:22 |
paulsherwood | my RFC on the list... trying to disambiguate ruby chunk and ruby stratum etc | 12:22 |
straycat | oh, i'd forgotten about the ml, hang on | 12:23 |
*** gary_perkins has joined #baserock | 12:24 | |
straycat | oh, i don't personally find that a problem | 12:25 |
jjardon | paulsherwood: Id say go ahead and write the patch, your proposal makes sense doesn't matter the name | 12:26 |
paulsherwood | jjardon: ok, i'll do that | 12:27 |
straycat | why is it confusing? | 12:28 |
paulsherwood | two main reasons i think... | 12:29 |
paulsherwood | 1) for users, a name should mean one thing (eg ruby should mean the ruby program, not the collection of things required to build ruby imo) | 12:30 |
paulsherwood | 2) from a code point of view, it would be simpler if names were unique | 12:31 |
straycat | i don't think so, right now the names add no information, you could remove them if you wanted | 12:32 |
jjardon | paulsherwood: Do you have any opinnions about https://gerrit.baserock.org/#/c/14/ ? | 12:32 |
paulsherwood | straycat: they get reported to users all the time | 12:32 |
paulsherwood | (in logs) | 12:32 |
straycat | okay i must be mistaken | 12:33 |
paulsherwood | jjardon: that appears to provoke very strong reactions from others, in both directions! :) | 12:35 |
straycat | just have an alias for --build-log-on-stdout and be done | 12:35 |
jjardon | paulsherwood: yeah, thats why I wait to commit even it already have 2 +1 for long time | 12:35 |
jjardon | straycat: sure, any suggestions? | 12:36 |
paulsherwood | jjardon: what's wrong with straycat's suggestion? (although i admit it took me a *long* time to realize that this option existed) | 12:36 |
paulsherwood | jjardon: i think he means user can set an alias | 12:37 |
straycat | well, it was only there for distbuild >.> i still think a nicer interface for accessing the existing build logs might be nice, but we can do both | 12:37 |
jjardon | My point in the comment that its going to be more likely that a baserock user is interesed in the build log than in the log from morph, and probably the intuitive option would be to use -v for this. But anything would be better then --build-log-on-stdout :) | 12:37 |
straycat | jjardon, i don't know what it should be called really | 12:37 |
paulsherwood | jjardon: i do agree with you. personally i find morph's actual log to be of approximately zero usefulness | 12:38 |
paulsherwood | (which leads me normally to hack morph and make it print what i need) | 12:39 |
straycat | it's useful for developers, less useful for users | 12:39 |
jjardon | exactly, I think the option shoulw be --morph-log-on-stdout for the morph log and -v for the actual build | 12:40 |
paulsherwood | jjardon: i agree, i'm reluctant to get drawn into a religious debate :) | 12:41 |
paulsherwood | jjardon: wouldn't it be better if morph just clearly told the user where the build log went, rather than spewing it onscreen, though? | 12:42 |
straycat | alright, so use the verbose log for build output etc | 12:43 |
straycat | and have a --debug option | 12:43 |
straycat | or something | 12:43 |
jjardon | paulsherwood: sure, but I think thats a different bug | 12:43 |
paulsherwood | jjardon: but if it were fixed, would you still see a real need for that patch? | 12:44 |
straycat | I don't know why we don't just drop the build logs into the definitions repo like we do for distbuild really, perhaps because then that doesn't really give you a good way to look at older logs | 12:45 |
jjardon | paulsherwood: yes, one step less if I can see the output instead check the output file (I can simply scroll in my terminal). For example, jhbuild shows everything on the terminal; maybe Im used to that | 12:46 |
straycat | iirc nix also prints everything when it builds | 12:47 |
straycat | well, at least that can be configured | 12:47 |
paulsherwood | ybd just displays the build commands it runs, at the moment, while putting the log in the artifacts directory | 12:47 |
paulsherwood | (which i think is a reasonable soln) | 12:48 |
paulsherwood | (since the log is an artifact) | 12:48 |
straycat | that's where the build logs are right now in morph | 12:49 |
paulsherwood | straycat: only on success, iirc? last time i looked in detail morph was putting them in some failed tmpdir? | 12:53 |
paulsherwood | also, morph doesn't feature the name of the component in the name of the build-log, which is... .annoying :) | 12:54 |
jjardon | paulsherwood: Did you submit a bug about that? :) | 12:56 |
paulsherwood | no. i could submit a patch, though :) | 12:58 |
straycat | paulsherwood, possibly, i don't remember | 13:00 |
straycat | jjardon, btw i did comment on your response to https://gerrit.baserock.org/#/c/207/1/morphlib/sourceresolver.py | 13:02 |
straycat | i'm really hoping this versioning stuff gets sorted this week because it's already holding stuff up | 13:02 |
jjardon | paulsherwood: thats even better :) | 13:04 |
straycat | indeed patches welcome! | 13:04 |
*** straycat is now known as undeadcat | 13:04 | |
* jjardon starts to think that maybe the jmacs suggestion to set in the definitions the needed version of morph would be better | 13:06 | |
undeadcat | what's wrong with what we have? | 13:08 |
undeadcat | i mean, i'd like to make it a set rather than a list as richard_maw suggested, but other than it works fine | 13:10 |
undeadcat | also, having a version of definitions gives us more control in morph, i think | 13:10 |
undeadcat | i mean, morph is where the decisions are made | 13:10 |
* paulsherwood looks at the backlog of changes waiting to go into morph, and decides not to increase it by sending patches | 13:25 | |
jjardon | paulsherwood: send it anyway. While some patches require more time for review because needs the approval of a more experience morph developer , others can be easily reviewed by anyone | 13:34 |
undeadcat | paulsherwood, should be okay? unless your change changes the definitions format :) | 13:34 |
paulsherwood | undeadcat: :) | 13:35 |
jjardon | undeadcat: returning 0 is exactly what I'm suggesting: "I think maybe its better in _parse_version_file to return "0" instead None if we are not able to parse the file" | 13:42 |
undeadcat | i don't get that, the parse function should just parse | 13:45 |
undeadcat | then if you get None, return 0 | 13:45 |
undeadcat | so functionally equivalent, but without putting the policy into the parser | 13:45 |
jjardon | also, no need to change that whn we stop supporting version 0: In that case we will detect we are version 0 and we will fail (which is the correct thing to do) | 13:53 |
*** pedroalvarez has quit IRC | 13:53 | |
*** flatmush has quit IRC | 13:53 | |
*** kejiahu has quit IRC | 13:53 | |
*** jjardon has quit IRC | 13:53 | |
*** simonh_ has quit IRC | 13:53 | |
*** inara` has quit IRC | 13:53 | |
*** Zara has quit IRC | 13:53 | |
*** bwh has quit IRC | 13:53 | |
*** petefotheringham has quit IRC | 13:53 | |
*** rjek has quit IRC | 13:53 | |
*** petefoth has quit IRC | 13:53 | |
*** sambishop has quit IRC | 13:53 | |
*** paulsherwood has quit IRC | 13:53 | |
*** ctgriffiths has quit IRC | 13:53 | |
*** JPohlmann has quit IRC | 13:53 | |
undeadcat | okay yes Kinnison said that too | 13:54 |
*** kejiahu has joined #baserock | 13:55 | |
*** jjardon has joined #baserock | 13:55 | |
undeadcat | jjardon, okay yes Kinnison said that too | 13:55 |
*** simonh_ has joined #baserock | 13:56 | |
*** inara` has joined #baserock | 13:56 | |
*** Zara has joined #baserock | 13:56 | |
*** petefotheringham has joined #baserock | 13:56 | |
*** bwh has joined #baserock | 13:56 | |
*** rjek has joined #baserock | 13:56 | |
*** pedroalvarez has joined #baserock | 13:58 | |
*** flatmush has joined #baserock | 13:58 | |
*** barjavel.freenode.net sets mode: +v pedroalvarez | 13:58 | |
*** petefoth has joined #baserock | 13:58 | |
*** sambishop has joined #baserock | 13:58 | |
*** paulsherwood has joined #baserock | 13:58 | |
*** ctgriffiths has joined #baserock | 13:58 | |
*** JPohlmann has joined #baserock | 13:58 | |
undeadcat | jjardon, i'll rework it to not raise that exception when i get a moment | 13:59 |
paulsherwood | jjardon: https://gerrit.baserock.org/#/c/218/ | 14:03 |
undeadcat | hrm, i'm tempted to submit something as a draft | 14:36 |
*** edcragg has quit IRC | 14:37 | |
undeadcat | gerrit > 2.3 has this iirc? | 14:37 |
*** edcragg has joined #baserock | 14:38 | |
undeadcat | paulsherwood, i wonder whether that might require some changes to the cache fetch stuff | 14:38 |
jjardon | undeadcat: thanks | 15:08 |
jjardon | paulsherwood: nice, reviewed :) | 15:08 |
paulsherwood | jjardon: i'm not sure whether my reply to your comment is sent or not... it says 'draft' on my screen | 15:12 |
* paulsherwood finds a different way to reply in gerrit | 15:15 | |
undeadcat | paulsherwood, yes you need to go back up to the change and then click reply for all your draft comments to be submitted | 15:16 |
undeadcat | i think this confuses everyone new to gerrit | 15:17 |
paulsherwood | undeadcat: :-) | 15:19 |
* undeadcat discovers the show-dependencies command | 15:26 | |
jjardon | undeadcat: ty for the review, I will reword and send back | 15:31 |
undeadcat | np :) | 15:43 |
*** edcragg has quit IRC | 16:25 | |
jjardon | Do anyone know if the port to armv8b64 has been completed? | 17:04 |
paulsherwood | i believe it has... kejiahu ? | 17:11 |
richard_maw | last I saw there were still patches on gerrit, and I'm not at all fond of the approach taken to allow a separate boot partition | 17:13 |
paulsherwood | ah, ok | 17:36 |
jjardon | Do you know if there is a place somewhere (storyboard?) when I can take a look to the remaining items? | 17:37 |
paulsherwood | jjardon: i don't understand your question, sorry | 17:49 |
jjardon | Do you know if there is a place somewhere (maybe storyboard?) where I can take a look to the remaining items of the armv8b64 port? | 17:50 |
*** undeadcat is now known as straycat | 17:58 | |
straycat | richard_maw, https://gerrit.baserock.org/219 is a draft of the change i was working on yesterday | 18:59 |
straycat | bah, i should have added you as a reviewer before i wrote the "cover letter" comment | 19:01 |
richard_maw | straycat: remind me to take a look at it tomorrow, I'm not capable today | 19:36 |
straycat | hehehe :) | 19:44 |
straycat | okay thanks :) | 19:44 |
*** gary_perkins has quit IRC | 22:02 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!