| *** pedroalvarez has quit IRC | 01:00 | |
| *** pedroalvarez has joined #baserock | 01:01 | |
| *** ChanServ sets mode: +v pedroalvarez | 01:01 | |
| *** jjardon has quit IRC | 04:47 | |
| *** jjardon has joined #baserock | 04:50 | |
| *** pacon has quit IRC | 06:28 | |
| *** pacon has joined #baserock | 06:28 | |
| *** pacon has quit IRC | 06:32 | |
| *** pacon has joined #baserock | 06:32 | |
| *** pacon has quit IRC | 07:07 | |
| *** pacon has joined #baserock | 07:08 | |
| *** pacon has quit IRC | 07:19 | |
| *** pacon has joined #baserock | 07:20 | |
| *** wdutch_ has joined #baserock | 07:44 | |
| *** pacon has quit IRC | 09:22 | |
| *** pacon has joined #baserock | 09:23 | |
| *** rdale has joined #baserock | 10:49 | |
| * straycat tries to do something useful with the branch morph series | 11:24 | |
| straycat | Okay, so let's leave the branching for now, and leave unversioned == version 0 | 11:34 |
|---|---|---|
| straycat | the main thing I'm after here is getting this bug fixed, and the fix kinda got lost in the noise | 11:34 |
| straycat | pedroalvarez, ping | 11:45 |
| paulsherwood | which is the bug, again? | 11:48 |
| straycat | you can put a path to a file that doesn't exist in your morph field and morph will just fetch the morph from the chunk repo or do build system detection, without giving any kind of warning | 11:49 |
| paulsherwood | ah | 11:51 |
| *** rdale has quit IRC | 12:12 | |
| *** pacon has quit IRC | 13:08 | |
| straycat | ! [remote rejected] HEAD -> refs/publish/master/straycat/fix-invalid-chunk-morph-ref-bug (no new changes) | 13:46 |
| straycat | hmmm | 13:46 |
| * straycat proposes https://gerrit.baserock.org/207 and https://gerrit.baserock.org/208 | 13:59 | |
| jjardon | straycat: not sure you have to add a new definitions version; I actually consider the fact that morph doesn't warn you / don't fail when a reference morph file doesn't exist a bug | 14:45 |
| straycat | it is a bug, but if we fix it without supplying a conditional and a version update then we could theoretically break someone's definitions | 15:22 |
| straycat | i'm playing devil's advocate here because i originally argued this shouldn't introduce a new version of definitions, but consensus seemed to be that it should | 15:23 |
| paulsherwood | i don't think it should introduce a new version of definitions either | 15:24 |
| paulsherwood | i wonder if i believed the opposite before? :0 | 15:25 |
| richard_maw | it _is_ a change | 15:26 |
| richard_maw | if it could break someone's definitions, it's a version change | 15:27 |
| doffm | How do I find the baserock version inside a baserock system? | 15:30 |
| doffm | Does baserock have a release file? | 15:30 |
| paulsherwood | richard_maw: only because of a bug in morph + a bug in their definitions | 15:32 |
| rjek | Do we still have an /etc/lsb_release? | 15:32 |
| rjek | I mean /etc/os-release | 15:32 |
| paulsherwood | yes but with no version number | 15:33 |
| paulsherwood | doffm: closest thing is the meta files in /baserock i think | 15:33 |
| doffm | paulsherwood, rjek: Thanks. I'll just skip version number. Check os-release. | 15:34 |
| paulsherwood | doffm: not sure os-release helps you much? | 15:34 |
| richard_maw | paulsherwood: So what if it is because of a bug? It is _still_ a version break, and we can only justify changing the behaviour without bumping the version if we are sure nobody will notice | 15:46 |
| straycat | It's a fair enough reason to introduce a new version, I don't really mind either way, just want the fix ;) | 15:53 |
| jjardon | richard_maw: if it breaks is because the user definitions is broken. Its a but not a definitions format change | 16:07 |
| jjardon | Its a bug* | 16:07 |
| * straycat proposes https://gerrit.baserock.org/209 | 16:08 | |
| jjardon | straycat: thanks for teaching me proper python :) | 16:12 |
| straycat | glad you like it :) | 16:19 |
| paulsherwood | straycat: that looks very elegant :) | 16:35 |
| straycat | thank you :) | 16:38 |
| jjardon | straycat: I commented in https://gerrit.baserock.org/#/c/207/ Do you think makes sense? | 16:39 |
| straycat | Ahh yes, I didn't think that the version file itself might change | 16:41 |
| straycat | bah, http://sprunge.us/PGQM is pretty vague and seems to surprise the folks in #virt | 18:36 |
| straycat | maybe morph shouldn't assume a default NIC_CONFIG for kvm deployments | 18:37 |
| straycat | no i guess it's fine as it is, if you want to deploy to a bridge then you should specify a NIC_CONFIG for that, there's no reason to make everyone specify NIC_CONFIG | 18:45 |
| jjardon | investigating how to do the builds faster, I wonder if someone has already taken a look to icecream? https://github.com/icecc/icecream | 20:26 |
| rjek | jjardon: ISTR people looking at it 2 years or so ago, and dismissing as complex and not significantly better than distcc | 21:14 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!