| *** zoli__ has quit IRC | 01:20 | |
| *** SotK has quit IRC | 01:28 | |
| *** SotK has joined #baserock | 01:28 | |
| *** petefoth has joined #baserock | 06:47 | |
| *** pacon has joined #baserock | 07:24 | |
| *** pacon has quit IRC | 07:32 | |
| *** a1exhughe5 has joined #baserock | 08:12 | |
| *** gfinney_ has joined #baserock | 08:18 | |
| *** gfinney has joined #baserock | 08:20 | |
| *** mdizzle has joined #baserock | 08:27 | |
| *** rdale has joined #baserock | 08:34 | |
| *** rdale has quit IRC | 08:38 | |
| *** rdale has joined #baserock | 08:43 | |
| *** bashrc has joined #baserock | 09:03 | |
| *** jonathanmaw has joined #baserock | 09:12 | |
| *** CTtpollard has joined #baserock | 09:20 | |
| *** tiagogomes_ has joined #baserock | 09:28 | |
| *** gary_perkins has joined #baserock | 09:38 | |
| tiagogomes_ | hey, could someone else review my patches for Moonshot deployment? | 10:03 |
|---|---|---|
| *** ssam2 has joined #baserock | 10:04 | |
| *** ChanServ sets mode: +v ssam2 | 10:04 | |
| * ssam2 begins operation "why does master of definitions not build on my Jetson" | 10:05 | |
| pedroalvarez | good luck :/ | 10:06 |
| franred | ssam2, good luck :S | 10:07 |
| pedroalvarez | tiagogomes_: I have a nitpick - you are installing the m400-1003.dtb file using INSTALL_FILES and also you are modifying the kernel in a moonshot configure extension. Would it make sense to install the dtb file also in the configure extension given that you always need it? | 10:10 |
| Kinnison | pedroalvarez: We're only installing the .dtb in the install-files because we're still waiting for a kernel patch to get it installed by-default from the kernel build | 10:11 |
| Kinnison | pedroalvarez: sadly we don't have the redistributable source yet | 10:11 |
| pedroalvarez | ok, so this is because we expect it to dissapear from definitions.git | 10:12 |
| Kinnison | We do. | 10:13 |
| tiagogomes_ | yep | 10:13 |
| pedroalvarez | fair | 10:13 |
| *** Krin has joined #baserock | 10:17 | |
| ssam2 | some of the artifacts that fail to build were cached, before I hid my artifact cache, so either this system image is broken, or Morph is broken | 10:18 |
| * tiagogomes_ is still puzzled why morph starting building everything from scratch yesterday | 10:20 | |
| ssam2 | I have a suspicion that my breakage is because my shared artifact cache (not cache.baserock.org) has a cached version of stage1-binutils that links against /lib/ld-linux.so.3 instead of /lib/ld-linux-armhf.so.3 | 10:32 |
| ssam2 | this ABI break in GLIBC has highlighted a problem in our bootstrap process, I guess... if I'm correct that this is the problem, it shows that we should have tracked the ABI break in cache keys somehow | 10:33 |
| ssam2 | bootstrap chunks should have some kind of 'bootstrap abi' field perhaps... | 10:34 |
| ssam2 | we could include the cache key of the host Baserock system, but this would greatly decrease the usefulness of Mason, because artifacts from cache.baserock.org would only be usable by people also running that exact version of Mason... | 10:34 |
| ssam2 | i reckon the reason nobody else has had this problem is that I'm using a different, quite old shared artifact cache, where most people use cache.baserock.org | 10:35 |
| pedroalvarez | ssam2: ah! so you are not building it from scratch | 10:35 |
| ssam2 | i've not yet build stage1-binutils from scratch, I'm going to try that now | 10:36 |
| pedroalvarez | ssam2: indeed, this is a problem in our bootstrap process.. | 10:47 |
| pedroalvarez | we sitll have another one, when a crossbootsraped stage1 gcc has the same cache key as a normal strage1 gcc | 10:48 |
| pedroalvarez | but that one is easy to fix | 10:48 |
| Zara | so, I've been slowed down a lot this last week by various conflicts between master of definitions and morph. I'm wondering if there's any way to improve testing before merge to master. | 10:49 |
| ssam2 | right now, the solution is test new branches when it's sent for review, and give it a -1 if it breaks stuff for you | 10:49 |
| ssam2 | s/it's/they are/ | 10:50 |
| ssam2 | the future goal, which tlsa is working on at the moment, is to run Mason's tests on candidate branches of definitions before they get merged, instead of testing master | 10:51 |
| Zara | ah, cool, I was going to ask if there was any way to use Mason beforehand. I'm not unwilling to test branches, but there are so many that it's not feasible for all of them, and sometimes it takes a while to tell that things are broken. | 10:52 |
| ssam2 | yes, it takes a bit of knowledge to know which ones are the dangerous ones :) | 10:53 |
| ssam2 | ok, i built stage1-binutils from scratch this time, and it's still broken (presumably linked against the wrong ld.so again) | 10:54 |
| ssam2 | but gcc on this system definitely doesn't link against the wrong ld.so, so.... | 10:54 |
| *** paulsherwood has joined #baserock | 10:58 | |
| ssam2 | I notice that config.guess has detected the system type as armv7l-unknown-linux-gnueabihf but TARGET_STAGE1 is armv7lhf-bootstrap-linux-abi .... maybe this is breaking things? | 11:11 |
| ssam2 | sorry, TARGET_STAGE1 is armv7lhf-bootstrap-linux-gnueabi | 11:15 |
| ssam2 | but the abi field doesn't end in 'hf', and maybe things expect it to now... i don't know | 11:15 |
| jjardon | Hey, does anyone here have a rp2? Does someone try to put baserock on it? | 11:42 |
| rjek | It's ARMv7, should just work | 11:42 |
| rjek | Still only 1GB of RAM, so I wouldn't want to build on it | 11:43 |
| straycat | won't the bootloader on the rp2 be something we'd need to do a bit of work on? | 11:46 |
| *** CTtpollard has quit IRC | 11:57 | |
| pedroalvarez | jjardon: I almost buy one just to do that, but then I though that for builds they won't be faster than the wandboards, and I don't know what else I could put on it | 12:05 |
| Kinnison | pedroalvarez: Did you ever finish the port to the RPi 1? | 12:06 |
| radiofree | straycat: we could provide a rootfs and leave the bootloader/kernel config as an exercise for the reader | 12:06 |
| pedroalvarez | Kinnison: nope, I gave up when I found that morph couldnt build with the kernel I was using in the RPI (raspbian kernel) | 12:08 |
| Kinnison | Okies | 12:08 |
| ssam2 | I don't think i'll be able to do a 15.09 release today, still debugging this bootstrap breakage on Jetson | 12:08 |
| ssam2 | it is totally mindbending | 12:08 |
| pedroalvarez | Kinnison: are you interested? | 12:08 |
| Kinnison | I have an rpi which was given to me for xmas | 12:08 |
| Kinnison | I was going to use it to write a smart snake vivarium monitor | 12:08 |
| Kinnison | but I can use raspbian | 12:09 |
| Kinnison | it's fine | 12:09 |
| straycat | my friend has an rpi2 and wanted to try baserock on it | 12:09 |
| straycat | radiofree, hrm, i guess :) | 12:09 |
| radiofree | ssam2: what bootstrap breakage? | 12:11 |
| ssam2 | I get a build failure in stage1-gcc when building master | 12:13 |
| ssam2 | i'm interested if you see the same thing | 12:13 |
| ssam2 | I've previously built the same commit successfully beyond master, but that was using cached artifacts | 12:13 |
| ssam2 | if I hide cache/artifacts I see the build failure (which is caused by 'armv7lhf-bootstrap-linux-gnueabi-as' being linked against ld-linux.so instead of ld-linux-armhf.so) | 12:14 |
| ssam2 | i'm totally at a loss to how it's happening so far | 12:14 |
| radiofree | does stage1-gcc use the hosts compiler? | 12:16 |
| rdale | yes | 12:16 |
| radiofree | ssam2: what version of gcc do you have on the host | 12:17 |
| ssam2 | 4.9.2 | 12:17 |
| ssam2 | the host is a really recent build of master | 12:17 |
| ssam2 | if I compile binutils on the host outside of morph, it works. And if I unpack the binutils chunk from the cache, it works | 12:17 |
| radiofree | :\ | 12:18 |
| ssam2 | but the version that makes it into the staging area doesn't workj | 12:18 |
| ssam2 | obviously I'm missing something, but no idea what | 12:18 |
| radiofree | i could try compiling master on my br machine | 12:18 |
| radiofree | jetson | 12:18 |
| ssam2 | if you could run a build with a clean artifact cache, and --artifact-cache-server and --trove-host set to none i'd much appreciate it | 12:19 |
| radiofree | well i don't really want to clean the artefact cache? can i just add "echo HELLO!" to binutils morph and build from there? | 12:20 |
| pedroalvarez | radiofree: that should be enough :) | 12:21 |
| ssam2 | radiofree: just move it out of the way | 12:22 |
| radiofree | /dev/sda1 109.9G 93.2G 11.1G 89% /src :\ | 12:22 |
| radiofree | oh well, i'll just build from master over the weekend | 12:23 |
| * radiofree nukes his artifacts | 12:23 | |
| pedroalvarez | mv /src/cache/artifacts /src/cachhe/artifacts-bkp? | 12:23 |
| radiofree | oh wait, maybe i can't rebuild from master over the weekend if this doesn't work | 12:23 |
| radiofree | yeah, i'll mv it | 12:23 |
| radiofree | should i clean out /src/cache? | 12:25 |
| radiofree | /src/cache/ccache even | 12:25 |
| ssam2 | i forgot about ccache, I think it's not used | 12:25 |
| ssam2 | but maybe that's the problem, who knows | 12:25 |
| radiofree | well i mv it | 12:26 |
| *** pacon has joined #baserock | 12:29 | |
| radiofree | ssam2: how long into the build does it take for it to fail? | 12:42 |
| radiofree | 2015-02-27 12:39:29 [Build 2/192] [stage1-gcc] Running build-commands | 12:42 |
| radiofree | by "master" did you mean master of definitions? | 12:43 |
| ssam2 | not sure. i'm running another build and it seems to be taking longer than it did before | 12:43 |
| ssam2 | yes, master of definitions | 12:43 |
| radiofree | ok | 12:43 |
| ssam2 | oh, my build just failed again | 12:44 |
| ssam2 | i keep thinking "Oh it's worked this time" just as it fails | 12:44 |
| ssam2 | error building target libgcc | 12:44 |
| *** zoli__ has joined #baserock | 12:50 | |
| ssam2 | radiofree: to actually answer your question, about 13 minutes | 12:50 |
| radiofree | i'm 13 minutes in now, this is exciting | 12:52 |
| jjardon | hi, seems there is something wrong with the indentation of the mailing list archives? http://listmaster.pepperfish.net/pipermail/baserock-dev-baserock.org/2015-February/thread.html | 12:58 |
| radiofree | jjardon: that seems to be a common problem with mailman? | 12:59 |
| radiofree | i have seen archives like that before | 13:00 |
| radiofree | ssam2: well i'm > 20 minutes in now | 13:01 |
| ssam2 | right | 13:02 |
| ssam2 | what sha1s of morph and what sha1 of definitions is it? and how old is your devel system? | 13:02 |
| radiofree | ssam2: how do i find out how old my devel system is? | 13:02 |
| ssam2 | /baserock/*-rootfs.meta | 13:03 |
| radiofree | "sha1": "83db755ad2d104af9084e567962bc6d0078dd4d1", | 13:04 |
| ssam2 | ok, thanks | 13:04 |
| radiofree | as for morph, i'm still using your "Hack petrify command into working again" branch | 13:04 |
| radiofree | so i guess the last "real" morph commit there is 1d7e39b955f4da58230f9c5a06ff1b05f8bc020b | 13:04 |
| radiofree | oooh | 13:07 |
| radiofree | actually | 13:07 |
| radiofree | it might still fail | 13:07 |
| radiofree | i've booted into the wrong kernel | 13:07 |
| radiofree | so this thing might still fail | 13:08 |
| ssam2 | what do you mean? | 13:08 |
| ssam2 | oh bum! I forgot about the chunk hardlink cache!!! | 13:08 |
| radiofree | my jetson is probably only running ~ 200MHz | 13:08 |
| * ssam2 looks forward to SotK killing it forever with OStree | 13:08 | |
| radiofree | i'll abort and tree again | 13:09 |
| ssam2 | I think my original assessment of the problem may have been correct (ABI break in glibc on ARM that the cache key doesn't track), i'll run a build with $tempdir/chunks deleted and see | 13:10 |
| *** zoli__ has quit IRC | 13:11 | |
| radiofree | tiagogomes_: you can ignore my 50 minute systemd benchmark (i think) | 13:13 |
| radiofree | i was booting into the wrong kernel on my jetson | 13:13 |
| radiofree | s/into/with | 13:13 |
| *** zoli__ has joined #baserock | 13:16 | |
| tiagogomes_ | radiofree are you saying that you built systemd in 50m running just at 200MHz!? | 13:29 |
| kejiahu | can anybody help me with the error please? http://paste.baserock.org/miguhidevi . also, markupsafe can be built if I checkout it from upstream and manually run build command | 13:54 |
| pedroalvarez | ssam2: that might be it, but, wasn't it failing in stage1-binutils? | 13:54 |
| SotK | kejiahu: the stratum containing markupsafe needs to build-depend on python-core | 13:54 |
| *** a1exhughe5 has quit IRC | 13:55 | |
| kejiahu | SotK, shouldn't that been defined in morph file already? | 13:56 |
| SotK | we recently moved setuptools and some strata didn't get updated | 13:56 |
| SotK | I think this is fixed in master of definitions though | 13:57 |
| kejiahu | SotK, thanks | 13:57 |
| straycat | I kind of feel that python-setuptools might have been better left in core | 13:58 |
| straycat | perhaps it's a bit late to be saying that, I missed the patch that moved it | 13:58 |
| * straycat disappears | 13:59 | |
| franred | straycat, as far as we fix it, it is not more pain | 14:06 |
| *** CTtpollard has joined #baserock | 14:07 | |
| tiagogomes_ | hey richard_maw, as you were the one to write the pxeboot extension, would have you time to review it? | 14:09 |
| *** a1exhughe5 has joined #baserock | 14:10 | |
| richard_maw | tiagogomes_: review it for what? | 14:11 |
| * richard_maw lacks context | 14:11 | |
| tiagogomes_ | richard_maw deploying baserock to a moonshot node | 14:12 |
| tiagogomes_ | sorry, I meant reviewing the patches that I've sent to the mailing list yesterday for adding support to deploy baserock into a HP Moonshot node | 14:13 |
| richard_maw | sure, I'll take a look | 14:14 |
| tiagogomes_ | thanks | 14:15 |
| SotK | How do we want the OSTree artifact cache to work with cross-boostrap? | 14:17 |
| Zara | (is there any way of searching branches on g.b.o for files, by name, without cloning the repo? the search bar in the top right doesn't seem able to do this, so I'm guessing not) | 14:30 |
| ssam2 | pedroalvarez: no, it was failing in stage1-gcc, due to being unable to execute programs from stage1-binutils | 14:33 |
| ssam2 | i left a build running over lunch having emptied tmp/chunks and it's got up to stage 21 | 14:33 |
| ssam2 | so I think I was right | 14:34 |
| tiagogomes_ | stage 21 :) | 14:34 |
| radiofree | ssam2: working for me as well | 14:35 |
| ssam2 | right. I shall send an email to the list :( | 14:37 |
| persia | Zara: I believe gitano has an ls-files command, but I don't know how it works. You might ask on #gitano. That said, if we move to a different git server, you'll have to learn a new rune :) | 14:44 |
| *** jonathanmaw has quit IRC | 14:46 | |
| *** jonathanmaw has joined #baserock | 14:46 | |
| Kinnison | I'm not sure quite what you're suggesting there but I dn't think it has what you think it has | 14:47 |
| pedroalvarez | I think the morph-cache-server of a trove has inproved with this patch: http://paste.baserock.org/kojemedanu | 15:10 |
| radiofree | after moving my /src/cache/gits directory back in place, i'm getting | 15:10 |
| radiofree | ERROR: Git directory /src/cache/gits/git___git_baserock_org_baserock_baserock_morph has no commit at ref bc3e042560424b433a408f01725f36cc2d47859c^{tree}. | 15:10 |
| radiofree | when trying to build a system from master of definitions | 15:10 |
| radiofree | rm /src/cache/*.pickle seemed to fix it | 15:12 |
| franred | what Im missing in my cluster to see this error http://paste.baserock.org/afimitucim? | 15:13 |
| ssam2 | radiofree: if your Morph is older than f5163dd418e342fe6e5fb18625828076130a5e57 it's a known bug | 15:13 |
| ssam2 | upgrade to hopefully fix it | 15:13 |
| ssam2 | franred: second item under 'deploy: | 15:14 |
| radiofree | ah ok, i should switch back to master morph (i'm using your petrify branch...) | 15:14 |
| straycat | Zara, git ls-remote | 15:14 |
| ssam2 | radiofree: rebase the petrify branch on top of master if you want | 15:14 |
| ssam2 | freanred: for whatever reason, you have to put: 'deploy:\n name-of-system:\n type: ...' | 15:15 |
| ssam2 | if that makes sense | 15:15 |
| ssam2 | name-of-system can actually be anything, but putting the name of the system is conventional I think | 15:15 |
| franred | ssam2, I forgot to add "relase:" | 15:16 |
| pedroalvarez | franred: as Sam said, it can be whatever :) | 15:16 |
| richard_maw | franred: biff | 15:17 |
| richard_maw | sorry, not franred | 15:17 |
| richard_maw | tiagogomes_: biff | 15:17 |
| Zara | straycat, persia: ah, sorry, I meant if it was possible to do it through the web interface. I should have been clearer. | 15:17 |
| franred | ssam2, oohh, I think I got it | 15:18 |
| persia | Zara: Sorry. No idea. | 15:18 |
| tiagogomes_ | thanks richard_maw! | 15:18 |
| *** pacon has quit IRC | 15:26 | |
| straycat | franred, yeah probably not | 15:30 |
| pedroalvarez | pdar: I don't think you need to resubmit the patch :) It has already a +2 and the commit message can be fixed during the merge | 15:31 |
| pedroalvarez | pdar: do you have push access to g.b.o? | 15:32 |
| pedroalvarez | Q: I've heard that we should move from urllib2 to requests, why? Does it work better? | 15:33 |
| pedroalvarez | i think it was ssam2 ^^ | 15:33 |
| straycat | requests does seem nicer | 15:34 |
| * SotK prefers requests | 15:34 | |
| pdar | pedroalvarez: Oh great! I dont have push access to g.b.o no | 15:35 |
| ssam2 | pedroalvarez: it is better | 15:35 |
| *** zoli__ has quit IRC | 15:36 | |
| pedroalvarez | cool | 15:43 |
| pedroalvarez | I may take a look at it | 15:43 |
| *** gfinney has quit IRC | 16:00 | |
| *** gfinney has joined #baserock | 16:02 | |
| tiagogomes_ | not again ERROR: Git directory /src/cache/gits/git___git_baserock_org_baserock_baserock_morph has no commit at ref bc3e042560424b433a408f01725f36cc2d47859c^{tree}. | 16:04 |
| radiofree | that sounds like the bug i had before tiagogomes_, apparently it's been fixed in morph master | 16:04 |
| jjardon | ssam2: "BAD morphlib/writeexts.py:1:# Copyright (C) 2012-2014 Codethink Limited" :) | 16:12 |
| ssam2 | oh, is that ./check in master of morph ? | 16:19 |
| ssam2 | i'll push a fix | 16:20 |
| *** CTtpollard has quit IRC | 16:23 | |
| franred | why the devel systems for arm and ppc have openstack-clients on them? do we have any openstack running in these machines? | 16:53 |
| franred | pedroalvarez, ^^ | 16:56 |
| ssam2 | you might still want to interact with an openstack cloud | 16:56 |
| ssam2 | I think we should aim for our systems to have the same components in them on all architectures | 16:56 |
| pedroalvarez | I agree | 16:56 |
| franred | fair enough | 16:57 |
| *** petefoth_ has joined #baserock | 16:57 | |
| *** petefoth has quit IRC | 16:58 | |
| *** petefoth_ is now known as petefoth | 16:58 | |
| radiofree | does openstack need kvm? | 16:58 |
| pedroalvarez | franred: also, we don't need to have an openstack running on those architectures. These clients will allow us to deploy to an x86 openstack from arm, for example | 16:59 |
| pedroalvarez | radiofree: it can work with qemu | 16:59 |
| radiofree | qemu-kvm surely | 16:59 |
| radiofree | i wouldn't like to use something not using kvm.... | 16:59 |
| pedroalvarez | We have kvm in baserock :) | 16:59 |
| radiofree | pedroalvarez: yes, kvm is on the kernel side | 17:00 |
| radiofree | you'll be using qemu-kvm for the actual 'meat' | 17:00 |
| pedroalvarez | note that kvm and qemu are the same thing now | 17:00 |
| radiofree | anyway, this stuff https://github.com/siemens/u-boot/tree/jetson-tk1-v4 from siemens might be interesting, kvm on jetson-tvm | 17:00 |
| radiofree | or at least, adds support to u-boot to allow you to use kvm on a jetson | 17:01 |
| persia | There are openstack environments for ARM available. | 17:01 |
| persia | For POWER, they don't use KVM, but rather the POWER hypervisors. I have the impression that there's work happening upstream to add KVM to POWER for the next generation, but I can't confirm this. | 17:02 |
| persia | Also, there are lots of other hypervisors supported, Xen is popular, for example. | 17:02 |
| *** mdizzle has quit IRC | 17:10 | |
| radiofree | persia: sure, but we have a lot of jetsons, baserock works there | 17:12 |
| radiofree | at least needs PSCI support adding to u-boot for hypervisor to work | 17:12 |
| persia | Hrm? | 17:12 |
| persia | Do you mean for remote console to work? | 17:12 |
| radiofree | no i mean for KVM to work at all | 17:14 |
| radiofree | cpu needs to be booted in hyp mode | 17:14 |
| persia | Oh, right. | 17:17 |
| persia | I'm happy with folk using Jetsons: I just wanted to point out there *were* environments where having the openstack clients available for ARM/POWER were useful. | 17:18 |
| persia | Another example that comes to mind is the Servergy hardware, which presented an OpenStack API for logical partitioning of the server. | 17:19 |
| persia | That was PPC, not POWER, but close, and I'd presume anyone doing PPC would start from the POWER systems. | 17:19 |
| radiofree | [ 4.321202] kvm [1]: Hyp mode initialized successfully :D | 17:41 |
| paulsherwood | radiofree: what device? | 17:44 |
| * paulsherwood has missed backscroll | 17:45 | |
| radiofree | jetson | 17:45 |
| tiagogomes_ | knowing James, I would be on jetson | 17:45 |
| tiagogomes_ | bet on | 17:45 |
| jjardon | mmm, running morph test fill up my /tmp directory, known issue? | 17:46 |
| jjardon | tests* | 17:47 |
| paulsherwood | jjardon: do you have a /src partition? | 17:48 |
| paulsherwood | (and is it mounted?) | 17:48 |
| ssam2 | jjardon: how big is your /tmp ? | 17:49 |
| paulsherwood | (and is morph.conf containing tempdir = /src/tmp) | 17:49 |
| jjardon | 2.4G | 17:49 |
| ssam2 | there are some checks in the Yarns that go 'if there's not enough space available, skip this test' but they aren't perfect | 17:49 |
| ssam2 | try setting TMPDIR=/src/tmp | 17:49 |
| ssam2 | ./check doesn't honour morph.conf's tempdir setting | 17:50 |
| * paulsherwood adds that to his list of gripes about morph's test code | 17:50 | |
| jjardon | to be clear: Im running the tests in a chroot, but its my host /tmp the one who gets filled | 17:50 |
| jjardon | paulsherwood: all seem correctly configured in my chroot | 17:51 |
| tiagogomes_ | jjardon did you mount bind /tmp? | 17:51 |
| tiagogomes_ | jjardon, is your host /tmp a tmpfs | 17:52 |
| jjardon | tiagogomes_: it is a tmpfs, yes | 17:52 |
| jjardon | tiagogomes_: not sure, I do what enter-baserock does ;) will check later | 17:53 |
| *** tiagogomes_ has quit IRC | 18:00 | |
| *** ssam2 has quit IRC | 18:08 | |
| *** bashrc has quit IRC | 18:10 | |
| *** jonathanmaw has quit IRC | 18:15 | |
| jjardon | the TMPDIR=/src/tmp hint fixed the issue; paulsherwood: Did you add this to storyboard/wiki or should I? | 18:17 |
| paulsherwood | jjardon: please do | 18:18 |
| *** rdale has quit IRC | 18:19 | |
| pedroalvarez | yay, requests tries 3 times to fetch an artifact: http://paste.baserock.org/esizobagez | 18:20 |
| pedroalvarez | :) | 18:20 |
| jjardon | paulsherwood: btw, probably you already know but python3 is already merged, so I closed the task assigned to you | 18:27 |
| paulsherwood | jjardon: i saw that. sorry, i've been 'on the road' | 18:28 |
| jjardon | sure, dont worry | 18:28 |
| *** sambishop has quit IRC | 18:39 | |
| *** a1exhughe5 has quit IRC | 18:55 | |
| paulsherwood | jjardon: i'm trying to review your versioning code... why precisely do you need all those checks in it at this point? it seems to me that any failcase, or valid version 0 should just assume version 0? any valid version 1 is treated as 1, 2 as 2, etc... ? | 19:05 |
| paulsherwood | (for example, suppose a user has created a VERSION file themselves, containing jrandom something else... morph will now fail for them???) | 19:07 |
| jjardon | paulsherwood: with the current implementation, yes | 19:08 |
| jjardon | VERSION can only be "version: 0" after the patches | 19:08 |
| paulsherwood | that's not useful for users with existing definitions - you break compatibility? i don't see why that is necessary | 19:11 |
| paulsherwood | for example if VERSION is a non-yaml file. morph should just ignore it, not fail | 19:12 |
| jjardon | paulsherwood: not really, definitions without VERSION file is treated as if they have a VERSION file with version: 0 on it | 19:13 |
| jjardon | paulsherwood: yeah, I was not sure about that (VERSION be a yaml file) we can rework that | 19:13 |
| paulsherwood | jjardon: i'm not explaining myself properly, maybe.... | 19:14 |
| paulsherwood | possible cases: | 19:14 |
| paulsherwood | no VERSION file: morph should assume version: 0 | 19:14 |
| paulsherwood | VERSION file contains non-yaml: assume version: 0 | 19:15 |
| paulsherwood | VERSION contains yaml, but version: is undefined or missing: assume version 0 | 19:15 |
| straycat | what's version 0? | 19:15 |
| paulsherwood | VERSION contains yaml, version: is 0 - assume version 0 | 19:15 |
| paulsherwood | VERSION contains yaml, version: is 'something', not 0, then reject unless morph understands the value of 'something' | 19:16 |
| paulsherwood | so there's no need for any testing except can i find a value of version: which is non-zero | 19:17 |
| paulsherwood | straycat: http://wiki.baserock.org/meetup/declarative-definitions/ | 19:17 |
| straycat | oh ok | 19:18 |
| * straycat disappears | 19:18 | |
| paulsherwood | jjardon: we could be even simpler and say VERSION contains yaml and version: is a version we understand, handle it. else assume version 0 | 19:24 |
| jjardon | paulsherwood: you are assuming we are going to carry the code to handle version 0 forever then | 19:26 |
| jjardon | I though the idea is to have a migration path for definitions instead | 19:26 |
| paulsherwood | the idea is to support multiple versions, iiuc. it would be trivial to drop the 'else' at some point. | 19:29 |
| paulsherwood | i am not assuming we carry code to handle version 0 forever - but i do expect we need to support a *set* of versions, not just one at a time | 19:32 |
| *** gary_perkins has quit IRC | 19:35 | |
| *** CTtpollard has joined #baserock | 19:37 | |
| *** CTtpollard has quit IRC | 19:39 | |
| jjardon | "VERSION contains yaml and version: is a version we understand, handle it. else assume version 0"; if we only understand version: 0, we will assume version: 0 if VERSION contains version: 4, for example. Are we sure we want to do that? | 19:39 |
| * jjardon notes that is late on friday so maybe his brain is not working correctly anymore | 19:40 | |
| *** gfinney has quit IRC | 20:05 | |
| *** zoli__ has joined #baserock | 20:31 | |
| paulsherwood | jjardon: if we don't understand 'version: 4' yet, the only options are break, or treat it as version: 0. i prefer not to break by default | 20:35 |
| persia | Perhaps if we can parse the VERSION file, but do not comprehend the version, we can report "This is version X, which this morph doesn't understand. Shall it be treated as version 0?" | 20:38 |
| persia | Whereas if we can't parse it, we declare it version 0. | 20:38 |
| persia | Sadly, lots of people use the "use-latest-morph" instructions to end up with an old morph because they forget to update morph when updating their devel system. | 20:39 |
| *** zoli__ has quit IRC | 22:40 | |
| *** zoli__ has joined #baserock | 22:41 | |
| *** zoli__ has quit IRC | 22:53 | |
| *** pacon has joined #baserock | 23:21 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!