| *** rajm <rajm!~robert@cpc126990-macc4-2-0-cust43.1-3.cable.virginm.net> has joined #cip | 00:40 | |
| *** masami <masami!~masami@FL1-220-144-160-220.tky.mesh.ad.jp> has quit IRC | 01:10 | |
| *** rajm <rajm!~robert@cpc126990-macc4-2-0-cust43.1-3.cable.virginm.net> has quit IRC | 01:11 | |
| *** rajm <rajm!~robert@cpc126990-macc4-2-0-cust43.1-3.cable.virginm.net> has joined #cip | 05:56 | |
| *** monstr <monstr!~monstr@2a02:768:2307:40d6::f9e> has joined #cip | 07:04 | |
| *** toscalix <toscalix!~toscalix@90.167.94.105> has joined #cip | 13:10 | |
| *** Flamefire <Flamefire!~Flamefire@pd9fe9547.dip0.t-ipconnect.de> has joined #cip | 14:37 | |
| Flamefire | Hi guys. I can't make it to the meeting(s) but wanted to let you know that a recent commit to the 4.4.y-st branch (and potentially others) introduced an annoying bug. Commit link: https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/commit/sound/soc/soc-ops.c?h=linux-4.4.y-st&id=7a78bde1faa42e0057350378baf518a04b3bae58 | 14:44 |
|---|---|---|
| Flamefire | The issue is that "val > mc->platform_max" check which would need to be adjusted by "min" as done for a similar function in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/commit/sound/soc/soc-ops.c?h=linux-4.4.y-st&id=e41846dbe6f49d305c1a8fc229c5deabd66e3e24 | 14:44 |
| Flamefire | Others already did that (e.g. https://github.com/baunilla/android_kernel_xiaomi_rosy/commit/969b9d366c1e9564e173aea325ec544dcd7804ff) but I've only found a mention in the kernel ML but seemingly it wasn't resolved | 14:44 |
| Flamefire | This bug (in short) e.g. leads to wired headsets being unusable on phones using this kernel. Due to the to-eager check the mic volume isn't changed leading to a feedback loop. | 14:44 |
| Flamefire | Hope that helps. | 14:44 |
| patersonc[m] | Hi Flamefire | 14:45 |
| patersonc[m] | Thank you for reporting | 14:45 |
| patersonc[m] | Could you also drop an email to the cip-dev mailing list about this? | 14:45 |
| patersonc[m] | Flamefire: https://lists.cip-project.org/g/cip-dev | 14:46 |
| Flamefire | Would you mind forwarding my message? I'm on my dev machine w/o email and not yet subscribed anyway. This issue took me a bit of time to find and I just wanted to make sure someone is aware ;-) | 14:48 |
| patersonc[m] | Flamefire: Will do! If you let me know your email I can add you on copy | 14:50 |
| Flamefire | All good. That's all info I have and as the issue is pretty obvious once found I fixed it in my kernel tree anyway similar to the github link above. Thanks! | 14:52 |
| patersonc[m] | Thanks | 14:53 |
| *** monstr <monstr!~monstr@2a02:768:2307:40d6::f9e> has quit IRC | 15:09 | |
| *** Flamefire <Flamefire!~Flamefire@pd9fe9547.dip0.t-ipconnect.de> has quit IRC | 15:49 | |
| *** alicef <alicef!~none@gentoo/developer/alicef> has quit IRC | 17:27 | |
| *** alicef <alicef!~none@gentoo/developer/alicef> has joined #cip | 17:34 | |
| *** prabhakarlad <prabhakarlad!~prabhakar@pc.renesas.eu> has joined #cip | 18:29 | |
| *** ChanServ sets mode: -o brlogger` | 18:34 | |
| *** ChanServ sets mode: +o collab-meetbot | 18:35 | |
| alicef | ironfoot: I think you can take down brlogger` and compress the logs folder in a tar.gz or similar file | 18:36 |
| alicef | or tar.xz for better compression | 18:37 |
| alicef | how many mb it come out? | 18:37 |
| alicef | if is less than few mb you could send it to us by email | 18:37 |
| *** ChanServ sets mode: +b *!*@45.114.123.168 | 18:39 | |
| *** brlogger` was kicked by ChanServ (User is banned from this channel) | 18:39 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!