| *** rajm has joined #cip | 07:14 | |
| *** toscalix has joined #cip | 07:53 | |
| *** vidda_ has joined #cip | 08:55 | |
| szlin | .o. time to meeting | 09:00 |
|---|---|---|
| szlin | #startmeeting | 09:00 |
| szlin | #topic roll call | 09:00 |
| * szlin please say hi if you're here | 09:00 | |
| vidda_ | hi | 09:00 |
| rajm | hi | 09:01 |
| bwh | hi | 09:01 |
| toscalix | hi | 09:01 |
| gavinlai | hi | 09:01 |
| szlin | #topic kernel patch review | 09:02 |
| szlin | Moxa team are still reviewing 4.4.130, the result will be sent out tomorrow | 09:02 |
| bwh | I'm also reviewing 4.4.130 now | 09:03 |
| szlin | we've got the email from Ben, thanks for the review. | 09:03 |
| szlin | it's interesting that half patches of 4.4.130 belongs to s390 arch. | 09:04 |
| bwh | Ah, we can ignore them, then | 09:05 |
| toscalix | Daniel Sangorrin has sent to cip-dev a review of a failing patch and a potential fix | 09:05 |
| toscalix | probably bwh , you want to have a look | 09:06 |
| bwh | It's a failing test case, should probably go to stable | 09:07 |
| toscalix | ok | 09:07 |
| *** HarryYJ_Jhou has joined #cip | 09:08 | |
| szlin | 2 questions from here | 09:08 |
| szlin | 1. According to https://patchwork.kernel.org/patch/10336267/ | 09:08 |
| szlin | bwh: you had mentioned that this patch is "bit big for stable" | 09:08 |
| bwh | Not the patch I was replying to, but the second one that I referred to | 09:09 |
| szlin | bwh: yes, the patch you mentioned is in https://patchwork.kernel.org/patch/9919313/ | 09:10 |
| bwh | OK, so the question.... | 09:11 |
| szlin | how to define "big" ? | 09:12 |
| bwh | The rule (but it is more of a guideline, not an absolute rule) is that patches should change up to 100 lines | 09:13 |
| szlin | bwh: yes, I saw some patches are over 100 lines. | 09:15 |
| bwh | I know, that's why I said it's a guideline | 09:16 |
| szlin | bwh: thanks. | 09:16 |
| szlin | 2. how to find related fix upstream | 09:17 |
| szlin | for example: https://lkml.org/lkml/2018/5/15/1104 | 09:17 |
| szlin | we've used some tools like cregit and email2git | 09:18 |
| bwh | I think what I did there was to run "git log e279e6d98e0cf2c2fe008b3c29042b92f0e17b1d..torvalds/master drivers/tty/serial/sccnxp.c" to see changes after the first commit | 09:19 |
| bwh | and then I saw there was another commit touching sccnxp_probe() | 09:19 |
| szlin | bwh: thanks for sharing. | 09:20 |
| bwh | The reason I looked was that the first commit added a call to clk_prepare_enable() without a matching clk_disable_unprepare(), which I found suspicious | 09:20 |
| bwh | I mean, that looked like a bug | 09:21 |
| szlin | Any questions? | 09:24 |
| szlin | #topic Misc | 09:24 |
| szlin | The linux-cip-rt mirror on gitlab.com | 09:25 |
| szlin | toscalix: thanks to AgustÃn | 09:25 |
| toscalix | wagi requested it. Easy to do | 09:26 |
| szlin | any questions in misc? | 09:26 |
| toscalix | szlin: I suggest you add the kernel review topic in the TSC f2f meeting at OSSJ | 09:27 |
| toscalix | if the time is right, bwh might join remotely | 09:27 |
| szlin | toscalix: agree | 09:28 |
| szlin | #action SZ will add the kernel review topic in TSC f2f meeting at OSSJ | 09:28 |
| szlin | if there are no more questions, the meeting will be end | 09:28 |
| toscalix | I am starting to prepare the kernel presentation. I will include this action (kernel patch review) as one of the outcomes | 09:28 |
| toscalix | of our current process | 09:28 |
| toscalix | I will send the slide to the ML for review | 09:29 |
| toscalix | slides | 09:29 |
| szlin | #action Agustin will send the presentation slide to ML for review | 09:30 |
| szlin | #endmeeting | 09:30 |
| bwh | szlin: thanks | 09:30 |
| szlin | thanks all | 09:30 |
| gavinlai | thanks | 09:31 |
| toscalix | bye | 09:31 |
| rajm | thanks | 09:31 |
| * rajm provisions fresh vm with the latest master and configures email and notify - BBB HC works and gets sent to the list | 10:00 | |
| rajm | iwg20m still not working though | 10:01 |
| *** vidda_ has quit IRC | 10:34 | |
| * rajm runs a successful iwg20m with email to the list | 12:23 | |
| toscalix | great, what was the problem? | 12:24 |
| rajm | I've no clear idea it may just be the random roll of the dice! however.... | 12:25 |
| rajm | I booted the board outside of lava and noticed FAT-fs (mmcblk2p1): Volume was not properly unmounted. Some data may be corrupt. Please run fsck. | 12:25 |
| rajm | and wondered whether that might be a problem so I manually shutdown the board and then set the power control to be off and ran the health check and it worked, let me try that sequence again! | 12:26 |
| rajm | I've done so - that worked, so tried it again - it failed; tried it again it worked | 12:47 |
| * rajm shrugs | 12:47 | |
| toscalix | rajm: maybe if you sit down with bwh and show him, he can give you ideas | 13:13 |
| rajm | maybe though he's now on leave, will see if patersonc can give some clarification | 13:14 |
| rajm | ...on his return | 13:15 |
| rajm | the current iwg20m test results are (starting from the first OK) OK;OK;Fail;OK;OK;Fail;Fail; and one of the OKs was without doing the manual poweroff and reset dance | 13:22 |
| rajm | I'll document some of this in the appropriate ticket and the journal | 13:24 |
| rajm | But I do have output from a 2018-4 HC for the renesas board so I've created the snippet updated the wiki and closed https://gitlab.com/cip-project/cip-testing/testing/issues/184 | 13:42 |
| *** rajm has quit IRC | 15:45 | |
| *** toscalix has quit IRC | 17:22 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!