| *** patersonc has joined #cip | 06:16 | |
| *** rajm has joined #cip | 07:15 | |
| * rajm runs BBB healthcheck with email to the list | 07:36 | |
| *** toscalix has joined #cip | 08:08 | |
| *** vidda_ has joined #cip | 08:43 | |
| szlin | time to start meeting | 09:00 |
|---|---|---|
| szlin | #startmeeting | 09:00 |
| szlin | #topic roll call | 09:00 |
| toscalix | o/ | 09:01 |
| szlin | please say hi if you are here | 09:01 |
| szlin | ._. | 09:01 |
| szlin | ._./ | 09:01 |
| vidda_ | hi | 09:01 |
| bwh | hi | 09:01 |
| rajm | hi | 09:01 |
| szlin | #topic kernel review status update | 09:02 |
| moxavict1r | hi | 09:02 |
| szlin | Moxa team are reviewing 4.4.130 | 09:02 |
| patersonc | hi | 09:03 |
| gavinlai | hi | 09:03 |
| szlin | the review task might be done in next week. | 09:04 |
| bwh | szlin: great | 09:04 |
| szlin | and the result of review will be sent out to cip-dev afterwards | 09:04 |
| szlin | we have some questions in reviewing task | 09:05 |
| moxavict1r | bwh: if we want to know kernel software architecture, where we can get the document ? | 09:05 |
| bwh | moxavict1r: I think either the document is either in Documentation or doesn't exist | 09:06 |
| bwh | In many cases, unfortunately, important information is not written down | 09:07 |
| moxavict1r | can you give some comment to know kernel software architecture ? | 09:07 |
| patersonc | moxavict1r: Tim Bird published this the other day: https://elinux.org/Developer_Guidelines | 09:08 |
| patersonc | Perhaps some useful information there | 09:08 |
| moxavict1r | OK, thank your information, I will check it | 09:09 |
| patersonc | o/ | 09:09 |
| moxavict1r | the patched code is very much and fast, how can we more fast to review it ? | 09:10 |
| moxavict1r | and how can we know it is right or good ? | 09:11 |
| patersonc | Experience/manpower | 09:11 |
| bwh | moxavict1r: First, ignore the changes that aren't relevant (e.g. architecture or driver not used in CIP) | 09:12 |
| bwh | And like patersonc says, you will get faster with experience | 09:13 |
| moxavict1r | how can I get good experience ? | 09:14 |
| bwh | Without test cases for everything, you're not going to know for sure if the changes are good, but you can catch more of the bad changes | 09:14 |
| bwh | Keep reviewing | 09:14 |
| moxavict1r | good | 09:15 |
| moxavict1r | but how we know the changes are right ? | 09:16 |
| moxavict1r | eg: some changes are about kernel schedule ? | 09:16 |
| bwh | If they're bad, either someone will notice during review or someone will notice afterward and you'll see another fix | 09:17 |
| bwh | and if that doesn't happen, you have to assume they're good | 09:18 |
| moxavict1r | so we need usually to review the code ? | 09:18 |
| moxavict1r | is right ? | 09:19 |
| bwh | Yes I think so | 09:20 |
| moxavict1r | got it, thanks | 09:20 |
| moxavict1r | can we see others code reviewer comment ? | 09:21 |
| bwh | They should all be on the stable@vger.kernel.org list | 09:22 |
| szlin | Have you ever rejected the patches which are from stable kernel in CIP kernel reviewing? | 09:23 |
| moxavict1r | OK. I will check it. | 09:23 |
| bwh | and no, there aren't many review comments - they are only sent if people notice problems | 09:23 |
| szlin | (and these patches are used in CIP | 09:23 |
| bwh | szlin: Yes, I have reverted them after merging from stable and also told Greg they should be reverted in the stable branch | 09:24 |
| szlin | bwh: is it a bug issue? | 09:24 |
| bwh | yes | 09:26 |
| moxavict1r | if some changes are no body to review it, we will merge it to cip kernel ? | 09:26 |
| bwh | moxavict1r: I believe I have reviewed all the relevant changes in the 4.4 stable branch before merging to CIP. | 09:27 |
| bwh | I think CIP should go on doing that | 09:27 |
| moxavict1r | thanks your effort and help | 09:27 |
| szlin | any questions with this topic? | 09:28 |
| moxavict1r | no | 09:28 |
| rajm | o/ more as a WIP | 09:28 |
| rajm | End of last week LAVA in stretch backports moved to version 2018-4 and then was broken | 09:28 |
| rajm | now repaired but to get B@D working small change needed (now in MR) and some wiki changes - in progress | 09:28 |
| szlin | rajm: will we follow the version in stable-backports? | 09:30 |
| rajm | we have been - not an easy was of installing named version from linaro | 09:30 |
| rajm | s/was/way/ | 09:30 |
| szlin | got it, thanks | 09:31 |
| szlin | any questions? | 09:31 |
| toscalix | need to leave too. bye | 09:31 |
| rajm | _o_ | 09:32 |
| szlin | #endmeeting | 09:32 |
| szlin | thank you! | 09:32 |
| rajm | thamks szlin | 09:32 |
| bwh | Thanks | 09:32 |
| rajm | *thanks | 09:32 |
| moxavict1r | thanks | 09:32 |
| *** vidda_ has quit IRC | 10:48 | |
| * rajm has built a set of lava install packages from the instructions here https://staging.validation.linaro.org/static/docs/v2/debian.html but the repos it asks you to clone only has 2018-4 tags - and it builds an install with that name | 12:07 | |
| * rajm has updated the reference test cases page for 2018-4 (more changes) will re-read to see if there's further tailoring needed | 13:43 | |
| *** patersonc has quit IRC | 15:04 | |
| *** rajm has quit IRC | 15:45 | |
| tpollard | urk, 62 patchset explosion | 16:16 |
| *** tpollard has quit IRC | 16:34 | |
| *** toscalix has quit IRC | 17:32 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!