| *** patersonc has joined #cip | 06:34 | |
| *** rajm has joined #cip | 07:12 | |
| *** toscalix has joined #cip | 07:53 | |
| rajm | BBB healthcheck runs with email to the list | 07:58 |
|---|---|---|
| rajm | the renesas HC however.... :-( | 08:14 |
| rajm | though again replacing our initramfs with the yocto core-image-minimal-iwg20m gets the HC to run | 08:23 |
| *** moxavictor has joined #cip | 08:31 | |
| szlin | Here is the proposed agenda for the meeting: | 08:38 |
| szlin | Kernel patch review status | 08:38 |
| *** vidda_ has joined #cip | 08:53 | |
| rajm | but a second attempt at running test (again using core-image-minimal-iwg20m) with lava-tool fails | 09:00 |
| szlin | time for CIP-dev IRC weekly meeting | 09:00 |
| moxavictor | hi everybody | 09:00 |
| szlin | #startmeeting | 09:01 |
| patersonc | hi | 09:01 |
| szlin | #topic Roll Call | 09:01 |
| toscalix | hi | 09:01 |
| vidda_ | hi | 09:01 |
| weshuang | hi | 09:01 |
| rajm | hi | 09:01 |
| * szlin please say hi if you're here | 09:01 | |
| patersonc | hi | 09:02 |
| moxavictor | who know to review kernel patch faster ? | 09:02 |
| szlin | #topic 1. Kernel patch review status | 09:02 |
| szlin | I have sent the status of review email in kernel 4.4.129 | 09:03 |
| szlin | We did not see any problematic patches | 09:03 |
| toscalix | szlin: do you mean you guys reviewed the patches sent to the mailing list? | 09:03 |
| szlin | yes | 09:04 |
| toscalix | directly in the 4.4-stable mailing list? | 09:04 |
| szlin | nope, in cip-dev | 09:04 |
| szlin | as Ben said before. | 09:04 |
| szlin | Email content | 09:05 |
| szlin | ==== | 09:05 |
| szlin | The following items in 4.4.129 are reviewed and mark as LGTM: | 09:05 |
| szlin | 6f051f8986a8 writeback: safer lock nesting 4533f7e1785f watchdog: f71808e_wdt: Fix WD_EN register read | 09:05 |
| szlin | b7b4411c8990 clk: mvebu: armada-38x: add support for missing clocks | 09:05 |
| szlin | 60f6c860c258 HID: core: Fix size as type u32 0ab6b8c91ecf usb: dwc3: pci: Properly cleanup resource | 09:05 |
| toscalix | ah, so you sent the summary | 09:05 |
| szlin | 318a306c53d1 ARM: dts: at91: sama5d4: fix pinctrl compatible string 31118e88019f ARM: dts: at91: at91sam9g25: fix mux-mask pinctrl property | 09:06 |
| toscalix | ok | 09:06 |
| szlin | e23007895028 usb: musb: gadget: misplaced out of bounds check 085c9c4b9e7e cdc_ether: flag the Cinterion AHS8 modem by gemalto as WWAN | 09:06 |
| toscalix | got you | 09:06 |
| szlin | SZ | 09:06 |
| szlin | ==== | 09:06 |
| *** HarryYJ_Jhou has joined #cip | 09:06 | |
| szlin | After this review, victor has a question that "how to review kernel patch in a efficient way" | 09:07 |
| toscalix | moxavictor: since bwh is not here today, I am afraid you will have to send a mail to cip-dev asking the question | 09:08 |
| moxavictor | got it | 09:08 |
| *** Tzongyen_Lin has joined #cip | 09:08 | |
| szlin | we will continue to review the patch - 4.4.130 and send out the review summary to cip-dev. | 09:09 |
| patersonc | szlin: Am I wrong in thinking v4.4.131 has already been released? | 09:09 |
| szlin | yes, 4.4.131 was released 16 hours ago | 09:10 |
| szlin | The release cycle is so quick | 09:10 |
| toscalix | you cannot pretend to beat the big guys, this is about learning | 09:10 |
| szlin | therefore, victor has that question - how to review kernel patch in a efficient way | 09:10 |
| toscalix | I would not focus at this point to be up to date | 09:11 |
| toscalix | pick up some of the latest patches, and if it takes longer for you, fine | 09:11 |
| szlin | that's my thought, stay tuned. | 09:11 |
| toscalix | if you detect a bug, you check if somebody else did already, and that's it | 09:12 |
| toscalix | the process is based on having many users testing the patches, not neccesarily the reviewrs themselves | 09:13 |
| szlin | review the patch step by step and no hurry | 09:13 |
| toscalix | bugs landing in 4.4-131 were discovered in 4.4.50, for instance | 09:14 |
| moxavictor | so, we don't need to review every commit ? | 09:14 |
| toscalix | I would focus first in those which areas you understand and have more control over. You would be more likely to discover issues there | 09:14 |
| patersonc | moxavictor: Perhaps just review patches relevant to your interests/experience for now? | 09:14 |
| moxavictor | OK. | 09:15 |
| toscalix | and expand your knowledge little by little | 09:15 |
| toscalix | this is about adding value, not about review coverage | 09:15 |
| moxavictor | we can learn what to review patch ? | 09:16 |
| toscalix | reviewers and maintainers read a lot of docu | 09:16 |
| toscalix | to do the reviews | 09:16 |
| moxavictor | coding skill ? kernel software architecture ? | 09:16 |
| toscalix | I see reviewers as experts in the kernel development and maintenance process, with a good general overview of how the kernel is structure and works and then they have one or two areas where they excel | 09:17 |
| toscalix | technical areas | 09:18 |
| toscalix | in the rest, they most likely have to read documentation | 09:18 |
| toscalix | they usually know more about problematic areas | 09:18 |
| toscalix | that has required a lot of review lately | 09:18 |
| moxavictor | where we can read it ? | 09:18 |
| toscalix | I am talking from my experience managing kernel hackers | 09:19 |
| szlin | for development process: https://www.kernel.org/doc/Documentation/process/ | 09:20 |
| toscalix | I am not aware of a document about these things. Include this in your question to Ben. I asked him some time ago but maybe there is a new blog post out there useful about these topics | 09:20 |
| moxavictor | good, could I get the blog home page ? | 09:21 |
| toscalix | ... but maybe... | 09:22 |
| toscalix | I mean, I haven't seen anything new/good about this. I would ask Ben if there is something recent | 09:22 |
| toscalix | there was not last time I asked him, a few months back | 09:22 |
| moxavictor | OK | 09:23 |
| moxavictor | thanks | 09:23 |
| szlin | any other questions for patch review? | 09:25 |
| szlin | #topic Miscellaneous | 09:26 |
| szlin | anything to discuss? | 09:26 |
| moxavictor | no question | 09:28 |
| toscalix | _o_ | 09:28 |
| szlin | #endmeeting | 09:28 |
| szlin | thanks all | 09:28 |
| toscalix | bye | 09:28 |
| rajm | thanks | 09:28 |
| *** Tzongyen_Lin has quit IRC | 09:33 | |
| * rajm was about to look at #160 and gets an error on provisioning - trying again with a clean pull from master | 09:47 | |
| rajm | yup - a fresh provision from master is broken I assume a lava update is the problem - creates issue | 09:58 |
| * rajm creates https://gitlab.com/cip-project/cip-testing/testing/issues/183 | 10:01 | |
| *** HarryYJ_Jhou_ has joined #cip | 10:32 | |
| *** HarryYJ_Jhou has quit IRC | 10:34 | |
| *** vidda_ has quit IRC | 10:49 | |
| * rajm finds https://lists.linaro.org/pipermail/lava-announce/2018-April/000051.html | 10:56 | |
| toscalix | rajm: something changed upstream? | 10:56 |
| rajm | yes that's it ^^ | 10:56 |
| rajm | so 2018.4 is now in stretch backports | 10:57 |
| * rajm goes to find lunch maybe brain will be better at working around this afterwards | 10:59 | |
| toscalix | can you make the provisioning point in the mirrors to the tag of the previous versions, so it works while you investigate the impact of the new changes? | 11:12 |
| rajm | that would be a quick temp fix | 11:19 |
| toscalix | that is the advantage to mirror the repos, we control that our "product" is always working | 11:21 |
| toscalix | it should always be working | 11:21 |
| toscalix | so until you figure out what upstream change broke our product... | 11:22 |
| rajm | though lava is being installed from stretch-backports so its only mentioned in our repos rather from the lava dev sources - so need to get a specific version from there | 11:31 |
| toscalix | do we need to revisit the repos we are mirroring maybe? | 11:34 |
| rajm | we're not mirroring anything as far as lava is concerned - or am I missing something? | 11:36 |
| toscalix | should we? | 11:36 |
| toscalix | they change fast | 11:36 |
| toscalix | so at least, when evaluating issues, we have a mechanism to not break the tool | 11:37 |
| toscalix | since we are not releasing images anymore | 11:37 |
| toscalix | we cannot point people to a working image as we used to | 11:37 |
| rajm | and build from source - I suppose that would indeed make things more robust | 11:37 |
| toscalix | the same strategy will apply when usig containers | 11:38 |
| rajm | ok let me see what's involved | 11:39 |
| toscalix | evaluate it and tell me what you think. bwh might have a better suggestion | 11:40 |
| rajm | also I'll subscribe to lava-announce - thought I had but clearly not! | 11:46 |
| * rajm sees very early in install a failure of rng-tools to run, think that install was added at an early stage in the development and wonders if it can be removed | 12:36 | |
| *** patersonc has quit IRC | 12:51 | |
| * rajm finds a shortage of info on installing lava other than from a debian repos but continues looking | 13:17 | |
| toscalix | "shortage of info". I love it, let's keep this level of politeness | 14:44 |
| rajm | I hadn't seen the INSTALL file at that point ;-) ;-) | 14:46 |
| *** rajm has quit IRC | 15:47 | |
| *** tpollard has quit IRC | 16:36 | |
| *** toscalix has quit IRC | 17:33 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!