| AdrianVovk[m] | [Here](https://github.com/apache/buildstream/blob/master/src/buildstream/_projectrefs.py#L149), is `element_list` being permanently mutated in some way? Is there a reason you don't just `return {}`? I'm guessing you need to append to the element_list to actually create the dict in the project.refs file? | 18:04 |
|---|---|---|
| AdrianVovk[m] | Basically, I tracked down https://github.com/apache/buildstream/issues/1851, but I'm not sure how to fix it | 18:06 |
| nanonyme | Adrian Vovk: out of curiosity, does the container that freedesktop-sdk is using work for you? | 18:23 |
| AdrianVovk[m] | nanonyme: I'll give it a test, but I figured out that another issue is due to a lack of fuse3 in the official buildstream/buildstream container | 18:24 |
| AdrianVovk[m] | > <@nanonyme:matrix.org> Adrian Vovk: out of curiosity, does the container that freedesktop-sdk is using work for you? | 18:24 |
| AdrianVovk[m] | * I'll give it a test, but I figured out that the other tracking issue is due to a lack of fuse3 in the official buildstream/buildstream container | 18:24 |
| nanonyme | That is... strange. I don't understand why it wouldn't have fuse3. | 18:24 |
| AdrianVovk[m] | Looks like the dockerfile is installing fuse instead of fuse3 | 18:24 |
| nanonyme | I suspect it should be installing both but what would I know | 18:25 |
| AdrianVovk[m] | I would do (what seems like) a trivial fix myself, however things like this https://gitlab.com/BuildStream/buildstream-docker-images/-/merge_requests/216 give me pause | 18:25 |
| nanonyme | BuildStream 1 uses fuse2 and BuildStream 2 fuse3 | 18:25 |
| AdrianVovk[m] | So I'll just open an issue :) | 18:26 |
| nanonyme | Oh heh, that is actually identical fix we just recently added into our stack | 18:26 |
| nanonyme | Only in master I guess | 18:27 |
| AdrianVovk[m] | <AdrianVovk[m]> "Basically, I tracked down https:..." <- Any ideas how to fix? | 18:28 |
| nanonyme | Interesting. I think neither freedesktop-sdk nor gnome-build-meta uses project.refs | 19:47 |
| AdrianVovk[m] | Yep carbonOS is the only one | 19:47 |
| AdrianVovk[m] | I've submitted a PR that should fix the issue | 19:47 |
| nanonyme | Cool | 19:56 |
| nanonyme | Adrian Vovk: any chance you could contribute a test that fails before your changes that is fixed by your changes? | 19:56 |
| AdrianVovk[m] | Is there some way to run the tests without using tox? tox is being wonky and handing me "Permission Denied" errors w/ no details | 20:34 |
| abderrahim[m] | You can run pytest directly, but you need to install dependencies first | 20:35 |
| AdrianVovk[m] | where can I find these deps? | 20:36 |
| abderrahim[m] | There are requirements files somewhere | 20:37 |
| abderrahim[m] | https://github.com/apache/buildstream/tree/master/requirements | 20:37 |
| abderrahim[m] | You need the dev as well | 20:38 |
| AdrianVovk[m] | ``` | 20:38 |
| AdrianVovk[m] | =================================================================================================================== ERRORS =================================================================================================================== | 20:38 |
| AdrianVovk[m] | _______________________________________________________________________________________________________ ERROR collecting test session ________________________________________________________________________________________________________ | 20:38 |
| AdrianVovk[m] | ../../.local/lib/python3.11/site-packages/_pytest/config/__init__.py:635: in _importconftest | 20:38 |
| AdrianVovk[m] | mod = import_path(conftestpath, mode=importmode, root=rootpath) | 20:38 |
| AdrianVovk[m] | ../../.local/lib/python3.11/site-packages/_pytest/pathlib.py:556: in import_path | 20:38 |
| AdrianVovk[m] | raise ImportPathMismatchError(module_name, module_file, path) | 20:38 |
| AdrianVovk[m] | E _pytest.pathlib.ImportPathMismatchError: ('buildstream._testing._sourcetests.conftest', '/usr/local/lib64/python3.11/site-packages/buildstream/_testing/_sourcetests/conftest.py', PosixPath('/var/home/adrian/Projects/buildstream/build/lib.linux-x86_64-cpython-311/buildstream/_testing/_sourcetests/conftest.py')) | 20:38 |
| AdrianVovk[m] | ========================================================================================================== short test summary info =========================================================================================================== | 20:38 |
| AdrianVovk[m] | ERROR - _pytest.pathlib.ImportPathMismatchError: ('buildstream._testing._sourcetests.conftest', '/usr/local/lib64/python3.11/site-packages/buildstream/_testing/_sourcetests/conftest.py', PosixPath('/var/home/adrian/Projects/buildstream/build... | 20:38 |
| AdrianVovk[m] | !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | 20:38 |
| AdrianVovk[m] | ============================================================================================================== 1 error in 0.12s ============================================================================================================== | 20:38 |
| AdrianVovk[m] | ``` | 20:38 |
| AdrianVovk[m] | Ideas what I'm looking at? | 20:38 |
| abderrahim[m] | Some leftovers in your directory | 20:38 |
| abderrahim[m] | Try removing the build directory | 20:38 |
| AdrianVovk[m] | Cool there it goes. Thanks! | 20:39 |
| AdrianVovk[m] | Where should I put the test? I don't see a place for regression tests to go | 20:40 |
| AdrianVovk[m] | Alright think i figured it out. Pushed a test | 21:15 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!