SamThursfield[m] | it seems like just the .gitlab-ci.yml would needto be updated | 09:12 |
---|---|---|
SamThursfield[m] | let me spend 2 minutes on a PR trying the obvious thing | 09:13 |
SamThursfield[m] | ah i see, its using the buildstream-docker-images | 09:15 |
SamThursfield[m] | so https://gitlab.com/BuildStream/bst-plugins-experimental/-/merge_requests/233 should work | 09:15 |
SamThursfield[m] | some weird errors there which i don't have time to take a look at, but its a start :) | 09:22 |
SamThursfield[m] | actually it just seems like pylint is broken by default in F38, everything else passed | 09:22 |
SamThursfield[m] | ah, passed because it found python3.10 missing, ran no tests, and declared success | 09:23 |
nanonyme | Sam Thursfield: it's good to know there's insane amounts of deprecation warnings with pluginbase | 16:20 |
nanonyme | I guess unless miracle happens, BuildStream will run into massive issues next October which are only going to get worse with the Python release after that | 16:22 |
SamThursfield[m] | oh, didnt see that. is pluginbase unmaintained these days? | 16:23 |
nanonyme | Wait, it doesn't come from pluginbase | 16:24 |
nanonyme | /builds/BuildStream/bst-plugins-experimental/.tox/py311-bst-fixed/lib/python3.11/site-packages/pluginbase.py:438: DeprecationWarning: The asyncore module is deprecated and will be removed in Python 3.12. The recommended replacement is asyncio | 16:24 |
SamThursfield[m] | no, i see it now at the top of the log | 16:24 |
nanonyme | /builds/BuildStream/bst-plugins-experimental/.tox/py311-bst-fixed/lib/python3.11/site-packages/pluginbase.py:438: DeprecationWarning: The asynchat module is deprecated and will be removed in Python 3.12. The recommended replacement is asyncio | 16:24 |
SamThursfield[m] | seems that pluginbase needs work before python 3.12 | 16:25 |
nanonyme | /builds/BuildStream/bst-plugins-experimental/.tox/py311-bst-fixed/lib/python3.11/site-packages/pluginbase.py:438: DeprecationWarning: 'crypt' is deprecated and slated for removal in Python 3.13 | 16:25 |
nanonyme | Sam Thursfield: I can't find these references in pluginbase source code | 16:25 |
SamThursfield[m] | ah ok | 16:25 |
nanonyme | Line 438 is exact the "import foreign code" | 16:25 |
nanonyme | I think this warning is emitted by something else that gets loaded by pluginbase | 16:25 |
SamThursfield[m] | ahh, makes sense | 16:26 |
SamThursfield[m] | yes, can't see those imported in bst or bst-plugins-experimental though | 16:26 |
SamThursfield[m] | i guess when py3.12 is released we'll see where the issue is :-) | 16:26 |
nanonyme | Yeah | 16:27 |
nanonyme | Sam Thursfield: I guess we could grep site-packages if we can repro the venv | 16:27 |
SamThursfield[m] | tox should do that | 16:29 |
SamThursfield[m] | on an OS with python3.11 installed | 16:29 |
juergbi | nanonyme, SamThursfield[m]: pyftpdlib seems to use these three modules. it seems we only use this for the FTP server in tests | 20:52 |
juergbi | not sure whether anything else is affected as well | 20:52 |
nanonyme | I see | 20:52 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!