jjardon[m] | @tristan94 @juergbi ok to merge https://github.com/apache/buildstream/pull/1654 ? | 00:18 |
---|---|---|
juergbi | jjardon[m]: I'm not familiar with the impact of the sphinx language change. See comment on MR. Otherwise LGTM | 05:34 |
*** coldtom <coldtom!coldtom@2a00:23c7:5e9a:5301:0:0:0:1b8> has joined #buildstream | 07:02 | |
*** tpollard <tpollard!tompollard@cpc109023-salf6-2-0-cust777.10-2.cable.virginm.net> has joined #buildstream | 08:31 | |
jjardon[m] | @juergbi thanks! commented there | 09:43 |
jjardon[m] | @juergbi ok to merge as is or you prefer me to rework the PR somehow? | 14:43 |
juergbi | jjardon[m]: merged | 15:06 |
jjardon[m] | thanks! | 17:20 |
*** tpollard <tpollard!tompollard@cpc109023-salf6-2-0-cust777.10-2.cable.virginm.net> has quit IRC | 17:23 | |
*** coldtom <coldtom!coldtom@2a00:23c7:5e9a:5301:0:0:0:1b8> has quit IRC | 20:23 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!