*** brlogger has joined #buildstream | 09:06 | |
tristan | benschubert, I discussed with you when discussing the scheduler and messaging, that I wanted you to be careful to not regress this behavior, i.e. there is a reason why the frontend prefers the task_id over the unique_id in Message() objects | 09:06 |
---|---|---|
tristan | benschubert, it turns out it already regressed last year | 09:06 |
*** gitlab-br-bot has joined #buildstream | 09:06 | |
tristan | The above is the fix for that | 09:06 |
benschubert | Tristan : oh, do you mind adding tests to it so I ensure I don't have problems? I'll review today | 09:09 |
benschubert | Wow that's gonna be fun rebasing on that | 09:09 |
*** tristan has quit IRC | 09:10 | |
*** brlogger has joined #buildstream | 09:28 | |
benschubert | Maybe have a sample output and tests against it? We can configure the format right? So we could remove the timestamps | 09:28 |
benschubert | And if we were to change format, it would be immediately clear what is changing | 09:29 |
*** tristan_ has joined #buildstream | 09:29 | |
*** ChanServ sets mode: +o tristan_ | 09:29 | |
*** tristan has quit IRC | 09:30 | |
*** gitlab-br-bot has joined #buildstream | 09:50 | |
*** tristan_ has quit IRC | 12:12 | |
*** tristan_ has joined #buildstream | 12:13 | |
*** ChanServ sets mode: +o tristan_ | 12:13 | |
valentind | I think the integration tests for bst-external do not work: https://gitlab.com/BuildStream/bst-external/-/jobs/748708284 | 13:54 |
*** lantw44 has joined #buildstream | 14:04 | |
*** benschubert has quit IRC | 14:51 | |
*** santi has quit IRC | 17:05 | |
*** benschubert has joined #buildstream | 17:39 | |
*** jward has joined #buildstream | 18:22 | |
*** tristan_ has quit IRC | 18:29 | |
*** benschubert has quit IRC | 19:41 | |
*** benschubert has joined #buildstream | 20:13 | |
*** benschubert has quit IRC | 23:11 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!