| *** tristan has quit IRC | 03:08 | |
| *** mohan43u has joined #buildstream | 03:50 | |
| *** mohan43u has quit IRC | 03:54 | |
| *** tristan has joined #buildstream | 04:02 | |
| *** ChanServ sets mode: +o tristan | 04:02 | |
| *** mohan43u has joined #buildstream | 04:05 | |
| *** tristan has quit IRC | 04:59 | |
| *** phildawson has joined #buildstream | 08:24 | |
| *** santi has joined #buildstream | 08:32 | |
| douglaswinship | So.... buildstream 2 won't checkout files into a directory with a "." in its name? | 08:46 |
|---|---|---|
| douglaswinship | I'm looking at some freedesktop-sdk CI jobs, and on master (using bst 1.4.3), it was checking out files in a directory called 'checkout/x86_64/vm/boot/virt.bst' | 08:48 |
| douglaswinship | But running the same job on the buildstream 2 branch, the files are ending up in 'checkout/aarch64/vm/minimal/virt' (without the '.bst' on the end). | 08:49 |
| douglaswinship | Even though "bst artifact checkout" was given the same directory name (with the '.bst') | 08:49 |
| douglaswinship | Is that supposed to happen for some reason? Or is it a bug? | 08:50 |
| juergbi | douglaswinship: bst shouldn't mangle the destination directory path. sounds like a bug | 08:52 |
| douglaswinship | Yup, that's what I thought. | 08:53 |
| douglaswinship | Out of interest, how do we handle bugs, in regards to dev tags like "bst-1.93.4". Do we ever backport and update the tag? Or do they stand as they are, warts and all? | 08:55 |
| juergbi | versioned tags should never be updated/replaced. this holds for both stable releases and dev snapshots | 08:59 |
| douglaswinship | That's what I thought. | 09:00 |
| juergbi | the bug is fixed in the corresponding branch(es) | 09:00 |
| juergbi | if a backport were necessary, we could create a branch from bst-1.93.4 and create a bst-1.93.4.1 tag | 09:00 |
| juergbi | however, for dev snapshots there shouldn't be a reason for this | 09:00 |
| douglaswinship | Yeah. | 09:00 |
| douglaswinship | That makes sense. I just asked because We have a branch of freedesktop-sdk that's specifically targetted at 1.93.4, and this bug means we'll have to change something if we want it to pass CI. | 09:02 |
| douglaswinship | Might be a good reason to drop that branch | 09:03 |
| douglaswinship | Interesting... from some quick testing, it only seems to happen to ".bst" in the filename | 09:04 |
| douglaswinship | and only if it's at the very end. | 09:04 |
| juergbi | there is code to strip .bst in certain cases but that's meant for elements, not for user-specified directories | 09:10 |
| douglaswinship | I tried it with other arguments, like "-o target_arch x86_64.bst". Got an error (as expected). So it's not happening to everything on the command line. I think it's just the directories. | 09:14 |
| douglaswinship | Will file an issue. | 09:14 |
| *** tristan has joined #buildstream | 09:54 | |
| *** ChanServ sets mode: +o tristan | 09:54 | |
| Frazer | hi, i noticed that docstrings for classes and methods in BuildStream seem to be inconsistency, some being #\n#\n class, and some being class:\n"""<docstring>""". is this an issue that needs addressing, """""" docstrings seem to be more desired, espically as programs like vs code can read that and format is for the user in the ide | 10:34 |
| coldtom | Frazer, it's intentional https://docs.buildstream.build/master/hacking/coding_guidelines.html#documenting-symbols | 10:35 |
| coldtom | https://gitlab.com/BuildStream/buildstream/-/issues/1321 is probably also relevant | 10:36 |
| Frazer | are "internal" classes and methods private methods and classes, i.e. "_<classname|methodname>"? | 10:38 |
| coldtom | from a comment on that issue: "Private API: at least one of the parts begins with an _. For example, _foo.bar, foo._bar, foo.baz._foobaz(), etc" | 10:42 |
| coldtom | so it's anything with a leading underscore or in a module with a leading underscore | 10:42 |
| Frazer | oh right, just that i think ive come across a few public methods and classes that dont use the """""" docstrings | 10:43 |
| douglaswinship | The artifact checkout bug is documented now: https://gitlab.com/BuildStream/buildstream/-/issues/1361 | 11:29 |
| WSalmon | douglaswinship, that is probly because when we dont supply a --directory the file is just the element name without the ".bst" should be a really easy fix, i will mark it as newcomer | 11:58 |
| WSalmon | i presume the logic is just being applied in the wrong order.. i seem to rember it being a bit of a faff tho as some of the code is in cli and some is in stream | 12:03 |
| douglaswinship | i'll have a look after I grab some lunch | 12:48 |
| douglaswinship | WSalmon: finally got to it. You were right, that was easy. | 15:11 |
| douglaswinship | I think i spent 5 times longer finding the code, than i did fixing it. | 15:11 |
| douglaswinship | https://gitlab.com/BuildStream/buildstream/-/merge_requests/1992 | 15:11 |
| WSalmon | douglaswinship, can you do a more descriptive description | 15:13 |
| WSalmon | your issue dose a very good job of describing what is wrong but the MR should say what change you maid to fix it | 15:14 |
| douglaswinship | Sure :) | 15:15 |
| douglaswinship | done | 15:18 |
| *** ash has joined #buildstream | 15:51 | |
| ash | Hi all, I'm trying to setup fsdk toolchains and i'm having this error. Any idea how to resolve it | 15:54 |
| ash | Error loading user configuration: /home/user/.local/lib/python3.7/site-packages/buildstream/data/userconfig.yaml: Severely malformed YAML: | 15:54 |
| ash | 'NoneType' object is not callable | 15:54 |
| WSalmon | hi ash, it looks like your having a install issue, its one that some times happens with bst-master but freedesktop generally support bst1.4 | 15:56 |
| ash | will the reinstalling solve the problem? | 15:57 |
| WSalmon | i would highly recommend joining #freedesktop-sdk on freenode | 15:58 |
| ash | heh sure ll give it a try, thank you very much WSalmon | 15:58 |
| WSalmon | but if your using the master branch of FD master or any of the stable branches then you will need bst-1.4 not bst-master, they are not compatible | 16:00 |
| *** mohan43u has quit IRC | 16:59 | |
| *** mohan43u has joined #buildstream | 17:00 | |
| *** nanonyme has joined #buildstream | 18:22 | |
| nanonyme | Hi, is there plan to have another bst 1.93.x (or whatnot) tag soon? | 18:24 |
| nanonyme | It would be helpful in helping freedesktop-sdk on the way towards bst 2 | 18:26 |
| *** santi has quit IRC | 18:39 | |
| *** phildawson has quit IRC | 22:17 | |
| dftxbs3e_ | hello! is it possible to have multiple conditions inside one? Like: - arch == "i686" || arch == "ppc64le": | 23:42 |
| *** dftxbs3e_ is now known as dftxbs3e | 23:42 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!