| *** benschubert has quit IRC | 00:33 | |
| *** xjuan_ has quit IRC | 00:36 | |
| *** hasebastian has joined #buildstream | 03:06 | |
| *** tristan has quit IRC | 05:50 | |
| *** tristan has joined #buildstream | 07:22 | |
| *** ChanServ sets mode: +o tristan | 07:22 | |
| *** hasebastian has quit IRC | 08:11 | |
| tristan | grrrr, /me wants do { ... } while (...) in python | 09:05 |
|---|---|---|
| *** benschubert has joined #buildstream | 09:05 | |
| * tristan has a working-so-far refactor of _variables.pyx | 09:05 | |
| tristan | minus the proper error reporting and cyclic variable checks | 09:06 |
| tristan | benschubert, https://gitlab.com/BuildStream/buildstream/-/blob/tristan/partial-variables/src/buildstream/_variables.pyx#L235 | 09:07 |
| tristan | Variable resolution without recursion :) | 09:07 |
| * tristan thinks that he might need deque instead of list for performant 'pop()' | 09:08 | |
| benschubert | tristan: oh nice! seems great | 09:08 |
| benschubert | you might want `extend` instead of for...append too :) | 09:09 |
| benschubert | have you run any initial benchmarks by any chance? | 09:09 |
| benschubert | it's also quite more readable | 09:09 |
| tristan | Broken down into Variables (the pool), Values (resolvable values), ValueClass (broken down strings in the cache) | 09:09 |
| tristan | Not yet no, I need to get errors working correctly | 09:09 |
| benschubert | ok :) | 09:09 |
| tristan | But I'm pretty sure it will work out well | 09:09 |
| benschubert | I've got the threaded scheduler pass all the tests now too, so i will cleanup, benchmakr and make a WIP MR for comments | 09:10 |
| tristan | Structure and flow is quite similar, maybe a little bit more loopy around ValueClass.parts() and ValueClass.dependencies() though | 09:10 |
| tristan | Right now I've got to restructure that loop though, every time I lookup a variable._values[varname] and handle a KeyError, I need the provenance of the preceding variable to issue the correct error | 09:11 |
| tristan | And I'd like to have that expressed with the same code which does the initial lookup on line 241 | 09:12 |
| tristan | Which is why... it would be really handy to have do { ... } while (...) in python right now | 09:12 |
| tristan | Maybe I'll add an ugly boolean for the purpose | 09:12 |
| benschubert | yeah, do-while is something I'm missing :D | 09:13 |
| *** tristan has quit IRC | 09:42 | |
| *** tristan has joined #buildstream | 10:20 | |
| *** ChanServ sets mode: +o tristan | 10:20 | |
| *** tristan has quit IRC | 11:21 | |
| *** hasebastian has joined #buildstream | 12:34 | |
| *** hasebastian has quit IRC | 18:33 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!