| *** xjuan has quit IRC | 00:10 | |
| *** tristan has quit IRC | 02:34 | |
| *** xjuan has joined #buildstream | 02:45 | |
| *** xjuan has quit IRC | 02:59 | |
| *** tristan has joined #buildstream | 03:00 | |
| *** ChanServ sets mode: +o tristan | 03:00 | |
| *** tristan has quit IRC | 05:38 | |
| *** hasebastian has joined #buildstream | 06:25 | |
| *** tristan has joined #buildstream | 06:41 | |
| *** ChanServ sets mode: +o tristan | 06:41 | |
| tristan | Can I get a quick review of https://gitlab.com/BuildStream/buildstream/-/merge_requests/1960 ? | 06:48 |
|---|---|---|
| tristan | This is just a minor fix I'd rather get rid of from my larger branch by landing it in advance | 06:48 |
| juergbi | tristan: lgtm. maybe you can take a quick look at the utils.py changes in https://gitlab.com/BuildStream/buildstream/-/merge_requests/1959 | 06:55 |
| tristan | Sure | 06:57 |
| juergbi | ta | 07:01 |
| tristan | Made one comment, the rest looks fine | 07:04 |
| *** benschubert has joined #buildstream | 07:35 | |
| *** tristan has quit IRC | 07:35 | |
| *** tristan has joined #buildstream | 07:54 | |
| *** ChanServ sets mode: +o tristan | 07:54 | |
| scottclarke | juergbi, if you get a moment, I was wondering if your comment on my MR is blocking it being merged? https://gitlab.com/BuildStream/buildstream/-/merge_requests/1955#note_355981891 | 08:45 |
| juergbi | scottclarke: will take a look asap. I wanted to do a quick check whether I can see the cause for this. if not, let's merge it | 08:46 |
| scottclarke | thanks juergbi! | 08:47 |
| *** santi has joined #buildstream | 08:53 | |
| *** phildawson has joined #buildstream | 09:00 | |
| *** hasebastian has quit IRC | 09:33 | |
| tristan | juergbi, I am reading that people are in need of a dev tag soon, I think we should roll one out as soon as we have a buildbox 0.0.9 and that BuildStream is using that new buildbox in CI | 09:51 |
| cphang | that would be really helpful. From my perspective the only critical issue blocking this is https://gitlab.com/BuildStream/buildstream/-/issues/1318 which the above should resolve. | 09:52 |
| cphang | WSalmon anything I'm missing? | 09:52 |
| tristan | We could roll out another after resolving the whole junction jungle, but I'd rather not block people from getting a tag for a few days just because of that | 09:52 |
| cphang | No objections to another dev tag. Happy to try out those changes as soon as they are available :) | 09:53 |
| WSalmon | cphang, yep, i was waiting for https://gitlab.com/BuildStream/buildstream/-/issues/1318#note_354475256 to be resolved and then was going to push for a dev tag | 09:53 |
| WSalmon | that seemed the most sensible route, stricktly speaking the web site bit is not needed for a dev tag, but needs doing | 09:54 |
| tristan | our merge request numbers are approaching rational birthday years | 09:55 |
| cphang | https://www.onthisday.com/birthdays/date/1318 | 09:58 |
| tristan | cphang, that's an issue, I rather mean people who are alive today | 10:00 |
| tristan | e.g. https://gitlab.com/BuildStream/buildstream/-/merge_requests/1960 | 10:00 |
| cphang | ah oops, my mistake. | 10:00 |
| tristan | but yeah indeed, there were people also born in the range of our issue numbers | 10:01 |
| tristan | maybe once the issue number birthdays catch up to our current year, we will reach maintenance mode and all the word's build problems will be solved :D | 10:01 |
| tristan | Hmmm, this is alarming | 10:11 |
| tristan | juergbi, `grep -r "\.artifact_cache_specs" src/buildstream/` <-- This only yields assignments, how can that possibly be ? | 10:12 |
| WSalmon | So having another think i dont think we can close https://gitlab.com/BuildStream/buildstream/-/issues/1318#note_354475256 until the note is complete but i dont think the bst code base needs any more change so i might be good to release a tag right now cphang tristan, when the current bst-master is used with buildbox-master the error dose not a cure. (as of when i tested it last week) | 10:12 |
| WSalmon | So having another think i dont think we can close https://gitlab.com/BuildStream/buildstream/-/issues/1318#note_354475256 until the note is complete but i dont think the bst code base needs any more change so it might be good to release a tag right now cphang tristan, when the current bst-master is used with buildbox-master the error dose not a cure. (as of when i tested it last week) | 10:12 |
| tristan | the artifact cache specs and source cache specs are parsed, and then completely ignored and unused | 10:14 |
| tristan | Which is interesting given https://mail.gnome.org/archives/buildstream-list/2020-May/msg00018.html | 10:14 |
| tristan | WSalmon, I think the opposite; i.e. we can close the issue because master & master works, but we should postpone the devtag until the new buildbox is used in CI, this way using buildstream-docker-images for the new tag guarantees a working solution | 10:16 |
| tristan | We could still postpone closing the issue though, kind of ambivalent about that | 10:17 |
| tristan | If it's fixed by the buildbox issue, we could logically close it as a dupe of the buildbox issue, though | 10:17 |
| tristan | juergbi, never mind, our code does wacky weird stuff with getatter in _basecache.py to access project/context public members | 10:19 |
| * tristan recalls wanting to do a big refactor around this along time ago | 10:20 | |
| WSalmon | tristan, happy to wait, shouldnt be long now | 10:20 |
| juergbi | tristan: snapshot, yes, that sounds fine by me. I'm planning to update BuildBox very soon | 10:46 |
| juergbi | tristan: basecache: yes, that's not quite obvious. I'm starting work on remote asset API, which will touch that code. so hopefully this can be improved along the way | 10:47 |
| juergbi | and please don't start a refactoring there right now :) | 10:47 |
| tristan | juergbi, the only refactor I'm planning around there is https://mail.gnome.org/archives/buildstream-list/2020-May/msg00018.html | 11:20 |
| tristan | which I think is worth blocking 2.0 for, but we need to figure out the design first | 11:20 |
| juergbi | right. I actually need to tweak the config format a bit for the remote asset API, however, the change is orthogonal to that mail | 11:22 |
| *** hasebastian has joined #buildstream | 11:23 | |
| juergbi | scottclarke: handed to marge | 11:24 |
| scottclarke | thanks juergbi, do I need to do anything else for that? I'm not familiar with marge bot | 11:27 |
| juergbi | no, there is a queue, so it'll take a while but it should get merged automatically | 11:28 |
| scottclarke | sounds great | 11:29 |
| cphang | \o/ nice one scottclarke | 11:33 |
| *** santi has quit IRC | 12:45 | |
| *** santi has joined #buildstream | 12:47 | |
| juergbi | WSalmon: https://gitlab.com/BuildStream/website/-/merge_requests/141 | 14:58 |
| WSalmon | thanks juergbi | 15:01 |
| *** lantw44 has joined #buildstream | 15:08 | |
| *** xjuan has joined #buildstream | 15:33 | |
| WSalmon | juergbi, do some of our docker images have cas-d in them and others dont? i preusme a docker image that is ment for people to use bst would have it but a docker image for testing dosent as then we can test diffrent versions of casd more easilly? | 15:41 |
| juergbi | all buildstream docker images include casd if I'm not forgetting anything | 15:41 |
| WSalmon | i was not expecting to see https://gitlab.com/BuildStream/buildstream/-/merge_requests/1962/diffs#587d266bb27a4dc3022bbed44dfa19849df3044c_298_296 | 15:42 |
| juergbi | we don't want to build buildbox components in every bst CI run | 15:42 |
| juergbi | WSalmon: that's for WSL where we can't use docker | 15:42 |
| WSalmon | ah | 15:43 |
| *** phildawson has quit IRC | 16:30 | |
| *** phildawson has joined #buildstream | 16:40 | |
| *** cphang has quit IRC | 17:32 | |
| *** traveltissues has quit IRC | 17:32 | |
| *** valentind has quit IRC | 17:34 | |
| *** robjh has quit IRC | 17:34 | |
| *** scottclarke has quit IRC | 17:34 | |
| *** WSalmon has quit IRC | 17:34 | |
| *** tpreston has quit IRC | 17:34 | |
| *** bethw has quit IRC | 17:34 | |
| *** bethw has joined #buildstream | 17:35 | |
| *** robjh has joined #buildstream | 17:36 | |
| *** WSalmon has joined #buildstream | 17:38 | |
| *** valentind has joined #buildstream | 17:39 | |
| *** santi has quit IRC | 17:48 | |
| *** scottclarke has joined #buildstream | 17:50 | |
| *** santi has joined #buildstream | 17:54 | |
| *** santi has quit IRC | 17:58 | |
| *** douglaswinship has quit IRC | 18:11 | |
| *** hasebastian has quit IRC | 18:11 | |
| *** xjuan has quit IRC | 18:25 | |
| *** xjuan has joined #buildstream | 18:39 | |
| *** benschubert has quit IRC | 23:44 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!