*** tristan has joined #buildstream | 01:30 | |
*** tristan has quit IRC | 02:20 | |
*** mohan43u has joined #buildstream | 05:55 | |
*** narispo has quit IRC | 06:37 | |
*** narispo has joined #buildstream | 06:37 | |
*** mohan43u has quit IRC | 07:03 | |
*** tristan has joined #buildstream | 07:05 | |
*** narispo has quit IRC | 07:13 | |
*** narispo has joined #buildstream | 07:13 | |
*** tristan has quit IRC | 07:14 | |
*** tristan has joined #buildstream | 07:26 | |
gitlab-br-bot | tristanvb opened (was WIP) MR !1864 (tristan/user-guide-refactor->master: User guide enhancements) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1864 | 07:45 |
---|---|---|
*** ChanServ sets mode: +o tristan | 07:59 | |
* tristan has a creepy feeling the docs on the website might not get updated by merging the above, due to the change in strategy to not run post-merge pipelines | 08:00 | |
tristan | might need some fixing, not entirely sure looking at .gitlab-ci.yml, there are a bunch of only: master statements which I presume don't actually run | 08:01 |
juergbi | tristan: we actually do still run everything on master post-merge | 08:03 |
tristan | Oh... I'm confused, I thought people were saying we don't do post-merge builds anymore | 08:03 |
juergbi | I got confused at some point about it | 08:03 |
tristan | Might have to do with dysfunctional runners | 08:04 |
juergbi | because gitlab is unclear when there are multiple pipelines for the same commit | 08:04 |
juergbi | e.g., mixing up post-merge and overnight | 08:04 |
juergbi | and wsl accidentally ran on overnight, which added to the confusion, but I fixed that | 08:04 |
tristan | Ok that's reassuring, I mostly care that our docs propagation works automatically | 08:04 |
tristan | for docs and for the badges | 08:04 |
tristan | I'm seeing this kind of failure a lot: https://gitlab.com/BuildStream/buildstream/-/jobs/516950937 | 08:05 |
tristan | I.e. it succeeded and then gitlab says "Ok fail !" | 08:05 |
tristan | tox is exiting with wrong exit status perhaps ? | 08:06 |
juergbi | tristan: there are two tox runs, the first one fails, the second one doesn't | 08:07 |
juergbi | the second one is for source plugin tests | 08:07 |
juergbi | so you have to scroll up to see the error | 08:07 |
juergbi | we should improve this | 08:07 |
juergbi | in this case it's an internal pytest error.. | 08:08 |
tristan | I just scrolled through the whole thing | 08:08 |
*** phoenix has joined #buildstream | 08:09 | |
tristan | and didn't see any failure | 08:09 |
tristan | Also, whatever is causing this, retry will fix it | 08:09 |
tristan | whatever it is it's racy or non deterministic in some way | 08:09 |
juergbi | tristan: search for "INTERNALERROR" | 08:10 |
tristan | Ah weird, easy to miss | 08:10 |
* tristan was expecting something with a bright red FAILED | 08:11 | |
* tristan just scrolled right past it | 08:11 | |
tristan | Still confident this will "just work" depending on the phase of the moon | 08:11 |
juergbi | I've seen such pytest internal errors before but not very frequently | 08:12 |
juergbi | and never locally, iirc | 08:12 |
tristan | So anyway, shall I set !1864 to merge ? | 08:12 |
gitlab-br-bot | MR !1864: User guide enhancements https://gitlab.com/BuildStream/buildstream/-/merge_requests/1864 | 08:12 |
tristan | It's a ton of new docs, and I think that we can always fix/perfect it later | 08:13 |
* tristan added the new section about "Handling files" too | 08:13 | |
tristan | Latest: https://buildstream.gitlab.io/-/buildstream/-/jobs/515954571/artifacts/public/main_using.html | 08:13 |
juergbi | great | 08:14 |
juergbi | I haven't looked at it in detail yet but I don't have any objections merging it already | 08:14 |
tristan | Ok I'm off, I guess I'll look into some odds and ends this week, maybe get the min-version thing done and error messaging around plugin/core mismatching | 08:25 |
tristan | Maybe dive into cache key related things, related to that, I think we need to start a discussion about default YAML values | 08:25 |
*** tristan has quit IRC | 08:29 | |
*** slaf_ has joined #buildstream | 08:30 | |
*** slaf has quit IRC | 08:32 | |
*** slaf_ is now known as slaf | 08:32 | |
*** mohan43u has joined #buildstream | 09:20 | |
*** narispo has quit IRC | 09:21 | |
*** narispo has joined #buildstream | 09:21 | |
gitlab-br-bot | tristanvb merged MR !1864 (tristan/user-guide-refactor->master: User guide enhancements) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1864 | 10:22 |
*** tpollard has joined #buildstream | 10:24 | |
*** tpollard has quit IRC | 10:25 | |
*** rdale has joined #buildstream | 10:26 | |
*** narispo has quit IRC | 10:41 | |
*** narispo has joined #buildstream | 10:41 | |
*** narispo has quit IRC | 10:48 | |
*** narispo has joined #buildstream | 10:48 | |
*** sstriker has joined #buildstream | 13:06 | |
*** sstriker has quit IRC | 13:08 | |
gitlab-br-bot | jjardon reopened MR !972 (jjardon/submodules->master: plugins/sources/git.py: Do not checkout submodules by default) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/972 | 13:11 |
*** narispo has quit IRC | 14:13 | |
*** narispo has joined #buildstream | 14:13 | |
*** mohan43u has quit IRC | 15:26 | |
*** mohan43u has joined #buildstream | 15:26 | |
*** mohan43u has quit IRC | 15:28 | |
*** mohan43u has joined #buildstream | 15:38 | |
*** narispo has quit IRC | 16:16 | |
*** narispo has joined #buildstream | 16:16 | |
*** narispo has quit IRC | 16:39 | |
*** narispo has joined #buildstream | 16:39 | |
*** lantw44 has quit IRC | 16:55 | |
*** lantw44 has joined #buildstream | 16:56 | |
*** narispo has quit IRC | 17:40 | |
*** narispo has joined #buildstream | 17:40 | |
*** toscalix has joined #buildstream | 18:13 | |
*** mohan43u has quit IRC | 18:24 | |
*** mohan43u has joined #buildstream | 18:25 | |
*** mohan43u has quit IRC | 18:25 | |
*** philn has quit IRC | 19:36 | |
*** philn has joined #buildstream | 19:38 | |
*** phoenix has quit IRC | 21:17 | |
*** phoenix has joined #buildstream | 21:18 | |
*** tristan has joined #buildstream | 21:51 | |
*** phoenix has quit IRC | 22:01 | |
*** rdale has quit IRC | 22:50 | |
*** ceibal has joined #buildstream | 23:13 | |
*** ceibal has quit IRC | 23:20 | |
*** toscalix has quit IRC | 23:28 | |
*** slaf has quit IRC | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!