| *** traveltissues has quit IRC | 05:40 | |
| *** traveltissues has joined #buildstream | 05:40 | |
| *** tristan_ has joined #buildstream | 06:43 | |
| *** mohan43u has quit IRC | 07:59 | |
| *** phildawson has joined #buildstream | 08:50 | |
| *** tpollard has joined #buildstream | 09:02 | |
| gitlab-br-bot | BenjaminSchubert opened MR !1840 (bschubert/notify-prepare-plan->master: _stream.py: Make `_enqueue_plan` a timed activity) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1840 | 09:12 |
|---|---|---|
| *** rdale has joined #buildstream | 09:37 | |
| *** santi has joined #buildstream | 09:38 | |
| WSalmon | hi benschubert is your mail saying that we would add a marker to the tests we have issues with and then add something around line 75 of tests/conftest.py so that the existing --plugins option in pytest also triggers these additional tests? so in order to run integration test that need plugins you would need `pytest [..] --integration --plugin` | 09:44 |
| WSalmon | but that would be hidden in tox | 09:44 |
| benschubert | WSalmon: you would to: `pytest --integration -m plugins` yes | 09:44 |
| benschubert | I also want to get rid if `--integration`, because it is more counter-intuitive than useful and definitely not how pytest markers are used elsewhere :) But that will be a separate ML thread | 09:45 |
| WSalmon | that was not quite how i read your mail but that makes more sence | 09:46 |
| benschubert | (IDE integration for example with Pycharm, I can't run integration tests easily) | 09:46 |
| WSalmon | `pytest --plugins` -> dose the external ones but `pytest --integration -m plugins` dose what we have | 09:47 |
| benschubert | ah, you are right we already have "--plugins". then I will go for that and make the change later for everything :) | 09:47 |
| WSalmon | we also already have plugin things for tox | 09:47 |
| WSalmon | that mirror what we have for pytest | 09:47 |
| benschubert | yep, my proposal will currently piggyback on that and extend it | 09:47 |
| benschubert | so that the underlying way of calling will change, but the dev-facing api will not :) | 09:48 |
| WSalmon | ok, one thing that isnt explicit is what happens for the 10 or so `core` tests that dont need a sandbox but do need source plugin that will now need the external plugins, currently we have `# With --plugins only run plugins test` are you saying that we completly rewrite this bit or would those few core tests run when we have plugins, i can see how this could work from the pytest point of view but not the tox | 09:53 |
| WSalmon | ie `pytest --integration -m plugins` or `pytest -m plugins` would run he core that need plugins | 09:55 |
| benschubert | Currently tox has: all tests / plugin tests. So it would run with "plugin tests". | 09:55 |
| WSalmon | but i dont understand how that would look at the tox level | 09:55 |
| benschubert | Tox has only two environments: non-plugins/plugins | 09:55 |
| benschubert | And if you want to run the integration tests in addition, you do the tox -- --integration | 09:55 |
| benschubert | would work the same here | 09:55 |
| WSalmon | ok yep | 09:56 |
| WSalmon | sorry the tox.ini comands sections is too complecated to grok at quickly, i think i get it | 09:57 |
| benschubert | I agree, not sure how we can improve that though | 09:57 |
| WSalmon | its kinda cool what it dose | 09:57 |
| WSalmon | but its not clear about it | 09:57 |
| WSalmon | i think you could make it a lot clearer but not without making it harder to maintian and a lot longer | 09:58 |
| WSalmon | i had a email saying yep this sounds good ready to go but i wanted to check i under stood, thanks for the clarifications | 09:58 |
| benschubert | great :) thanks! | 09:59 |
| *** tristan_ has quit IRC | 10:01 | |
| *** lachlan has joined #buildstream | 10:03 | |
| *** lantw44 has quit IRC | 10:24 | |
| *** lantw44 has joined #buildstream | 10:24 | |
| *** lantw44 has quit IRC | 10:26 | |
| *** lantw44 has joined #buildstream | 10:26 | |
| *** lantw44 has quit IRC | 10:27 | |
| *** lantw44 has joined #buildstream | 10:27 | |
| *** narispo has quit IRC | 10:36 | |
| *** narispo has joined #buildstream | 10:37 | |
| *** cphang has quit IRC | 10:38 | |
| *** ikerperez has quit IRC | 10:38 | |
| *** ikerperez has joined #buildstream | 10:38 | |
| *** cphang has joined #buildstream | 10:39 | |
| *** lachlan has quit IRC | 10:56 | |
| *** lachlan has joined #buildstream | 11:08 | |
| *** jib has joined #buildstream | 11:49 | |
| *** jib has left #buildstream | 11:49 | |
| *** lachlan has quit IRC | 11:53 | |
| *** lachlan has joined #buildstream | 11:58 | |
| *** lachlan has quit IRC | 12:17 | |
| *** lachlan has joined #buildstream | 12:30 | |
| *** lachlan has quit IRC | 12:41 | |
| *** lachlan has joined #buildstream | 12:46 | |
| *** mohan43u has joined #buildstream | 12:47 | |
| *** lachlan has quit IRC | 12:52 | |
| *** mohan43u has quit IRC | 12:54 | |
| *** mohan43u has joined #buildstream | 12:55 | |
| *** phildawson has quit IRC | 13:10 | |
| *** jib1 has joined #buildstream | 13:31 | |
| *** jib1 is now known as jib | 13:34 | |
| *** mohan43u has quit IRC | 13:34 | |
| *** mohan43u has joined #buildstream | 13:36 | |
| *** phildawson has joined #buildstream | 13:36 | |
| *** jib has left #buildstream | 13:57 | |
| *** lachlan has joined #buildstream | 14:14 | |
| *** phildawson has quit IRC | 14:30 | |
| *** phildawson has joined #buildstream | 14:32 | |
| *** lachlan has quit IRC | 14:49 | |
| *** lachlan has joined #buildstream | 14:59 | |
| *** hasebastian has joined #buildstream | 15:09 | |
| *** mohan43u has quit IRC | 15:19 | |
| *** mohan43u has joined #buildstream | 15:23 | |
| *** phildawson has quit IRC | 15:28 | |
| *** lachlan has quit IRC | 15:57 | |
| *** mohan43u has quit IRC | 16:23 | |
| *** mohan43u has joined #buildstream | 16:27 | |
| *** mohan43u has quit IRC | 16:37 | |
| *** mohan43u has joined #buildstream | 16:37 | |
| *** tristan has joined #buildstream | 17:28 | |
| *** tristan has joined #buildstream | 17:29 | |
| *** lachlan has joined #buildstream | 17:31 | |
| *** lachlan has quit IRC | 17:48 | |
| *** toscalix has joined #buildstream | 17:50 | |
| *** lachlan has joined #buildstream | 18:05 | |
| *** lachlan has quit IRC | 18:14 | |
| *** tpollard has quit IRC | 18:14 | |
| *** lachlan has joined #buildstream | 18:20 | |
| *** santi has quit IRC | 18:23 | |
| *** lachlan has quit IRC | 18:25 | |
| *** lachlan has joined #buildstream | 18:27 | |
| *** jib has joined #buildstream | 18:45 | |
| *** toscalix has quit IRC | 18:55 | |
| *** toscalix has joined #buildstream | 18:56 | |
| *** lachlan has quit IRC | 19:13 | |
| *** hasebastian has quit IRC | 19:27 | |
| *** phoenix has joined #buildstream | 19:29 | |
| *** phoenix has quit IRC | 19:34 | |
| *** phoenix has joined #buildstream | 19:43 | |
| *** rdale has quit IRC | 20:08 | |
| *** phoenix has quit IRC | 20:17 | |
| *** toscalix has quit IRC | 20:45 | |
| *** benschubert has quit IRC | 20:49 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!