| *** jward has quit IRC | 01:02 | |
| *** ikerperez has quit IRC | 01:02 | |
| *** ikerperez has joined #buildstream | 01:03 | |
| *** robjh has quit IRC | 01:03 | |
| *** WSalmon has quit IRC | 01:03 | |
| *** paulsherwood has quit IRC | 01:04 | |
| *** valentind has quit IRC | 01:04 | |
| *** douglaswinship has quit IRC | 01:05 | |
| *** douglaswinship has joined #buildstream | 01:05 | |
| *** robjh has joined #buildstream | 01:05 | |
| *** jward has joined #buildstream | 01:05 | |
| *** valentind has joined #buildstream | 01:06 | |
| *** traveltissues has joined #buildstream | 01:07 | |
| *** WSalmon has joined #buildstream | 01:07 | |
| *** traveltissues has quit IRC | 01:07 | |
| *** paulsherwood has joined #buildstream | 01:09 | |
| *** traveltissues has joined #buildstream | 01:22 | |
| *** traveltissues has quit IRC | 01:25 | |
| *** hasebastian has joined #buildstream | 03:42 | |
| *** narispo has quit IRC | 03:54 | |
| *** narispo has joined #buildstream | 03:54 | |
| *** hasebastian has quit IRC | 06:40 | |
| *** traveltissues has joined #buildstream | 08:27 | |
| *** mohan43u has quit IRC | 08:36 | |
| *** benschubert has joined #buildstream | 08:47 | |
| *** mohan43u has joined #buildstream | 08:50 | |
| gitlab-br-bot | BenjaminSchubert approved MR !1833 (abderrahim/etag->master: _downloadablefilesource.py: don't download the file if etag matches) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1833 | 09:08 |
|---|---|---|
| benschubert | abderrahim[m]: do you have merge permissions on the project? If not, can I merge ^ ? | 09:08 |
| *** tpollard has joined #buildstream | 09:08 | |
| *** rdale has joined #buildstream | 09:26 | |
| *** santi has joined #buildstream | 09:35 | |
| *** phildawson has joined #buildstream | 09:38 | |
| abderrahim[m] | benschubert: Thanks. I do | 09:59 |
| gitlab-br-bot | abderrahimk merged MR !1833 (abderrahim/etag->master: _downloadablefilesource.py: don't download the file if etag matches) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1833 | 09:59 |
| benschubert | awesome | 09:59 |
| benschubert | Am I the only one for which the artifactcache tests take ages? It roughly 1 minute per test... | 10:01 |
| juergbi | I'm running tests in parallel | 10:05 |
| juergbi | some buildtree tests are the slowest for me | 10:05 |
| benschubert | interesting, I'll dig a bit deeper :) | 10:06 |
| gitlab-br-bot | abderrahimk opened MR !1838 (abderrahim/etag-1->bst-1: _downloadablefilesource.py: don't download the file if etag matches) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1838 | 10:08 |
| *** lachlan has joined #buildstream | 10:15 | |
| *** lachlan has quit IRC | 10:40 | |
| *** lachlan has joined #buildstream | 10:45 | |
| *** lachlan has quit IRC | 11:00 | |
| *** lachlan has joined #buildstream | 11:11 | |
| *** lachlan has quit IRC | 11:16 | |
| *** jib has joined #buildstream | 11:22 | |
| *** jib has left #buildstream | 11:24 | |
| *** lachlan has joined #buildstream | 11:25 | |
| *** narispo has quit IRC | 11:56 | |
| *** narispo has joined #buildstream | 11:56 | |
| *** lachlan has quit IRC | 12:43 | |
| gitlab-br-bot | BenjaminSchubert opened (was WIP) MR !1832 (bschubert/stricter-cas-soc->master: Don't create Buildstream-related directories in the cas - owned directory) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1832 | 12:44 |
| benschubert | juergbi: ^ finally fixed all the tests. How does that look? | 12:44 |
| *** cphang has joined #buildstream | 12:50 | |
| *** traveltissues has quit IRC | 12:52 | |
| *** traveltissues_ has joined #buildstream | 12:52 | |
| *** cphang has left #buildstream | 12:54 | |
| *** cphang has joined #buildstream | 12:54 | |
| *** cphang has left #buildstream | 12:54 | |
| *** cphang has joined #buildstream | 12:54 | |
| *** lachlan has joined #buildstream | 12:58 | |
| *** lachlan has quit IRC | 13:11 | |
| *** traveltissues_ has quit IRC | 14:06 | |
| gitlab-br-bot | juergbi approved MR !1832 (bschubert/stricter-cas-soc->master: Don't create Buildstream-related directories in the cas - owned directory) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1832 | 14:25 |
| benschubert | Thanks a lot :) | 14:26 |
| *** lachlan has joined #buildstream | 14:30 | |
| *** traveltissues has joined #buildstream | 15:01 | |
| *** lachlan has quit IRC | 15:19 | |
| *** lachlan has joined #buildstream | 15:34 | |
| gitlab-br-bot | BenjaminSchubert merged MR !1832 (bschubert/stricter-cas-soc->master: Don't create Buildstream-related directories in the cas - owned directory) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1832 | 15:36 |
| *** lachlan has quit IRC | 16:16 | |
| cphang | Hi! Many apologies if this has been answered already. For getting towards a bst 2.0 release, plugin API cleanup was one of the items as a todo. How close are we to having a stable plugin API in master? Are there any outstanding issues I could have a look at that are towards this cleanup effort? :) | 16:38 |
| tpollard | I'm not aware of a catchall issue | 16:44 |
| coldtom | aiui adopting the Remote Asset API will require plugin API changes, at least for the features proposed on the mailing list | 16:45 |
| coldtom | but that's the only piece of work on my radar which requires plugin API changes | 16:45 |
| juergbi | cphang: one related WIP item is to drop support for element plugins that don't use the virtual directory API (Directory class) | 16:48 |
| juergbi | as they are incompatible with remote execution as well as buildbox-run sandboxing | 16:48 |
| juergbi | i.e., update the remaining plugins, and supplement the virtual directory API as necessary. I've already started with this | 16:49 |
| *** lachlan has joined #buildstream | 16:49 | |
| juergbi | related to that, review the whole Directory API whether it's good enough as stable API for 2.0 | 16:51 |
| juergbi | I've also been thinking about whether it could make sense to drop the separation between prepare() and assemble() in the core API. it might simplify a few things in light of the need for batch operations with remote execution / buildbox-run | 16:52 |
| juergbi | and some general review of the batch-based sandboxing API in light of the move to buildbox-run + remote-execution | 16:53 |
| cphang | Aha tvm juergbi, the WIP item is https://gitlab.com/BuildStream/buildstream/-/issues/1262 ? | 16:58 |
| juergbi | yes | 16:58 |
| cphang | Cool ta, looks like there are 7 plugins at latest count that don't use the virtual directory API https://paste.gnome.org/p0ewexfqg | 17:02 |
| cphang | juergbi would you appreciate any MRs that helped with that port from bst-plugins-experimental? Or is it something you've got already in hand? :) | 17:03 |
| juergbi | cphang: I'd appreciate help there. just need to make sure we don't do duplicate work. my messy WIP branch is https://gitlab.com/BuildStream/bst-plugins-experimental/-/commits/juerg/vdirectory | 17:10 |
| juergbi | I'd definitely be happy anyone working on plugins I haven't touched yet at all | 17:11 |
| juergbi | or when there are none left, possibly taking over WIP ones | 17:11 |
| juergbi | I'm currently finishing up another task related to buildbox sandboxing before coming back to this | 17:12 |
| juergbi | there are also a few plugins in the freedesktop-sdk repo that require work | 17:12 |
| *** lachlan has quit IRC | 17:13 | |
| juergbi | for some plugins there might not be sufficient test coverage | 17:13 |
| cphang | ack makes sense. How about if I open up an issue in bst-plugins-experimental to track this. I can have a crack at the oci and dpkg_deploy plugins. Don't think from that branch you've started work on that? | 17:15 |
| juergbi | sounds good, thanks | 17:15 |
| juergbi | also have to tag a new buildstream snapshot such that bst-plugins-experimental master can use the new directory API | 17:16 |
| juergbi | wanted to wait until I'm relatively certain that all the needs are covered | 17:17 |
| cphang | cool | 17:17 |
| *** lachlan has joined #buildstream | 17:17 | |
| *** lachlan has quit IRC | 17:24 | |
| *** lachlan has joined #buildstream | 17:29 | |
| jjardon | juergbi: to make easier to track them; would it be ok to use a milestone or a label to mark issues we know are bst2 blockers? | 17:51 |
| abderrahim[m] | cphang: there is also this issue I stumbled upon (filed as #1269). The fixme here needs to be addressed https://gitlab.com/BuildStream/buildstream/-/blob/master/src/buildstream/source.py#L1009 | 17:52 |
| gitlab-br-bot | Issue #1269: documentation for Source.set_ref is incomplete and incorrect https://gitlab.com/BuildStream/buildstream/-/issues/1269 | 17:52 |
| abderrahim[m] | (and generally documentation needs to be updated) | 17:52 |
| abderrahim[m] | It's currently written for buildstream developers, a 3rd party developer can't figure out how to write a plugin from reading the documentation alone | 17:53 |
| *** chipb has joined #buildstream | 17:54 | |
| benschubert | abderrahim[m]: oh that's me who put that on. I should try to get that done :( | 17:56 |
| benschubert | (the TODO I mean) | 17:56 |
| benschubert | jjardon: I believe the milestone/tag is a great idea yep! | 17:56 |
| juergbi | agreed, we should use a milestone | 17:57 |
| jjardon | ok! https://gitlab.com/BuildStream/buildstream/-/milestones/3 created | 17:58 |
| jjardon | exciting times | 17:58 |
| benschubert | awesome thanks :) | 17:58 |
| cphang | ooh nice jjardon :D | 18:01 |
| *** tpollard has quit IRC | 18:06 | |
| *** lachlan has quit IRC | 18:20 | |
| *** traveltissues has quit IRC | 18:23 | |
| *** lachlan has joined #buildstream | 18:33 | |
| *** santi has quit IRC | 18:39 | |
| cphang | thanks abderrahim[m] Would it be possible to add https://gitlab.com/BuildStream/buildstream/-/issues/1269 to the milestone for 2.0? I would add but don't have the necessary permissions | 18:43 |
| abderrahim[m] | done | 18:44 |
| cphang | thanks :) | 18:45 |
| *** lachlan has quit IRC | 19:09 | |
| *** benschubert has quit IRC | 20:22 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!