| *** narispo has quit IRC | 00:58 | |
| *** narispo has joined #buildstream | 00:59 | |
| *** hasebastian has joined #buildstream | 04:11 | |
| *** hasebastian has quit IRC | 07:03 | |
| *** hasebastian has joined #buildstream | 08:12 | |
| *** traveltissues has joined #buildstream | 08:15 | |
| *** hasebastian has quit IRC | 08:22 | |
| *** narispo has quit IRC | 08:52 | |
| *** narispo has joined #buildstream | 08:53 | |
| *** santi has joined #buildstream | 09:30 | |
| *** rdale has joined #buildstream | 09:35 | |
| *** narispo has quit IRC | 09:35 | |
| *** narispo has joined #buildstream | 09:36 | |
| *** tme5 has joined #buildstream | 09:40 | |
| *** jonathanmaw has joined #buildstream | 10:18 | |
| *** traveltissues has quit IRC | 11:50 | |
| valentind | juergbi, If there are commits we can backport from master to support 3.8, this would be great. But when I was looking for fixes in master I did not find what was related to fixing running on 3.8. | 11:57 |
|---|---|---|
| *** traveltissues has joined #buildstream | 11:57 | |
| juergbi | maybe not all commits were clearly marked as related, some might have been general cleanup/improvement that happens to be important for 3.8 | 11:58 |
| juergbi | valentind: I've linked a few commits in the MR, though | 11:58 |
| valentind | Not easy to backport with the changed paths. | 12:01 |
| *** traveltissues has quit IRC | 12:03 | |
| *** traveltissues has joined #buildstream | 12:04 | |
| juergbi | valentind: if that's the main issue, a possible workaround is to edit/sed the `src/` out of patch files before cherry-picking them | 12:07 |
| juergbi | git rebase --onto might also work better than cherry-pick across renames | 12:07 |
| valentind | rebase did not work, I had to use patch -p2 | 12:08 |
| valentind | And the code is quite changed. | 12:08 |
| juergbi | the black reformatting is probably a culprit as well | 12:11 |
| valentind | OK, managed to port them. Now running the tests. | 12:22 |
| valentind | But I am not sure it is enough. | 12:22 |
| valentind | Because after these 4 commits it still calls add_child_handler outside of the loop. | 12:22 |
| valentind | So far the tests work. | 12:25 |
| valentind | Ah maybe the fix is fc6b3f37f173fd19e5a2593b7bf8cce40f03c615 | 12:26 |
| gitlab-br-bot | valentindavid opened MR !1830 (valentindavid/bst-1/python3.8-with-backports->bst-1: [BuildStream 1.4] Backport changes to enable Python 3.8) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1830 | 12:31 |
| valentind | It works. Just one test fails but this is because of the same bug in Python that triggers only during testing because of coverage. | 12:50 |
| valentind | It is missing some fixes. Otherwise it prints too much in the console after terminating | 13:00 |
| valentind | I wonder if master has the issue. | 13:01 |
| *** traveltissues has quit IRC | 13:08 | |
| *** traveltissues has joined #buildstream | 13:08 | |
| valentind | It seems we receive the SIGTERM we send to the child processes back in the parent | 13:27 |
| *** CTtpollard is now known as tpollard | 13:30 | |
| tpollard | that rings a bell | 13:30 |
| juergbi | valentind: sounds like https://gitlab.com/BuildStream/buildstream/commit/278d010b873b59aa5eed577cb92dd1342a6f6f34 | 13:45 |
| valentind | I think it inherits the signal handler at fork. | 13:45 |
| juergbi | yes, that commit should fix it | 13:46 |
| valentind | Seems to work better yes | 13:58 |
| *** santi has quit IRC | 14:00 | |
| *** santi has joined #buildstream | 14:00 | |
| gitlab-br-bot | juergbi approved MR !1830 (valentindavid/bst-1/python3.8-with-backports->bst-1: [BuildStream 1.4] Backport changes to enable Python 3.8) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1830 | 14:19 |
| *** narispo has quit IRC | 14:21 | |
| *** traveltissues has quit IRC | 14:31 | |
| valentind | juergbi, thank you. | 14:34 |
| gitlab-br-bot | valentindavid merged MR !1830 (valentindavid/bst-1/python3.8-with-backports->bst-1: [BuildStream 1.4] Backport changes to enable Python 3.8) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1830 | 14:35 |
| gitlab-br-bot | valentindavid closed MR !1829 (valentindavid/bst-1/python3.8->bst-1: [Buildstream 1.4] Add support for Python 3.8) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1829 | 14:35 |
| *** traveltissues has joined #buildstream | 14:45 | |
| *** santi has quit IRC | 14:56 | |
| *** santi has joined #buildstream | 14:57 | |
| *** pulsar has joined #buildstream | 15:44 | |
| *** hasebastian has joined #buildstream | 15:45 | |
| *** pulsar has quit IRC | 15:47 | |
| *** phildawson_ has quit IRC | 16:35 | |
| *** phildawson_ has joined #buildstream | 16:37 | |
| *** phildawson has joined #buildstream | 16:38 | |
| *** tme5 has quit IRC | 17:32 | |
| *** traveltissues has quit IRC | 17:54 | |
| *** santi has quit IRC | 17:58 | |
| *** jonathanmaw has quit IRC | 18:10 | |
| *** phildawson_ has joined #buildstream | 18:16 | |
| *** phildawson has quit IRC | 18:17 | |
| *** hasebastian has quit IRC | 18:17 | |
| *** juergbi has quit IRC | 18:17 | |
| *** flatmush has quit IRC | 18:17 | |
| *** douglaswinship has quit IRC | 18:17 | |
| *** paulsherwood has quit IRC | 18:17 | |
| *** benbrown has quit IRC | 18:17 | |
| *** benbrown has joined #buildstream | 18:19 | |
| *** flatmush has joined #buildstream | 18:20 | |
| *** paulsherwood has joined #buildstream | 18:20 | |
| *** douglaswinship has joined #buildstream | 18:21 | |
| *** juergbi has joined #buildstream | 18:24 | |
| *** phildawson_ has quit IRC | 18:35 | |
| *** slaf_ has joined #buildstream | 18:35 | |
| *** phildawson_ has joined #buildstream | 18:37 | |
| *** slaf has quit IRC | 18:37 | |
| *** slaf_ is now known as slaf | 18:37 | |
| *** phildawson_ has quit IRC | 18:40 | |
| *** traveltissues has joined #buildstream | 18:50 | |
| gitlab-br-bot | juergbi merged MR !1827 (juerg/vdirectory->master: Improve `Directory` API) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/1827 | 19:00 |
| *** narispo has joined #buildstream | 21:39 | |
| *** narispo has quit IRC | 21:41 | |
| *** narispo has joined #buildstream | 21:42 | |
| *** narispo has quit IRC | 22:25 | |
| *** narispo has joined #buildstream | 22:29 | |
| *** rdale has quit IRC | 23:01 | |
| *** narispo has quit IRC | 23:09 | |
| *** narispo has joined #buildstream | 23:10 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!