IRC logs for #buildstream for Monday, 2020-02-17

*** tristan has joined #buildstream01:57
*** narispo has quit IRC06:33
*** narispo has joined #buildstream06:33
*** narispo has quit IRC07:00
*** narispo has joined #buildstream07:02
*** slaf has quit IRC07:09
*** slaf has joined #buildstream07:11
*** slaf has joined #buildstream07:11
*** narispo has quit IRC07:11
*** slaf has joined #buildstream07:12
*** slaf has joined #buildstream07:12
*** slaf has joined #buildstream07:12
*** slaf has joined #buildstream07:12
*** slaf has joined #buildstream07:13
*** slaf has joined #buildstream07:13
*** narispo has joined #buildstream07:13
*** traveltissues has joined #buildstream08:18
*** mohan43u has quit IRC08:43
*** mohan43u has joined #buildstream08:46
*** paulsherwood has quit IRC09:01
*** paulsherwood has joined #buildstream09:02
*** bochecha has joined #buildstream09:04
*** phildawson_ has quit IRC09:27
*** phildawson_ has joined #buildstream09:27
benschubertvalentind: Sorry, was out end of last week. Thanks for the rational. We could also "just" use the public key for the source id :)09:39
benschubertjuergbi: do we have extensive tests on cache cleanup with casd? (v0.0.4) On a sample of 200 builds, I roughly had 20% failing because of a cache too full09:39
*** santi has joined #buildstream09:40
juergbibenschubert: we do have tests, both on casd and buildstream side. they attempt to capture corner cases but we might still be missing some09:43
juergbihowever, "cache too full" error is supposed to mean that the quota is too small for the session09:43
juergbiare you sure that is not the case?09:44
benschubertjuergbi: I have 2To of disk space for buildbox-casd, the entire buildstream project built + sources is under 200Go09:44
benschubertThe error is always on 'bst source fetch' also09:44
juergbihm, that's very odd09:44
juergbiabderrahim[m] has reported #1264 where we fail cleanup too much09:45
juergbibut I'm not aware of an issue where we incorrectly report cache too full09:45
benschubertjuergbi: ah, I mean the 2To are entirely full, but it's all available to casd to clean :)09:45
juergbibenschubert: can you check whether you have something in cas/tmp?09:46
benschubertyep, 1sec09:46
juergbithere is a buildbox-fuse bug about not cleaning up temp files. don't know whether you're using fuse09:46
juergbifixed here https://gitlab.com/BuildGrid/buildbox/buildbox-fuse/-/merge_requests/2709:46
benschubertmmh I don't have anything there09:47
benschubertbut my entire cas/ dir is 66G09:47
benschubertWut09:47
juergbitons of stuff in the non-cas sources?09:48
juergbithat's (intentionally) not covered by cleanup09:48
benschubertchecking09:48
juergbibtw: buildstream status bar should provide hints in such cases as it shows real time quota info from casd09:48
benschubertIt's an automated process, I don't ge tthe status bar :)09:49
juergbiah ok09:49
benschubertok I guess I found the culprit: my sources09:49
benschubertI have over 1To of data in buildstream/sources/09:49
juergbiso maybe lots of git repos with large history09:50
benschubertyep09:50
benschubertThat's gonna be a very bad experience to users :/09:50
*** tme5 has joined #buildstream09:51
juergbiremote asset API could help here09:51
benschubertbut on the other hand I'm not sure we want to expose a cleanup mechanism to sources09:51
benschubertah fair09:51
juergbiwe could consider a configuration option where we don't keep the non-cas sources directory around at all09:52
juergbii.e., delete the corresponding sources directory immediately after getting a source into CAS09:53
valentindAny body know about this issue with ruamel.yaml? https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/jobs/43921390709:54
benschubertvalentind: first time I see it :/09:55
benschubertcould you open an issue?09:55
juergbidoesn't look familiar to me either09:55
juergbivalentind: that's not master, is it?09:56
valentindYes, but I want first  to figure out why it is. If it is a specific element that we modified. Or if someone updated ruamel.yaml (I do not think we did).09:56
valentindIt is 1.409:56
juergbia lot changed in our yaml code since then, iirc09:56
*** jonathanmaw has joined #buildstream09:57
benschubertjuergbi: it was indeed my sources :(09:58
juergbibenschubert: btw: are you or Chandan still planning to review !1816? otherwise I'll probably merge it soon as it's been up for quite a while and Sander has already taken a look09:58
gitlab-br-botMR !1816: Reimplement support for incremental workspace builds https://gitlab.com/BuildStream/buildstream/-/merge_requests/181609:58
benschubertoh sorry, was a bit off buildstream those days. Let me have a quick look09:59
juergbita09:59
benschubertjuergbi: any performance regression expected for the non workspace case?10:00
*** tpollard has joined #buildstream10:02
juergbibenschubert: no, there should be almost no impact on non-workspace builds10:02
juergbione general change is the addition of a sources field to the artifact proto10:02
juergbihowever, it's populated only if we're also caching buildtree10:02
juergbiand it should be very cheap10:02
valentindFound the issue. There was a comment in a (>): list10:04
benschubertvalentind: that is probably also failing on master then, mind double checking/opening an issue?10:05
valentindLet me make a simple example.10:05
gitlab-br-botBenjaminSchubert approved MR !1816 (juerg/incremental-workspace-build->master: Reimplement support for incremental workspace builds) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/181610:06
benschubertjuergbi: it's quite nice to follow, thanks!10:06
*** phildawson-ct has joined #buildstream10:12
gitlab-br-botvalentindavid opened issue #1265 (Multiline comment in a "(>)" crashes "bst track") on buildstream https://gitlab.com/BuildStream/buildstream/issues/126510:13
valentindbenschubert, ^10:13
benschubertvalentind: thanks!10:18
*** toscalix has joined #buildstream10:28
gitlab-br-botjuergbi merged MR !1816 (juerg/incremental-workspace-build->master: Reimplement support for incremental workspace builds) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/181610:37
gitlab-br-botjuergbi closed issue #985 (Workspaces via CAS) on buildstream https://gitlab.com/BuildStream/buildstream/issues/98510:47
benschubertjuergbi: also, any reason buildstream/build would not be empty at the end of a run?10:50
juergbibenschubert: except for segfaults, SIGKILL or similar, I don't think so10:52
juergbiwe used to keep failed build roots around but that was dropped a long time ago10:52
benschubertok, easy way opf recovering 30Go then x')10:57
*** douglaswinship has joined #buildstream11:26
douglaswinshipDoes anyone have experience using the bzr source plugin? I've never used Bazaar before. I'm trying to port a project to build with buildstream, and one of the sources is listed as a bazaar source. I can't seem to get the tracking right.11:29
douglaswinshipthe documentation I have lists a source url (http://bazaar.launchpad.net/~dbusmenu-team/libdbusmenu-qt/trunk/) and a revision (0.9.3+16.04.20160218-0ubuntu1).11:29
douglaswinshipIf I try to build with just the URL, the plugin crashes and complains that the key "track" was expected and not found. If I try to "track: 0.9.3+16.04.20160218-0ubuntu1", then it tells me that that's not a branch of the repository.11:30
douglaswinship"0.9.3" doesn't work either.11:30
benschubertdouglaswinship: what does your element look like?11:31
coldtomdouglaswinship: the branches are listed here https://code.launchpad.net/libdbusmenu-qt, i believe `trunk` is a branch (but that's master, so you probably want a release branch)11:32
tpollardyou want 271 as the ref11:34
tpollardand track as trunk11:35
WSalmonany of the bst_external maintainers interested in https://gitlab.com/BuildStream/bst-external/-/merge_requests/117 ? once i start to move crash over to bst2 then i will try and get this functionality in to other plugins but as those plugins are currently in master of 1.4 changing them there seems like a bad idea11:35
persiaWSalmon: Wouldn't ported versions live in https://gitlab.com/BuildStream/bst-plugins-experimental ?11:37
WSalmonyes that repo is for bst1.9/2 plugins so thats were i will work once crash is using bst2 but bst-experiment is were the bst1.4 plugins live atm11:39
WSalmonwell exactly were the core plugins will end up is not 100% so were ever the remote plugin ends up is probably were this functionality will eventually live but bst-external seems like the right place for this plugin11:40
benschubertWSalmon: I wonder whether the trick with '{project_dir}' would do instead for this? (adding a variable that resolves to the project's directory)11:44
coldtombenschubert: how does one add such a variable at present ooi? or is this a feature that would need to be implemented in buildstream?11:45
benschubertcoldtom: something we were talking about implementing11:45
benschubertbut the ML thread stalled11:45
coldtomah, aiui that ML thread would have been enough to solve WSalmon's issue11:46
benschubertyup :)11:46
douglaswinshipbenschubert: coldtom: got it resolved. I needed to move "trunk" off the end of the URL, and have _that_ as the value under 'track'.11:49
douglaswinshipI also had https instead of http, which is apparently enough to break it.11:49
douglaswinshiptpollard: 271 was close. When I run bst track, i get 271 as the ref, rather than as the tracking instruction.11:50
tpollardyep, that's the ref/rev of that release11:51
WSalmonyes, benschubert as for the best solution for master then the jury is very much still out. but for bst1.4 then a plugin seems like the way to go11:51
douglaswinshipOf course, the element still doesn't build. But at least it's not a source issue :) On to the next bug... :D11:51
*** xjuan has joined #buildstream13:16
*** phildawson has joined #buildstream14:00
*** phildawson-ct has quit IRC14:00
*** narispo has quit IRC14:25
*** narispo has joined #buildstream14:26
*** phildawson has quit IRC14:57
*** traveltissues has quit IRC15:02
*** phildawson has joined #buildstream15:03
gitlab-br-botabderrahimk opened issue #1266 (Can't load a project with an older workspace to a junction) on buildstream https://gitlab.com/BuildStream/buildstream/issues/126615:21
*** lachlan has joined #buildstream15:56
gitlab-br-botabderrahimk opened MR !1820 (abderrahim/simple-host-files->master: _project.py: fix the case where a simple string is passed to host-files) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/182016:05
*** lachlan has quit IRC16:05
gitlab-br-botBenjaminSchubert approved MR !1820 (abderrahim/simple-host-files->master: _project.py: fix the case where a simple string is passed to host-files) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/182016:07
*** lachlan has joined #buildstream16:47
*** lachlan has quit IRC16:57
*** lachlan has joined #buildstream16:59
*** lachlan has quit IRC17:03
*** lachlan has joined #buildstream17:08
*** lachlan has quit IRC17:13
*** lachlan has joined #buildstream17:15
*** lachlan has quit IRC17:32
*** lachlan has joined #buildstream17:38
*** phildawson has quit IRC17:42
*** lachlan has quit IRC17:43
*** tme5 has quit IRC17:58
*** lachlan has joined #buildstream18:02
*** rafaelff1[m] has quit IRC18:04
*** reuben640[m] has quit IRC18:05
*** m_22[m] has quit IRC18:05
*** segfault1[m] has quit IRC18:05
*** abderrahim[m]1 has quit IRC18:05
*** tchaik[m] has quit IRC18:05
*** Abderrahim[m] has quit IRC18:05
*** theawless[m] has quit IRC18:05
*** asingh_[m] has quit IRC18:05
*** Trevio[m] has quit IRC18:05
*** SamThursfield[m] has quit IRC18:05
*** awacheux[m] has quit IRC18:05
*** doras[m] has quit IRC18:05
*** cgm[m] has quit IRC18:05
*** connorshea[m] has quit IRC18:05
*** DineshBhattarai[m] has quit IRC18:05
*** krichter[m] has quit IRC18:05
*** mattiasb has quit IRC18:05
*** dbuch[m] has quit IRC18:05
*** pro[m] has quit IRC18:05
*** Demos[m] has quit IRC18:05
*** albfan[m] has quit IRC18:05
*** tlater[m] has quit IRC18:05
*** kailueke[m] has quit IRC18:05
*** jjardon[m] has quit IRC18:06
*** walterve[m][m] has quit IRC18:06
*** skullone[m] has quit IRC18:06
*** dylan-m has quit IRC18:06
*** lachlan has quit IRC18:08
*** brlogger has joined #buildstream18:12
*** rafaelff1[m] has joined #buildstream18:20
*** segfault1[m] has joined #buildstream18:21
*** lachlan has joined #buildstream18:22
*** segfault1[m] has quit IRC18:27
*** rafaelff1[m] has quit IRC18:27
*** abderrahim[m] has joined #buildstream18:28
*** jonathanmaw has quit IRC18:29
*** lachlan has quit IRC18:39
*** Abderrahim[m]1 has joined #buildstream18:57
*** asingh_[m] has joined #buildstream18:57
*** kailueke[m] has joined #buildstream18:57
*** tlater[m] has joined #buildstream18:57
*** albfan[m] has joined #buildstream18:57
*** rafaelff1[m] has joined #buildstream18:57
*** reuben640[m] has joined #buildstream18:57
*** doras[m] has joined #buildstream18:57
*** jjardon[m] has joined #buildstream18:57
*** SamThursfield[m] has joined #buildstream18:57
*** dbuch[m] has joined #buildstream18:57
*** tchaik[m] has joined #buildstream18:57
*** Demos[m] has joined #buildstream18:57
*** m_22[m] has joined #buildstream18:57
*** awacheux[m] has joined #buildstream18:57
*** cgm[m] has joined #buildstream18:57
*** mattiasb has joined #buildstream18:57
*** DineshBhattarai[m] has joined #buildstream18:57
*** theawless[m] has joined #buildstream18:57
*** segfault1[m] has joined #buildstream18:57
*** Trevio[m] has joined #buildstream18:57
*** walterve[m][m] has joined #buildstream18:57
*** dylan-m has joined #buildstream18:57
*** connorshea[m] has joined #buildstream18:57
*** skullone[m] has joined #buildstream18:57
*** pro[m] has joined #buildstream18:57
*** krichter[m] has joined #buildstream18:57
*** lachlan has joined #buildstream18:58
*** lachlan has quit IRC19:02
*** toscalix has quit IRC19:03
*** lachlan has joined #buildstream19:20
*** lachlan has quit IRC19:21
*** narispo has quit IRC20:13
*** narispo has joined #buildstream20:27
*** narispo has quit IRC20:33
*** narispo has joined #buildstream20:34
*** narispo has quit IRC20:44
*** narispo has joined #buildstream20:44
*** xjuan has quit IRC21:43
*** xjuan has joined #buildstream21:44
*** abderrahim[m] has quit IRC21:47
*** abderrahim[m] has joined #buildstream21:47
*** xjuan has quit IRC22:04
*** xjuan has joined #buildstream23:18

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!