IRC logs for #buildstream for Wednesday, 2020-01-29

*** dylan-m has joined #buildstream00:14
*** dylan-m has quit IRC00:35
*** dylan-m has joined #buildstream01:19
*** dylan-m has quit IRC01:36
*** dylan-m has joined #buildstream02:20
*** dylan-m has quit IRC03:13
*** traveltissues has joined #buildstream08:44
gitlab-br-botcoldtom opened MR !1811 (coldtom/fix-overnight-test->master: .gitlab-ci.yml: Bump bst-plugins-experimental) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/181109:15
*** benschubert has quit IRC09:20
*** benschubert has joined #buildstream09:20
*** jonathanmaw has joined #buildstream09:36
gitlab-br-botBenjaminSchubert approved MR !1811 (coldtom/fix-overnight-test->master: .gitlab-ci.yml: Bump bst-plugins-experimental) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/181109:41
*** tme5 has joined #buildstream09:44
tme5is it possible for !1808 to be merged today? pretty sure it's passed review09:45
gitlab-br-botMR !1808: Improvements to _GitSourceBase and _GitMirror https://gitlab.com/BuildStream/buildstream/-/merge_requests/180809:45
benschuberttme5: sure, can I go ahead and merge it now?09:48
tme5yeah, it's ready09:50
gitlab-br-botBenjaminSchubert merged MR !1808 (tmewett/git-source->master: Improvements to _GitSourceBase and _GitMirror) on buildstream https://gitlab.com/BuildStream/buildstream/-/merge_requests/180809:50
benschubertthanks :)09:50
*** santi has joined #buildstream09:54
*** slaf has quit IRC09:58
*** slaf has joined #buildstream09:59
*** slaf has joined #buildstream10:00
tme5np, thanks for merge10:06
robjhironfoot, you were right. the '/' at the beginning of the path was the issue.10:22
robjhthere's a new problem now though, it looks like overlap-whitelist follows symlinks /o\10:23
ironfootoh, ouch10:24
robjhnot the whitelist itsself, but the thing that detects changes in overlapped files, so the symlink is being flagged as an overlap when the destination is what's actually overlapping10:26
robjhi should probably raise a bug report10:26
juergbirobjh: please do, we should definitely not be following symlinks. if you've seen this issue on bst 1.x, it's possible it's already fixed in master, though10:29
juergbi(we fixed a lot of symlink issues a while ago but I don't remember whether those were applied before branching / to bst 1.x)10:30
robjhmy bst is from the debian repo, so its probably ancient10:31
*** santi has quit IRC10:33
*** santi has joined #buildstream10:33
juergbiok, so it might be fixed already10:33
coldtomhi, i'm trying to figure out exactly how proxying through buildbox-casd to push artifacts works, but I can't for the life of me see how buildbox-casd is informed of the remote url, does anyone have any pointers on where this happens?10:36
coldtoms/artifacts/blobs from artifacts/10:37
juergbicoldtom: GetInstanceNameForRemoteRequest() is used to get an identifier (instance name) for the URL and that identifier is then used in actual blob-related requests10:47
coldtomah, thanks juergbi, i think i was missing the fact that the instance name is sufficient to push/pull things10:51
*** santi has quit IRC10:51
*** santi has joined #buildstream10:52
juergbiit may be a bit confusing but this approach allows us to work with existing CAS protocol methods that we couldn't extend10:52
*** phildawson-ct has quit IRC11:12
*** narispo has joined #buildstream11:16
*** santi has quit IRC11:52
*** santi has joined #buildstream11:52
coldtomso, i've written a patch to allow bst-artifact-server to optionally proxy artifact/reference storage to a remote CAS, however while implementing said feature i realised that this might actually be better as an external tool altogether. does this sound like something people would be interested in?13:15
coldtomthe reasoning for writing this being mainly "i want to store my artifact protos with some other backend" and "i don't want to add more storage for artifact protos when i have a perfectly good volume attached to my CAS"13:17
juergbicoldtom: how exactly do you store the artifact protos? standard CAS alone does not suffice13:32
juergbias discussed yesterday, the plan is to switch to the Remote Asset API13:33
juergbinot sure yet how bst-artifact-server should be changed at that point13:35
*** xjuan has joined #buildstream13:37
*** tpollard has quit IRC13:42
*** tpollard has joined #buildstream13:46
*** phildawson-ct has joined #buildstream13:48
*** phildawson-ct has quit IRC14:00
coldtomjuergbi: i'm just serialising them and using bytestream to push them, is this approach naïve? i agree that the remote asset api is the best way to go in the future, which is part of the reason why i think an external tool for this would be more useful14:00
juergbicoldtom: ah, you have a CAS server that accepts bytestreams with arbitrary names instead of strictly just CAS objects?14:01
juergbi(i.e., not content addressed)14:01
coldtomah, i hadn't thought of that, i might need to do some more digging14:02
*** phildawson-ct has joined #buildstream14:02
juergbiwith strict CAS, it's not possible to store artifact protos/refs14:02
juergbi(you can store the artifact protos, of course, but you couldn't get them back without knowing the hash)14:03
juergbibuildgrid and buildbox casd don't accept non-CAS objects, afaik14:03
juergbidon't know about buildbarn/buildgrid but I wouldn't expect those to accept non-CAS objects either14:03
coldtomi _think_ bb-storage (which is what i'm intending to use) does handle arbitrary bytestreams with some caveats, so it should be able to store them safely14:12
coldtombut other CAS implementations not accepting this confirms to me that this should be an external tool for sure14:12
coldtomack, i was wrong, i think i'll just have to accept that bst-artifact-server is unavoidable :/14:48
*** phildawson-ct has quit IRC14:57
*** rdale has quit IRC15:03
*** rdale has joined #buildstream15:03
*** phildawson has joined #buildstream15:05
*** tme5 has quit IRC15:29
*** tme5 has joined #buildstream15:29
*** rdale has quit IRC15:42
*** rdale has joined #buildstream15:45
*** xjuan has quit IRC16:12
*** phildawson-ct has joined #buildstream16:21
*** phildawson has quit IRC16:22
*** traveltissues has quit IRC16:48
*** xjuan has joined #buildstream17:07
*** dylan-m has joined #buildstream17:23
*** jonathanmaw has quit IRC17:29
*** dylan-m_ has joined #buildstream17:29
*** dylan-m has quit IRC17:30
*** dylan-m_ is now known as dylan-m17:30
*** narispo has quit IRC17:33
*** tme5 has quit IRC17:38
*** santi has quit IRC18:10
*** phildawson-ct has quit IRC18:11
*** phildawson-ct has joined #buildstream18:11
*** dylan-m has quit IRC19:07
*** dylan-m has joined #buildstream19:17
*** dylan-m has quit IRC19:29
*** phildawson-ct has quit IRC19:40
*** toscalix has joined #buildstream20:48
*** dylan-m has joined #buildstream21:32
*** xjuan has quit IRC23:11
*** xjuan has joined #buildstream23:25

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!