| *** dylan-m has quit IRC | 01:17 | |
| *** awacheux[m] has quit IRC | 01:37 | |
| *** awacheux[m] has joined #buildstream | 02:02 | |
| *** dylan-m has joined #buildstream | 03:15 | |
| *** dylan-m has quit IRC | 03:31 | |
| *** delli3_ has joined #buildstream | 04:24 | |
| *** delli3 has quit IRC | 04:27 | |
| *** segfault3[m] has quit IRC | 08:11 | |
| *** traveltissues has joined #buildstream | 08:22 | |
| *** phildawson has joined #buildstream | 09:21 | |
| *** tme5 has joined #buildstream | 09:53 | |
| *** jonathanmaw has joined #buildstream | 10:29 | |
| tme5 | is it allowed for a plugin to run subprocesses without using self.call ? | 10:43 |
|---|---|---|
| tpollard | why wouldn't you use call? | 10:45 |
| tme5 | i don't know tbh lol | 10:48 |
| *** phildawson has quit IRC | 10:59 | |
| *** phildawson has joined #buildstream | 10:59 | |
| traveltissues | i think the question is would it be acceptable for that to happen? | 11:06 |
| traveltissues | my thinking is no | 11:07 |
| tpollard | there's nothing in the coding guidelines that specifically restricts it | 11:12 |
| tpollard | but I agree, I don't think it should be acceptable/needed | 11:13 |
| gitlab-br-bot | jjardon closed issue #1258 (Plugin tests accessing private API) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1258 | 11:15 |
| gitlab-br-bot | jjardon merged MR !1806 (coldtom/testing-api->master: Stop plugin tests using private API) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1806 | 11:15 |
| tme5 | i have added a version check to the optimisation added in !1808. I found the required functionality was added in git 1.9.0, 6 years ago :P | 11:15 |
| gitlab-br-bot | MR !1808: Improvements to _GitSourceBase and _GitMirror https://gitlab.com/BuildStream/buildstream/merge_requests/1808 | 11:15 |
| *** ChanServ sets mode: +o tristan | 11:15 | |
| tristan | its incorrect to bypass the buildstream APIs | 11:15 |
| tristan | in the case of the utilities for spawning processes, the subprocess will not be properly terminated or put to sleep / woken up when the master process gets SIGTERM and SIGTSTP | 11:16 |
| tristan | e.g. when the user hits ^Z or ^C and such | 11:17 |
| *** phildawson has quit IRC | 11:26 | |
| *** phildawson has joined #buildstream | 11:30 | |
| tpollard | well, doesn't that depending if the plugin code is already under a buildstream job process | 11:31 |
| tpollard | at which point itself is under the sig handlers | 11:31 |
| tpollard | anyway I agree it's incorrect | 11:32 |
| tpollard | do we have any current implementations that require shell=True on the subprocess calls? looking at the api, we'd allow it in kwargs | 11:34 |
| coldtom | a quick grep on bst-plugins-experimental suggests not | 11:37 |
| tme5 | benschubert, if you have a second could you look at the version check I added in !1808 and see if it's ok? | 12:30 |
| tristan | tpollard, no it doesnt depend | 13:24 |
| tristan | tpollard, the master <--> child process handling is one thing, child processes which spawn things and use Plugin.call() and such do another recursive thing | 13:24 |
| tristan | and the sandboxing calls do yet another (similar to Plugin.call()) thing | 13:25 |
| tristan | calls to Plugin.call() from the main process are rather rare and not as well tested as I recall (these are exceptions to the rule, like when you do a fetch at the beginning of a `bst workspace open` call in the foreground process) | 13:27 |
| *** narispo has joined #buildstream | 13:46 | |
| benschubert | tme5: sure looking now | 13:53 |
| *** xjuan has joined #buildstream | 13:55 | |
| gitlab-br-bot | BenjaminSchubert approved MR !1808 (tmewett/git-source->master: Improvements to _GitSourceBase and _GitMirror) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1808 | 13:55 |
| benschubert | Seems good tme5 thanks for the cleanup and optimisation :) | 13:55 |
| *** dellie__ has joined #buildstream | 14:03 | |
| *** delli3_ has quit IRC | 14:03 | |
| *** phoenix has joined #buildstream | 14:14 | |
| *** phoenix has quit IRC | 14:18 | |
| tme5 | ah ty, i've just rebased | 14:33 |
| *** narispo has quit IRC | 15:00 | |
| *** traveltissues has quit IRC | 15:08 | |
| *** xjuan has quit IRC | 15:17 | |
| *** narispo has joined #buildstream | 16:08 | |
| *** dylan-m has joined #buildstream | 16:40 | |
| *** xjuan has joined #buildstream | 16:59 | |
| *** tme5 has quit IRC | 17:39 | |
| *** narispo has quit IRC | 17:41 | |
| *** narispo has joined #buildstream | 17:43 | |
| *** tpollard has quit IRC | 17:48 | |
| *** narispo has quit IRC | 17:53 | |
| *** narispo has joined #buildstream | 17:53 | |
| *** rdale has quit IRC | 18:01 | |
| *** jonathanmaw has quit IRC | 18:06 | |
| *** dylan-m has quit IRC | 18:27 | |
| *** narispo has quit IRC | 18:28 | |
| *** narispo has joined #buildstream | 18:29 | |
| *** dylan-m has joined #buildstream | 18:31 | |
| *** dylan-m has quit IRC | 18:36 | |
| *** narispo has quit IRC | 19:05 | |
| *** xjuan has quit IRC | 20:28 | |
| *** brlogger has joined #buildstream | 20:59 | |
| *** awacheux[m] has joined #buildstream | 21:58 | |
| *** cgmcintyre[m] has joined #buildstream | 22:04 | |
| *** tlater[m] has joined #buildstream | 22:26 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!