| *** narispo has quit IRC | 00:20 | |
| *** ikerperez has quit IRC | 02:41 | |
| *** delli3 has quit IRC | 06:00 | |
| *** delli3 has joined #buildstream | 06:01 | |
| *** traveltissues has joined #buildstream | 07:21 | |
| *** slaf has quit IRC | 08:03 | |
| *** slaf has joined #buildstream | 08:05 | |
| *** slaf has joined #buildstream | 08:05 | |
| *** slaf has joined #buildstream | 08:05 | |
| *** slaf has joined #buildstream | 08:05 | |
| *** slaf has joined #buildstream | 08:06 | |
| *** slaf has joined #buildstream | 08:06 | |
| *** slaf has joined #buildstream | 08:06 | |
| *** slaf has joined #buildstream | 08:06 | |
| *** slaf has joined #buildstream | 08:07 | |
| *** slaf has joined #buildstream | 08:07 | |
| *** slaf has joined #buildstream | 08:07 | |
| *** slaf has joined #buildstream | 08:07 | |
| *** bochecha has joined #buildstream | 09:25 | |
| *** rdale has joined #buildstream | 09:35 | |
| *** ikerperez has joined #buildstream | 09:43 | |
| *** ikerperez has joined #buildstream | 09:43 | |
| *** ikerperez has quit IRC | 09:45 | |
| *** ikerperez has joined #buildstream | 09:45 | |
| *** ikerperez has joined #buildstream | 09:48 | |
| *** tpollard has joined #buildstream | 09:54 | |
| *** jonathanmaw has joined #buildstream | 09:55 | |
| *** ikerperez has quit IRC | 10:00 | |
| *** qinusty has joined #buildstream | 10:01 | |
| *** qinusty has joined #buildstream | 10:02 | |
| *** qinusty has quit IRC | 10:03 | |
| *** qinusty has joined #buildstream | 10:03 | |
| *** ikerperez has joined #buildstream | 10:16 | |
| *** cs-shadow has joined #buildstream | 10:37 | |
| *** benschubert has joined #buildstream | 10:40 | |
| *** juergbi has quit IRC | 10:41 | |
| *** juergbi has joined #buildstream | 10:43 | |
| *** lachlan has joined #buildstream | 10:44 | |
| *** lachlan has quit IRC | 11:10 | |
| tpollard | wooo 3.8.1 support | 11:11 |
|---|---|---|
| *** narispo has joined #buildstream | 11:19 | |
| *** lachlan has joined #buildstream | 11:28 | |
| gitlab-br-bot | BenjaminSchubert approved MR !1786 (chandan/fix-cpu-count->master: _platform: Don't use psutil.Process.cpu_affinity on unsupported platforms) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1786 | 11:31 |
| gitlab-br-bot | tpollard approved MR !1784 (chandan/tag-1.91.3->master: Prepare NEWS for 1.91.3 development snapshot release) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1784 | 11:32 |
| gitlab-br-bot | cs-shadow closed issue #1244 (Don't use psutil.Process.cpu_affinity on platform not supporting it) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1244 | 11:33 |
| gitlab-br-bot | cs-shadow merged MR !1786 (chandan/fix-cpu-count->master: _platform: Don't use psutil.Process.cpu_affinity on unsupported platforms) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1786 | 11:33 |
| cs-shadow | tpollard: do try it on 3.8.1 if you can :) BuildStream hasn’t been extensively tested on 3.8 just yet (or 3.8 itself for that matter) | 11:36 |
| tpollard | I'm semi glad the recursion bug was upstream & not us | 11:38 |
| cs-shadow | yeah, i've just learned to not trust *.0 releases. Someone always misses something | 11:39 |
| gitlab-br-bot | BenjaminSchubert approved MR !1785 (tlater/clean-shutils->master: Clean up usage of shutil.rmtree()) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1785 | 12:03 |
| tlater[m] | Ta benschubert | 12:04 |
| tlater[m] | Hm... | 12:05 |
| tlater[m] | I wonder if that's right | 12:05 |
| tlater[m] | `shutil.rmtree(ignore_errors=True)` will probably remove more than an except/pass on it | 12:05 |
| benschubert | tlater[m]: I'm not 100% around https://gitlab.com/BuildStream/buildstream/merge_requests/1787/diffs I wonder whether we should not have multiple classes instead, which would also remove the need to compare per string :) | 12:06 |
| tlater[m] | benschubert: I thought about that, but it would be pretty hard to use multiple classes when they're passed down into stream | 12:07 |
| tlater[m] | Or do you mean just multiple classes that match different kinds of arguments? | 12:07 |
| benschubert | Multiple inheritance, with Stream expecting hte abse class :) | 12:07 |
| benschubert | yup | 12:07 |
| tlater[m] | Ah | 12:07 |
| benschubert | ah shoot, I forbid inheritance in the FastEnum :( | 12:07 |
| tlater[m] | Hm, that's an option, yeah | 12:07 |
| tlater[m] | :( | 12:08 |
| benschubert | well, multiple inheritance | 12:08 |
| benschubert | so that won't work | 12:08 |
| benschubert | unless I fix it, but that will be harder | 12:08 |
| tlater[m] | In either case, we've suggested re-working the whole --deps stuff, so this is more of a stopgap than the final solution. | 12:08 |
| benschubert | oh? Did I miss the suggestion? | 12:09 |
| tlater[m] | benschubert: It's a couple of months ago by now | 12:09 |
| tlater[m] | It was the big UI/UX rework email jennis and I sent out | 12:09 |
| benschubert | ah right | 12:09 |
| *** lachlan has quit IRC | 12:31 | |
| *** lachlan has joined #buildstream | 12:41 | |
| *** lachlan has quit IRC | 12:51 | |
| gitlab-br-bot | cs-shadow merged MR !1784 (chandan/tag-1.91.3->master: Prepare NEWS for 1.91.3 development snapshot release) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1784 | 12:54 |
| *** lachlan has joined #buildstream | 12:55 | |
| *** lachlan has quit IRC | 12:58 | |
| *** lachlan has joined #buildstream | 13:06 | |
| *** lachlan has quit IRC | 13:12 | |
| traveltissues | if anyone has merge permissions for buildbox i have some mrs still open: https://gitlab.com/BuildGrid/buildbox/buildbox-fuse/merge_requests/24 https://gitlab.com/BuildGrid/buildbox/buildbox-casd/merge_requests/102 | 13:56 |
| gitlab-br-bot | BenjaminSchubert approved MR !1787 (tlater/pipeline-enums->master: Make PipelineSelection a proper enum type) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1787 | 13:58 |
| tlater[m] | Ta benschubert - comments make a lot of sense too | 13:59 |
| benschubert | tlater[m]: happy to help! If there is anything that needs review/my attention don't hesitate | 14:00 |
| tlater[m] | :) | 14:00 |
| benschubert | (worth for anybody ^^) | 14:00 |
| tlater[m] | I'll probably ask you again on 1785 once I've thought through it. | 14:00 |
| tlater[m] | Let me just do this now, get it behind me... | 14:00 |
| *** lachlan has joined #buildstream | 14:04 | |
| *** bochecha has quit IRC | 14:21 | |
| tlater[m] | benschubert: For reference, did you mean giving a list like [_PipelineSelection.ALL, _PipelineSelection.NONE, ...] to the FastEnum here: https://gitlab.com/BuildStream/buildstream/merge_requests/1787#note_266494361 ? | 14:27 |
| benschubert | yes | 14:28 |
| benschubert | that would seem less error prone | 14:28 |
| tlater[m] | Yeah, interestingly it means we need to take the .value of those | 14:28 |
| benschubert | but if you'd rather not since too verbose, I can agree too :) | 14:28 |
| tlater[m] | Rather than using the actual enums | 14:28 |
| tlater[m] | Because click will pass strings to its convert... | 14:28 |
| benschubert | correct | 14:28 |
| * tlater[m] wonders why this is taking him so long, but will press on | 14:29 | |
| tlater[m] | Grmbl grmbl dynamic typing | 14:29 |
| benschubert | otherwise we can keep as it | 14:29 |
| tlater[m] | Nah, I prefer your suggestion, just annoyed at click x) | 14:29 |
| benschubert | Can someone explain to me why buildstream plugins specify buildstream as a dependency? It's really annoying when testing a new version of BuildStream with plugins | 14:32 |
| cs-shadow | I think this is a problem with plugins in general as there is no definitive guideline. For example, half of django plugins depend on it, and the other half doesn't. The argument for having the dependency goes like this - plugins `import buildstream` and hence must declare it as a dependency | 14:39 |
| *** lachlan has quit IRC | 14:46 | |
| *** lachlan has joined #buildstream | 14:53 | |
| benschubert | :/ that's annoying | 14:57 |
| *** lachlan has quit IRC | 15:17 | |
| gitlab-br-bot | tpollard opened MR !1788 (tpollard/loop_exception->master: scheduler.py: Handle exceptions that are caught under the event loop) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1788 | 15:25 |
| tlater[m] | benschubert: Think this is ok for that if/elif/else thing? https://gitlab.com/BuildStream/buildstream/merge_requests/1787/diffs#abbdbda11b4ad0e8b59c5218ca0989e0348849d9_228_199 | 15:33 |
| tlater[m] | Otherwise I can just fix the blanket else | 15:33 |
| tlater[m] | But that's so much more readable... | 15:33 |
| * tlater[m] has probably been doing too much rust, though | 15:34 | |
| benschubert | I personnally like it iff it doesn't affect performances :) | 15:35 |
| tlater[m] | It will probably by a tiny bit; an additional function call each | 15:37 |
| * tlater[m] isn't sure he can be bothered to run benchmarks though | 15:37 | |
| tlater[m] | Eh, let's see if the bot works | 15:38 |
| *** lachlan has joined #buildstream | 15:45 | |
| *** lachlan has quit IRC | 16:00 | |
| *** lachlan has joined #buildstream | 16:06 | |
| *** lachlan has quit IRC | 16:12 | |
| *** traveltissues has quit IRC | 16:18 | |
| *** lachlan has joined #buildstream | 16:23 | |
| *** lachlan has quit IRC | 16:26 | |
| cs-shadow | https://gitlab.com/BuildStream/bst-plugins-experimental/merge_requests/64 for review - to add more test environments to the plugins repo | 16:28 |
| *** lachlan has joined #buildstream | 16:43 | |
| *** lachlan has quit IRC | 16:46 | |
| *** lachlan has joined #buildstream | 16:49 | |
| *** lachlan has quit IRC | 16:59 | |
| *** lachlan has joined #buildstream | 17:41 | |
| *** jonathanmaw has quit IRC | 17:52 | |
| *** lachlan has quit IRC | 17:54 | |
| *** slaf has quit IRC | 18:20 | |
| *** slaf has joined #buildstream | 18:26 | |
| *** slaf has joined #buildstream | 18:26 | |
| *** slaf has joined #buildstream | 18:26 | |
| *** slaf has joined #buildstream | 18:26 | |
| *** slaf has joined #buildstream | 18:27 | |
| *** traveltissues has joined #buildstream | 20:01 | |
| *** narispo has quit IRC | 20:05 | |
| *** narispo has joined #buildstream | 20:05 | |
| *** rdale has quit IRC | 22:02 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!