IRC logs for #buildstream for Thursday, 2019-12-19

« Wednesday, 2019-12-18 Index Friday, 2019-12-20 »
*** benschubert has joined #buildstream00:32
*** rdale has joined #buildstream01:57
*** swick has quit IRC01:58
*** swick has joined #buildstream02:09
*** rdale has quit IRC02:15
*** benschubert has quit IRC02:42
*** phoenix has joined #buildstream02:54
*** phoenix has quit IRC03:00
*** phoenix__ has joined #buildstream03:00
*** phoenix__ is now known as phoenix03:01
*** phoenix has quit IRC04:06
*** phoenix has joined #buildstream05:52
*** phoenix has quit IRC05:56
gitlab-br-botjuergbi opened MR !1775 (juerg/pytest-timeout->master: setup.cfg: Set pytest default timeout) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/177507:44
*** slaf has quit IRC07:59
*** slaf has joined #buildstream08:01
*** slaf has joined #buildstream08:01
*** slaf has joined #buildstream08:02
*** slaf has joined #buildstream08:02
*** slaf has joined #buildstream08:02
*** slaf has joined #buildstream08:02
*** slaf has joined #buildstream08:03
*** slaf has joined #buildstream08:03
*** phoenix has joined #buildstream08:25
gitlab-br-botjuergbi opened MR !1776 (juerg/job-process-close->master: job.py: Do not call Process.close()) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/177608:28
*** phoenix has quit IRC08:35
*** benschubert has joined #buildstream09:15
*** santi has joined #buildstream09:49
*** tiagogomes has joined #buildstream09:51
gitlab-br-bottpollard approved MR !1775 (juerg/pytest-timeout->master: setup.cfg: Set pytest default timeout) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/177509:57
gitlab-br-bottpollard approved MR !1776 (juerg/job-process-close->master: job.py: Do not call Process.close()) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/177610:06
*** lachlan has joined #buildstream10:31
*** lachlan has quit IRC10:49
*** lachlan has joined #buildstream10:59
*** lachlan has quit IRC11:02
*** lachlan has joined #buildstream11:05
gitlab-br-botBenjaminSchubert closed MR !1773 (bschubert/fix-resource-deletion->master: _compat.py: Add module to handle version compatibility in python) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/177311:10
gitlab-br-botBenjaminSchubert approved MR !1775 (juerg/pytest-timeout->master: setup.cfg: Set pytest default timeout) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/177511:11
gitlab-br-botjuergbi merged MR !1775 (juerg/pytest-timeout->master: setup.cfg: Set pytest default timeout) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/177511:13
*** lachlan has quit IRC11:27
*** lachlan has joined #buildstream11:28
*** lachlan has quit IRC11:32
*** lachlan has joined #buildstream11:34
*** lachlan has quit IRC11:40
juergbiremote execution CI is broken again with today's BuildGrid docker image. I've tracked it down to this issue: https://gitlab.com/BuildGrid/buildgrid/issues/24011:41
*** lachlan has joined #buildstream11:43
gitlab-br-botjuergbi opened issue #1245 (Install asyncio exception handler) on buildstream https://gitlab.com/BuildStream/buildstream/issues/124511:44
*** santi has quit IRC11:47
gitlab-br-botjuergbi opened MR !1777 (juerg/drop-chroot-sandbox->master: Drop chroot sandboxing backend) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/177711:50
*** santi has joined #buildstream11:55
*** lachlan has quit IRC11:58
*** lachlan has joined #buildstream12:07
*** lachlan has quit IRC12:10
*** lachlan has joined #buildstream12:13
*** lachlan has quit IRC12:16
*** lachlan has joined #buildstream12:21
*** lachlan has quit IRC12:25
*** lachlan has joined #buildstream12:35
gitlab-br-botjuergbi closed issue #1243 (close() on child subprocesses is causing ValueErrors on Python 3.7+) on buildstream https://gitlab.com/BuildStream/buildstream/issues/124312:37
gitlab-br-botjuergbi merged MR !1776 (juerg/job-process-close->master: job.py: Do not call Process.close()) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/177612:37
*** lachlan has quit IRC12:41
*** narispo has joined #buildstream13:19
*** santi has quit IRC13:55
tpollardif anyone has any input on https://gitlab.com/BuildStream/buildstream/merge_requests/1745 it would be much appreciated13:57
*** santi has joined #buildstream14:01
juergbitpollard: does this also have an effect when not running in an (interactive) terminal?14:13
tpollardit should not have an affect14:13
tpollardoh wait I see what you mean14:14
tpollardit should behave the same for both interactive/non-interactive14:15
*** lachlan has joined #buildstream14:15
*** lachlan has quit IRC14:20
juergbitpollard: does it actually help in any way in the non-interactive UI? i.e., if we print everything anyway as we don't have the curses-like UI, we might as well print it immediately14:21
tpollardit reduces the number of UI updates, so I can't see why it wouldn't help?14:25
tpollardI could benchmark with --no-interactive set, but afaict it will give the same time reduction14:26
tpollardor do you mean specifically no tty?14:29
*** lachlan has joined #buildstream14:29
*** adds68 has quit IRC14:30
*** phildawson has quit IRC14:30
*** qinusty has quit IRC14:30
*** ikerperez has quit IRC14:30
tpollardif so, all of the status drawing methods are no-op when there's no terminal14:31
juergbitpollard: I meant no tty but explicit --no-interactive should be the same14:33
juergbijust want to make sure there are no downsides in that case as I don't think throttling is needed there14:33
tpollard--no-interactive in does as many echos to the terminal as interactive does, so they should both benefit from the reduction in calls14:34
tpollard*in master14:34
tpollardwell, minus the app specific calls to notify14:35
*** lachlan has quit IRC14:36
tpollardwhich is like 4 or 5 specific messages in a session14:36
tpollardwas it originally intended the --no-interactive sent no messaging?14:37
*** ikerperez has joined #buildstream14:39
juergbinot sure I understand correctly. I don't think --no-interactive was ever intended to reduce the number of messages (but it drops status bar etc.)14:39
tpollardI don't believe it drops the status bar14:40
tpollardnot in master14:40
tpollardno part of status or widget is defined by interactivity from app14:41
juergbibenschubert: just got "Severely malformed YAML: 'NoneType' object is not callable"14:42
tpollardjust benchmarked with --no-interactive & a tty, roughly the same speed improvement as being interactive14:43
juergbiok, ta14:45
tpollardIf we're in non interactive & purposely don't notify for instance 'self._notify("{} succeeded".format(session_name), "")' then I think there's validity to say that we shouldn't be messaging at all14:48
tpollardessentially making --non-interactive == no tty, or a more restricted subset of the UI14:49
tpollardwould be a big change though, especially for the test suite14:50
juergbitpollard: probably not needed. I just thought --no-interactive was identical to not running with a tty14:52
juergbiso my previous comments only apply to the non-tty case14:52
juergbibut the MR is probably fine as is14:52
tpollardmy biggest consideration with the behaviour is wether it should be opt-in14:53
tpollardas in most realistic cases, the benefits are far less dramatic or needed14:53
tpollardjuergbi: if possible do you think you could get some quick times from it on your wsl vm please?14:56
juergbiI can give it a try14:57
tpollardthanks!14:57
*** lachlan has joined #buildstream15:01
*** lachlan has quit IRC15:52
*** santi has quit IRC16:31
*** lachlan has joined #buildstream16:34
*** lachlan has quit IRC16:40
*** lachlan has joined #buildstream16:56
*** lachlan has quit IRC17:01
*** santi has joined #buildstream17:04
*** lachlan has joined #buildstream17:11
*** qinusty has joined #buildstream17:11
*** lachlan has quit IRC17:16
*** lachlan has joined #buildstream17:16
*** lachlan has quit IRC17:31
*** lachlan has joined #buildstream17:42
*** lachlan has quit IRC17:45
*** phoenix has joined #buildstream17:46
*** phoenix has quit IRC17:52
*** santi has quit IRC18:08
*** doras has quit IRC18:25
*** tiagogomes has quit IRC18:39
*** narispo has quit IRC19:14
*** narispo has joined #buildstream19:14
*** adds68 has joined #buildstream19:44
*** coldtom has quit IRC22:29
*** coldtom has joined #buildstream22:32
« Wednesday, 2019-12-18 Index Friday, 2019-12-20 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!