| *** narispo has quit IRC | 00:25 | |
| *** narispo has joined #buildstream | 00:25 | |
| *** benschubert has quit IRC | 00:30 | |
| *** qinusty has joined #buildstream | 01:11 | |
| *** phildawson_ has quit IRC | 01:29 | |
| *** narispo has quit IRC | 03:29 | |
| *** phildawson_ has joined #buildstream | 04:32 | |
| *** phildawson_ has quit IRC | 05:16 | |
| *** benschubert has joined #buildstream | 06:46 | |
| benschubert | Kinnison: may I ask why the python3.8 question yesterday? Is there an immediate need? :) | 07:54 |
|---|---|---|
| *** bochecha has joined #buildstream | 08:35 | |
| *** bochecha has quit IRC | 09:17 | |
| *** bochecha has joined #buildstream | 09:24 | |
| *** phoenix has joined #buildstream | 09:24 | |
| *** phoenix_ has joined #buildstream | 09:28 | |
| *** phoenix has quit IRC | 09:28 | |
| *** phoenix_ is now known as phoenix | 09:29 | |
| *** santi has joined #buildstream | 09:31 | |
| *** tiagogomes has joined #buildstream | 09:40 | |
| *** tme5 has joined #buildstream | 09:52 | |
| *** traveltissues has joined #buildstream | 10:05 | |
| *** phoenix has quit IRC | 10:05 | |
| juergbi | The remote execution test should be working again. With this, also Marge will hopefully no longer have issues merging | 10:09 |
| traveltissues | thanks | 10:10 |
| tme5 | shall i re-run the job on my MR? | 10:11 |
| *** jonathanmaw has joined #buildstream | 10:12 | |
| tme5 | ah, looks like you already did, thanks | 10:19 |
| benschubert | juergbi: awesome, thanks! | 10:23 |
| benschubert | juergbi: also, about buildbox-run-userchroot, I've been reading my gitlab notifications, it's currently blocked by the changes required in userchroot by regards to the group's permissions of devices right? | 10:23 |
| juergbi | benschubert: yes. I'm working on addressing a recent comment in that PR. that shouldn't take too much time, though, so after that it'll again be waiting for review/merge | 10:24 |
| juergbi | and have to add tlater[m]'s fix from yesterday to the buildstream branch to fix a recent CI failure | 10:25 |
| benschubert | juergbi: juergbi ok! Let me know if I can help in any ways | 10:26 |
| juergbi | ok, thanks. there has been initial review of the two upstream PRs, so there is progress | 10:26 |
| *** jonathanmaw has quit IRC | 10:27 | |
| *** jonathanmaw has joined #buildstream | 10:27 | |
| juergbi | it's a bit less of an issue now that we have buildbox-run-bubblewrap and buildbox-fuse available | 10:27 |
| juergbi | which is anyway preferred on Linux | 10:27 |
| benschubert | oh, run-bubblewrap has been implemented? How did I miss that? | 10:28 |
| juergbi | yes, it's all merged | 10:28 |
| benschubert | awesome, and buildbox-fuse's cli has been updated to work as the buildbox-run one, is that correct? | 10:29 |
| juergbi | correct, sandboxing/command execution has been dropped and buildbox-casd can now manage it | 10:30 |
| benschubert | ok! So the last thing missing before removing our sandboxes in BuildStream would be buildbox-casd fuse support correct? | 10:30 |
| juergbi | it's not fully optimal yet but it works well enough to pass the buildstream test suite (with some xfails) | 10:30 |
| *** lachlan has joined #buildstream | 10:30 | |
| juergbi | benschubert: that's already in place as well | 10:31 |
| juergbi | benschubert: see unchecked tasks in https://gitlab.com/BuildStream/buildstream/issues/719 | 10:31 |
| benschubert | Wait what? How did I miss that? How fast did this go? | 10:32 |
| benschubert | That's awesome :D | 10:32 |
| benschubert | Is there something I can do to help around that effort? I probably won't have that much time, but might manage to squeeze in a few things | 10:33 |
| juergbi | santi already started on that a while ago, so we just had to apply a few finishing touches | 10:33 |
| juergbi | benschubert: #719 links to various issues that need to be worked on. some also require discussion first. feel free to contribute to one of those if you have time :) | 10:37 |
| gitlab-br-bot | Issue #719: Support BuildBox for local builds https://gitlab.com/BuildStream/buildstream/issues/719 | 10:37 |
| benschubert | I will :) | 10:37 |
| benschubert | thanks a lot for all of this! | 10:37 |
| juergbi | also, if you can think of further potential issues, let me know | 10:38 |
| *** lachlan has quit IRC | 10:38 | |
| benschubert | yep | 10:38 |
| juergbi | i.e., you could give BST_FORCE_SANDBOX=buildbox-run a try | 10:38 |
| juergbi | should also work on WSL to the extent the bwrap sandbox works | 10:38 |
| juergbi | (I haven't tested that at all yet, though) | 10:38 |
| benschubert | Ok, I'll add this to my todo list :) | 10:39 |
| tme5 | so to clarify, if i want to work on git_tag i should do so in bst-plugins-experimental ? | 10:44 |
| benschubert | Yes please :) | 10:45 |
| benschubert | and if it needs to be backported, making a PR to bst-external afterwards | 10:46 |
| benschubert | Also if people have time to reply around my standardized tests ML post: https://mail.gnome.org/archives/buildstream-list/2019-December/msg00014.html, would be appreciated! | 10:47 |
| *** santi has quit IRC | 10:49 | |
| *** santi has joined #buildstream | 10:58 | |
| *** lachlan has joined #buildstream | 11:05 | |
| traveltissues | i missed that before benschubert | 11:12 |
| benschubert | traveltissues: ah, if you have time, it would help :) | 11:14 |
| *** santi has quit IRC | 11:16 | |
| tme5 | for when anyone has time, my MR !1765 is ready for review | 11:20 |
| gitlab-br-bot | MR !1765: Make Git source plugin clone submodules recursively https://gitlab.com/BuildStream/buildstream/merge_requests/1765 | 11:20 |
| *** santi has joined #buildstream | 11:29 | |
| *** lachlan has quit IRC | 11:33 | |
| *** lachlan has joined #buildstream | 11:36 | |
| benschubert | tme5: I gave it a first look, overall I like the idea, but wonder if we could make it a tad cleaner :) | 11:42 |
| *** lachlan has quit IRC | 11:45 | |
| tme5 | thanks | 11:50 |
| *** lachlan has joined #buildstream | 11:51 | |
| *** lachlan has quit IRC | 11:54 | |
| *** lachlan has joined #buildstream | 11:57 | |
| *** lachlan has quit IRC | 12:01 | |
| *** lachlan has joined #buildstream | 12:06 | |
| *** lachlan has quit IRC | 12:54 | |
| *** lachlan has joined #buildstream | 13:02 | |
| *** santi has quit IRC | 13:08 | |
| lachlan | benschubert: F.Y.I. - I've been double checking some of the recent overnight benchmarks and it does look like your recent changes have improved one of the tests - https://buildstream.gitlab.io/benchmarking/buildstream-benchmarking/test-bstgen-100-square/public/average_time_master_Hundred_Square_bstgen_20191211-053021.html | 13:09 |
| lachlan | This improvement translates back to the scheduling | 13:10 |
| lachlan | .. changes | 13:10 |
| benschubert | Oh good! | 13:13 |
| *** santi has joined #buildstream | 13:38 | |
| tme5 | benschubert, could you point me to a file that has the required internal docs format? I'm looking around and I can't find anything very different to what I've done | 13:55 |
| *** traveltissues has quit IRC | 14:07 | |
| benschubert | tme5: something like https://gitlab.com/BuildStream/buildstream/blob/master/src/buildstream/element.py#L982 | 14:07 |
| *** traveltissues has joined #buildstream | 14:07 | |
| tme5 | ah ok - so for a class you would want that but just without a returns section? | 14:10 |
| tme5 | I can't find any classes annotated in such a way | 14:10 |
| *** lachlan has quit IRC | 14:27 | |
| *** lachlan has joined #buildstream | 14:30 | |
| *** lachlan has quit IRC | 14:35 | |
| *** lachlan has joined #buildstream | 14:40 | |
| *** lachlan has quit IRC | 14:47 | |
| *** lachlan has joined #buildstream | 14:47 | |
| *** lachlan has quit IRC | 14:51 | |
| *** lachlan has joined #buildstream | 14:55 | |
| *** lachlan has quit IRC | 14:58 | |
| tme5 | is there any harm in not calling mark_download_url in the configure method? | 15:02 |
| tme5 | the docs says it must happen then, but again with recursive submodules I don't have complete information before fetching | 15:03 |
| tme5 | (of course i would call it elsewhere, always before fetching, just not in configure) | 15:03 |
| *** lachlan has joined #buildstream | 15:10 | |
| Kinnison | benschubert: no immediate need, no. I was just going over some instructions which coldtom wrote, which said it didn't work yet | 15:17 |
| *** Trevinho has quit IRC | 15:27 | |
| *** Trevinho has joined #buildstream | 15:27 | |
| *** lachlan has quit IRC | 15:29 | |
| *** lachlan has joined #buildstream | 15:42 | |
| *** lachlan has quit IRC | 15:48 | |
| *** lachlan has joined #buildstream | 15:53 | |
| *** lachlan has quit IRC | 15:56 | |
| *** bochecha_ has joined #buildstream | 16:03 | |
| *** bochecha has quit IRC | 16:04 | |
| *** lachlan has joined #buildstream | 16:09 | |
| *** lachlan has quit IRC | 16:12 | |
| tme5 | i think !1765 is ready for another look | 16:25 |
| tme5 | <gitlab-br-bot> MR 1765: Make Git source plugin clone submodules recursively https://gitlab.com/BuildStream/buildstream/merge_requests/1765 | 16:26 |
| *** lachlan has joined #buildstream | 16:33 | |
| *** lachlan has quit IRC | 16:37 | |
| *** santi has quit IRC | 16:43 | |
| *** santi has joined #buildstream | 16:49 | |
| *** lachlan has joined #buildstream | 17:10 | |
| *** benschubert has quit IRC | 17:15 | |
| *** lachlan has quit IRC | 17:24 | |
| *** narispo has joined #buildstream | 17:26 | |
| *** narispo has joined #buildstream | 17:26 | |
| *** narispo has quit IRC | 17:34 | |
| *** narispo has joined #buildstream | 17:34 | |
| *** narispo has quit IRC | 17:46 | |
| *** tme5 has quit IRC | 17:47 | |
| *** santi has quit IRC | 17:47 | |
| *** narispo has joined #buildstream | 17:51 | |
| *** narispo has joined #buildstream | 17:55 | |
| *** narispo has quit IRC | 17:58 | |
| *** narispo has joined #buildstream | 17:58 | |
| *** narispo has joined #buildstream | 18:04 | |
| *** tiagogomes has quit IRC | 18:11 | |
| *** tiagogomes has joined #buildstream | 18:11 | |
| *** jonathanmaw has quit IRC | 18:14 | |
| gitlab-br-bot | juergbi opened MR !1766 (juerg/job-pipe->master: job.py: Replace message queue with pipe) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/1766 | 18:20 |
| juergbi | lachlan: https://gitlab.com/BuildStream/buildstream/merge_requests/1766 would be a candidate for the benchmarking bot | 18:21 |
| *** tiagogomes has quit IRC | 18:30 | |
| *** traveltissues has quit IRC | 18:35 | |
| *** Trevinho has quit IRC | 18:38 | |
| *** Trevinho has joined #buildstream | 18:44 | |
| gitlab-br-bot | albfan opened issue #1238 (Unable to build examples) on buildstream https://gitlab.com/BuildStream/buildstream/issues/1238 | 19:33 |
| *** phildawson_ has joined #buildstream | 22:42 | |
| *** phildawson_ has quit IRC | 22:56 | |
| *** phildawson_ has joined #buildstream | 23:05 | |
| *** phildawson_ has quit IRC | 23:10 | |
| *** phildawson_ has joined #buildstream | 23:10 | |
| *** phildawson_ has quit IRC | 23:13 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!