IRC logs for #buildstream for Friday, 2019-11-15

« Thursday, 2019-11-14 Index Saturday, 2019-11-16 »
*** narispo has quit IRC00:32
*** narispo has joined #buildstream00:32
*** lchlan has quit IRC01:10
*** jjardon has quit IRC01:10
*** lchlan has joined #buildstream01:10
*** jjardon has joined #buildstream01:10
*** ChanServ sets mode: +o jjardon01:10
*** kapip has quit IRC01:11
*** aevri has quit IRC01:11
*** jjardon has quit IRC01:11
*** jjardon has joined #buildstream01:12
*** ChanServ sets mode: +o jjardon01:12
*** aevri has joined #buildstream01:12
*** kapip has joined #buildstream01:12
*** narispo has quit IRC07:40
*** narispo has joined #buildstream07:40
*** narispo has quit IRC08:06
*** narispo has joined #buildstream08:06
*** phildawson has joined #buildstream08:18
gitlab-br-botcs-shadow merged MR !1703 (chandan/black->master: Use Black to format code) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/170308:26
*** traveltissues has joined #buildstream08:47
*** tpollard has joined #buildstream08:59
*** bochecha has joined #buildstream09:26
*** rdale has joined #buildstream09:30
*** dtf has joined #buildstream09:38
*** santi has joined #buildstream09:44
*** lachlan has joined #buildstream10:30
*** rdale has quit IRC10:42
*** rdale has joined #buildstream10:42
*** phoenix has joined #buildstream10:42
*** cs-shadow has joined #buildstream10:44
*** lachlan has quit IRC10:46
*** lachlan has joined #buildstream10:53
*** dtf has joined #buildstream11:03
*** lachlan has quit IRC11:07
*** phildawson has quit IRC11:08
*** phildawson has joined #buildstream11:09
*** narispo has quit IRC11:17
*** narispo has joined #buildstream11:19
*** narispo has quit IRC11:22
*** narispo has joined #buildstream11:22
*** narispo has quit IRC11:28
*** narispo has joined #buildstream11:29
aevriFolks may find `git rebase upstream/master -X theirs --exec 'git diff-tree --no-commit-id --name-only -r @ | xargs black && git commit --amend -a --no-edit'` helpful when rebasing on top of the black changes.11:29
aevriNo warranty! :)11:29
aevriIf you want to see what the difference commit-to-commit with your upstream branch is, you can use `git range-diff origin/master @{u} @`11:31
*** lachlan has joined #buildstream11:32
aevriNote that you should first manually rebase on the commit before the blackening, in case you have any meaningful conflicts.11:42
*** lachlan has quit IRC11:42
*** phildawson has quit IRC11:53
*** phildawson has joined #buildstream11:59
*** lachlan has joined #buildstream12:03
*** lachlan has quit IRC12:08
tlater[m]ta aevri12:14
tlater[m]Very handy little shortcuts :)12:14
gitlab-br-bottlater opened MR !1712 (tlater/fix-test-env->master: cascache.py: Use a shebang that won't fail on /bin/bash-less systems) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/171212:38
gitlab-br-botaevri opened (was WIP) MR !1638 (aevri/casdprocessmanager->master: cascache: refactor, extract CASDProcessManager and CASDConnection) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/163812:47
*** lachlan has joined #buildstream12:49
gitlab-br-bottraveltissues approved MR !1638 (aevri/casdprocessmanager->master: cascache: refactor, extract CASDProcessManager and CASDConnection) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/163812:52
gitlab-br-bottraveltissues unapproved MR !1638 (aevri/casdprocessmanager->master: cascache: refactor, extract CASDProcessManager and CASDConnection) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/163812:53
*** lachlan has quit IRC12:54
gitlab-br-bottlater approved MR !1709 (traveltissues/1171->master: _stream: Force workspace removal) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/170912:55
gitlab-br-botmarge-bot123 merged MR !1709 (traveltissues/1171->master: _stream: Force workspace removal) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/170912:58
*** lachlan has joined #buildstream12:59
*** lachlan has quit IRC13:02
*** santi has quit IRC13:13
gitlab-br-bottraveltissues approved MR !1638 (aevri/casdprocessmanager->master: cascache: refactor, extract CASDProcessManager and CASDConnection) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/163813:25
*** tpollard has quit IRC13:44
*** santi has joined #buildstream13:44
*** traveltissues has quit IRC13:47
*** tpollard has joined #buildstream13:48
gitlab-br-botcs-shadow approved MR !1712 (tlater/fix-test-env->master: cascache.py: Use a shebang that won't fail on /bin/bash-less systems) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/171214:06
*** tpollard has quit IRC14:11
*** santi has quit IRC14:27
*** lachlan has joined #buildstream14:36
*** santi has joined #buildstream14:37
*** tpollard has joined #buildstream14:44
*** bochecha has quit IRC15:23
* tlater[m] thinks we have intermittent test suite failures15:25
tlater[m]Or maybe not, nevermind. These are fairly consistent15:26
*** lachlan has quit IRC15:26
tlater[m]Ah, of course, we *did* use bash specifics, cs-shadow, `echo` and `trap`15:27
*** lachlan has joined #buildstream15:27
* tlater[m] just forgot those were built-ins15:28
*** lachlan has joined #buildstream15:29
coldtomhi, could someone take a look at https://gitlab.com/buildstream/bst-plugins-experimental/merge_requests/50 if they get a chance please?15:30
*** narispo has quit IRC15:35
tpollardbenschubert: I'm not really sure where to look to narrow down the differences between the two machines. afaict it's showing that the frontend still bottlenecks your machine, regardless15:38
benschuberttpollard: my backend didn't get quicker either, which is more concerning to me, since we don't have this bottleneck of writing to the UI15:40
*** narispo has joined #buildstream15:41
tpollardyes, it's all 25-30% slower15:41
tpollard(compared to the profile here)15:42
*** lachlan has quit IRC15:42
benschubertand that's the part I'm not expecting, I'll try to give it a more thorough look on monday.15:43
*** bochecha has joined #buildstream15:51
*** lachlan has joined #buildstream15:51
*** lachlan has quit IRC15:55
*** narispo has quit IRC16:04
*** narispo has joined #buildstream16:05
*** phoenix_ has joined #buildstream16:09
*** phoenix has quit IRC16:11
*** phoenix_ is now known as phoenix16:11
*** santi has quit IRC16:17
*** phildawson has quit IRC16:18
*** lachlan has joined #buildstream16:19
*** lachlan has quit IRC16:23
cs-shadowtlater[m]: `echo` and `trap` are both defined by POSIX, aren't they?16:26
tlater[m]cs-shadow: Yes, but not `echo -e` and `trap` behaves differently than it's used in that script16:27
cs-shadowtlater[m]: ah! for `echo -e`, we can  use `printf`16:27
* tlater[m] hasn't had to work with POSIX `trap` enough to fix it, unfortunately16:27
tlater[m]Yeah, that one's easy enough16:27
tpollardI do like black's usage of emoji's16:27
cs-shadowfor `trap` https://unix.stackexchange.com/questions/520035/exit-trap-with-posix/520041 might be useful16:28
cs-shadowbut if that's not straightforward, we shouldn't block your MR on that since it already fixes an issue16:29
tlater[m]tpollard: I don't, but luckily it's easy enough to ignore if your editor runs it for you whenever you save a file.16:29
tlater[m]cs-shadow: Yeah, I was going to sit down and look at it, just can't do it off the top of my head16:29
tpollardbut, cake16:29
tlater[m]Would you prefer I just swap back to `bash` and think about this some other time?16:30
cs-shadowthat makes sense to me. It'll be great for future reference if you can please convert the discussion into an issue16:30
tlater[m]tpollard: I prefer my CI stoic and somber, thank you.16:32
tlater[m];p16:32
gitlab-br-bottlater opened issue #1211 (Stop using non-POSIX features in small test suite tests to avoid fake test failures) on buildstream https://gitlab.com/BuildStream/buildstream/issues/121116:38
*** narispo has quit IRC16:41
*** narispo has joined #buildstream16:41
*** bochecha has quit IRC16:43
*** lachlan has joined #buildstream16:51
*** santi has joined #buildstream17:06
*** tpollard has quit IRC17:14
*** phildawson has joined #buildstream17:19
gitlab-br-botcs-shadow opened MR !1713 (chandan/extras-require->master: setup.py: Add plugin requirements as extras) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/171317:26
gitlab-br-botmarge-bot123 merged MR !1712 (tlater/fix-test-env->master: cascache.py: Use a shebang that won't fail on /bin/bash-less systems) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/171217:34
*** santi has quit IRC17:40
gitlab-br-botcs-shadow opened MR !1714 (chandan/re-enable-import-check->master: plugins/sources/deb: Re-enable import check for arpy) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/171417:41
*** phildawson has quit IRC18:05
*** rdale has quit IRC18:24
*** phoenix has quit IRC18:32
*** toscalix has joined #buildstream19:16
*** toscalix has quit IRC19:29
*** traveltissues has joined #buildstream22:34
« Thursday, 2019-11-14 Index Saturday, 2019-11-16 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!