IRC logs for #buildstream for Wednesday, 2019-11-13

« Tuesday, 2019-11-12 Index Thursday, 2019-11-14 »
*** testy has quit IRC00:46
*** slaf has quit IRC06:55
*** slaf has joined #buildstream06:59
*** slaf has joined #buildstream06:59
*** slaf has joined #buildstream06:59
*** slaf has joined #buildstream06:59
*** slaf has joined #buildstream07:00
*** slaf has joined #buildstream07:00
*** slaf has joined #buildstream07:00
*** slaf has joined #buildstream07:00
*** slaf has joined #buildstream07:01
*** slaf has joined #buildstream07:01
*** slaf has joined #buildstream07:01
coldtomdoes anyone know if bb-storage is compatible with buildstream for an artifact cache?08:41
*** rdale has joined #buildstream09:33
*** santi has joined #buildstream09:38
*** traveltissues has joined #buildstream09:42
benschuberttpollard: the status bar is meant to be displayed on your branch rigth?09:55
benschubertBecause my terminal apparently isn't showing that :(09:55
tpollardbenschubert: works for me :/ what if you try one of the doc examples, like autotools?09:56
tpollardit renders slightly differently on purpose, but it should work09:58
benschubertautotools won't build, I don't get a sandbox on wsl :)09:59
*** phildawson has joined #buildstream10:00
gitlab-br-bottraveltissues opened MR !1707 (traveltissues/1204->master: app: Pass color setting to Status) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/170710:19
traveltissuestpollard, ^10:20
*** phildawson has quit IRC10:22
*** phildawson has joined #buildstream10:22
*** phildawson_ has joined #buildstream10:25
*** phildawson has quit IRC10:27
*** jonathanmaw has joined #buildstream10:32
*** lachlan has joined #buildstream10:36
gitlab-br-botcs-shadow approved MR !1707 (traveltissues/1204->master: app: Pass color setting to Status) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/170710:43
tpollardI don't think we should merge that traveltissues ^10:49
traveltissuesright10:53
traveltissueswe don't need that attribute10:53
tpollardjust dropping ._colors from Status should do it10:54
traveltissuesyes10:54
traveltissueseither works but removing that is better10:55
tpollardI'm not sure I like overriding clicks autodetection globally with its context, but it's probably a non issue10:57
traveltissuesright, this is not the fix i'd eventually like, but it's just the minimal one on top of the change that went in10:58
tpollardyep11:00
tpollardthanks for looking at the issue, I got sucked into something else yesterday before leaving11:01
tlater[m]benschubert: If you get some time, mind having a look at !1645 again? Not much has changed code-wise, though I've responded to a couple of your comments.11:01
gitlab-br-botMR !1645: WIP: Refactor casserver.py: Stop relying on the buildstream-internal `CASCache` implementation https://gitlab.com/BuildStream/buildstream/merge_requests/164511:01
gitlab-br-bottpollard approved MR !1707 (traveltissues/1204->master: app: Pass color setting to Status) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/170711:01
tlater[m]I'll probably add in-code comments once we're through with the discussion instead of leaving things as-is, but I don't think I want to make code changes atm.11:01
benschuberttlater[m]: did I? Or do you mean the update_State MR?11:02
tlater[m]benschubert: Update state, yeah11:02
tlater[m]Hehe11:02
tlater[m]Wrong mr11:02
tlater[m]Should be !66011:02
gitlab-br-botMR !660: CAS: Fix resource_name format for blobs https://gitlab.com/BuildStream/buildstream/merge_requests/66011:02
tlater[m]Argh11:02
tlater[m]!166011:03
gitlab-br-botMR !1660: Remove update_state https://gitlab.com/BuildStream/buildstream/merge_requests/166011:03
*** cs-shadow has joined #buildstream11:03
* tlater[m] thinks he's not entirely awake yet11:03
benschubertsure I'll have a look11:03
*** lachlan has quit IRC11:05
*** lachlan has joined #buildstream11:05
*** lachlan has quit IRC11:16
*** lachlan has joined #buildstream11:19
*** lachlan has quit IRC11:32
*** lachlan has joined #buildstream11:43
jjardoncoldtom: it should work: see https://gitlab.com/BuildStream/buildstream/issues/1050 if not please open a new issue11:45
*** lachlan has quit IRC11:55
*** lachlan has joined #buildstream12:06
*** brlogger has joined #buildstream12:12
gitlab-br-botmarge-bot123 closed issue #1204 (Colourisation lost in Status Widget UI) on buildstream https://gitlab.com/BuildStream/buildstream/issues/120412:28
gitlab-br-botmarge-bot123 merged MR !1707 (traveltissues/1204->master: app: Pass color setting to Status) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/170712:28
cs-shadowhi, would anyone like to have another look at https://gitlab.com/BuildStream/buildstream/merge_requests/1703 ?13:03
cs-shadowit's the black reformatting MR13:04
* tlater[m] is looking forward to that landing :D13:04
*** santi has quit IRC13:19
gitlab-br-botcs-shadow opened issue #1206 (Pylint configuratin is busted) on buildstream https://gitlab.com/BuildStream/buildstream/issues/120613:23
gitlab-br-bottraveltissues approved MR !1692 (bschubert/graceful-children-sigterm->master: Gracefully shutdown children on termination) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/169213:23
cs-shadowtlater[m]: you may be interested in ^^13:24
cs-shadowthat would also explain why we were confused on the flake8 mr about pylint not reporting those errors13:24
tlater[m]cs-shadow: Ah, that makes a lot of sense13:27
tlater[m]Yeah, pylint is module based, to the confusion of anyone who's ever tried to set it up13:27
tlater[m]It won't like file paths like that13:27
cs-shadow6 months no pylint, only 15 regressions, not too bad :)13:28
benschuberttpollard: would you mind testing !1692 since you opened the issue? :)13:41
tpollardyep, on my list for today13:42
gitlab-br-botcs-shadow opened MR !1708 (chandan/pylint->master: Fix pylint configuration) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/170813:45
gitlab-br-bottraveltissues approved MR !1708 (chandan/pylint->master: Fix pylint configuration) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/170813:58
gitlab-br-bottlater approved MR !1708 (chandan/pylint->master: Fix pylint configuration) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/170814:18
*** santi has joined #buildstream14:21
*** akvilebirgelyte_ has joined #buildstream14:57
gitlab-br-botmarge-bot123 closed issue #1206 (Pylint configuration is busted) on buildstream https://gitlab.com/BuildStream/buildstream/issues/120615:11
gitlab-br-botmarge-bot123 merged MR !1708 (chandan/pylint->master: Fix pylint configuration) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/170815:11
*** phoenix has joined #buildstream15:20
*** rdale has quit IRC15:23
*** rdale has joined #buildstream15:24
*** phoenix has quit IRC15:26
*** lachlan has quit IRC15:29
gitlab-br-bottlater approved MR !1703 (chandan/black->master: Use Black to format code) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/170315:32
*** santi has quit IRC15:42
*** jonathanmaw has quit IRC15:51
*** jonathanmaw has joined #buildstream15:52
tlater[m]cs-shadow: Your build --track removal MR didn't remove the options from, say, fetch15:54
tlater[m]Was that intentional?15:55
* tlater[m] doesn't think we can simplify things much if fetch is still able to build a pipeline that also needs to track15:55
cs-shadowIntentional, yes15:56
cs-shadowDesirable, maybe no15:56
*** bochecha_ has joined #buildstream15:56
cs-shadowWe also need to consider workspace open —track15:56
*** bochecha has quit IRC15:56
traveltissuesalso #119315:56
gitlab-br-botIssue #1193: Split `Stream._load` for target types https://gitlab.com/BuildStream/buildstream/issues/119315:56
*** bochecha_ is now known as bochecha15:57
cs-shadowMy stance is that we should probably still support those two cases, but as syntactic sugar. And without needing to do them in a single pipeline15:57
tlater[m]traveltissues: I'm... actually working on that right now15:57
cs-shadowBut maybe we need to discus that on the list as well15:58
tpollardbenschubert: WFM :)15:58
tlater[m]cs-shadow: That's going to be hairy code wise, and I'm not sure it's really beneficial15:58
benschuberttpollard: o/ let's send that to marge then15:58
tpollard\o/15:59
tlater[m]If we're disallowing `bst build --track` because we don't think it's worth the maintenance effort, why whould we allow `bst fetch --track`? It's just UI inconsistency.15:59
*** traveltissues has quit IRC16:00
cs-shadowpersonally I’ll be very happy to drop them. I was just saying that if we do support them, we should at least simplify the code such that track and everything else don’t need to happen in the same pipeline16:00
tlater[m]Ah, right, I see what you mean16:01
* tlater[m] thinks he'll start a ML discussion on the topic, then16:01
cs-shadowThat’ll be useful16:02
benschuberttpollard: wsl vs windows fs doesn't change much from my current tests, I'm now running the profiles :)16:02
gitlab-br-botfrazerleslieclews opened (was WIP) MR !1693 (frazer/flake8->chandan/black: flake8) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/169316:15
tpollardbenschubert: :/ well at least that can be ruled out I guess16:16
* tpollard thinks we should implement a render limiter to the frontend, like we have for the task reporting16:18
tpollardwe have a minimum refresh rate, I also think as a human have a upper limit also makes sense16:18
*** traveltissues has joined #buildstream16:19
benschubertYES YES PLEASE!16:21
benschubertsorry :)16:21
benschubertbut more than every .5 sec makes it useless16:21
benschubertI am happy not to be epileptic those days, wathcing big builds16:21
tpollardxD16:22
tpollardbst disco16:22
*** traveltissues has quit IRC16:23
tlater[m]hah16:23
tlater[m]Increases refresh rate to once every .1s!16:24
tpollardpretty sure the debian build causes a higher rate than that for me16:24
* tlater[m] wonders if we could do some smart ncurses only-update-what-needs-to-be thing16:25
tlater[m]But I suppose with the scrolling log it's not that easy16:25
benschubertclick does use curses, so i hope it's smart-ish :)16:27
tlater[m]benschubert: iirc it takes a bit more effort to get it to be really smart (otherwise you get flickering like we do)16:29
gitlab-br-botmarge-bot123 closed issue #1185 (bst build does not exit gracefully on a second CTRL-C) on buildstream https://gitlab.com/BuildStream/buildstream/issues/118516:39
gitlab-br-botmarge-bot123 closed issue #1185 (bst build does not exit gracefully on a second CTRL-C) on buildstream https://gitlab.com/BuildStream/buildstream/issues/118516:39
gitlab-br-botmarge-bot123 merged MR !1692 (bschubert/graceful-children-sigterm->master: Gracefully shutdown children on termination) on buildstream https://gitlab.com/BuildStream/buildstream/merge_requests/169216:39
tpollardwoop16:39
* coldtom mashes CTRL-C to celebrate16:40
benschuberto/that was an ugly one16:43
*** santi has joined #buildstream16:57
tpollardbenschubert: works in my branch after rebasing too, now to see if I can drop a signal.set_wakeup_fd I had to add....17:18
*** lachlan has joined #buildstream17:20
*** narispo has quit IRC17:45
*** narispo has joined #buildstream17:46
*** bochecha has quit IRC17:48
*** santi has quit IRC17:50
*** lachlan has quit IRC17:52
*** narispo has quit IRC18:04
*** lachlan has joined #buildstream18:10
*** tiagogomes has quit IRC18:17
*** paulsherwood has quit IRC18:18
benschubertoh nice :)18:18
*** qinusty has quit IRC18:19
*** paulsherwood has joined #buildstream18:19
*** ikerperez has quit IRC18:19
*** adds68 has quit IRC18:19
*** bethw has quit IRC18:21
*** laurence has quit IRC18:22
*** valentind has quit IRC18:22
*** valentind has joined #buildstream18:22
*** WSalmon has quit IRC18:22
*** WSalmon has joined #buildstream18:22
*** paulsherwood has quit IRC18:23
*** phildawson_ has quit IRC18:26
*** laurence has joined #buildstream18:27
*** bethw has joined #buildstream18:27
*** narispo has joined #buildstream18:28
*** valentind has quit IRC18:39
*** laurence has quit IRC18:39
*** jward has quit IRC18:39
*** bethw has quit IRC18:39
*** WSalmon has quit IRC18:39
*** narispo has quit IRC18:39
*** bethw has joined #buildstream18:39
*** jward has joined #buildstream18:40
*** jward has joined #buildstream18:42
*** valentind has joined #buildstream18:43
*** laurence has joined #buildstream18:43
*** jward has joined #buildstream18:44
*** WSalmon has joined #buildstream18:44
*** lachlan has quit IRC18:54
*** jonathanmaw has quit IRC19:00
*** adds68 has joined #buildstream19:33
*** cs-shadow has quit IRC20:23
*** lachlan has joined #buildstream20:46
*** lachlan has quit IRC21:46
*** narispo has joined #buildstream21:48
*** bochecha has joined #buildstream21:55
*** narispo has quit IRC22:01
*** narispo has joined #buildstream22:04
*** narispo has quit IRC22:11
*** narispo has joined #buildstream22:12
*** narispo has quit IRC22:16
*** narispo has joined #buildstream22:18
*** narispo has quit IRC22:51
*** narispo has joined #buildstream22:55
*** narispo has joined #buildstream22:56
*** paulsherwood has joined #buildstream23:22
« Tuesday, 2019-11-12 Index Thursday, 2019-11-14 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!